223954 2021-03-30 13:35:17 -0700 Add a fast-cq mode for commit-queue which will skip build and test 2021-10-23 04:59:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223942 https://bugs.webkit.org/show_bug.cgi?id=224286 https://bugs.webkit.org/show_bug.cgi?id=224580 https://bugs.webkit.org/show_bug.cgi?id=232196 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1745280 0 aakash_jain 2021-03-30 13:35:17 -0700 Add a fast-cq mode for commit-queue which will skip build and test. This will help in scenarios where the patch author wants to quickly land the patch (skipping building and testing on commit-queue). Few scenario where people might want to land patch without building/testing: build fix, quick typo fix. 1745285 1 424687 aakash_jain 2021-03-30 13:43:11 -0700 Created attachment 424687 Patch 1745289 2 aakash_jain 2021-03-30 13:46:07 -0700 (In reply to Aakash Jain from comment #1) > Created attachment 424687 [details] This patch allows commit-queue to look at patch name and enable fast-cq mode when the patch name on bugzilla starts with [fast-cq] keyword. This is similar to how commit-queue currently skips building and testing for revert patches. We can also update webkit-patch command to add this keyword to patch name when a certain parameter (e.g.: --fast-cq) is passed. 1745635 3 ews-feeder 2021-03-31 09:03:37 -0700 Committed r275282: <https://commits.webkit.org/r275282> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424687. 1745636 4 webkit-bug-importer 2021-03-31 09:04:14 -0700 <rdar://problem/76055353> 1745987 5 aakash_jain 2021-04-01 04:47:37 -0700 Restarted EWS server to pick up this change. This change is now live. 1746244 6 aakash_jain 2021-04-01 13:52:55 -0700 Working fine. For e.g.: https://webkit.org/b/224054 had '[fast-cq] Patch', commit-queue took ~1 minute to land that patch in https://ews-build.webkit.org/#/builders/28/builds/10630 424687 2021-03-30 13:43:11 -0700 2021-03-31 09:03:37 -0700 Patch bug-223954-20210330134310.patch text/plain 4584 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTIzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIxLTAzLTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgYSBmYXN0LWNxIG1vZGUgZm9yIGNvbW1pdC1xdWV1ZSB3aGljaCB3 aWxsIHNraXAgYnVpbGQgYW5kIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMzk1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weTogRW5hYmxlIGZh c3QtY3EgbW9kZSB3aGVuIHBhdGNoIG5hbWUgb24gYnVnemlsbGEgc3RhcnRzIHdpdGggW2Zhc3Qt Y3FdLgorICAgICAgICAoQnVnemlsbGFNaXhpbik6CisgICAgICAgIChCdWd6aWxsYU1peGluLl9p c19wYXRjaF9vYnNvbGV0ZSk6CisgICAgICAgIChDb21waWxlV2ViS2l0LmRvU3RlcElmKTogU2tp cCBidWlsZGluZyBvbiBjb21taXQtcXVldWUgd2hlbiBmYXN0X2NvbW1pdF9xdWV1ZSBwcm9wZXJ0 eSBpcyBzZXQuCisgICAgICAgIChSdW5XZWJLaXRUZXN0cy5kb1N0ZXBJZik6IFNraXAgdGVzdGlu ZyBvbiBjb21taXQtcXVldWUgd2hlbiBmYXN0X2NvbW1pdF9xdWV1ZSBwcm9wZXJ0eSBpcyBzZXQu CisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weToKKwogMjAy MS0wMy0zMCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAg W3Jlc3VsdHNkYnB5XSBSZXR1cm4gbmV3LXN0eWxlIGNvbW1pdHMgKEZvbGxvdy11cCBmaXgpCklu ZGV4OiBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI3NTIzMSkKKysrIFRv b2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTUxNyw2 ICs1MTcsNyBAQCBjbGFzcyBCdWd6aWxsYU1peGluKG9iamVjdCk6CiAgICAgYnVnX29wZW5fc3Rh dHVzZXMgPSBbJ1VOQ09ORklSTUVEJywgJ05FVycsICdBU1NJR05FRCcsICdSRU9QRU5FRCddCiAg ICAgYnVnX2Nsb3NlZF9zdGF0dXNlcyA9IFsnUkVTT0xWRUQnLCAnVkVSSUZJRUQnLCAnQ0xPU0VE J10KICAgICByZXZlcnRfcHJlYW1ibGUgPSAnUkVWRVJUIG9mIHInCisgICAgZmFzdF9jcV9wcmVh bWJsZSA9ICdbZmFzdC1jcV0nCiAKICAgICBAZGVmZXIuaW5saW5lQ2FsbGJhY2tzCiAgICAgZGVm IF9hZGRUb0xvZyhzZWxmLCBsb2dOYW1lLCBtZXNzYWdlKToKQEAgLTU5NCw4ICs1OTUsOCBAQCBj bGFzcyBCdWd6aWxsYU1peGluKG9iamVjdCk6CiAgICAgICAgIHBhdGNoX2F1dGhvciA9IHBhdGNo X2pzb24uZ2V0KCdjcmVhdG9yJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hfYXV0 aG9yJywgcGF0Y2hfYXV0aG9yKQogICAgICAgICBwYXRjaF90aXRsZSA9IHBhdGNoX2pzb24uZ2V0 KCdzdW1tYXJ5JykKLSAgICAgICAgaWYgcGF0Y2hfdGl0bGUuc3RhcnRzd2l0aChzZWxmLnJldmVy dF9wcmVhbWJsZSk6Ci0gICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdyZXZlcnQnLCBUcnVl KQorICAgICAgICBpZiBwYXRjaF90aXRsZS5sb3dlcigpLnN0YXJ0c3dpdGgoKHNlbGYucmV2ZXJ0 X3ByZWFtYmxlLCBzZWxmLmZhc3RfY3FfcHJlYW1ibGUpKToKKyAgICAgICAgICAgIHNlbGYuc2V0 UHJvcGVydHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJywgVHJ1ZSkKICAgICAgICAgaWYgc2VsZi5hZGRV UkxzOgogICAgICAgICAgICAgc2VsZi5hZGRVUkwoJ1BhdGNoIGJ5OiB7fScuZm9ybWF0KHBhdGNo X2F1dGhvciksICcnKQogICAgICAgICByZXR1cm4gcGF0Y2hfanNvbi5nZXQoJ2lzX29ic29sZXRl JykKQEAgLTE1MDQsNyArMTUwNSw3IEBAIGNsYXNzIENvbXBpbGVXZWJLaXQoc2hlbGwuQ29tcGls ZSk6CiAgICAgICAgIHN1cGVyKENvbXBpbGVXZWJLaXQsIHNlbGYpLl9faW5pdF9fKGxvZ0Vudmly b249RmFsc2UsICoqa3dhcmdzKQogCiAgICAgZGVmIGRvU3RlcElmKHNlbGYsIHN0ZXApOgotICAg ICAgICByZXR1cm4gbm90IChzZWxmLmdldFByb3BlcnR5KCdyZXZlcnQnKSBhbmQgc2VsZi5nZXRQ cm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnJykubG93ZXIoKSA9PSAnY29tbWl0LXF1ZXVlJykKKyAg ICAgICAgcmV0dXJuIG5vdCAoc2VsZi5nZXRQcm9wZXJ0eSgnZmFzdF9jb21taXRfcXVldWUnKSBh bmQgc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnJykubG93ZXIoKSA9PSAnY29tbWl0 LXF1ZXVlJykKIAogICAgIGRlZiBzdGFydChzZWxmKToKICAgICAgICAgcGxhdGZvcm0gPSBzZWxm LmdldFByb3BlcnR5KCdwbGF0Zm9ybScpCkBAIC0yMDgzLDcgKzIwODQsNyBAQCBjbGFzcyBSdW5X ZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKIAogICAgIGRlZiBkb1N0ZXBJZihzZWxmLCBzdGVwKToK ICAgICAgICAgcmV0dXJuIG5vdCAoKHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJycp Lmxvd2VyKCkgPT0gJ2NvbW1pdC1xdWV1ZScpIGFuZAotICAgICAgICAgICAgICAgICAgICAoc2Vs Zi5nZXRQcm9wZXJ0eSgncmV2ZXJ0Jykgb3Igc2VsZi5nZXRQcm9wZXJ0eSgncGFzc2VkX21hY193 azInKSkpCisgICAgICAgICAgICAgICAgICAgIChzZWxmLmdldFByb3BlcnR5KCdmYXN0X2NvbW1p dF9xdWV1ZScpIG9yIHNlbGYuZ2V0UHJvcGVydHkoJ3Bhc3NlZF9tYWNfd2syJykpKQogCiAgICAg ZGVmIHNldExheW91dFRlc3RDb21tYW5kKHNlbGYpOgogICAgICAgICBwbGF0Zm9ybSA9IHNlbGYu Z2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWls ZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjc1MjMxKQorKysgVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTA4NSw3ICsx MDg1LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXQoQnVpbGRTdGVwTWl4aW5BZAogICAgICAg ICBzZWxmLnNldHVwU3RlcChDb21waWxlV2ViS2l0KCkpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVy dHkoJ2J1aWxkZXJuYW1lJywgJ0NvbW1pdC1RdWV1ZScpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVy dHkoJ2NvbmZpZ3VyYXRpb24nLCAnZGVidWcnKQotICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdy ZXZlcnQnLCBUcnVlKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmYXN0X2NvbW1pdF9xdWV1 ZScsIFRydWUpCiAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3Rh dGVfc3RyaW5nPSdDb21waWxlZCBXZWJLaXQgKHNraXBwZWQpJykKICAgICAgICAgcmV0dXJuIHNl bGYucnVuU3RlcCgpCiAKQEAgLTE2ODUsNyArMTY4NSw3IEBAIHRzIiwidmVyc2lvbiI6NCwibnVt X3Bhc3NlcyI6NDIxNTgsInBpeGUKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5h bWUnLCAnQ29tbWl0LVF1ZXVlJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRm b3JtJywgJ21hYycpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAn ZGVidWcnKQotICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdyZXZlcnQnLCBUcnVlKQorICAgICAg ICBzZWxmLnNldFByb3BlcnR5KCdmYXN0X2NvbW1pdF9xdWV1ZScsIFRydWUpCiAgICAgICAgIHNl bGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdsYXlvdXQtdGVz dHMgKHNraXBwZWQpJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKQEAgLTIxMDgs NyArMjEwOCw3IEBAIGNsYXNzIFRlc3RSdW5XZWJLaXQxVGVzdHMoQnVpbGRTdGVwTWl4aW4KICAg ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnQ29tbWl0LVF1ZXVlJykKICAg ICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ21hYycpCiAgICAgICAgIHNl bGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAnZGVidWcnKQotICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdyZXZlcnQnLCBUcnVlKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmYXN0 X2NvbW1pdF9xdWV1ZScsIFRydWUpCiAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9 U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdsYXlvdXQtdGVzdHMgKHNraXBwZWQpJykKICAgICAgICAg cmV0dXJuIHNlbGYucnVuU3RlcCgpCiAK