223951 2021-03-30 13:13:23 -0700 Add more information to GC verifier verbose dumps. 2021-03-30 13:23:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1745265 0 mark.lam 2021-03-30 13:13:23 -0700 Patch coming. 1745266 1 424680 mark.lam 2021-03-30 13:15:33 -0700 Created attachment 424680 proposed patch. 1745267 2 424680 ysuzuki 2021-03-30 13:16:45 -0700 Comment on attachment 424680 proposed patch. r=me 1745270 3 mark.lam 2021-03-30 13:22:15 -0700 Thanks for the review. Landed in r275229: <http://trac.webkit.org/r275229>. 1745271 4 webkit-bug-importer 2021-03-30 13:23:16 -0700 <rdar://problem/76018788> 424680 2021-03-30 13:15:33 -0700 2021-03-30 13:16:45 -0700 proposed patch. bug-223951.patch text/plain 2799 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1MjI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTAzLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgbW9yZSBpbmZvcm1hdGlvbiB0byBHQyB2ZXJpZmllciB2ZXJib3NlIGR1bXBzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzOTUxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoZWFwL1ZlcmlmaWVy U2xvdFZpc2l0b3IuY3BwOgorICAgICAgICAoSlNDOjpWZXJpZmllclNsb3RWaXNpdG9yOjpkdW1w TWFya2VyRGF0YSk6CisKIDIwMjEtMDMtMzAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIEVuc3VyZSB0aGF0IEdsb2JhbFByb3BlcnR5SW5mbyBpcyBhbGxvY2F0ZWQg b24gdGhlIHN0YWNrLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvVmVyaWZpZXJT bG90VmlzaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv VmVyaWZpZXJTbG90VmlzaXRvci5jcHAJKHJldmlzaW9uIDI3NTIxMSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL1ZlcmlmaWVyU2xvdFZpc2l0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNTIsNiArMjUyLDExIEBAIHZvaWQgVmVyaWZpZXJTbG90VmlzaXRvcjo6ZHVtcE1hcmtlckRh dGEKICAgICAgICAgaWYgKGNlbGwpIHsKICAgICAgICAgICAgIGlmIChpc0pTQ2VsbEtpbmQoY2Vs bC0+Y2VsbEtpbmQoKSkpCiAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKEpTVmFsdWUoc3RhdGlj X2Nhc3Q8SlNDZWxsKj4oY2VsbCkpKTsKKworICAgICAgICAgICAgYm9vbCBpc01hcmtlZCA9IGhl YXAoKS0+aXNNYXJrZWQoY2VsbCk7CisgICAgICAgICAgICBjb25zdCBjaGFyKiB3YXNPcldhc05v dCA9IGlzTWFya2VkID8gIndhcyIgOiAid2FzIE5PVCI7CisgICAgICAgICAgICBkYXRhTG9nTG4o IkluIHRoZSByZWFsIEdDLCBjZWxsICIsIFJhd1BvaW50ZXIoY2VsbCksICIgIiwgd2FzT3JXYXNO b3QsICIgbWFya2VkLiIpOworCiAgICAgICAgICAgICBpZiAoY2VsbC0+aXNQcmVjaXNlQWxsb2Nh dGlvbigpKQogICAgICAgICAgICAgICAgIG1hcmtlckRhdGEgPSBtYXJrZXJEYXRhRm9yUHJlY2lz ZUFsbG9jYXRpb24oY2VsbC0+cHJlY2lzZUFsbG9jYXRpb24oKSk7CiAgICAgICAgICAgICBlbHNl CkBAIC0yNjAsMjEgKzI2NSwyMSBAQCB2b2lkIFZlcmlmaWVyU2xvdFZpc2l0b3I6OmR1bXBNYXJr ZXJEYXRhCiAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKCJNYXJrZXIgZGF0YSBpcyBub3QgYXZh aWxhYmxlIGZvciBjZWxsICIsIFJhd1BvaW50ZXIoY2VsbCkpOwogICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgZGF0YUxvZygiQ2VsbCAiLCBSYXdQb2lu dGVyKGNlbGwpLCAiIHdhcyB2aXNpdGVkIik7CisgICAgICAgICAgICBkYXRhTG9nKCJJbiB0aGUg dmVyaWZpZXIgR0MsIGNlbGwgIiwgUmF3UG9pbnRlcihjZWxsKSwgIiB3YXMgdmlzaXRlZCIpOwog CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChvcGFxdWVSb290 KTsKIAogICAgICAgICAgICAgYm9vbCBjb250YWluc09wYXF1ZVJvb3QgPSBoZWFwKCktPm1fb3Bh cXVlUm9vdHMuY29udGFpbnMob3BhcXVlUm9vdCk7CiAgICAgICAgICAgICBjb25zdCBjaGFyKiB3 YXNPcldhc05vdCA9IGNvbnRhaW5zT3BhcXVlUm9vdCA/ICJ3YXMiIDogIndhcyBOT1QiOwotICAg ICAgICAgICAgZGF0YUxvZ0xuKCJJbiB0aGUgcmVhbCBHQywgb3BhcXVlIHJvb3QiLCBSYXdQb2lu dGVyKG9wYXF1ZVJvb3QpLCAiICIsIHdhc09yV2FzTm90LCAiIGFkZGVkIHRvIHRoZSBoZWFwJ3Mg b3BhcXVlIHJvb3RzLiIpOworICAgICAgICAgICAgZGF0YUxvZ0xuKCJJbiB0aGUgcmVhbCBHQywg b3BhcXVlIHJvb3QgIiwgUmF3UG9pbnRlcihvcGFxdWVSb290KSwgIiAiLCB3YXNPcldhc05vdCwg IiBhZGRlZCB0byB0aGUgaGVhcCdzIG9wYXF1ZSByb290cy4iKTsKIAogICAgICAgICAgICAgbWFy a2VyRGF0YSA9IG1hcmtlckRhdGFGb3JPcGFxdWVSb290KG9wYXF1ZVJvb3QpOwogICAgICAgICAg ICAgaWYgKCFtYXJrZXJEYXRhKSB7CiAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKCJNYXJrZXIg ZGF0YSBpcyBub3QgYXZhaWxhYmxlIGZvciBvcGFxdWUgcm9vdCAiLCBSYXdQb2ludGVyKG9wYXF1 ZVJvb3QpKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KLSAgICAgICAg ICAgIGRhdGFMb2coIk9wYXF1ZSByb290ICIsIFJhd1BvaW50ZXIob3BhcXVlUm9vdCksICIgd2Fz IGFkZGVkIik7CisgICAgICAgICAgICBkYXRhTG9nKCJJbiB0aGUgdmVyaWZpZXIgR0MsIG9wYXF1 ZSByb290ICIsIFJhd1BvaW50ZXIob3BhcXVlUm9vdCksICIgd2FzIGFkZGVkIik7CiAgICAgICAg IH0KIAogICAgICAgICBSZWZlcnJlclRva2VuIHJlZmVycmVyID0gbWFya2VyRGF0YS0+cmVmZXJy ZXIoKTsK