223942 2021-03-30 11:37:37 -0700 Add confirmation prompt to discourage manual commits 2021-04-06 11:38:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=223954 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist glenn jbedard ryanhaddad sam webkit-bug-importer oldest_to_newest 1745200 0 aakash_jain 2021-03-30 11:37:37 -0700 Add a confirmation prompt which appears while doing manual committing (e.g.: through webkit-patch land) to discourage manual commits. Manual commits will not be allowed after we move to github. So, it would be good to provide such warning so that people can either start using commit-queue, or let us know the reason for manual commits, so that commit-queue can be improved. 1745219 1 424672 aakash_jain 2021-03-30 11:58:27 -0700 Created attachment 424672 Patch 1745226 2 aakash_jain 2021-03-30 12:05:26 -0700 unit-tests needs to be updated, but would be nice to have it reviewed meanwhile. 1745235 3 424672 jbedard 2021-03-30 12:18:07 -0700 Comment on attachment 424672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424672&action=review Looks good, just need to update the unit tests. > Tools/Scripts/webkitpy/tool/steps/commit.py:72 > + warning_message += '\nIn future, when WebKit moves to github, manual commiting would not be allowed.' github -> GitHub 1745237 4 424672 sam 2021-03-30 12:22:31 -0700 Comment on attachment 424672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424672&action=review > Tools/Scripts/webkitpy/tool/steps/commit.py:74 > + warning_message += '\nIn you have a specific reason for manual commit, please let us know at admin@webkit.org or please file a bug.' > + warning_message += '\nAre you sure you want to continue with manual committing?' Manual committing is very useful for quick typo fixes and build fixes. This doesn't seem like a great new rule to push on the community, especially if we don't have big problem with it. 1745241 5 jbedard 2021-03-30 12:38:44 -0700 (In reply to Sam Weinig from comment #4) > Comment on attachment 424672 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424672&action=review > > > Tools/Scripts/webkitpy/tool/steps/commit.py:74 > > + warning_message += '\nIn you have a specific reason for manual commit, please let us know at admin@webkit.org or please file a bug.' > > + warning_message += '\nAre you sure you want to continue with manual committing?' > > Manual committing is very useful for quick typo fixes and build fixes. This > doesn't seem like a great new rule to push on the community, especially if > we don't have big problem with it. We don't have a great way to do any pre-commit validation in GitHub the way we do in Subversion. This is important for things like enforcing rules with tabs, adding identifiers to commit messages, rejecting changes with "OOPS" in them. To address build-fix/type style changes, the plan is to have a fast-path commit-queue that works the way current commit queue does when EWS was successful. 1746250 6 aakash_jain 2021-04-01 13:55:03 -0700 > To address build-fix/type style changes, the plan is to have a fast-path commit-queue that works the way current commit queue does when EWS was successful. Note that the fast-commit-queue will also skip Building. It should take it only ~1 minute to land the patch. We just add the fast-commit-queue mode in https://bugs.webkit.org/show_bug.cgi?id=223954. We also plan to add webkit-patch support for it (e.g.: using --fast-cq parameter). 1747546 7 webkit-bug-importer 2021-04-06 11:38:17 -0700 <rdar://problem/76276805> 424672 2021-03-30 11:58:27 -0700 2021-03-30 17:04:33 -0700 Patch bug-223942-20210330115826.patch text/plain 2222 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTIxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAzLTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgY29uZmlybWF0aW9uIHByb21wdCB0byBkaXNjb3VyYWdlIG1hbnVh bCBjb21taXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjM5NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHk6CisgICAgICAgIChDb21t aXQud2Fybl9mb3JfbWFudWFsX2NvbW1pdCk6IE1ldGhvZCB0byBkaXNwbGF5IHdhcm5pbmcgd2hp bGUgZG9pbmcgbWFudWFsIGNvbW1pdC4KKyAgICAgICAgKENvbW1pdC5ydW4pOgorCiAyMDIxLTAz LTI5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFs bG93IG5vbi02MGZwcyBkaXNwbGF5IHVwZGF0ZXMgdG8gYmUgZHJpdmVuIGJ5IERpc3BsYXlSZWZy ZXNoTW9uaXRvcgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1p dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29t bWl0LnB5CShyZXZpc2lvbiAyNzUyMTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvY29tbWl0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02NywxMSArNjcsMjAgQEAgY2xhc3Mg Q29tbWl0KEFic3RyYWN0U3RlcCk6CiAgICAgICAgICAgICBpZiBub3Qgc2VsZi5fdG9vbC51c2Vy LmNvbmZpcm0oIkFyZSB5b3Ugc3VyZSB5b3Ugd2FudCB0byBjb250aW51ZT8iLCBkZWZhdWx0PSJu Iik6CiAgICAgICAgICAgICAgICAgc2VsZi5fZXhpdCgxKQogCisgICAgZGVmIHdhcm5fZm9yX21h bnVhbF9jb21taXQoc2VsZik6CisgICAgICAgIHdhcm5pbmdfbWVzc2FnZSA9ICdcbk1hbnVhbCBj b21taXR0aW5nIGlzIGRpc2NvdXJhZ2VkLiBQbGVhc2UgdXNlIGNvbW1pdC1xdWV1ZSB0byBjb21t aXQgeW91ciBjaGFuZ2VzLicKKyAgICAgICAgd2FybmluZ19tZXNzYWdlICs9ICdcbkluIGZ1dHVy ZSwgd2hlbiBXZWJLaXQgbW92ZXMgdG8gZ2l0aHViLCBtYW51YWwgY29tbWl0aW5nIHdvdWxkIG5v dCBiZSBhbGxvd2VkLicKKyAgICAgICAgd2FybmluZ19tZXNzYWdlICs9ICdcbkluIHlvdSBoYXZl IGEgc3BlY2lmaWMgcmVhc29uIGZvciBtYW51YWwgY29tbWl0LCBwbGVhc2UgbGV0IHVzIGtub3cg YXQgYWRtaW5Ad2Via2l0Lm9yZyBvciBwbGVhc2UgZmlsZSBhIGJ1Zy4nCisgICAgICAgIHdhcm5p bmdfbWVzc2FnZSArPSAnXG5BcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gY29udGludWUgd2l0aCBt YW51YWwgY29tbWl0dGluZz8nCisgICAgICAgIGlmIG5vdCBzZWxmLl90b29sLnVzZXIuY29uZmly bSh3YXJuaW5nX21lc3NhZ2UsIGRlZmF1bHQ9Im4iKToKKyAgICAgICAgICAgIHNlbGYuX2V4aXQo MSkKKwogICAgIGRlZiBydW4oc2VsZiwgc3RhdGUpOgogICAgICAgICBzZWxmLl9jb21taXRfbWVz c2FnZSA9IHNlbGYuX3Rvb2wuY2hlY2tvdXQoKS5jb21taXRfbWVzc2FnZV9mb3JfdGhpc19jb21t aXQoc2VsZi5fb3B0aW9ucy5naXRfY29tbWl0KS5tZXNzYWdlKCkKICAgICAgICAgaWYgbGVuKHNl bGYuX2NvbW1pdF9tZXNzYWdlKSA8IDEwOgogICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJB dHRlbXB0ZWQgdG8gY29tbWl0IHdpdGggYSBjb21taXQgbWVzc2FnZSBzaG9ydGVyIHRoYW4gMTAg Y2hhcmFjdGVycy4gIEVpdGhlciB5b3VyIHBhdGNoIGlzIG1pc3NpbmcgYSBDaGFuZ2VMb2cgb3Ig d2Via2l0LXBhdGNoIG1heSBoYXZlIGEgYnVnLiIpCiAKKyAgICAgICAgc2VsZi53YXJuX2Zvcl9t YW51YWxfY29tbWl0KCkKICAgICAgICAgc2VsZi5fY2hlY2tfdGVzdF9leHBlY3RhdGlvbnMoc2Vs Zi5fY2hhbmdlZF9maWxlcyhzdGF0ZSkpCiAgICAgICAgIHNlbGYuX3N0YXRlID0gc3RhdGUKIAo=