223939 2021-03-30 10:40:39 -0700 [ews] Make RunWebKitTests class easy to extend 2021-03-30 11:55:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223938 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1745179 0 aakash_jain 2021-03-30 10:40:39 -0700 Make RunWebKitTests class easy to extend, especially start() method which does bunch of things like setting up the layout-tests command and starting the step. 1745184 1 424660 aakash_jain 2021-03-30 10:58:17 -0700 Created attachment 424660 Patch 1745215 2 ews-feeder 2021-03-30 11:54:17 -0700 Committed r275218: <https://commits.webkit.org/r275218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424660. 1745216 3 webkit-bug-importer 2021-03-30 11:55:16 -0700 <rdar://problem/76014760> 424660 2021-03-30 10:58:17 -0700 2021-03-30 11:54:18 -0700 Patch bug-223939-20210330135816.patch text/plain 3290 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTIxNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTAzLTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBNYWtlIFJ1bldlYktpdFRlc3RzIGNsYXNzIGVhc3kgdG8gZXh0 ZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM5 MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChSdW5XZWJLaXRUZXN0cyk6Cisg ICAgICAgIChSdW5XZWJLaXRUZXN0cy5zZXRMYXlvdXRUZXN0Q29tbWFuZCk6IFNlcGFyYXRlZCBv dXQgY29kZSB0byBzZXQgdGhlIGxheW91dC10ZXN0IGNvbW1hbmQuCisgICAgICAgIChSdW5XZWJL aXRUZXN0cy5zdGFydCk6CisKIDIwMjEtMDMtMzAgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtld3NdIEFkZCBidWlsZCBzdGVwIHRvIGZpbmQgbGlzdCBv ZiBsYXlvdXQgdGVzdHMgbW9kaWZpZWQgYnkgYSBwYXRjaApJbmRleDogVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzUyMTQpCisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMDYzLDYgKzIwNjMsNyBAQCBjbGFzcyBS dW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICBqc29uRmlsZU5hbWUgPSAnbGF5b3V0LXRl c3QtcmVzdWx0cy9mdWxsX3Jlc3VsdHMuanNvbicKICAgICBsb2dmaWxlcyA9IHsnanNvbic6IGpz b25GaWxlTmFtZX0KICAgICB0ZXN0X2ZhaWx1cmVzX2xvZ19uYW1lID0gJ3Rlc3QtZmFpbHVyZXMn CisgICAgRVhJVF9BRlRFUl9GQUlMVVJFUyA9ICczMCcKICAgICBjb21tYW5kID0gWydweXRob24n LCAnVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzJywKICAgICAgICAgICAgICAgICctLW5v LWJ1aWxkJywKICAgICAgICAgICAgICAgICctLW5vLXNob3ctcmVzdWx0cycsCkBAIC0yMDg0LDEy ICsyMDg1LDcgQEAgY2xhc3MgUnVuV2ViS2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgIHJl dHVybiBub3QgKChzZWxmLmdldFByb3BlcnR5KCdidWlsZGVybmFtZScsICcnKS5sb3dlcigpID09 ICdjb21taXQtcXVldWUnKSBhbmQKICAgICAgICAgICAgICAgICAgICAgKHNlbGYuZ2V0UHJvcGVy dHkoJ3JldmVydCcpIG9yIHNlbGYuZ2V0UHJvcGVydHkoJ3Bhc3NlZF9tYWNfd2syJykpKQogCi0g ICAgZGVmIHN0YXJ0KHNlbGYpOgotICAgICAgICBzZWxmLmxvZ19vYnNlcnZlciA9IGxvZ29ic2Vy dmVyLkJ1ZmZlckxvZ09ic2VydmVyKHdhbnRTdGRlcnI9VHJ1ZSkKLSAgICAgICAgc2VsZi5hZGRM b2dPYnNlcnZlcignc3RkaW8nLCBzZWxmLmxvZ19vYnNlcnZlcikKLSAgICAgICAgc2VsZi5sb2df b2JzZXJ2ZXJfanNvbiA9IGxvZ29ic2VydmVyLkJ1ZmZlckxvZ09ic2VydmVyKCkKLSAgICAgICAg c2VsZi5hZGRMb2dPYnNlcnZlcignanNvbicsIHNlbGYubG9nX29ic2VydmVyX2pzb24pCi0KKyAg ICBkZWYgc2V0TGF5b3V0VGVzdENvbW1hbmQoc2VsZik6CiAgICAgICAgIHBsYXRmb3JtID0gc2Vs Zi5nZXRQcm9wZXJ0eSgncGxhdGZvcm0nKQogICAgICAgICBhcHBlbmRDdXN0b21CdWlsZEZsYWdz KHNlbGYsIHBsYXRmb3JtLCBzZWxmLmdldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nKSkKICAgICAg ICAgYWRkaXRpb25hbEFyZ3VtZW50cyA9IHNlbGYuZ2V0UHJvcGVydHkoJ2FkZGl0aW9uYWxBcmd1 bWVudHMnKQpAQCAtMjEwNCw3ICsyMTAwLDcgQEAgY2xhc3MgUnVuV2ViS2l0VGVzdHMoc2hlbGwu VGVzdCk6CiAgICAgICAgIGlmIHBhdGNoX2F1dGhvciBpbiBbJ3dlYmtpdC13cHQtaW1wb3J0LWJv dEBpZ2FsaWEuY29tJ106CiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5k ICsgWydpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzJ10pCiAgICAgICAgIGVsc2U6Ci0g ICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLWV4aXQtYWZ0ZXIt bi1mYWlsdXJlcycsICczMCcsICctLXNraXAtZmFpbGluZy10ZXN0cyddKQorICAgICAgICAgICAg c2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS1leGl0LWFmdGVyLW4tZmFpbHVyZXMn LCBzZWxmLkVYSVRfQUZURVJfRkFJTFVSRVMsICctLXNraXAtZmFpbGluZy10ZXN0cyddKQogCiAg ICAgICAgIGlmIGFkZGl0aW9uYWxBcmd1bWVudHM6CiAgICAgICAgICAgICBzZWxmLnNldENvbW1h bmQoc2VsZi5jb21tYW5kICsgYWRkaXRpb25hbEFyZ3VtZW50cykKQEAgLTIxMzQsNiArMjEzMCwx MiBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAgICAgICAgICAg ICAgbGlzdF9yZXRyeV90ZXN0cyA9IHNvcnRlZChmaXJzdF9yZXN1bHRzX2ZhaWxpbmdfdGVzdHMu dW5pb24oc2Vjb25kX3Jlc3VsdHNfZmFpbGluZ190ZXN0cykpCiAgICAgICAgICAgICAgICAgICAg IHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBsaXN0X3JldHJ5X3Rlc3RzKQogCisgICAg ZGVmIHN0YXJ0KHNlbGYpOgorICAgICAgICBzZWxmLmxvZ19vYnNlcnZlciA9IGxvZ29ic2VydmVy LkJ1ZmZlckxvZ09ic2VydmVyKHdhbnRTdGRlcnI9VHJ1ZSkKKyAgICAgICAgc2VsZi5hZGRMb2dP YnNlcnZlcignc3RkaW8nLCBzZWxmLmxvZ19vYnNlcnZlcikKKyAgICAgICAgc2VsZi5sb2dfb2Jz ZXJ2ZXJfanNvbiA9IGxvZ29ic2VydmVyLkJ1ZmZlckxvZ09ic2VydmVyKCkKKyAgICAgICAgc2Vs Zi5hZGRMb2dPYnNlcnZlcignanNvbicsIHNlbGYubG9nX29ic2VydmVyX2pzb24pCisgICAgICAg IHNlbGYuc2V0TGF5b3V0VGVzdENvbW1hbmQoKQogICAgICAgICByZXR1cm4gc2hlbGwuVGVzdC5z dGFydChzZWxmKQogCiAgICAgIyBGSVhNRTogVGhpcyB3aWxsIGJyZWFrIGlmIHJ1bi13ZWJraXQt dGVzdHMgY2hhbmdlcyBpdHMgZGVmYXVsdCBsb2cgZm9ybWF0dGVyLgo=