223908 2021-03-29 18:31:58 -0700 Web Inspector: CSS Grid overlay track sizes are incorrect when inline styles are applied to the element 2021-03-31 10:49:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle bburg ews-watchlist graouts hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1745006 0 pangle 2021-03-29 18:31:58 -0700 For elements that have inline style attributes, those column and row sizes should be shown as the authored values. Instead, we currently show the most specific CSS rule's values that apply instead. 1745007 1 webkit-bug-importer 2021-03-29 18:32:16 -0700 <rdar://problem/75983927> 1745009 2 424608 pangle 2021-03-29 18:41:38 -0700 Created attachment 424608 Patch v1.0 1745329 3 424608 bburg 2021-03-30 14:33:58 -0700 Comment on attachment 424608 Patch v1.0 r=me 1745688 4 ews-feeder 2021-03-31 10:49:12 -0700 Committed r275293: <https://commits.webkit.org/r275293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424608. 424608 2021-03-29 18:41:38 -0700 2021-03-31 10:49:13 -0700 Patch v1.0 bug-223908-20210329184137.patch text/plain 3154 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJlOTY0ODEwMGUyMDI3 YTIyZDk3YWMzMzhmZjZjODUwYzQwNGM0Ni4uOGE3NjBjNTNhOGVmOWU4NWJlNDZmMzNjYTRhMDFj MmU1YjlmOWZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAzLTI5ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD U1MgR3JpZCBvdmVybGF5IHRyYWNrIHNpemVzIGFyZSBpbmNvcnJlY3Qgd2hlbiBpbmxpbmUgc3R5 bGVzIGFyZSBhcHBsaWVkIHRvIHRoZSBlbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM5MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2hlY2tpbmcgdGhlIGlubGluZSBzdHlsZSBhdHRy aWJ1dGVzIG9uIGFuIGVsZW1lbnQgd2hlbiBjb2xsZWN0aW5nIGF1dGhvcmVkIHRyYWNrIHNpemVz IGZvciBncmlkIG92ZXJsYXlzLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJs YXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXV0aG9yZWRHcmlkVHJhY2tTaXplcyk6CisKIDIw MjEtMDMtMjggIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92 ZSBKU0N1c3RvbVhQYXRoTlNSZXNvbHZlci5oL0pTQ3VzdG9tWFBhdGhOU1Jlc29sdmVyLmNwcCBm cm9tIHRoZSBYY29kZSBwcm9qZWN0IGFzIHRoZXkgZG9uJ3QgZXhpc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAppbmRleCBhNDQ4NmZhMWY4ZWY5NTYz NTYwOWVkYjY1ZmFmMDJlMDIzNDEzYzczLi4yNmM1ZWNkZmM2NjkzN2FjYjM3MjM2Zjc0MzliMDRh MGU1MmMzMzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y T3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJs YXkuY3BwCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSAiQ1NTR3JpZEF1dG9SZXBlYXRWYWx1 ZS5oIgogI2luY2x1ZGUgIkNTU0dyaWRJbnRlZ2VyUmVwZWF0VmFsdWUuaCIKICNpbmNsdWRlICJD U1NHcmlkTGluZU5hbWVzVmFsdWUuaCIKKyNpbmNsdWRlICJDU1NTdHlsZURlY2xhcmF0aW9uLmgi CiAjaW5jbHVkZSAiRE9NQ1NTTmFtZXNwYWNlLmgiCiAjaW5jbHVkZSAiRE9NVG9rZW5MaXN0Lmgi CiAjaW5jbHVkZSAiRWxlbWVudC5oIgpAQCAtMTQ5NCwyMCArMTQ5NSwyNCBAQCB2b2lkIEluc3Bl Y3Rvck92ZXJsYXk6OmRyYXdHcmlkT3ZlcmxheShHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNv bnN0IEluc3BlY3RvcgogCiBzdGF0aWMgVmVjdG9yPFN0cmluZz4gYXV0aG9yZWRHcmlkVHJhY2tT aXplcyhOb2RlKiBub2RlLCBHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGlyZWN0aW9uLCB1bnNp Z25lZCBleHBlY3RlZFRyYWNrQ291bnQpCiB7Ci0gICAgaWYgKCFpczxFbGVtZW50Pihub2RlKSkK KyAgICBpZiAoIWlzPFN0eWxlZEVsZW1lbnQ+KG5vZGUpKQogICAgICAgICByZXR1cm4geyB9Owot ICAgIAotICAgIGF1dG8gZWxlbWVudCA9IGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpOwotICAgIGF1 dG8gc3R5bGVSdWxlcyA9IGVsZW1lbnQtPnN0eWxlUmVzb2x2ZXIoKS5zdHlsZVJ1bGVzRm9yRWxl bWVudChlbGVtZW50KTsKLSAgICBzdHlsZVJ1bGVzLnJldmVyc2UoKTsKLSAgICBSZWZQdHI8Q1NT VmFsdWU+IGNzc1ZhbHVlOwotICAgIGZvciAoYXV0byBzdHlsZVJ1bGUgOiBzdHlsZVJ1bGVzKSB7 Ci0gICAgICAgIEFTU0VSVChzdHlsZVJ1bGUpOwotICAgICAgICBpZiAoIXN0eWxlUnVsZSkKLSAg ICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBjc3NWYWx1ZSA9IHN0eWxlUnVsZS0+cHJvcGVy dGllcygpLmdldFByb3BlcnR5Q1NTVmFsdWUoZGlyZWN0aW9uID09IEdyaWRUcmFja1NpemluZ0Rp cmVjdGlvbjo6Rm9yQ29sdW1ucyA/IENTU1Byb3BlcnR5SUQ6OkNTU1Byb3BlcnR5R3JpZFRlbXBs YXRlQ29sdW1ucyA6IENTU1Byb3BlcnR5SUQ6OkNTU1Byb3BlcnR5R3JpZFRlbXBsYXRlUm93cyk7 Ci0gICAgICAgIGlmIChjc3NWYWx1ZSkKLSAgICAgICAgICAgIGJyZWFrOworCisgICAgYXV0byBl bGVtZW50ID0gZG93bmNhc3Q8U3R5bGVkRWxlbWVudD4obm9kZSk7CisgICAgYXV0byBkaXJlY3Rp b25DU1NQcm9wZXJ0eUlEID0gZGlyZWN0aW9uID09IEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbjo6 Rm9yQ29sdW1ucyA/IENTU1Byb3BlcnR5SUQ6OkNTU1Byb3BlcnR5R3JpZFRlbXBsYXRlQ29sdW1u cyA6IENTU1Byb3BlcnR5SUQ6OkNTU1Byb3BlcnR5R3JpZFRlbXBsYXRlUm93czsKKyAgICBSZWZQ dHI8Q1NTVmFsdWU+IGNzc1ZhbHVlID0gZWxlbWVudC0+Y3Nzb21TdHlsZSgpLmdldFByb3BlcnR5 Q1NTVmFsdWVJbnRlcm5hbChkaXJlY3Rpb25DU1NQcm9wZXJ0eUlEKTsKKworICAgIGlmICghY3Nz VmFsdWUpIHsKKyAgICAgICAgYXV0byBzdHlsZVJ1bGVzID0gZWxlbWVudC0+c3R5bGVSZXNvbHZl cigpLnN0eWxlUnVsZXNGb3JFbGVtZW50KGVsZW1lbnQpOworICAgICAgICBzdHlsZVJ1bGVzLnJl dmVyc2UoKTsKKyAgICAgICAgZm9yIChhdXRvIHN0eWxlUnVsZSA6IHN0eWxlUnVsZXMpIHsKKyAg ICAgICAgICAgIEFTU0VSVChzdHlsZVJ1bGUpOworICAgICAgICAgICAgaWYgKCFzdHlsZVJ1bGUp CisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICBjc3NWYWx1ZSA9IHN0eWxl UnVsZS0+cHJvcGVydGllcygpLmdldFByb3BlcnR5Q1NTVmFsdWUoZGlyZWN0aW9uQ1NTUHJvcGVy dHlJRCk7CisgICAgICAgICAgICBpZiAoY3NzVmFsdWUpCisgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgIH0KICAgICB9CiAgICAgCiAgICAgaWYgKCFjc3NWYWx1ZSB8fCAhaXM8Q1NTVmFs dWVMaXN0Pihjc3NWYWx1ZSkpCg==