223889 2021-03-29 11:36:48 -0700 Some WPT are failing because of colors being in the wrong format 2021-04-05 11:37:33 -0700 1 1 1 Unclassified WebKit CSS Safari 14 Unspecified Unspecified NEW InRadar P2 Normal --- 1 ntim webkit-unassigned graouts koivisto sam simon.fraser webkit-bug-importer oldest_to_newest 1744804 0 ntim 2021-03-29 11:36:48 -0700 Example: https://webkit-search.igalia.com/webkit/source/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt 1744810 1 424555 sam 2021-03-29 11:47:15 -0700 Created attachment 424555 Minimal test case 1744812 2 sam 2021-03-29 11:48:48 -0700 Looks like something (likely CSSGradientValue) is not resolving color identifiers down to Colors before serializing. 1744857 3 sam 2021-03-29 13:19:28 -0700 I haven't dropped into the debugger yet, but I am pretty sure this happening in ComputedStyleExtractor::valueForPropertyInStyle(): case CSSPropertyBackgroundImage: case CSSPropertyWebkitMaskImage: { auto& layers = propertyID == CSSPropertyWebkitMaskImage ? style.maskLayers() : style.backgroundLayers(); if (!layers.next()) { if (layers.image()) return layers.image()->cssValue(); return cssValuePool.createIdentifierValue(CSSValueNone); } auto list = CSSValueList::createCommaSeparated(); for (auto* currLayer = &layers; currLayer; currLayer = currLayer->next()) { if (currLayer->image()) list->append(currLayer->image()->cssValue()); else list->append(cssValuePool.createIdentifierValue(CSSValueNone)); } return list; } When the `layers.image()->cssValue()` call happens, the `image()`, which is of type CSSGradientValue, has not had its color styles resolved. You can see in the lines above it what a call with color resolving looks like: case CSSPropertyBackgroundColor: return m_allowVisitedStyle ? cssValuePool.createColorValue(style.visitedDependentColor(CSSPropertyBackgroundColor)) : currentColorOrValidColor(&style, style.backgroundColor()); So, somehow, we need to resolve those colors. 1744859 4 sam 2021-03-29 13:19:41 -0700 Antti, any ideas on a good pattern for this? 1747031 5 webkit-bug-importer 2021-04-05 11:37:33 -0700 <rdar://problem/76226756> 424555 2021-03-29 11:47:15 -0700 2021-03-29 11:47:15 -0700 Minimal test case testcase.html text/html 913 sam PHByZSBpZD0ibG9nIj48L3ByZT4KCjxzY3JpcHQ+CgogICAgZnVuY3Rpb24gbG9nKG1zZykKICAg IHsKICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibG9nIikuYXBwZW5kKG1zZyArICJc biIpOwogICAgfQoKICAgIGZ1bmN0aW9uIGNvbXB1dGVkU3R5bGUocHJvcGVydHksIHZhbHVlKQog ICAgewogICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAg ICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdik7CiAgICAgICAgZGl2LnN0eWxlLnNl dFByb3BlcnR5KHByb3BlcnR5LCB2YWx1ZSk7CiAgICAgICAgdmFyIGNvbXB1dGVkVmFsdWUgPSBn ZXRDb21wdXRlZFN0eWxlKGRpdikuZ2V0UHJvcGVydHlWYWx1ZShwcm9wZXJ0eSk7CiAgICAgICAg ZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkaXYpOwogICAgICAgIHJldHVybiBjb21wdXRlZFZh bHVlOwogICAgfQoKICAgIGZ1bmN0aW9uIHRlc3RDb21wdXRlZFByb3BlcnR5KHByb3BlcnR5LCB2 YWx1ZSwgZXhwZWN0ZWQpCiAgICB7CiAgICAgICAgY29uc3QgcmVzdWx0ID0gY29tcHV0ZWRTdHls ZShwcm9wZXJ0eSwgdmFsdWUpOwogICAgICAgIGlmIChyZXN1bHQgPT0gZXhwZWN0ZWQpCiAgICAg ICAgICAgIGxvZyhgU3VjY2VzcyFgKTsKICAgICAgICBlbHNlCiAgICAgICAgICAgIGxvZyhgRmFp bCE6IFJlc3VsdCBpcyAnJHtyZXN1bHR9JywgZXhwZWN0ZWQgJyR7ZXhwZWN0ZWR9J2ApOwogICAg fQoKICAgIHRlc3RDb21wdXRlZFByb3BlcnR5KCdiYWNrZ3JvdW5kLWltYWdlJywgJ2xpbmVhci1n cmFkaWVudCh0byBsZWZ0IGJvdHRvbSwgcmVkLCBibHVlKScsICdsaW5lYXItZ3JhZGllbnQodG8g bGVmdCBib3R0b20sIHJnYigyNTUsIDAsIDApLCByZ2IoMCwgMCwgMjU1KSknKTsKCjwvc2NyaXB0 Pg==