22387 2008-11-20 11:44:52 -0800 Add a test for the HTMLOptionsCollection indexed setter 2008-11-20 15:20:24 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam pam oldest_to_newest 99522 0 pam 2008-11-20 11:44:52 -0800 Simple test. 99523 1 25321 pam 2008-11-20 11:48:02 -0800 Created attachment 25321 New test + result 99525 2 25321 darin 2008-11-20 11:52:02 -0800 Comment on attachment 25321 New test + result r=me It's a little sad to have these one-off tests when they could easily be changed to have more coverage. It makes our test suite run a lot faster when individual tests can test more than one closely-related thing. 99538 3 25323 pam 2008-11-20 13:52:39 -0800 Created attachment 25323 Better new test, checks function-style getter too Combining the next one on my list with this one, and using the JS wrapper. Sorry for the wasted previous review. 99539 4 25321 pam 2008-11-20 13:53:28 -0800 Comment on attachment 25321 New test + result Clearing r+ on obsolete patch. 99544 5 25323 darin 2008-11-20 14:07:12 -0800 Comment on attachment 25323 Better new test, checks function-style getter too r=me 99547 6 pam 2008-11-20 15:20:24 -0800 Landed in r38633. 25321 2008-11-20 11:48:02 -0800 2008-11-20 13:53:28 -0800 New test + result 22387a.txt text/plain 1939 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NjI1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MjAgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjM4NworICAgICAgICBBZGQgYSB0ZXN0IGZvciB0aGUgSFRNTE9wdGlv bnNDb2xlbGN0aW9uIGluZGV4ZWQgc2V0dGVyLgorCisgICAgICAgICogZmFzdC9kb20vSFRNTE9w dGlvbkVsZW1lbnQvaW5kZXhlZC1zZXR0ZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2RvbS9IVE1MT3B0aW9uRWxlbWVudC9pbmRleGVkLXNldHRlci5odG1sOiBBZGRlZC4K KwogMjAwOC0xMS0yMCAgQ2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCkluZGV4OiBmYXN0L2RvbS9IVE1MT3B0aW9u RWxlbWVudC9pbmRleGVkLXNldHRlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZmFzdC9k b20vSFRNTE9wdGlvbkVsZW1lbnQvaW5kZXhlZC1zZXR0ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1lbnQvaW5kZXhlZC1zZXR0ZXItZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1B1cnBvc2U6IFRlc3RzIHRoZSBp bmRleGVkIHNldHRlciBmb3IgSFRNTE9wdGlvbnNDb2xsZWN0aW9uIGJ5IGFkZGluZyBpdGVtcyB0 byBhIHNlbGVjdCBjb250cm9sIGR5bmFtaWNhbGx5LiBZb3Ugc2hvdWxkIHNlZSAiVEVTVCBQQVNT RUQiIGJlbG93LgorCitURVNUIFBBU1NFRApJbmRleDogZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1l bnQvaW5kZXhlZC1zZXR0ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2RvbS9IVE1MT3B0aW9u RWxlbWVudC9pbmRleGVkLXNldHRlci5odG1sCShyZXZpc2lvbiAwKQorKysgZmFzdC9kb20vSFRN TE9wdGlvbkVsZW1lbnQvaW5kZXhlZC1zZXR0ZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyNSBAQAorPEhUTUw+Cis8Qk9EWT4KK1B1cnBvc2U6IFRlc3RzIHRoZSBpbmRleGVkIHNldHRl ciBmb3IgSFRNTE9wdGlvbnNDb2xsZWN0aW9uIGJ5IGFkZGluZyBpdGVtcyB0bworYSBzZWxlY3Qg Y29udHJvbCBkeW5hbWljYWxseS4gIFlvdSBzaG91bGQgc2VlICJURVNUIFBBU1NFRCIgYmVsb3cu Cis8Zm9ybSBuYW1lPSJRdWlja0Zvcm0iPgorPHNlbGVjdCBuYW1lPSJzZWwiID4KKzxvcHRpb24g dmFsdWU9IiI+PT09PT09PTwvb3B0aW9uPgorPC9zZWxlY3Q+Cis8L0ZPUk0+CisKKzxzY3JpcHQ+ CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKworZG9jdW1lbnQuUXVpY2tGb3JtLnNlbC5vcHRpb25zWzFdID0g bmV3IE9wdGlvbigiQSIpOworZG9jdW1lbnQuUXVpY2tGb3JtLnNlbC5vcHRpb25zWzJdID0gbmV3 IE9wdGlvbigiQiIpOworaWYgKFF1aWNrRm9ybS5zZWwub3B0aW9ucy5sZW5ndGggPT0gMykgewor ICAgIGRvY3VtZW50LndyaXRlKCJURVNUIFBBU1NFRCIpOworfSBlbHNlIHsKKyAgICBkb2N1bWVu dC53cml0ZSgiVEVTVCBGQUlMRUQiKTsKK30KKzwvc2NyaXB0PgorCis8L0JPRFk+Cis8L0hUTUw+ Cg== 25323 2008-11-20 13:52:39 -0800 2008-11-20 14:07:12 -0800 Better new test, checks function-style getter too 22387b.txt text/plain 2631 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NjI5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MjAgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjM4NworICAgICAgICBBZGQgYSB0ZXN0IGZvciBIVE1MT3B0aW9uc0Nv bGxlY3Rpb24gaW5kZXhlZCBnZXR0ZXIgYW5kIHNldHRlci4KKworICAgICAgICAqIGZhc3QvZG9t L0hUTUxPcHRpb25FbGVtZW50L2NvbGxlY3Rpb24tc2V0dGVyLWdldHRlci1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxPcHRpb25FbGVtZW50L2NvbGxlY3Rpb24t c2V0dGVyLWdldHRlci5odG1sOiBBZGRlZC4KKwogMjAwOC0xMS0yMCAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSB1cGRhdGUgdGVzdCByZXN1bHQgZm9yIDxyZGFy Oi8vcHJvYmxlbS80MTA4NTcyPiBSRUdSRVNTSU9OOiBDYW4ndCBleHRlbmQKSW5kZXg6IGZhc3Qv ZG9tL0hUTUxPcHRpb25FbGVtZW50L2NvbGxlY3Rpb24tc2V0dGVyLWdldHRlci1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gZmFzdC9kb20vSFRNTE9wdGlvbkVsZW1lbnQvY29sbGVjdGlvbi1z ZXR0ZXItZ2V0dGVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL0hUTUxP cHRpb25FbGVtZW50L2NvbGxlY3Rpb24tc2V0dGVyLWdldHRlci1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMTIgQEAKK1Rlc3RzIHRoZSBpbmRleGVkIHNldHRlciBhbmQgZ2V0 dGVyIGZvciBIVE1MT3B0aW9uc0NvbGxlY3Rpb24uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCitQQVNTIG15X2Zvcm0uc2V0X3NlbC5vcHRpb25zLmxlbmd0aCBpcyAzCitQQVNTIG9w dGlvbnMoMCkgaXMgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29uZScpCitQQVNTIG9wdGlvbnMo MSkgaXMgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3R3bycpCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKyAgCkluZGV4OiBmYXN0L2RvbS9IVE1MT3B0 aW9uRWxlbWVudC9jb2xsZWN0aW9uLXNldHRlci1nZXR0ZXIuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBm YXN0L2RvbS9IVE1MT3B0aW9uRWxlbWVudC9jb2xsZWN0aW9uLXNldHRlci1nZXR0ZXIuaHRtbAko cmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL0hUTUxPcHRpb25FbGVtZW50L2NvbGxlY3Rpb24tc2V0 dGVyLWdldHRlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM2IEBACis8aHRtbD4KKzxo ZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+ PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxmb3JtIG5hbWU9Im15X2Zvcm0iPgor PHNlbGVjdCBuYW1lPSJzZXRfc2VsIj4KKyAgICA8b3B0aW9uIGlkPSdvcHQnPj09PT09PT09PC9v cHRpb24+Cis8L3NlbGVjdD4KKworPHNlbGVjdCBuYW1lPSJnZXRfc2VsIj4KKyAgICA8b3B0aW9u IGlkPSJvbmUiPm9wdGlvbiAxPC9vcHRpb24+CisgICAgPG9wdGlvbiBpZD0idHdvIj5vcHRpb24g Mjwvb3B0aW9uPgorPC9zZWxlY3Q+Cis8L2Zvcm0+CisKKzxzY3JpcHQ+CitkZXNjcmlwdGlvbign VGVzdHMgdGhlIGluZGV4ZWQgc2V0dGVyIGFuZCBnZXR0ZXIgZm9yIEhUTUxPcHRpb25zQ29sbGVj dGlvbi4nKTsKKworZG9jdW1lbnQubXlfZm9ybS5zZXRfc2VsLm9wdGlvbnNbMV0gPSBuZXcgT3B0 aW9uKCJBIik7Citkb2N1bWVudC5teV9mb3JtLnNldF9zZWwub3B0aW9uc1syXSA9IG5ldyBPcHRp b24oIkIiKTsKK3Nob3VsZEJlKCJteV9mb3JtLnNldF9zZWwub3B0aW9ucy5sZW5ndGgiLCAiMyIp OworCit2YXIgb3B0aW9ucyA9IGRvY3VtZW50Lm15X2Zvcm0uZ2V0X3NlbC5vcHRpb25zOworc2hv dWxkQmUoIm9wdGlvbnMoMCkiLCAiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29uZScpIik7Citz aG91bGRCZSgib3B0aW9ucygxKSIsICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndHdvJykiKTsK KwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4K