223826 2021-03-26 16:16:07 -0700 REGRESSION (r275038?): Perf test IndexedDB/stress/large-binary-keys.html failing with logging about memory pressure events 2021-03-26 18:00:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223717 InRadar P2 Normal --- 1 ryanhaddad cdumez achristensen benjamin cdumez cmarcelo darin ews-watchlist ggaren webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1744375 0 ryanhaddad 2021-03-26 16:16:07 -0700 REGRESSION: Catalina-Release-WK2-Perf tests failing with logging about memory pressure events: Running IndexedDB/stress/large-binary-keys.html (98 of 207) error: IndexedDB/stress/large-binary-keys.html Received memory pressure event 16 vm pressure 0 Received memory pressure event 32 vm pressure 0 FAILED Finished: 208.580084 s https://build.webkit.org/#/builders/20/builds/416 1744376 1 webkit-bug-importer 2021-03-26 16:16:23 -0700 <rdar://problem/75906134> 1744377 2 ryanhaddad 2021-03-26 16:17:53 -0700 https://trac.webkit.org/changeset/275038/webkit looks like it could have been related 1744384 3 424418 cdumez 2021-03-26 16:29:20 -0700 Created attachment 424418 Patch 1744408 4 424418 darin 2021-03-26 17:40:39 -0700 Comment on attachment 424418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424418&action=review > Source/WTF/ChangeLog:10 > + Use RELEASE_LOG() instead of WTFLogAlways() to log memory pressure events, so that they don't > + show on stdout in the performance tests and make them fail. Does this still achieve what we want in production builds? 1744414 5 cdumez 2021-03-26 17:43:20 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 424418 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424418&action=review > > > Source/WTF/ChangeLog:10 > > + Use RELEASE_LOG() instead of WTFLogAlways() to log memory pressure events, so that they don't > > + show on stdout in the performance tests and make them fail. > > Does this still achieve what we want in production builds? We will see the logging is os_log which I believe is suitable for such logging. 1744423 6 ews-feeder 2021-03-26 18:00:40 -0700 Committed r275125: <https://commits.webkit.org/r275125> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424418. 424418 2021-03-26 16:29:20 -0700 2021-03-26 18:00:41 -0700 Patch bug-223826-20210326162919.patch text/plain 2543 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5NzEyMDY0MWZhOGI2NjE0YzFhZTBk NGI0ZDI1ZTcyOWMzMjAzNzguLjIwODQ5NmE2YTVhNGU4NDUyM2NhNmVkYWQ0N2RhZjA4OGE5NGQy MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDMtMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjc1MDM4Pyk6IFBlcmYgdGVzdCBJ bmRleGVkREIvc3RyZXNzL2xhcmdlLWJpbmFyeS1rZXlzLmh0bWwgZmFpbGluZyB3aXRoIGxvZ2dp bmcgYWJvdXQgbWVtb3J5IHByZXNzdXJlIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzODI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 NTkwNjEzND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgUkVMRUFTRV9MT0coKSBpbnN0ZWFkIG9mIFdURkxvZ0Fsd2F5cygpIHRvIGxvZyBtZW1v cnkgcHJlc3N1cmUgZXZlbnRzLCBzbyB0aGF0IHRoZXkgZG9uJ3QKKyAgICAgICAgc2hvdyBvbiBz dGRvdXQgaW4gdGhlIHBlcmZvcm1hbmNlIHRlc3RzIGFuZCBtYWtlIHRoZW0gZmFpbC4KKworICAg ICAgICAqIHd0Zi9jb2NvYS9NZW1vcnlQcmVzc3VyZUhhbmRsZXJDb2NvYS5tbToKKyAgICAgICAg KFdURjo6TWVtb3J5UHJlc3N1cmVIYW5kbGVyOjppbnN0YWxsKToKKwogMjAyMS0wMy0yNiAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZpY2UgV29ya2VyIHNj cmlwdHMgdXNlIHRvbyBtdWNoIG1lbW9yeSBpbiB0aGUgbmV0d29yayBwcm9jZXNzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9NZW1vcnlQcmVzc3VyZUhhbmRsZXJDb2NvYS5tbSBi L1NvdXJjZS9XVEYvd3RmL2NvY29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNvY29hLm1tCmluZGV4 IDExOTA0MjBmYTc2ZTA5M2RhNzc3MjE2MzY2NTAyODEzZTAwY2RhYzEuLmE5ZjNjYTI2ZjM3ZDIz ZGNmMjBmNDEzODEyYjliOTUzYzY3ZDMwZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2Nv Y29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNvY29hLm1tCisrKyBiL1NvdXJjZS9XVEYvd3RmL2Nv Y29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNvY29hLm1tCkBAIC0zNyw4ICszNywxNiBAQAogCiBl eHRlcm4gIkMiIHZvaWQgY2FjaGVfc2ltdWxhdGVfbWVtb3J5X3dhcm5pbmdfZXZlbnQodWludDY0 X3QpOwogCisjZGVmaW5lIExPR19DSEFOTkVMX1BSRUZJWCBMb2cKKwogbmFtZXNwYWNlIFdURiB7 CiAKKyNpZiBSRUxFQVNFX0xPR19ESVNBQkxFRAorV1RGTG9nQ2hhbm5lbCBMb2dQZXJmb3JtYW5j ZUxvZ2dpbmcgPSB7IFdURkxvZ0NoYW5uZWxTdGF0ZTo6T24sICJQZXJmb3JtYW5jZUxvZ2dpbmci LCBXVEZMb2dMZXZlbDo6RXJyb3IgfTsKKyNlbHNlCitXVEZMb2dDaGFubmVsIExvZ1BlcmZvcm1h bmNlTG9nZ2luZyA9IHsgV1RGTG9nQ2hhbm5lbFN0YXRlOjpPbiwgIlBlcmZvcm1hbmNlTG9nZ2lu ZyIsIFdURkxvZ0xldmVsOjpFcnJvciwgTE9HX0NIQU5ORUxfV0VCS0lUX1NVQlNZU1RFTSwgT1Nf TE9HX0RFRkFVTFQgfTsKKyNlbmRpZgorCiB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6cGxh dGZvcm1SZWxlYXNlTWVtb3J5KENyaXRpY2FsIGNyaXRpY2FsKQogewogICAgIGlmIChjcml0aWNh bCA9PSBDcml0aWNhbDo6WWVzICYmICghaXNVbmRlck1lbW9yeVByZXNzdXJlKCkgfHwgbV9pc1Np bXVsYXRpbmdNZW1vcnlQcmVzc3VyZSkpIHsKQEAgLTk2LDcgKzEwNCw3IEBAIHZvaWQgTWVtb3J5 UHJlc3N1cmVIYW5kbGVyOjppbnN0YWxsKCkKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIGlmIChtX3Nob3VsZExvZ01lbW9yeU1lbW9yeVByZXNzdXJl RXZlbnRzKQotICAgICAgICAgICAgICAgIFdURkxvZ0Fsd2F5cygiUmVjZWl2ZWQgbWVtb3J5IHBy ZXNzdXJlIGV2ZW50ICVsdSB2bSBwcmVzc3VyZSAlZCIsIHN0YXR1cywgaXNVbmRlck1lbW9yeVBy ZXNzdXJlKCkpOworICAgICAgICAgICAgICAgIFJFTEVBU0VfTE9HKFBlcmZvcm1hbmNlTG9nZ2lu ZywgIlJlY2VpdmVkIG1lbW9yeSBwcmVzc3VyZSBldmVudCAlbHUgdm0gcHJlc3N1cmUgJWQiLCBz dGF0dXMsIGlzVW5kZXJNZW1vcnlQcmVzc3VyZSgpKTsKICAgICAgICAgfSk7CiAgICAgICAgIGRp c3BhdGNoX3Jlc3VtZShtZW1vcnlQcmVzc3VyZUV2ZW50U291cmNlKTsKICAgICB9KTsKQEAgLTIw MiwzICsyMTAsNSBAQCBPcHRpb25hbDxNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OlJlbGllZkxvZ2dl cjo6TWVtb3J5VXNhZ2U+IE1lbW9yeVByZXNzdXJlSGFuZGxlcgogfQogCiB9IC8vIG5hbWVzcGFj ZSBXVEYKKworI3VuZGVmIExPR19DSEFOTkVMX1BSRUZJWAo=