223825 2021-03-26 16:15:02 -0700 Avoid heap allocation on the audio thread in BaseAudioContext::scheduleNodeDeletion() 2021-03-26 20:53:23 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1744374 0 cdumez 2021-03-26 16:15:02 -0700 Avoid heap allocation on the audio thread in BaseAudioContext::scheduleNodeDeletion() for performance. 1744380 1 424415 cdumez 2021-03-26 16:20:50 -0700 Created attachment 424415 Patch 1744450 2 ews-feeder 2021-03-26 20:52:58 -0700 Committed r275129: <https://commits.webkit.org/r275129> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424415. 1744451 3 webkit-bug-importer 2021-03-26 20:53:23 -0700 <rdar://problem/75913277> 424415 2021-03-26 16:20:50 -0700 2021-03-26 20:52:59 -0700 Patch bug-223825-20210326162049.patch text/plain 3402 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxYmRiM2FjMzE5YjRm ODlkMTc3YTdiZjdkMzE4YzVlM2JmZTAwYi4uNDAwYzljMDUxNWUzODRjMjlkOWYwODNmN2NkMjZi YWI5MWNmNjIzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAzLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIG9uIHRoZSBhdWRpbyB0aHJlYWQgaW4gQmFzZUF1ZGlvQ29udGV4dDo6c2NoZWR1bGVOb2Rl RGVsZXRpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIzODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQXZvaWQgaGVhcCBhbGxvY2F0aW9uIG9uIHRoZSBhdWRpbyB0aHJlYWQgaW4gQmFzZUF1ZGlv Q29udGV4dDo6c2NoZWR1bGVOb2RlRGVsZXRpb24oKQorICAgICAgICBmb3IgcGVyZm9ybWFuY2Uu IFN0b3AgY2FsbGluZyBhcHBlbmRWZWN0b3IoKSBvbiBtX25vZGVzVG9EZWxldGUgc2luY2UgbV9u b2Rlc1RvRGVsZXRlCisgICAgICAgIGlzIGFsd2F5cyBlbXB0eS4gV2UgY2FuIHVzZSBzdGQ6OmV4 Y2hhbmdlKCkgaW5zdGVhZCBvZiBhcHBlbmRWZWN0b3IoKSBhbmQgY2xlYXIoKSB0bworICAgICAg ICBhdm9pZCB0aGUgaGVhcCBhbGxvY2F0aW9uLgorCisgICAgICAgIFRoZSByZWFzb24gbV9ub2Rl c1RvRGVsZXRlIGlzIGFsd2F5cyBlbXB0eSBpcyB0aGF0IEJhc2VBdWRpb0NvbnRleHQ6OnNjaGVk dWxlTm9kZURlbGV0aW9uKCkKKyAgICAgICAgcmVsaWVzIG9uIHRoZSBtX2lzRGVsZXRpb25TY2hl ZHVsZWQgZmxhZyB0byBhdm9pZCBhZGRpbmcgdG8gbV9ub2Rlc1RvRGVsZXRlIHVudGlsCisgICAg ICAgIG1fbm9kZXNUb0RlbGV0ZSBpcyBjbGVhcmVkIG9uIHRoZSBtYWluIHRocmVhZCBhbmQgdGhl IG1faXNEZWxldGlvblNjaGVkdWxlZCBnZXRzIHJlc2V0LgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJhc2VBdWRp b0NvbnRleHQ6OmNsZWFyKToKKyAgICAgICAgKFdlYkNvcmU6OkJhc2VBdWRpb0NvbnRleHQ6OnNj aGVkdWxlTm9kZURlbGV0aW9uKToKKwogMjAyMS0wMy0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZpY2UgV29ya2VyIHNjcmlwdHMgdXNlIHRvbyBtdWNo IG1lbW9yeSBpbiB0aGUgbmV0d29yayBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0Jhc2VBdWRpb0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmNwcAppbmRleCAyNDc2NzhmMjhkODIy OGQ0OTQ1MjBiNTg0ODE5ZTU1MWE0MjI3MzUzLi4xMzc5MTRiMjZhMTVlNDE1MjQ5M2QzZTQyYjgw OTBhNDNhNTY2ZDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0Jhc2VBdWRpb0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vQmFzZUF1ZGlvQ29udGV4dC5jcHAKQEAgLTIxMCw5ICsyMTAsOCBAQCB2b2lkIEJhc2VBdWRp b0NvbnRleHQ6OmNsZWFyKCkKICAgICAvLyBBdWRpbyB0aHJlYWQgaXMgZGVhZC4gTm9ib2R5IHdp bGwgc2NoZWR1bGUgbm9kZSBkZWxldGlvbiBhY3Rpb24uIExldCdzIGRvIGl0IG91cnNlbHZlcy4K ICAgICBkbyB7CiAgICAgICAgIGRlbGV0ZU1hcmtlZE5vZGVzKCk7Ci0gICAgICAgIG1fbm9kZXNU b0RlbGV0ZS5hcHBlbmRWZWN0b3IobV9ub2Rlc01hcmtlZEZvckRlbGV0aW9uKTsKLSAgICAgICAg bV9ub2Rlc01hcmtlZEZvckRlbGV0aW9uLmNsZWFyKCk7Ci0gICAgfSB3aGlsZSAobV9ub2Rlc1Rv RGVsZXRlLnNpemUoKSk7CisgICAgICAgIG1fbm9kZXNUb0RlbGV0ZSA9IHN0ZDo6ZXhjaGFuZ2Uo bV9ub2Rlc01hcmtlZEZvckRlbGV0aW9uLCB7IH0pOworICAgIH0gd2hpbGUgKCFtX25vZGVzVG9E ZWxldGUuaXNFbXB0eSgpKTsKIAogICAgIGNsZWFyUGVuZGluZ0FjdGl2aXR5KCk7CiB9CkBAIC03 ODEsMTYgKzc4MCwxNSBAQCB2b2lkIEJhc2VBdWRpb0NvbnRleHQ6OnNjaGVkdWxlTm9kZURlbGV0 aW9uKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gTWFrZSBzdXJlIHRvIGNhbGwgZGVsZXRl TWFya2VkTm9kZXMoKSBvbiBtYWluIHRocmVhZC4gICAgCi0gICAgaWYgKG1fbm9kZXNNYXJrZWRG b3JEZWxldGlvbi5zaXplKCkgJiYgIW1faXNEZWxldGlvblNjaGVkdWxlZCkgewotICAgICAgICAv LyBIZWFwIGFsbG9jYXRpb25zIGFyZSBmb3JiaWRkZW4gb24gdGhlIGF1ZGlvIHRocmVhZCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucyBzbyB3ZSBuZWVkIHRvCi0gICAgICAgIC8vIGV4cGxpY2l0bHkg YWxsb3cgdGhlIGZvbGxvd2luZyBhbGxvY2F0aW9uKHMpLgotICAgICAgICBEaXNhYmxlTWFsbG9j UmVzdHJpY3Rpb25zRm9yQ3VycmVudFRocmVhZFNjb3BlIGRpc2FibGVNYWxsb2NSZXN0cmljdGlv bnM7Ci0KLSAgICAgICAgbV9ub2Rlc1RvRGVsZXRlLmFwcGVuZFZlY3RvcihtX25vZGVzTWFya2Vk Rm9yRGVsZXRpb24pOwotICAgICAgICBtX25vZGVzTWFya2VkRm9yRGVsZXRpb24uY2xlYXIoKTsK KyAgICBpZiAoIW1fbm9kZXNNYXJrZWRGb3JEZWxldGlvbi5pc0VtcHR5KCkgJiYgIW1faXNEZWxl dGlvblNjaGVkdWxlZCkgeworICAgICAgICBBU1NFUlQobV9ub2Rlc1RvRGVsZXRlLmlzRW1wdHko KSk7CisgICAgICAgIG1fbm9kZXNUb0RlbGV0ZSA9IHN0ZDo6ZXhjaGFuZ2UobV9ub2Rlc01hcmtl ZEZvckRlbGV0aW9uLCB7IH0pOwogCiAgICAgICAgIG1faXNEZWxldGlvblNjaGVkdWxlZCA9IHRy dWU7CiAKKyAgICAgICAgLy8gSGVhcCBhbGxvY2F0aW9ucyBhcmUgZm9yYmlkZGVuIG9uIHRoZSBh dWRpbyB0aHJlYWQgZm9yIHBlcmZvcm1hbmNlIHJlYXNvbnMgc28gd2UgbmVlZCB0bworICAgICAg ICAvLyBleHBsaWNpdGx5IGFsbG93IHRoZSBmb2xsb3dpbmcgYWxsb2NhdGlvbihzKS4KKyAgICAg ICAgRGlzYWJsZU1hbGxvY1Jlc3RyaWN0aW9uc0ZvckN1cnJlbnRUaHJlYWRTY29wZSBkaXNhYmxl TWFsbG9jUmVzdHJpY3Rpb25zOwogICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0ZWRU aGlzID0gbWFrZVJlZigqdGhpcyldKCkgbXV0YWJsZSB7CiAgICAgICAgICAgICBwcm90ZWN0ZWRU aGlzLT5kZWxldGVNYXJrZWROb2RlcygpOwogICAgICAgICB9KTsK