223824 2021-03-26 16:07:56 -0700 Fix leaks in WKInspectorResourceURLSchemeHandler 2021-03-27 10:16:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1744367 0 ddkilzer 2021-03-26 16:07:56 -0700 Fix leaks in WKInspectorResourceURLSchemeHandler. Missing some use of adoptNS() and a local variable is never released. 1744373 1 424414 ddkilzer 2021-03-26 16:14:04 -0700 Created attachment 424414 Patch v1 1744472 2 424414 joepeck 2021-03-27 00:46:07 -0700 Comment on attachment 424414 Patch v1 Nice! 1744518 3 ews-feeder 2021-03-27 10:15:24 -0700 Committed r275135: <https://commits.webkit.org/r275135> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424414. 1744519 4 webkit-bug-importer 2021-03-27 10:16:15 -0700 <rdar://problem/75922102> 424414 2021-03-26 16:14:04 -0700 2021-03-27 10:15:25 -0700 Patch v1 bug-223824-20210326161403.patch text/plain 3184 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkYTY1NWUwNWUxMjI4Y2Nm NDM0ZjYwOWYyMjk0YjczNGY4YTUwMzAuLmU3ZDExYzRlN2YwMDdmNjU2MjJlMGYwY2RhOWYzNWU0 YTIyY2VmMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDMtMjYgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbGVha3MgaW4gV0tJbnNw ZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzIyMzgyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dLSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hl bWVIYW5kbGVyLm1tOgorICAgICAgICAoLVtXS0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1lSGFu ZGxlciB3ZWJWaWV3OnN0YXJ0VVJMU2NoZW1lVGFzazpdKToKKyAgICAgICAgLSBNYWtlIHVzZSBv ZiBhZG9wdE5TKCkgd2hlbiBhc3NpZ25pbmcgYSBuZXdseSBhbGxvY2F0ZWQsICsxCisgICAgICAg ICAgcmV0YWluZWQgT2JqZWN0aXZlLUMgb2JqZWN0IHRvIGEgUmV0YWluUHRyPD4uCisgICAgICAg IC0gQWxzbyBmaXggbGVhayBvZiBsb2NhbCBOU0hUVFBVUkxSZXNwb25zZSBvYmplY3QgYnkgdXNp bmcgYQorICAgICAgICAgIFJldGFpblB0cjw+LgorCiAyMDIxLTAzLTIzICBGdWppaSBIaXJvbm9y aSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gSW1wbGVt ZW50IGluc3BlY3Rvci1yZXNvdXJjZTovLyBVUkwgc2NoZW1lIGhhbmRsZXIgZm9yIFdlYiBJbnNw ZWN0b3IgcmVzb3VyY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNw ZWN0b3IvbWFjL1dLSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLm1tIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9XS0luc3BlY3RvclJlc291cmNlVVJMU2No ZW1lSGFuZGxlci5tbQppbmRleCA2NzE0NzQ0MTk5YWM4YTQyMTJmMGMzNTI4NzdjNGY2M2ZlNmUx N2E1Li4zZmIwZDgyYmQ2ZTJjZjU1YTg0YTQ0MzU1YjFkZWFjZTA2OGIxNjY2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dLSW5zcGVjdG9yUmVzb3Vy Y2VVUkxTY2hlbWVIYW5kbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3Bl Y3Rvci9tYWMvV0tJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIubW0KQEAgLTUyLDEw ICs1MiwxMCBAQCAtICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgc3RhcnRVUkxT Y2hlbWVUYXNrOihpZCA8V0tVUkxTY2hlbWVUYXNrPil1cgogICAgIH0KIAogICAgIGlmICghX2Zp bGVMb2FkT3BlcmF0aW9ucykKLSAgICAgICAgX2ZpbGVMb2FkT3BlcmF0aW9ucyA9IFtbTlNNYXBU YWJsZSBhbGxvY10gaW5pdFdpdGhLZXlPcHRpb25zOk5TUG9pbnRlckZ1bmN0aW9uc1N0cm9uZ01l bW9yeSB2YWx1ZU9wdGlvbnM6TlNQb2ludGVyRnVuY3Rpb25zU3Ryb25nTWVtb3J5IGNhcGFjaXR5 OjVdOworICAgICAgICBfZmlsZUxvYWRPcGVyYXRpb25zID0gYWRvcHROUyhbW05TTWFwVGFibGUg YWxsb2NdIGluaXRXaXRoS2V5T3B0aW9uczpOU1BvaW50ZXJGdW5jdGlvbnNTdHJvbmdNZW1vcnkg dmFsdWVPcHRpb25zOk5TUG9pbnRlckZ1bmN0aW9uc1N0cm9uZ01lbW9yeSBjYXBhY2l0eTo1XSk7 CiAKICAgICBpZiAoIV9vcGVyYXRpb25RdWV1ZSkgewotICAgICAgICBfb3BlcmF0aW9uUXVldWUg PSBbW05TT3BlcmF0aW9uUXVldWUgYWxsb2NdIGluaXRdOworICAgICAgICBfb3BlcmF0aW9uUXVl dWUgPSBhZG9wdE5TKFtbTlNPcGVyYXRpb25RdWV1ZSBhbGxvY10gaW5pdF0pOwogICAgICAgICBf b3BlcmF0aW9uUXVldWUuZ2V0KCkudW5kZXJseWluZ1F1ZXVlID0gZGlzcGF0Y2hfZ2V0X2dsb2Jh bF9xdWV1ZShRT1NfQ0xBU1NfVVNFUl9JTlRFUkFDVElWRSwgMCk7CiAgICAgICAgIF9vcGVyYXRp b25RdWV1ZS5nZXQoKS5xdWFsaXR5T2ZTZXJ2aWNlID0gTlNPcGVyYXRpb25RdWFsaXR5T2ZTZXJ2 aWNlVXNlckludGVyYWN0aXZlOwogICAgIH0KQEAgLTg1LDEzICs4NSwxMyBAQCAtICh2b2lkKXdl YlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgc3RhcnRVUkxTY2hlbWVUYXNrOihpZCA8V0tVUkxT Y2hlbWVUYXNrPil1cgogICAgICAgICBpZiAoIW1pbWVUeXBlKQogICAgICAgICAgICAgbWltZVR5 cGUgPSBAImFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbSI7CiAKLSAgICAgICAgTlNIVFRQVVJMUmVz cG9uc2UgKnVybFJlc3BvbnNlID0gW1tOU0hUVFBVUkxSZXNwb25zZSBhbGxvY10gaW5pdFdpdGhV Ukw6dXJsU2NoZW1lVGFzay5yZXF1ZXN0LlVSTCBzdGF0dXNDb2RlOjIwMCBIVFRQVmVyc2lvbjpu aWwgaGVhZGVyRmllbGRzOkB7CisgICAgICAgIFJldGFpblB0cjxOU0hUVFBVUkxSZXNwb25zZT4g dXJsUmVzcG9uc2UgPSBhZG9wdE5TKFtbTlNIVFRQVVJMUmVzcG9uc2UgYWxsb2NdIGluaXRXaXRo VVJMOnVybFNjaGVtZVRhc2sucmVxdWVzdC5VUkwgc3RhdHVzQ29kZToyMDAgSFRUUFZlcnNpb246 bmlsIGhlYWRlckZpZWxkczpAewogICAgICAgICAgICAgQCJBY2Nlc3MtQ29udHJvbC1BbGxvdy1P cmlnaW4iOiBAIioiLAogICAgICAgICAgICAgQCJDb250ZW50LUxlbmd0aCI6IFtOU1N0cmluZyBz dHJpbmdXaXRoRm9ybWF0OkAiJXp1IiwgKHNpemVfdClmaWxlRGF0YS5sZW5ndGhdLAogICAgICAg ICAgICAgQCJDb250ZW50LVR5cGUiOiBtaW1lVHlwZSwKLSAgICAgICAgfV07CisgICAgICAgIH1d KTsKIAotICAgICAgICBbdXJsU2NoZW1lVGFzayBkaWRSZWNlaXZlUmVzcG9uc2U6dXJsUmVzcG9u c2VdOworICAgICAgICBbdXJsU2NoZW1lVGFzayBkaWRSZWNlaXZlUmVzcG9uc2U6dXJsUmVzcG9u c2UuZ2V0KCldOwogICAgICAgICBbdXJsU2NoZW1lVGFzayBkaWRSZWNlaXZlRGF0YTpmaWxlRGF0 YV07CiAgICAgICAgIFt1cmxTY2hlbWVUYXNrIGRpZEZpbmlzaF07CiAgICAgfV07Cg==