223823 2021-03-26 15:56:41 -0700 WebFeature class fails to copy/retain its instance variables 2021-03-27 10:00:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer sam webkit-bug-importer oldest_to_newest 1744362 0 ddkilzer 2021-03-26 15:56:41 -0700 WebFeature class fails to copy/retain its instance variables despite what its @property declarations state. To fix this, I'm just going to add -copy methods in the init method, and add a -dealloc method that can be deleted when switching to ARC. Using RetainPtr<> for this class seems overkill. 1744365 1 424412 ddkilzer 2021-03-26 15:58:20 -0700 Created attachment 424412 Patch v1 1744404 2 424412 sam 2021-03-26 17:27:04 -0700 Comment on attachment 424412 Patch v1 I think Chris is trying to use RetainPtr everywhere, so we probably should here too, but you don't have to in this patch. I can do so in a follow up. 1744459 3 ews-feeder 2021-03-26 21:47:07 -0700 Committed r275131: <https://commits.webkit.org/r275131> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424412. 1744460 4 webkit-bug-importer 2021-03-26 21:48:12 -0700 <rdar://problem/75913890> 1744516 5 ddkilzer 2021-03-27 10:00:12 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 424412 [details] > Patch v1 > > I think Chris is trying to use RetainPtr everywhere, so we probably should > here too, but you don't have to in this patch. I can do so in a follow up. Those were some speculative fixes to try to resolve some CoreIPC crashes if I remember correctly. I appreciate you offering to follow up on this. 424412 2021-03-26 15:58:20 -0700 2021-03-26 21:47:07 -0700 Patch v1 bug-223823-20210326155819.patch text/plain 2468 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggMzMwNTI1NjIwNWJhMDVmMjhiOTE3M2JjMjhlZTY0YTQ3NjBhZDJiNS4uYzM0MzM0Y2YxMDc1 YWNiNWNjNmNmZWViNGZiZWM1OGMzM2NmZmM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAzLTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKKyAgICAgICAgV2ViRmVhdHVyZSBjbGFzcyBmYWlscyB0byBjb3B5L3JldGFp biBpdHMgaW5zdGFuY2UgdmFyaWFibGVzCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8y MjM4MjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJWaWV3L1dlYkZlYXR1cmUubToKKyAgICAgICAgKC1bV2ViRmVhdHVyZSBpbml0V2l0aEtl eTpwcmVmZXJlbmNlS2V5Om5hbWU6ZGV0YWlsczpkZWZhdWx0VmFsdWU6aGlkZGVuOl0pOgorICAg ICAgICAtIENvcHkgKGFuZCB0aGVyZWJ5IHJldGFpbikgaW5zdGFuY2UgdmFyaWFibGVzLCBmdWxm aWxsaW5nIHRoZQorICAgICAgICAgIHByb21pc2Ugb2YgaXRzIEBwcm9wZXJ0eSBkZWNsYXJhdGlv bnMgYW5kIHByZXZlbnRpbmcKKyAgICAgICAgICB1c2UtYWZ0ZXItcmVsZWFzZSBpc3N1ZXMuCisg ICAgICAgICgtW1dlYkZlYXR1cmUgZGVhbGxvY10pOiBBZGQuCisgICAgICAgIC0gUmVsZWFzZSB0 aGUgaW5zdGFuY2UgdmFyaWFibGVzIGNvcGllZCBpbiB0aGUgY29uc3RydWN0b3IuCisKIDIwMjEt MDMtMjIgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Zl IG1hbmFnZW1lbnQgb2YgUmVtb3RlQ29tbWFuZExpc3RlbmVyIGZyb20gTWVkaWFTZXNzaW9uTWFu YWdlckNvY29hIGludG8gTm93UGxheWluZ01hbmFnZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRmVhdHVyZS5tIGIvU291cmNlL1dlYktpdExlZ2FjeS9t YWMvV2ViVmlldy9XZWJGZWF0dXJlLm0KaW5kZXggODJhZWZkZGJhM2RlNDJkMDcxNTRhNDAyMmIx YjhkMjA1NWJlMmJiNi4uNTM4ZjdiY2FkZTUxYTIxZGIzZTlhZTBlN2ViYjNiNDBkM2VkZjAwYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJGZWF0dXJlLm0K KysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJGZWF0dXJlLm0KQEAgLTEs NSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAyMC0yMDIxIEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMzIsMTUg KzMyLDI0IEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEtleTooTlNTdHJpbmcgKilrZXkgcHJl ZmVyZW5jZUtleTooTlNTdHJpbmcgKilwcmVmZXJlbmNlCiAgICAgaWYgKCEoc2VsZiA9IFtzdXBl ciBpbml0XSkpCiAgICAgICAgIHJldHVybiBuaWw7CiAKLSAgICBfa2V5ID0ga2V5OwotICAgIF9w cmVmZXJlbmNlS2V5ID0gcHJlZmVyZW5jZUtleTsKLSAgICBfbmFtZSA9IG5hbWU7Ci0gICAgX2Rl dGFpbHMgPSBkZXRhaWxzOworICAgIF9rZXkgPSBba2V5IGNvcHldOworICAgIF9wcmVmZXJlbmNl S2V5ID0gW3ByZWZlcmVuY2VLZXkgY29weV07CisgICAgX25hbWUgPSBbbmFtZSBjb3B5XTsKKyAg ICBfZGV0YWlscyA9IFtkZXRhaWxzIGNvcHldOwogICAgIF9kZWZhdWx0VmFsdWUgPSBkZWZhdWx0 VmFsdWU7CiAgICAgX2hpZGRlbiA9IGhpZGRlbjsKICAgICByZXR1cm4gc2VsZjsKIH0KIAorLSAo dm9pZClkZWFsbG9jCit7CisgICAgW19rZXkgcmVsZWFzZV07CisgICAgW19wcmVmZXJlbmNlS2V5 IHJlbGVhc2VdOworICAgIFtfbmFtZSByZWxlYXNlXTsKKyAgICBbX2RldGFpbHMgcmVsZWFzZV07 CisgICAgW3N1cGVyIGRlYWxsb2NdOworfQorCiAtIChOU1N0cmluZyAqKWRlc2NyaXB0aW9uCiB7 CiAgICAgcmV0dXJuIFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiPCVAOiAlcDsgbmFtZSA9 ICVAOyBrZXkgPSAlQDsgZGVmYXVsdFZhbHVlID0gJUA+IiwgTlNTdHJpbmdGcm9tQ2xhc3Moc2Vs Zi5jbGFzcyksIHNlbGYsIHNlbGYubmFtZSwgc2VsZi5rZXksIHNlbGYuZGVmYXVsdFZhbHVlID8g QCJvbiIgOiBAIm9mZiJdOwo=