223822 2021-03-26 15:51:22 -0700 System installing webkitcorepy can break certain scripts 2021-03-26 16:48:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard alancoon dewei_zhu ews-watchlist glenn jlewis3 slewis webkit-bug-importer oldest_to_newest 1744360 0 jbedard 2021-03-26 15:51:22 -0700 This issue happens when webkitcorepy (or webkitscmpy) is installed to the system's Python libraries, and the installed version does not match the version checked in to WebKit. This issue is caused by us doing sys.path.append instead of sys.path.insert(0, ...). 1744361 1 webkit-bug-importer 2021-03-26 15:51:58 -0700 <rdar://problem/75905163> 1744366 2 424413 jbedard 2021-03-26 15:59:35 -0700 Created attachment 424413 Patch 1744368 3 alancoon 2021-03-26 16:09:37 -0700 So the fix was something along the lines of Cmd+F for imports of "webkitcorepy" and then changing the insertion method? rs=me as I'm not sure which files need this change but that logic makes sense to me 1744370 4 424413 alancoon 2021-03-26 16:11:19 -0700 Comment on attachment 424413 Patch The services failure looks unrelated 1744379 5 jbedard 2021-03-26 16:20:50 -0700 (In reply to Alan Coon from comment #3) > So the fix was something along the lines of Cmd+F for imports of > "webkitcorepy" and then changing the insertion method? > > rs=me as I'm not sure which files need this change but that logic makes > sense to me Actually, I just searched for 'sys.path.appned', that's almost always incorrect, and even if it's not implicated in this bug, it's just going to bite us later. 1744388 6 jbedard 2021-03-26 16:47:51 -0700 Committed r275122 (235827@main): <https://commits.webkit.org/235827@main> 424413 2021-03-26 15:59:35 -0700 2021-03-26 16:48:22 -0700 Patch bug-223822-20210326155934.patch text/plain 5549 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTExOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIxLTAzLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBTeXN0ZW0gaW5zdGFsbGluZyB3ZWJraXRjb3JlcHkgY2FuIGJyZWFrIGNl cnRhaW4gc2NyaXB0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIzODIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTkwNTE2Mz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFy aWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2V4YW1wbGUvZW52aXJvbm1lbnQucHk6CisgICAg ICAgICogU2NyaXB0cy90ZXN0LWxsZGItd2Via2l0OiBSZXBsYWNlIHN5cy5wYXRoLmFwcGVuZCB3 aXRoIHN5cy5wYXRoLmluc2VydC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L19faW5pdF9f LnB5OiBPbmx5IHB1dCB3ZWJraXRjb3JlcHkgcGF0aCBpbnRvIHN5cy5wYXRoIGlmIGl0IGlzbid0 IGFscmVhZHkgdGhlcmUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVu bmVyL2h0dHBfc2VydmVyX2RyaXZlci9odHRwX3NlcnZlci90d2lzdGVkX2h0dHBfc2VydmVyLnB5 OgorICAgICAgICBSZXBsYWNlIHN5cy5wYXRoLmFwcGVuZCB3aXRoIHN5cy5wYXRoLmluc2VydC4K KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0 ZXN0LnB5OiBEaXR0by4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvY29uZmlnX3N0 YW5kYWxvbmUucHk6IERpdHRvLgorCiAyMDIxLTAzLTI2ICBEb24gT2xtc3RlYWQgIDxkb24ub2xt c3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBEZXByZWNhdGUgdXNpbmcgREVSSVZF RF9TT1VSQ0VTX0RJUi9GT1dBUkRJTkdfSEVBREVSU19ESVIgZGlyZWN0bHkKSW5kZXg6IFRvb2xz L1NjcmlwdHMvdGVzdC1sbGRiLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3Rl c3QtbGxkYi13ZWJraXQJKHJldmlzaW9uIDI3NTExNCkKKysrIFRvb2xzL1NjcmlwdHMvdGVzdC1s bGRiLXdlYmtpdAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDcgKzEzNSw3IEBAIGRlZiBtYWluKCk6 CiAgICAgd2Via2l0X3Jvb3QgPSB1cCh1cCh1cChob3N0LmZpbGVzeXN0ZW0uYWJzcGF0aChfX2Zp bGVfXykpKSkKIAogICAgIGlmIGxsZGJfcHl0aG9uX2RpcmVjdG9yeSBub3QgaW4gc3lzLnBhdGg6 Ci0gICAgICAgIHN5cy5wYXRoLmFwcGVuZChsbGRiX3B5dGhvbl9kaXJlY3RvcnkpCisgICAgICAg IHN5cy5wYXRoLmluc2VydCgwLCBsbGRiX3B5dGhvbl9kaXJlY3RvcnkpCiAgICAgdGVzdGVyLmFk ZF90cmVlKGhvc3QuZmlsZXN5c3RlbS5qb2luKHdlYmtpdF9yb290LCAnVG9vbHMnLCAnbGxkYicp KQogCiAgICAgcmV0dXJuIG5vdCB0ZXN0ZXIucnVuKGhvc3Q9aG9zdCwgd2Via2l0X3Jvb3Q9d2Vi a2l0X3Jvb3QpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS9leGFtcGxlL2Vudmlyb25tZW50LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L2V4YW1wbGUvZW52aXJvbm1lbnQu cHkJKHJldmlzaW9uIDI3NTExNCkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L2V4YW1wbGUvZW52aXJvbm1lbnQucHkJKHdvcmtpbmcgY29weSkKQEAg LTI3LDcgKzI3LDcgQEAgZnJvbSBjYXNzYW5kcmEuYXV0aCBpbXBvcnQgUGxhaW5UZXh0QXV0aAog ZnJvbSBmYWtlcmVkaXMgaW1wb3J0IEZha2VTdHJpY3RSZWRpcwogZnJvbSByZWRpcyBpbXBvcnQg U3RyaWN0UmVkaXMKIAotc3lzLnBhdGguYXBwZW5kKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRp cm5hbWUob3MucGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpKSkpCitzeXMu cGF0aC5pbnNlcnQoMCwgb3MucGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRp cm5hbWUob3MucGF0aC5hYnNwYXRoKF9fZmlsZV9fKSkpKSkKIAogZnJvbSByZXN1bHRzZGJweS5t b2RlbC5jYXNzYW5kcmFfY29udGV4dCBpbXBvcnQgQ2Fzc2FuZHJhQ29udGV4dAogZnJvbSByZXN1 bHRzZGJweS5tb2RlbC5jYXNzZXJvbGUgaW1wb3J0IENhc3Nlcm9sZU5vZGVzLCBDYXNzZXJvbGVS ZWRpcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzUxMTQp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0xOSw3ICsxOSwxMCBAQCBpbXBvcnQgc3lzCiBvcy5lbnZpcm9uWydTWVNURU1fVkVSU0lPTl9D T01QQVQnXSA9ICcwJwogCiBsaWJyYXJpZXMgPSBvcy5wYXRoLmpvaW4ob3MucGF0aC5hYnNwYXRo KG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRpcm5hbWUoX19maWxlX18pKSksICdsaWJyYXJpZXMn KQotc3lzLnBhdGguaW5zZXJ0KDAsIG9zLnBhdGguam9pbihsaWJyYXJpZXMsICd3ZWJraXRjb3Jl cHknKSkKK3dlYmtpdGNvcmVweV9wYXRoID0gb3MucGF0aC5qb2luKGxpYnJhcmllcywgJ3dlYmtp dGNvcmVweScpCitpZiB3ZWJraXRjb3JlcHlfcGF0aCBub3QgaW4gc3lzLnBhdGg6CisgICAgc3lz LnBhdGguaW5zZXJ0KDAsIHdlYmtpdGNvcmVweV9wYXRoKQoraW1wb3J0IHdlYmtpdGNvcmVweQog CiBpZiBzeXMucGxhdGZvcm0gPT0gJ2Rhcndpbic6CiAgICAgaXNfcm9vdCA9IG5vdCBvcy5nZXR1 aWQoKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2h0dHBf c2VydmVyX2RyaXZlci9odHRwX3NlcnZlci90d2lzdGVkX2h0dHBfc2VydmVyLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9odHRwX3NlcnZl cl9kcml2ZXIvaHR0cF9zZXJ2ZXIvdHdpc3RlZF9odHRwX3NlcnZlci5weQkocmV2aXNpb24gMjc1 MTE0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2h0dHBfc2Vy dmVyX2RyaXZlci9odHRwX3NlcnZlci90d2lzdGVkX2h0dHBfc2VydmVyLnB5CSh3b3JraW5nIGNv cHkpCkBAIC05LDcgKzksNyBAQCBpbXBvcnQgc3lzCiAjIHRoYXQgVG9vbHMvU2NyaXB0cyBpcyBp biBzeXMucGF0aCBmb3IgdGhlIG5leHQgaW1wb3J0cyB0byB3b3JrIGNvcnJlY3RseS4KIHNjcmlw dF9kaXIgPSBvcy5wYXRoLmFic3BhdGgob3MucGF0aC5qb2luKG9zLnBhdGguZGlybmFtZShvcy5w YXRoLmFic3BhdGgoX19maWxlX18pKSwgJy4uLy4uLy4uLy4uJykpCiBpZiBzY3JpcHRfZGlyIG5v dCBpbiBzeXMucGF0aDoKLSAgICBzeXMucGF0aC5hcHBlbmQoc2NyaXB0X2RpcikKKyAgICBzeXMu cGF0aC5pbnNlcnQoMCwgc2NyaXB0X2RpcikKIAogZnJvbSBwa2dfcmVzb3VyY2VzIGltcG9ydCBy ZXF1aXJlLCBWZXJzaW9uQ29uZmxpY3QsIERpc3RyaWJ1dGlvbk5vdEZvdW5kCiBmcm9tIHdlYmtp dHB5LmF1dG9pbnN0YWxsZWQgaW1wb3J0IHR3aXN0ZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5w eQkocmV2aXNpb24gMjc1MTE0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzgsMTAgKzM4LDEw IEBAIGltcG9ydCB1bml0dGVzdAogIyB0aGF0IFRvb2xzL1NjcmlwdHMgaXMgaW4gc3lzLnBhdGgg Zm9yIHRoZSBuZXh0IGltcG9ydHMgdG8gd29yayBjb3JyZWN0bHkuCiBzY3JpcHRfZGlyID0gb3Mu cGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJu YW1lKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpKSkpCiBpZiBzY3JpcHRfZGlyIG5vdCBpbiBz eXMucGF0aDoKLSAgICBzeXMucGF0aC5hcHBlbmQoc2NyaXB0X2RpcikKKyAgICBzeXMucGF0aC5p bnNlcnQoMCwgc2NyaXB0X2RpcikKIHRoaXJkX3BhcnR5X3B5ID0gb3MucGF0aC5qb2luKHNjcmlw dF9kaXIsICJ3ZWJraXRweSIsICJ0aGlyZHBhcnR5IiwgImF1dG9pbnN0YWxsZWQiKQogaWYgdGhp cmRfcGFydHlfcHkgbm90IGluIHN5cy5wYXRoOgotICAgIHN5cy5wYXRoLmFwcGVuZCh0aGlyZF9w YXJ0eV9weSkKKyAgICBzeXMucGF0aC5pbnNlcnQoMCwgdGhpcmRfcGFydHlfcHkpCiAKIGZyb20g d2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZSwgU2NyaXB0 RXJyb3IKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtX21vY2sgaW1wb3J0 IE1vY2tGaWxlU3lzdGVtCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvY29uZmln X3N0YW5kYWxvbmUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2NvbmZpZ19zdGFuZGFsb25lLnB5CShyZXZpc2lvbiAyNzUxMTQpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvY29uZmlnX3N0YW5kYWxvbmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTQx LDcgKzQxLDcgQEAgdGhpc19kaXIgPSBvcy5wYXRoLmFic3BhdGgoc3lzLnBhdGhbMF0pCiB1cCA9 IG9zLnBhdGguZGlybmFtZQogc2NyaXB0X2RpciA9IHVwKHVwKHRoaXNfZGlyKSkKIGlmIHNjcmlw dF9kaXIgbm90IGluIHN5cy5wYXRoOgotICAgIHN5cy5wYXRoLmFwcGVuZChzY3JpcHRfZGlyKQor ICAgIHN5cy5wYXRoLmluc2VydCgwLCBzY3JpcHRfZGlyKQogCiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5zeXN0ZW0gaW1wb3J0IGV4ZWN1dGl2ZQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGlt cG9ydCBleGVjdXRpdmVfbW9jawo=