223821 2021-03-26 15:29:35 -0700 UBSan: runtime error: load of value <unknown>, which is not a valid value for type 'const WebCore::RealtimeMediaSourceCapabilities::EchoCancellation' 2021-04-01 19:50:02 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176131 InRadar P2 Normal --- 224090 1 ddkilzer ddkilzer cdumez darin eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1744351 0 ddkilzer 2021-03-26 15:29:35 -0700 Fix runtime issues found by UBSan running layout tests: Source/WebKit/Platform/IPC/Encoder.h:68:93: runtime error: load of value <unknown>, which is not a valid value for type 'const WebCore::RealtimeMediaSourceCapabilities::EchoCancellation' Found in the following tests: LayoutTests/fast/mediastream/MediaDevices-addEventListener.html LayoutTests/fast/mediastream/constraint-intrinsic-size.html LayoutTests/http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html LayoutTests/http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-bitrate.https.html LayoutTests/webrtc/addICECandidate-closed.html LayoutTests/webrtc/ice-candidate-sdpMLineIndex.html LayoutTests/webrtc/libwebrtc/descriptionGetters.html LayoutTests/webrtc/peerconnection-page-cache.html 1744358 1 424410 ddkilzer 2021-03-26 15:48:56 -0700 Created attachment 424410 Patch v1 1744405 2 424410 darin 2021-03-26 17:27:54 -0700 Comment on attachment 424410 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=424410&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:110 > + ValueUnion m_minOrValue { 0 }; > + ValueUnion m_max { 0 }; In cases like this, I am pretty sure we can use just "{ }" instead of "{ 0 }" if we prefer. Has the same effect. But also I am not sure this makes logical sense. The double is still uninitialized, so what’s the value to just initializing the int here? > Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:111 > + Type m_type { Undefined }; Could do the same here, but here I think there is more value in writing out Undefined, so I am not recommending it. > Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:209 > + EchoCancellation m_echoCancellation { EchoCancellation::ReadOnly }; Same. 1744534 3 424410 ddkilzer 2021-03-27 12:59:46 -0700 Comment on attachment 424410 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=424410&action=review >> Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:110 >> + ValueUnion m_max { 0 }; > > In cases like this, I am pretty sure we can use just "{ }" instead of "{ 0 }" if we prefer. Has the same effect. > > But also I am not sure this makes logical sense. The double is still uninitialized, so what’s the value to just initializing the int here? Verified that "{ }" is the same as "{ 0 }" for ValueUnion. Will change. Only the first non-static union member can be initialized with C++ member initializer syntax, so I swapped asInt and asDouble in ValueUnion to clear all memory since the double is 8 bytes and the int is 4 bytes. 1744535 4 424463 ddkilzer 2021-03-27 13:01:59 -0700 Created attachment 424463 Patch for landing 1744559 5 ews-feeder 2021-03-27 16:26:51 -0700 Committed r275142: <https://commits.webkit.org/r275142> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424463. 1744560 6 webkit-bug-importer 2021-03-27 16:27:13 -0700 <rdar://problem/75924950> 1744799 7 darin 2021-03-29 11:26:32 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Only the first non-static union member can be initialized with C++ member > initializer syntax, so I swapped asInt and asDouble in ValueUnion to clear > all memory since the double is 8 bytes and the int is 4 bytes. That works from a practical point of view, but not great from an "undefined behavior" point of view. 1744856 8 ddkilzer 2021-03-29 13:18:46 -0700 (In reply to Darin Adler from comment #7) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > Only the first non-static union member can be initialized with C++ member > > initializer syntax, so I swapped asInt and asDouble in ValueUnion to clear > > all memory since the double is 8 bytes and the int is 4 bytes. > > That works from a practical point of view, but not great from an "undefined > behavior" point of view. Can you give an example of a "undefined behavior" point of view that you're thinking of? In this specific case, setting the double value to 0 will clear all the memory that could be used by the members of this particular union. Or do you mean this in the more general sense of "clearing all memory used by a union used as a C++ member variable"? 1744884 9 darin 2021-03-29 13:37:07 -0700 (In reply to David Kilzer (:ddkilzer) from comment #8) > In this specific case, setting the double value to 0 will clear all the > memory that could be used by the members of this particular union. That’s not specified by the standard. Setting the double value to 0 does not guarantee anything about the int value. That’s the problem with "undefined behavior sanitizer"; where do you draw the line? 1744914 10 ddkilzer 2021-03-29 14:24:32 -0700 (In reply to Darin Adler from comment #9) > (In reply to David Kilzer (:ddkilzer) from comment #8) > > In this specific case, setting the double value to 0 will clear all the > > memory that could be used by the members of this particular union. > > That’s not specified by the standard. Setting the double value to 0 does not > guarantee anything about the int value. I see. > That’s the problem with "undefined behavior sanitizer"; where do you draw > the line? UBSan only flagged the m_echoCancellation member variable. It did not flag the ValueUnion fields. I noticed them via source code inspection. Sorry if this wasn't clear in my original patch. Maybe a better solution to using unions is to use WTF::Variant instead. 1744922 11 ddkilzer 2021-03-29 14:43:22 -0700 (In reply to David Kilzer (:ddkilzer) from comment #10) > (In reply to Darin Adler from comment #9) > > That’s the problem with "undefined behavior sanitizer"; where do you draw > > the line? > > UBSan only flagged the m_echoCancellation member variable. It did not flag > the ValueUnion fields. I noticed them via source code inspection. Sorry if > this wasn't clear in my original patch. > > Maybe a better solution to using unions is to use WTF::Variant instead. Okay, looking at the CapabilityValueOrRange() constructors again: - All of them set m_minOrValue (either int or double). - Three do not set m_max. - All of them set m_type. Is it better to remove the default member initializers and do everything explicitly in the constructors, or let the constructors override the values and use the default member initializers as a fallback? For example, if we leave the default member initializers, we can change this: CapabilityValueOrRange() : m_type(Undefined) { } To this: CapabilityValueOrRange() = default; Hmmm...since both m_minOrValue and m_max should be the same time, perhaps it's better to initialize everything in the constructors in this case. I'll file a new bug for that. And maybe look to see how much work switching to WTF::Variant is. 1744925 12 ddkilzer 2021-03-29 14:44:14 -0700 (In reply to David Kilzer (:ddkilzer) from comment #11) > Hmmm...since both m_minOrValue and m_max should be the same time, [...] time => type 1744951 13 darin 2021-03-29 15:09:18 -0700 I’m not sure what problem we are solving. The idea of initializing in constructors instead of in the header sounds good here. The idea of using Variant instead of union can be good too, as long as it doesn’t hurt performance or anything. 1744994 14 ddkilzer 2021-03-29 17:26:29 -0700 (In reply to Darin Adler from comment #13) > I’m not sure what problem we are solving. I was trying to determine how to address your follow-up comments. So there is no specific action that is required? 1745001 15 darin 2021-03-29 18:02:44 -0700 (In reply to David Kilzer (:ddkilzer) from comment #14) > I was trying to determine how to address your follow-up comments. So there > is no specific action that is required? My comments assumed that you were initializing these fields because of UBSan. If you’re just initializing them to make our code more foolproof without any connection to "undefined behavior", then what you have in the patch is OK with me. Not *great*, because it seems super likely that some day someone will re-order the union since we don’t have a comment explaining why we put double first. 1746370 16 ddkilzer 2021-04-01 19:50:02 -0700 (In reply to Darin Adler from comment #15) > (In reply to David Kilzer (:ddkilzer) from comment #14) > > I was trying to determine how to address your follow-up comments. So there > > is no specific action that is required? > > My comments assumed that you were initializing these fields because of UBSan. > > If you’re just initializing them to make our code more foolproof without any > connection to "undefined behavior", then what you have in the patch is OK > with me. Not *great*, because it seems super likely that some day someone > will re-order the union since we don’t have a comment explaining why we put > double first. Tracking follow-up fixes here: Bug 224090: [CoreIPC] Encoding/decoding of WebCore::CapabilityValueOrRange transmits padding bytes 424410 2021-03-26 15:48:56 -0700 2021-03-26 20:39:36 -0700 Patch v1 bug-223821-20210326154855.patch text/plain 3250 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA4NjM0Nzg5NzBlYmEx OGI4NWMyNTg0MWNhYmIxM2Q3YWQ1ZDU1ZC4uMjhmZjdkMDU3ZmY4OWE0NzdiNGNhYTY1MWE3MmYw OTU4NThlMWVlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIxLTAzLTI2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgVUJTYW46IHJ1bnRpbWUg ZXJyb3I6IGxvYWQgb2YgdmFsdWUgPHVua25vd24+LCB3aGljaCBpcyBub3QgYSB2YWxpZCB2YWx1 ZSBmb3IgdHlwZSAnY29uc3QgV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGll czo6RWNob0NhbmNlbGxhdGlvbicKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIyMzgy MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 czogZmFzdC9tZWRpYXN0cmVhbS9NZWRpYURldmljZXMtYWRkRXZlbnRMaXN0ZW5lci5odG1sCisg ICAgICAgICAgICAgICBmYXN0L21lZGlhc3RyZWFtL2NvbnN0cmFpbnQtaW50cmluc2ljLXNpemUu aHRtbAorICAgICAgICAgICAgICAgaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1zdHJlYW0vZW51bWVy YXRlLWRldmljZXMtaWZyYW1lLWFsbG93LWF0dHJpYnV0ZS5odG1sCisgICAgICAgICAgICAgICBo dHRwL3Rlc3RzL21lZGlhL21lZGlhLXN0cmVhbS9nZXQtZGlzcGxheS1tZWRpYS1pZnJhbWUtYWxs b3ctYXR0cmlidXRlLmh0bWwKKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvbWVkaWFjYXB0dXJlLXJlY29yZC9NZWRpYVJlY29yZGVyLWJpdHJhdGUuaHR0cHMu aHRtbAorICAgICAgICAgICAgICAgd2VicnRjL2FkZElDRUNhbmRpZGF0ZS1jbG9zZWQuaHRtbAor ICAgICAgICAgICAgICAgd2VicnRjL2ljZS1jYW5kaWRhdGUtc2RwTUxpbmVJbmRleC5odG1sCisg ICAgICAgICAgICAgICB3ZWJydGMvbGlid2VicnRjL2Rlc2NyaXB0aW9uR2V0dGVycy5odG1sCisg ICAgICAgICAgICAgICB3ZWJydGMvcGVlcmNvbm5lY3Rpb24tcGFnZS1jYWNoZS5odG1sCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlQ2FwYWJpbGl0 aWVzLmg6CisgICAgICAgIChXZWJDb3JlOjpDYXBhYmlsaXR5VmFsdWVPclJhbmdlOjptX21pbk9y VmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q2FwYWJpbGl0eVZhbHVlT3JSYW5nZTo6bV9tYXgp OgorICAgICAgICAoV2ViQ29yZTo6Q2FwYWJpbGl0eVZhbHVlT3JSYW5nZTo6bV90eXBlKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VDYXBhYmlsaXRpZXM6Om1fZWNob0Nh bmNlbGxhdGlvbik6CisgICAgICAgIC0gUHJvdmlkZSBkZWZhdWx0IGluaXRpYWxpemVyIHZhbHVl cy4gU2V0dGluZyBhIGRlZmF1bHQgdmFsdWUKKyAgICAgICAgICBmb3IgbV9lY2hvQ2FuY2VsbGF0 aW9uIGZpeGVzIHRoZSBidWcuCisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU1lZGlhU291cmNl Q2FwYWJpbGl0aWVzOjplbmNvZGUgY29uc3QpOgorICAgICAgICAtIERyaXZlLWJ5IGNsZWFuLXVw IG9mIGVuY29kZXIgc3RhdGVtZW50LgorCiAyMDIxLTAzLTIzICBZdXN1a2UgU3V6dWtpICA8eXN1 enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gRnVuY3RvciBmb3IgV2Vha0dDTWFwOjpl bnN1cmVWYWx1ZSBtdXN0IG5vdCBpbnZva2UgR0MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2VDYXBhYmlsaXRpZXMuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2VD YXBhYmlsaXRpZXMuaAppbmRleCBhNTY0YjQwNDdlMDI1NzBiOWJhZTMyNTZmODYzMzkwZWU2YmIx OWRjLi4yMjQ3NGNkN2IxODU3YTE3Nzc2NmFmZTMxNjcxM2JhZDA3M2YxNjg0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNl Q2FwYWJpbGl0aWVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v UmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGllcy5oCkBAIC0xMDYsOSArMTA2LDkgQEAgcHVi bGljOgogICAgIHRlbXBsYXRlPGNsYXNzIERlY29kZXI+IHN0YXRpYyBXQVJOX1VOVVNFRF9SRVRV Uk4gYm9vbCBkZWNvZGUoRGVjb2RlciYsIENhcGFiaWxpdHlWYWx1ZU9yUmFuZ2UmKTsKIAogcHJp dmF0ZToKLSAgICBWYWx1ZVVuaW9uIG1fbWluT3JWYWx1ZTsKLSAgICBWYWx1ZVVuaW9uIG1fbWF4 OwotICAgIFR5cGUgbV90eXBlOworICAgIFZhbHVlVW5pb24gbV9taW5PclZhbHVlIHsgMCB9Owor ICAgIFZhbHVlVW5pb24gbV9tYXggeyAwIH07CisgICAgVHlwZSBtX3R5cGUgeyBVbmRlZmluZWQg fTsKIH07CiAKIHRlbXBsYXRlPGNsYXNzIEVuY29kZXI+CkBAIC0yMDYsNyArMjA2LDcgQEAgcHJp dmF0ZToKICAgICBDYXBhYmlsaXR5VmFsdWVPclJhbmdlIG1fdm9sdW1lOwogICAgIENhcGFiaWxp dHlWYWx1ZU9yUmFuZ2UgbV9zYW1wbGVSYXRlOwogICAgIENhcGFiaWxpdHlWYWx1ZU9yUmFuZ2Ug bV9zYW1wbGVTaXplOwotICAgIEVjaG9DYW5jZWxsYXRpb24gbV9lY2hvQ2FuY2VsbGF0aW9uOwor ICAgIEVjaG9DYW5jZWxsYXRpb24gbV9lY2hvQ2FuY2VsbGF0aW9uIHsgRWNob0NhbmNlbGxhdGlv bjo6UmVhZE9ubHkgfTsKICAgICBBdG9tU3RyaW5nIG1fZGV2aWNlSWQ7CiAgICAgQXRvbVN0cmlu ZyBtX2dyb3VwSWQ7CiAKQEAgLTIyNiw4ICsyMjYsOCBAQCB2b2lkIFJlYWx0aW1lTWVkaWFTb3Vy Y2VDYXBhYmlsaXRpZXM6OmVuY29kZShFbmNvZGVyJiBlbmNvZGVyKSBjb25zdAogICAgICAgICA8 PCBtX3NhbXBsZVNpemUKICAgICAgICAgPDwgbV9kZXZpY2VJZAogICAgICAgICA8PCBtX2dyb3Vw SWQKLSAgICAgICAgPDwgbV9zdXBwb3J0ZWRDb25zdHJhaW50czsKLSAgICBlbmNvZGVyIDw8IG1f ZWNob0NhbmNlbGxhdGlvbjsKKyAgICAgICAgPDwgbV9zdXBwb3J0ZWRDb25zdHJhaW50cworICAg ICAgICA8PCBtX2VjaG9DYW5jZWxsYXRpb247CiB9CiAKIHRlbXBsYXRlPGNsYXNzIERlY29kZXI+ Cg== 424463 2021-03-27 13:01:59 -0700 2021-03-27 16:26:52 -0700 Patch for landing bug-223821-20210327130158.patch text/plain 3621 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY1MjI4Yzk0YzVlYWI2 YTU0NGY0MjIzMmE3NGY1N2RlMDRmNDBlNC4uNDA4ZjM1Yjc2ODZiYjhmMDJiYmFhMmE2NWJmOGEy YTE2ZWYzOTcxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDIxLTAzLTI3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgVUJTYW46IHJ1bnRpbWUg ZXJyb3I6IGxvYWQgb2YgdmFsdWUgPHVua25vd24+LCB3aGljaCBpcyBub3QgYSB2YWxpZCB2YWx1 ZSBmb3IgdHlwZSAnY29uc3QgV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGll czo6RWNob0NhbmNlbGxhdGlvbicKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIyMzgy MT4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBUZXN0czog ZmFzdC9tZWRpYXN0cmVhbS9NZWRpYURldmljZXMtYWRkRXZlbnRMaXN0ZW5lci5odG1sCisgICAg ICAgICAgICAgICBmYXN0L21lZGlhc3RyZWFtL2NvbnN0cmFpbnQtaW50cmluc2ljLXNpemUuaHRt bAorICAgICAgICAgICAgICAgaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1zdHJlYW0vZW51bWVyYXRl LWRldmljZXMtaWZyYW1lLWFsbG93LWF0dHJpYnV0ZS5odG1sCisgICAgICAgICAgICAgICBodHRw L3Rlc3RzL21lZGlhL21lZGlhLXN0cmVhbS9nZXQtZGlzcGxheS1tZWRpYS1pZnJhbWUtYWxsb3ct YXR0cmlidXRlLmh0bWwKKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvbWVkaWFjYXB0dXJlLXJlY29yZC9NZWRpYVJlY29yZGVyLWJpdHJhdGUuaHR0cHMuaHRt bAorICAgICAgICAgICAgICAgd2VicnRjL2FkZElDRUNhbmRpZGF0ZS1jbG9zZWQuaHRtbAorICAg ICAgICAgICAgICAgd2VicnRjL2ljZS1jYW5kaWRhdGUtc2RwTUxpbmVJbmRleC5odG1sCisgICAg ICAgICAgICAgICB3ZWJydGMvbGlid2VicnRjL2Rlc2NyaXB0aW9uR2V0dGVycy5odG1sCisgICAg ICAgICAgICAgICB3ZWJydGMvcGVlcmNvbm5lY3Rpb24tcGFnZS1jYWNoZS5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlQ2FwYWJpbGl0aWVz Lmg6CisgICAgICAgIChXZWJDb3JlOjpDYXBhYmlsaXR5VmFsdWVPclJhbmdlOjp1bmlvbiBWYWx1 ZVVuaW9uKToKKyAgICAgICAgLSBNYWtlIGFzRG91YmxlIHRoZSBmaXJzdCB1bmlvbiBtZW1iZXIg c28gQysrIG1lbWJlcgorICAgICAgICAgIGluaXRpYWxpemVycyBzZXQgYWxsIG1lbW9yeS4KKyAg ICAgICAgKFdlYkNvcmU6OkNhcGFiaWxpdHlWYWx1ZU9yUmFuZ2U6Om1fbWluT3JWYWx1ZSk6Cisg ICAgICAgIChXZWJDb3JlOjpDYXBhYmlsaXR5VmFsdWVPclJhbmdlOjptX21heCk6CisgICAgICAg IChXZWJDb3JlOjpDYXBhYmlsaXR5VmFsdWVPclJhbmdlOjptX3R5cGUpOgorICAgICAgICAoV2Vi Q29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGllczo6bV9lY2hvQ2FuY2VsbGF0aW9u KToKKyAgICAgICAgLSBQcm92aWRlIG1lbWJlciBpbml0aWFsaXplcnMuIFNldHRpbmcgYSBkZWZh dWx0IHZhbHVlIGZvcgorICAgICAgICAgIG1fZWNob0NhbmNlbGxhdGlvbiBmaXhlcyB0aGUgYnVn LgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGllczo6ZW5j b2RlIGNvbnN0KToKKyAgICAgICAgLSBEcml2ZS1ieSBjbGVhbi11cCBvZiBlbmNvZGVyIHN0YXRl bWVudC4KKwogMjAyMS0wMy0yNyAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxl LmNvbT4KIAogICAgICAgICBQQ006IFNlbmQgcmVwb3J0IHRvIGJvdGggY2xpY2sgc291cmNlIGFu ZCBhdHRyaWJ1dGlvbiBkZXN0aW5hdGlvbiB3ZWJzaXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlQ2FwYWJpbGl0aWVz LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291 cmNlQ2FwYWJpbGl0aWVzLmgKaW5kZXggYTU2NGI0MDQ3ZTAyNTcwYjliYWUzMjU2Zjg2MzM5MGVl NmJiMTlkYy4uMjQwZmQ0OTY3MmJjZTgzNjdlYTcyMjlhNTZkN2E0ZTdjOGVmNmJhYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNv dXJjZUNhcGFiaWxpdGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2VDYXBhYmlsaXRpZXMuaApAQCAtNDksOCArNDksOCBAQCBw dWJsaWM6CiAgICAgVHlwZSB0eXBlKCkgY29uc3QgeyByZXR1cm4gbV90eXBlOyB9CiAKICAgICB1 bmlvbiBWYWx1ZVVuaW9uIHsKLSAgICAgICAgaW50IGFzSW50OwogICAgICAgICBkb3VibGUgYXNE b3VibGU7CisgICAgICAgIGludCBhc0ludDsKICAgICB9OwogCiAgICAgQ2FwYWJpbGl0eVZhbHVl T3JSYW5nZSgpCkBAIC0xMDYsOSArMTA2LDkgQEAgcHVibGljOgogICAgIHRlbXBsYXRlPGNsYXNz IERlY29kZXI+IHN0YXRpYyBXQVJOX1VOVVNFRF9SRVRVUk4gYm9vbCBkZWNvZGUoRGVjb2RlciYs IENhcGFiaWxpdHlWYWx1ZU9yUmFuZ2UmKTsKIAogcHJpdmF0ZToKLSAgICBWYWx1ZVVuaW9uIG1f bWluT3JWYWx1ZTsKLSAgICBWYWx1ZVVuaW9uIG1fbWF4OwotICAgIFR5cGUgbV90eXBlOworICAg IFZhbHVlVW5pb24gbV9taW5PclZhbHVlIHsgfTsKKyAgICBWYWx1ZVVuaW9uIG1fbWF4IHsgfTsK KyAgICBUeXBlIG1fdHlwZSB7IFVuZGVmaW5lZCB9OwogfTsKIAogdGVtcGxhdGU8Y2xhc3MgRW5j b2Rlcj4KQEAgLTIwNiw3ICsyMDYsNyBAQCBwcml2YXRlOgogICAgIENhcGFiaWxpdHlWYWx1ZU9y UmFuZ2UgbV92b2x1bWU7CiAgICAgQ2FwYWJpbGl0eVZhbHVlT3JSYW5nZSBtX3NhbXBsZVJhdGU7 CiAgICAgQ2FwYWJpbGl0eVZhbHVlT3JSYW5nZSBtX3NhbXBsZVNpemU7Ci0gICAgRWNob0NhbmNl bGxhdGlvbiBtX2VjaG9DYW5jZWxsYXRpb247CisgICAgRWNob0NhbmNlbGxhdGlvbiBtX2VjaG9D YW5jZWxsYXRpb24geyBFY2hvQ2FuY2VsbGF0aW9uOjpSZWFkT25seSB9OwogICAgIEF0b21TdHJp bmcgbV9kZXZpY2VJZDsKICAgICBBdG9tU3RyaW5nIG1fZ3JvdXBJZDsKIApAQCAtMjI2LDggKzIy Niw4IEBAIHZvaWQgUmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxpdGllczo6ZW5jb2RlKEVuY29k ZXImIGVuY29kZXIpIGNvbnN0CiAgICAgICAgIDw8IG1fc2FtcGxlU2l6ZQogICAgICAgICA8PCBt X2RldmljZUlkCiAgICAgICAgIDw8IG1fZ3JvdXBJZAotICAgICAgICA8PCBtX3N1cHBvcnRlZENv bnN0cmFpbnRzOwotICAgIGVuY29kZXIgPDwgbV9lY2hvQ2FuY2VsbGF0aW9uOworICAgICAgICA8 PCBtX3N1cHBvcnRlZENvbnN0cmFpbnRzCisgICAgICAgIDw8IG1fZWNob0NhbmNlbGxhdGlvbjsK IH0KIAogdGVtcGxhdGU8Y2xhc3MgRGVjb2Rlcj4K