223802 2021-03-26 09:55:06 -0700 [Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default 2021-05-04 13:27:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson peng.liu6 webkit-bug-importer oldest_to_newest 1744214 0 jer.noble 2021-03-26 09:55:06 -0700 [Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default 1744216 1 424368 jer.noble 2021-03-26 09:57:16 -0700 Created attachment 424368 Patch 1744898 2 webkit-bug-importer 2021-03-29 13:55:17 -0700 <rdar://problem/75971620> 1744901 3 424368 peng.liu6 2021-03-29 13:58:49 -0700 Comment on attachment 424368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424368&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:199 > + _mediaDataLoadsAutomatically = !_allowsInlineMediaPlayback; Not a problem of this patch. I am curious whether we can move this line out of the macro. 1749920 4 jer.noble 2021-04-13 16:13:03 -0700 <rdar://75302974> 1749921 5 424368 eric.carlson 2021-04-13 16:13:45 -0700 Comment on attachment 424368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424368&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:199 >> + _mediaDataLoadsAutomatically = !_allowsInlineMediaPlayback; > > Not a problem of this patch. I am curious whether we can move this line out of the macro. Isn't this comparison backwards? 1756548 6 427673 jer.noble 2021-05-04 09:03:43 -0700 Created attachment 427673 Patch 1756646 7 ews-feeder 2021-05-04 13:27:19 -0700 Committed r276979 (237306@main): <https://commits.webkit.org/237306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427673. 424368 2021-03-26 09:57:16 -0700 2021-04-13 16:13:45 -0700 Patch bug-223802-20210326095716.patch text/plain 1778 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI0YWYzYWI5YzE5YzkyY2Vi MjhjZTcxNWJkMzlkNTdiYjRmZmE0MWUuLjA2YjcxODVjMDkwZmMyOGJjOGY5ZmZlYzEyMWY0MWU4 MTIwMTFmOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDMtMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBbGxvdyBIVE1MTWVk aWFFbGVtZW50IHByZWxvYWQgPiAibWV0YWRhdGEiIG9uIGlQYWQgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzODAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxpZ24gZGVmYXVsdCBp UGFkIFdlYktpdCBiZWhhdmlvciBmb3IgbWVkaWEgZWxlbWVudCBwcmVsb2FkIHdpdGggTWFjIFdl YktpdCBiZWhhdmlvci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Q29uZmlndXJhdGlvbi5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBpbml0 XSk6CisKIDIwMjEtMDMtMjUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0NvY29hXSBFbmFibGUgdGhlIFVzZUdQVVByb2Nlc3NGb3JNZWRpYSBwcmVmZXJlbmNl IGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KaW5kZXggYTkzZGQxZmEwMzcxMmQ5Nzkw MDMwYzFlMDUwMGZhMjcyMzExMDdmMC4uZDY1MTE0ZmIyZDg4MzNkNThjM2I2OGJjNmJjYTY3OWMy MDllNjUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KQEAgLTE5Niw4ICsxOTYsNyBAQCAtIChp bnN0YW5jZXR5cGUpaW5pdAogICAgIF9hbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrID0gV2ViS2l0 OjpjdXJyZW50VXNlckludGVyZmFjZUlkaW9tSXNQYWRPck1hYygpOwogICAgIF9pbmxpbmVNZWRp YVBsYXliYWNrUmVxdWlyZXNQbGF5c0lubGluZUF0dHJpYnV0ZSA9ICFfYWxsb3dzSW5saW5lTWVk aWFQbGF5YmFjazsKICAgICBfYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFja0FmdGVyRnVsbHNjcmVl biA9ICFfYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjazsKLQotICAgIF9tZWRpYURhdGFMb2Fkc0F1 dG9tYXRpY2FsbHkgPSBOTzsKKyAgICBfbWVkaWFEYXRhTG9hZHNBdXRvbWF0aWNhbGx5ID0gIV9h bGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrOwogI2lmICFQTEFURk9STShXQVRDSE9TKQogICAgIGlm IChXZWJDb3JlOjpsaW5rZWRPbk9yQWZ0ZXIoV2ViQ29yZTo6U0RLVmVyc2lvbjo6Rmlyc3RXaXRo TWVkaWFUeXBlc1JlcXVpcmluZ1VzZXJBY3Rpb25Gb3JQbGF5YmFjaykpCiAgICAgICAgIF9tZWRp YVR5cGVzUmVxdWlyaW5nVXNlckFjdGlvbkZvclBsYXliYWNrID0gV0tBdWRpb3Zpc3VhbE1lZGlh VHlwZUF1ZGlvOwo= 427673 2021-05-04 09:03:43 -0700 2021-05-04 13:27:20 -0700 Patch bug-223802-20210504090343.patch text/plain 1773 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjZGE0NTdkMGMyY2I0MzQ3 ZGIyYjY2ODA1ZGU3ZmNhOTY1Y2FjY2MuLmNmZDc5ZWJjYjk3ODg4YTI4ZjBmZDczNGFhYjVmOGMw YmE1OTkzY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUtMDQgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBbGxvdyBIVE1MTWVk aWFFbGVtZW50IHByZWxvYWQgPiAibWV0YWRhdGEiIG9uIGlQYWQgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzODAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIEFsaWduIGRlZmF1bHQgaVBh ZCBXZWJLaXQgYmVoYXZpb3IgZm9yIG1lZGlhIGVsZW1lbnQgcHJlbG9hZCB3aXRoIE1hYyBXZWJL aXQgYmVoYXZpb3IuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0Nv bmZpZ3VyYXRpb24ubW06CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gaW5pdF0p OgorCiAyMDIxLTA0LTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtHUFVQXVtpT1NdIFNpbGVudCB2aWRlbyBwbGF5YmFjayBjYW4gaW50ZXJydXB0IHN5c3Rl bSBhdWRpbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld0NvbmZpZ3VyYXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCBlNTEzMDc2OTMxZjZiNDkzNTljNzdj YWE5NjgxOTgyMTE1ODIwYjJkLi4xYjYxMWZlMzY5MTMzMzVmOTZlYzc3NTk5NDI0NTNhNTUwYThj ZjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Q29uZmlndXJhdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQpAQCAtMjAwLDggKzIwMCw3IEBAIC0gKGluc3Rh bmNldHlwZSlpbml0CiAgICAgX2FsbG93c0lubGluZU1lZGlhUGxheWJhY2sgPSBXZWJLaXQ6OmN1 cnJlbnRVc2VySW50ZXJmYWNlSWRpb21Jc1BhZE9yTWFjKCk7CiAgICAgX2lubGluZU1lZGlhUGxh eWJhY2tSZXF1aXJlc1BsYXlzSW5saW5lQXR0cmlidXRlID0gIV9hbGxvd3NJbmxpbmVNZWRpYVBs YXliYWNrOwogICAgIF9hbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrQWZ0ZXJGdWxsc2NyZWVuID0g IV9hbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrOwotCi0gICAgX21lZGlhRGF0YUxvYWRzQXV0b21h dGljYWxseSA9IE5POworICAgIF9tZWRpYURhdGFMb2Fkc0F1dG9tYXRpY2FsbHkgPSBfYWxsb3dz SW5saW5lTWVkaWFQbGF5YmFjazsKICNpZiAhUExBVEZPUk0oV0FUQ0hPUykKICAgICBpZiAoV2Vi Q29yZTo6bGlua2VkT25PckFmdGVyKFdlYkNvcmU6OlNES1ZlcnNpb246OkZpcnN0V2l0aE1lZGlh VHlwZXNSZXF1aXJpbmdVc2VyQWN0aW9uRm9yUGxheWJhY2spKQogICAgICAgICBfbWVkaWFUeXBl c1JlcXVpcmluZ1VzZXJBY3Rpb25Gb3JQbGF5YmFjayA9IFdLQXVkaW92aXN1YWxNZWRpYVR5cGVB dWRpbzsK