223797 2021-03-26 07:44:37 -0700 Add a fast path for text only render tree updates 2021-04-02 07:45:17 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1744164 0 koivisto 2021-03-26 07:44:37 -0700 Render tree updates for text content changes are done along with style updates. However much of the machinery can be skipped if there is nothing else to do besides the text update. 1744165 1 424351 koivisto 2021-03-26 07:45:05 -0700 Created attachment 424351 wip 1744170 2 424353 koivisto 2021-03-26 07:51:34 -0700 Created attachment 424353 wip 1744172 3 424355 koivisto 2021-03-26 07:57:08 -0700 Created attachment 424355 wip 1744186 4 424359 koivisto 2021-03-26 08:43:00 -0700 Created attachment 424359 wip 1746494 5 webkit-bug-importer 2021-04-02 07:45:17 -0700 <rdar://problem/76148447> 424351 2021-03-26 07:45:05 -0700 2021-03-26 07:48:57 -0700 wip text-update-fast-path.patch text/plain 1550 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGUxYzc5OWIyNGVhZS4uNDUzMzhkNWE4MjhmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE5OTcsNiArMTk5NywxNCBAQCB2b2lkIERvY3Vt ZW50OjpyZXNvbHZlU3R5bGUoUmVzb2x2ZVN0eWxlVHlwZSB0eXBlKQogICAgIAogICAgIGlmICht X2luU3R5bGVSZWNhbGMpCiAgICAgICAgIHJldHVybjsgLy8gR3VhcmQgYWdhaW5zdCByZS1lbnRy YW5jeS4gLWR3aAorICAgIAorICAgIC8vIEZhc3QgcGF0aCBmb3Igd2hlbiBhIHRleHQgY29udGVu dCB1cGRhdGUgaXMgdGhlIG9ubHkgcmVhc29uIHdlIGFyZSBoZXJlLgorICAgIGF1dG8gcGVuZGlu Z1JlbmRlclRyZWVUZXh0VXBkYXRlID0gc3RkOjpleGNoYW5nZShtX3BlbmRpbmdSZW5kZXJUcmVl VGV4dFVwZGF0ZSwgbnVsbHB0cik7CisgICAgaWYgKCFuZWVkc1N0eWxlUmVjYWxjKCkpIHsKKyAg ICAgICAgaWYgKHBlbmRpbmdSZW5kZXJUcmVlVGV4dFVwZGF0ZSkKKyAgICAgICAgICAgIHVwZGF0 ZVJlbmRlclRyZWUoV1RGTW92ZShwZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRhdGUpKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KIAogICAgIFRyYWNlU2NvcGUgdHJhY2luZ1Njb3BlKFN0eWxlUmVj YWxjU3RhcnQsIFN0eWxlUmVjYWxjRW5kKTsKIApAQCAtMjA1Myw3ICsyMDYxLDcgQEAgdm9pZCBE b2N1bWVudDo6cmVzb2x2ZVN0eWxlKFJlc29sdmVTdHlsZVR5cGUgdHlwZSkKICAgICAgICAgICAg ICAgICBkb2N1bWVudEVsZW1lbnQtPmludmFsaWRhdGVTdHlsZUZvclN1YnRyZWUoKTsKICAgICAg ICAgfQogCi0gICAgICAgIFN0eWxlOjpUcmVlUmVzb2x2ZXIgcmVzb2x2ZXIoKnRoaXMsIFdURk1v dmUobV9wZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRhdGUpKTsKKyAgICAgICAgU3R5bGU6OlRyZWVS ZXNvbHZlciByZXNvbHZlcigqdGhpcywgV1RGTW92ZShwZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRh dGUpKTsKICAgICAgICAgYXV0byBzdHlsZVVwZGF0ZSA9IHJlc29sdmVyLnJlc29sdmUoKTsKIAog ICAgICAgICBtX2xhc3RTdHlsZVVwZGF0ZVNpemVGb3JUZXN0aW5nID0gc3R5bGVVcGRhdGUgPyBz dHlsZVVwZGF0ZS0+c2l6ZSgpIDogMDsKQEAgLTIxMDYsNyArMjExNCw3IEBAIHZvaWQgRG9jdW1l bnQ6OnVwZGF0ZVRleHRSZW5kZXJlcihUZXh0JiB0ZXh0LCB1bnNpZ25lZCBvZmZzZXRPZlJlcGxh Y2VkVGV4dCwgdW5zCiAKICAgICBtX3BlbmRpbmdSZW5kZXJUcmVlVGV4dFVwZGF0ZS0+YWRkVGV4 dCh0ZXh0LCB7IG9mZnNldE9mUmVwbGFjZWRUZXh0LCBsZW5ndGhPZlJlcGxhY2VkVGV4dCwgV1RG OjpudWxsb3B0IH0pOwogCi0gICAgc2NoZWR1bGVSZW5kZXJpbmdVcGRhdGUoeyB9KTsKKyAgICBz Y2hlZHVsZVN0eWxlUmVjYWxjKCk7CiB9CiAKIGJvb2wgRG9jdW1lbnQ6Om5lZWRzU3R5bGVSZWNh bGMoKSBjb25zdAo= 424353 2021-03-26 07:51:34 -0700 2021-03-26 07:57:08 -0700 wip text-update-fast-path-2.patch text/plain 1587 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGUxYzc5OWIyNGVhZS4uODk3ZTdmNTEwYTdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE5OTcsNiArMTk5NywxNCBAQCB2b2lkIERvY3Vt ZW50OjpyZXNvbHZlU3R5bGUoUmVzb2x2ZVN0eWxlVHlwZSB0eXBlKQogICAgIAogICAgIGlmICht X2luU3R5bGVSZWNhbGMpCiAgICAgICAgIHJldHVybjsgLy8gR3VhcmQgYWdhaW5zdCByZS1lbnRy YW5jeS4gLWR3aAorICAgIAorICAgIC8vIEZhc3QgcGF0aCBmb3Igd2hlbiBhIHRleHQgY29udGVu dCB1cGRhdGUgaXMgdGhlIG9ubHkgcmVhc29uIHdlIGFyZSBoZXJlLgorICAgIGF1dG8gcGVuZGlu Z1JlbmRlclRyZWVUZXh0VXBkYXRlID0gc3RkOjpleGNoYW5nZShtX3BlbmRpbmdSZW5kZXJUcmVl VGV4dFVwZGF0ZSwgbnVsbHB0cik7CisgICAgaWYgKCFuZWVkc1N0eWxlUmVjYWxjKCkgJiYgdHlw ZSAhPSBSZXNvbHZlU3R5bGVUeXBlOjpSZWJ1aWxkKSB7CisgICAgICAgIGlmIChwZW5kaW5nUmVu ZGVyVHJlZVRleHRVcGRhdGUpCisgICAgICAgICAgICB1cGRhdGVSZW5kZXJUcmVlKFdURk1vdmUo cGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlKSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAK ICAgICBUcmFjZVNjb3BlIHRyYWNpbmdTY29wZShTdHlsZVJlY2FsY1N0YXJ0LCBTdHlsZVJlY2Fs Y0VuZCk7CiAKQEAgLTIwNTMsNyArMjA2MSw3IEBAIHZvaWQgRG9jdW1lbnQ6OnJlc29sdmVTdHls ZShSZXNvbHZlU3R5bGVUeXBlIHR5cGUpCiAgICAgICAgICAgICAgICAgZG9jdW1lbnRFbGVtZW50 LT5pbnZhbGlkYXRlU3R5bGVGb3JTdWJ0cmVlKCk7CiAgICAgICAgIH0KIAotICAgICAgICBTdHls ZTo6VHJlZVJlc29sdmVyIHJlc29sdmVyKCp0aGlzLCBXVEZNb3ZlKG1fcGVuZGluZ1JlbmRlclRy ZWVUZXh0VXBkYXRlKSk7CisgICAgICAgIFN0eWxlOjpUcmVlUmVzb2x2ZXIgcmVzb2x2ZXIoKnRo aXMsIFdURk1vdmUocGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlKSk7CiAgICAgICAgIGF1dG8g c3R5bGVVcGRhdGUgPSByZXNvbHZlci5yZXNvbHZlKCk7CiAKICAgICAgICAgbV9sYXN0U3R5bGVV cGRhdGVTaXplRm9yVGVzdGluZyA9IHN0eWxlVXBkYXRlID8gc3R5bGVVcGRhdGUtPnNpemUoKSA6 IDA7CkBAIC0yMTA2LDcgKzIxMTQsNyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVUZXh0UmVuZGVy ZXIoVGV4dCYgdGV4dCwgdW5zaWduZWQgb2Zmc2V0T2ZSZXBsYWNlZFRleHQsIHVucwogCiAgICAg bV9wZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRhdGUtPmFkZFRleHQodGV4dCwgeyBvZmZzZXRPZlJl cGxhY2VkVGV4dCwgbGVuZ3RoT2ZSZXBsYWNlZFRleHQsIFdURjo6bnVsbG9wdCB9KTsKIAotICAg IHNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKHsgfSk7CisgICAgc2NoZWR1bGVTdHlsZVJlY2FsYygp OwogfQogCiBib29sIERvY3VtZW50OjpuZWVkc1N0eWxlUmVjYWxjKCkgY29uc3QK 424355 2021-03-26 07:57:08 -0700 2021-03-26 08:43:00 -0700 wip text-update-fast-path-3.patch text/plain 1967 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGUxYzc5OWIyNGVhZS4uMzIxNzhlYjNkM2NlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE5NDMsNyArMTk0Myw3IEBAIHZvaWQgRG9jdW1l bnQ6OnNjaGVkdWxlU3R5bGVSZWNhbGMoKQogICAgIGlmIChtX3N0eWxlUmVjYWxjVGltZXIuaXNB Y3RpdmUoKSB8fCBiYWNrRm9yd2FyZENhY2hlU3RhdGUoKSAhPSBOb3RJbkJhY2tGb3J3YXJkQ2Fj aGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFTU0VSVChjaGlsZE5lZWRzU3R5bGVSZWNhbGMo KSB8fCBtX25lZWRzRnVsbFN0eWxlUmVidWlsZCk7CisgICAgQVNTRVJUKGNoaWxkTmVlZHNTdHls ZVJlY2FsYygpIHx8IG1fbmVlZHNGdWxsU3R5bGVSZWJ1aWxkIHx8IG1fcGVuZGluZ1JlbmRlclRy ZWVUZXh0VXBkYXRlKTsKIAogICAgIG1fc3R5bGVSZWNhbGNUaW1lci5zdGFydE9uZVNob3QoMF9z KTsKIApAQCAtMTk5Nyw2ICsxOTk3LDE0IEBAIHZvaWQgRG9jdW1lbnQ6OnJlc29sdmVTdHlsZShS ZXNvbHZlU3R5bGVUeXBlIHR5cGUpCiAgICAgCiAgICAgaWYgKG1faW5TdHlsZVJlY2FsYykKICAg ICAgICAgcmV0dXJuOyAvLyBHdWFyZCBhZ2FpbnN0IHJlLWVudHJhbmN5LiAtZHdoCisgICAgCisg ICAgLy8gRmFzdCBwYXRoIGZvciB3aGVuIGEgdGV4dCBjb250ZW50IHVwZGF0ZSBpcyB0aGUgb25s eSByZWFzb24gd2UgYXJlIGhlcmUuCisgICAgYXV0byBwZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRh dGUgPSBzdGQ6OmV4Y2hhbmdlKG1fcGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlLCBudWxscHRy KTsKKyAgICBpZiAoIW5lZWRzU3R5bGVSZWNhbGMoKSAmJiB0eXBlICE9IFJlc29sdmVTdHlsZVR5 cGU6OlJlYnVpbGQpIHsKKyAgICAgICAgaWYgKHBlbmRpbmdSZW5kZXJUcmVlVGV4dFVwZGF0ZSkK KyAgICAgICAgICAgIHVwZGF0ZVJlbmRlclRyZWUoV1RGTW92ZShwZW5kaW5nUmVuZGVyVHJlZVRl eHRVcGRhdGUpKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIFRyYWNlU2NvcGUgdHJh Y2luZ1Njb3BlKFN0eWxlUmVjYWxjU3RhcnQsIFN0eWxlUmVjYWxjRW5kKTsKIApAQCAtMjA1Myw3 ICsyMDYxLDcgQEAgdm9pZCBEb2N1bWVudDo6cmVzb2x2ZVN0eWxlKFJlc29sdmVTdHlsZVR5cGUg dHlwZSkKICAgICAgICAgICAgICAgICBkb2N1bWVudEVsZW1lbnQtPmludmFsaWRhdGVTdHlsZUZv clN1YnRyZWUoKTsKICAgICAgICAgfQogCi0gICAgICAgIFN0eWxlOjpUcmVlUmVzb2x2ZXIgcmVz b2x2ZXIoKnRoaXMsIFdURk1vdmUobV9wZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRhdGUpKTsKKyAg ICAgICAgU3R5bGU6OlRyZWVSZXNvbHZlciByZXNvbHZlcigqdGhpcywgV1RGTW92ZShwZW5kaW5n UmVuZGVyVHJlZVRleHRVcGRhdGUpKTsKICAgICAgICAgYXV0byBzdHlsZVVwZGF0ZSA9IHJlc29s dmVyLnJlc29sdmUoKTsKIAogICAgICAgICBtX2xhc3RTdHlsZVVwZGF0ZVNpemVGb3JUZXN0aW5n ID0gc3R5bGVVcGRhdGUgPyBzdHlsZVVwZGF0ZS0+c2l6ZSgpIDogMDsKQEAgLTIxMDYsNyArMjEx NCw3IEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0ZVRleHRSZW5kZXJlcihUZXh0JiB0ZXh0LCB1bnNp Z25lZCBvZmZzZXRPZlJlcGxhY2VkVGV4dCwgdW5zCiAKICAgICBtX3BlbmRpbmdSZW5kZXJUcmVl VGV4dFVwZGF0ZS0+YWRkVGV4dCh0ZXh0LCB7IG9mZnNldE9mUmVwbGFjZWRUZXh0LCBsZW5ndGhP ZlJlcGxhY2VkVGV4dCwgV1RGOjpudWxsb3B0IH0pOwogCi0gICAgc2NoZWR1bGVSZW5kZXJpbmdV cGRhdGUoeyB9KTsKKyAgICBzY2hlZHVsZVN0eWxlUmVjYWxjKCk7CiB9CiAKIGJvb2wgRG9jdW1l bnQ6Om5lZWRzU3R5bGVSZWNhbGMoKSBjb25zdAo= 424359 2021-03-26 08:43:00 -0700 2021-03-26 08:43:00 -0700 wip text-update-fast-path-4.patch text/plain 2001 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGUxYzc5OWIyNGVhZS4uNzNiYzc2MWQ0MTI4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE5NDMsNyArMTk0Myw3IEBAIHZvaWQgRG9jdW1l bnQ6OnNjaGVkdWxlU3R5bGVSZWNhbGMoKQogICAgIGlmIChtX3N0eWxlUmVjYWxjVGltZXIuaXNB Y3RpdmUoKSB8fCBiYWNrRm9yd2FyZENhY2hlU3RhdGUoKSAhPSBOb3RJbkJhY2tGb3J3YXJkQ2Fj aGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFTU0VSVChjaGlsZE5lZWRzU3R5bGVSZWNhbGMo KSB8fCBtX25lZWRzRnVsbFN0eWxlUmVidWlsZCk7CisgICAgQVNTRVJUKGNoaWxkTmVlZHNTdHls ZVJlY2FsYygpIHx8IG1fbmVlZHNGdWxsU3R5bGVSZWJ1aWxkIHx8IG1fcGVuZGluZ1JlbmRlclRy ZWVUZXh0VXBkYXRlKTsKIAogICAgIG1fc3R5bGVSZWNhbGNUaW1lci5zdGFydE9uZVNob3QoMF9z KTsKIApAQCAtMTk5Nyw2ICsxOTk3LDE1IEBAIHZvaWQgRG9jdW1lbnQ6OnJlc29sdmVTdHlsZShS ZXNvbHZlU3R5bGVUeXBlIHR5cGUpCiAgICAgCiAgICAgaWYgKG1faW5TdHlsZVJlY2FsYykKICAg ICAgICAgcmV0dXJuOyAvLyBHdWFyZCBhZ2FpbnN0IHJlLWVudHJhbmN5LiAtZHdoCisgICAgCisg ICAgLy8gRmFzdCBwYXRoIGZvciB3aGVuIGEgdGV4dCBjb250ZW50IHVwZGF0ZSBpcyB0aGUgb25s eSByZWFzb24gd2UgYXJlIGhlcmUuCisgICAgYXV0byBwZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRh dGUgPSBzdGQ6OmV4Y2hhbmdlKG1fcGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlLCBudWxscHRy KTsKKyAgICBpZiAoIW5lZWRzU3R5bGVSZWNhbGMoKSAmJiB0eXBlICE9IFJlc29sdmVTdHlsZVR5 cGU6OlJlYnVpbGQpIHsKKyAgICAgICAgaWYgKHBlbmRpbmdSZW5kZXJUcmVlVGV4dFVwZGF0ZSkK KyAgICAgICAgICAgIHVwZGF0ZVJlbmRlclRyZWUoV1RGTW92ZShwZW5kaW5nUmVuZGVyVHJlZVRl eHRVcGRhdGUpKTsKKyAgICAgICAgdW5zY2hlZHVsZVN0eWxlUmVjYWxjKCk7CisgICAgICAgIHJl dHVybjsKKyAgICB9CiAKICAgICBUcmFjZVNjb3BlIHRyYWNpbmdTY29wZShTdHlsZVJlY2FsY1N0 YXJ0LCBTdHlsZVJlY2FsY0VuZCk7CiAKQEAgLTIwNTMsNyArMjA2Miw3IEBAIHZvaWQgRG9jdW1l bnQ6OnJlc29sdmVTdHlsZShSZXNvbHZlU3R5bGVUeXBlIHR5cGUpCiAgICAgICAgICAgICAgICAg ZG9jdW1lbnRFbGVtZW50LT5pbnZhbGlkYXRlU3R5bGVGb3JTdWJ0cmVlKCk7CiAgICAgICAgIH0K IAotICAgICAgICBTdHlsZTo6VHJlZVJlc29sdmVyIHJlc29sdmVyKCp0aGlzLCBXVEZNb3ZlKG1f cGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlKSk7CisgICAgICAgIFN0eWxlOjpUcmVlUmVzb2x2 ZXIgcmVzb2x2ZXIoKnRoaXMsIFdURk1vdmUocGVuZGluZ1JlbmRlclRyZWVUZXh0VXBkYXRlKSk7 CiAgICAgICAgIGF1dG8gc3R5bGVVcGRhdGUgPSByZXNvbHZlci5yZXNvbHZlKCk7CiAKICAgICAg ICAgbV9sYXN0U3R5bGVVcGRhdGVTaXplRm9yVGVzdGluZyA9IHN0eWxlVXBkYXRlID8gc3R5bGVV cGRhdGUtPnNpemUoKSA6IDA7CkBAIC0yMTA2LDcgKzIxMTUsNyBAQCB2b2lkIERvY3VtZW50Ojp1 cGRhdGVUZXh0UmVuZGVyZXIoVGV4dCYgdGV4dCwgdW5zaWduZWQgb2Zmc2V0T2ZSZXBsYWNlZFRl eHQsIHVucwogCiAgICAgbV9wZW5kaW5nUmVuZGVyVHJlZVRleHRVcGRhdGUtPmFkZFRleHQodGV4 dCwgeyBvZmZzZXRPZlJlcGxhY2VkVGV4dCwgbGVuZ3RoT2ZSZXBsYWNlZFRleHQsIFdURjo6bnVs bG9wdCB9KTsKIAotICAgIHNjaGVkdWxlUmVuZGVyaW5nVXBkYXRlKHsgfSk7CisgICAgc2NoZWR1 bGVTdHlsZVJlY2FsYygpOwogfQogCiBib29sIERvY3VtZW50OjpuZWVkc1N0eWxlUmVjYWxjKCkg Y29uc3QK