223782 2021-03-25 22:03:08 -0700 REGRESSION(r272301): [SOUP] default port attribute when persisting credential information with libsecret 2021-03-26 02:39:53 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 enometh webkit-unassigned aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1744068 0 enometh 2021-03-25 22:03:08 -0700 with webkit-2.31.91 When logging into http://192.168.20.1/ with Basic authentication, the password prompt says: "Authentication required by 192.168.20.1:0" The default port (via protectionSpace.port()) is now 0 instead of 80 and earlier credentials are missed when libsecret calls SearchItems because of this mismatch. ]I'm not sure if this was an oversight or if it were intended, hence this report] 1744086 1 424322 cgarcia 2021-03-26 00:40:44 -0700 Created attachment 424322 Patch 1744123 2 cgarcia 2021-03-26 02:39:53 -0700 Committed r275085 (235796@main): <https://commits.webkit.org/235796@main> 424322 2021-03-26 00:40:44 -0700 2021-03-26 02:11:35 -0700 Patch wk2-auth-port.diff text/plain 1466 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYjEyYjhjZDg2YjUuLmJjYzNiMmJkMTE0NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIxLTAzLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNzIzMDEpOiBbU09VUF0gZGVmYXVs dCBwb3J0IGF0dHJpYnV0ZSB3aGVuIHBlcnNpc3RpbmcgY3JlZGVudGlhbCBpbmZvcm1hdGlvbiB3 aXRoIGxpYnNlY3JldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIzNzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNlIHRoZSBkZWZhdWx0IHBvcnQgaW5zdGVhZCBvZiAwIHdoZW4gdGhlIFVSTCBvbWl0 cyB0aGUgcG9ydC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNh dGlvbkNoYWxsZW5nZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJvdGVjdGlvblNwYWNl RnJvbVNvdXBBdXRoQW5kVVJMKToKKwogMjAyMS0wMy0yNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzQ4 MjYgYW5kIHIyNzQ5NjguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2VTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZVNvdXAuY3BwCmlu ZGV4IDVlNjBmYjRhZTNiMi4uNGI4MjljNjNjODA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2VTb3VwLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25D aGFsbGVuZ2VTb3VwLmNwcApAQCAtNjQsNiArNjQsOCBAQCBzdGF0aWMgUHJvdGVjdGlvblNwYWNl IHByb3RlY3Rpb25TcGFjZUZyb21Tb3VwQXV0aEFuZFVSTChTb3VwQXV0aCogc291cEF1dGgsIGNv bgogI2lmIFVTRShTT1VQMikKICAgICBhdXRvIGhvc3QgPSB1cmwuaG9zdCgpOwogICAgIGF1dG8g cG9ydCA9IHVybC5wb3J0KCk7CisgICAgaWYgKCFwb3J0KQorICAgICAgICBwb3J0ID0gZGVmYXVs dFBvcnRGb3JQcm90b2NvbCh1cmwucHJvdG9jb2woKSk7CiAjZWxzZQogICAgIFVSTCBhdXRoVVJM KHsgfSwgbWFrZVN0cmluZygiaHR0cDovLyIsIHNvdXBfYXV0aF9nZXRfYXV0aG9yaXR5KHNvdXBB dXRoKSkpOwogICAgIGF1dG8gaG9zdCA9IGF1dGhVUkwuaG9zdCgpOwo=