223778 2021-03-25 18:40:29 -0700 [Metal ANGLE] Mipmap generation on Intel does not reliably work for textures with width less than four 2021-03-25 23:27:46 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220076 1 kpiddington webkit-unassigned dino ews-watchlist graouts kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1744032 0 kpiddington 2021-03-25 18:40:29 -0700 The following four tests are failing on Intel configurations webgl/1.0.3/conformance/limits/gl-max-texture-dimensions.html webgl/1.0.3/conformance/textures/texture-size.html webgl/2.0.0/conformance/limits/gl-max-texture-dimensions.html webgl/2.0.0/conformance/textures/misc/texture-size.html All four are failing in subcases when sampling off of mipmaps of 'thin' textures. (Textures with a width less than four, in this case.) 1744035 1 424310 kpiddington 2021-03-25 18:46:20 -0700 Created attachment 424310 Patch 1744036 2 ews-watchlist 2021-03-25 18:47:31 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1744045 3 dino 2021-03-25 20:09:50 -0700 Committed r275073 (235785@main): <https://commits.webkit.org/235785@main> 1744046 4 webkit-bug-importer 2021-03-25 20:10:15 -0700 <rdar://problem/75869063> 424310 2021-03-25 18:46:20 -0700 2021-03-25 18:49:42 -0700 Patch bug-223778-20210325184619.patch text/plain 6122 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOWExZTQ2NmJkMWM2NDEzYjVmYjM0OGM2MmJjYzQ5MTYzMzZkOWQwMS4uNjAwMTk3YjE1ZGNi ZmY3MjU4ZjJlMTgwZTRkOTBlOGM5NmY1YWNlMiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTAzLTI1ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICBbTWV0YWwgQU5HTEVdIEFkZCBDUFUgbWlwbWFwIGdl bmVyYXRpb24gZm9yIHdvcmthcm91bmQgb24gSW50ZWwgZGV2aWNlcy4KKyAgICAgICBNaXBtYXAg Z2VuZXJhdGlvbiBvbiBJbnRlbCBkb2VzIG5vdCByZWxpYWJseSB3b3JrIGZvciB0ZXh0dXJlcyB3 aXRoIHdpZHRoIGxlc3MgdGhhbiBmb3VyLiBUbyByZWxpYWJseSBwYXNzIHdlYkdMIGNvbmZvcm1h bmNlLCB3ZSBuZWVkIHRvIHN3aXRjaCB0byBDUFUgbWlwbWFwIGdlbmVyYXRpb24gd2hlbiBnZW5l cmF0aW5nIG1pcG1hcHMgaW4gdGhpcyBzcGVjaWZpYyBjaXJjdW1zdGFuY2UuCisKKyAgICAgICAg VGhpcyBwYXRjaCBmaXhlcyB0aGUgZm9sbG93aW5nIGZvdXIgdGVzdHMgb24gSW50ZWwKKyAgICAg ICAgd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvbGltaXRzL2dsLW1heC10ZXh0dXJlLWRpbWVuc2lv bnMuaHRtbAorICAgICAgICB3ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS90ZXh0dXJlcy90ZXh0dXJl LXNpemUuaHRtbAorICAgICAgICB3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZS9saW1pdHMvZ2wtbWF4 LXRleHR1cmUtZGltZW5zaW9ucy5odG1sCisgICAgICAgIHdlYmdsLzIuMC4wL2NvbmZvcm1hbmNl L3RleHR1cmVzL21pc2MvdGV4dHVyZS1zaXplLmh0bWwKKworCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM3NzgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluY2x1ZGUvcGxhdGZvcm0vRmVhdHVyZS5o OgorICAgICAgICAoYW5nbGU6OkZlYXR1cmVDYXRlZ29yeVRvU3RyaW5nKToKKyAgICAgICAgKiBp bmNsdWRlL3BsYXRmb3JtL0ZlYXR1cmVzTXRsLmg6CisgICAgICAgICogc3JjL2xpYkFOR0xFL3Jl bmRlcmVyL21ldGFsL0Rpc3BsYXlNdGwubW06CisgICAgICAgIChyeDo6RGlzcGxheU10bDo6aW5p dGlhbGl6ZUZlYXR1cmVzKToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwv VGV4dHVyZU10bC5tbToKKyAgICAgICAgKHJ4OjpUZXh0dXJlTXRsOjpnZW5lcmF0ZU1pcG1hcCk6 CisKIDIwMjEtMDMtMjUgIEt5bGUgUGlkZGluZ3RvbiAgPGtwaWRkaW5ndG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBBTkdMRSBNZXRhbCBjcmFzaCBBU0FOIHdlYmdsLzEuMC4zL2NvbmZvcm1hbmNl L21pc2Mvb2JqZWN0LWRlbGV0aW9uLWJlaGF2aW91ci5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3BsYXRmb3JtL0ZlYXR1cmUuaCBiL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxhdGZvcm0vRmVhdHVyZS5oCmluZGV4IDNhYzI2M2Q2ZWM5 ZjRhMmRjY2ZiYmFjOTY5MDg0ZjRjMzkyYWM0OWEuLmVkOTkzODE4NTBjNjU1YzYyYjdkMTliNjA1 MzgyNzM3YWRmMGVmYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1 ZGUvcGxhdGZvcm0vRmVhdHVyZS5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1 ZGUvcGxhdGZvcm0vRmVhdHVyZS5oCkBAIC0zMyw2ICszMyw3IEBAIGVudW0gY2xhc3MgRmVhdHVy ZUNhdGVnb3J5CiAgICAgVnVsa2FuV29ya2Fyb3VuZHMsCiAgICAgVnVsa2FuRmVhdHVyZXMsCiAg ICAgTWV0YWxGZWF0dXJlcywKKyAgICBNZXRhbFdvcmthcm91bmRzLAogfTsKIAogY29uc3RleHBy IGNoYXIga0ZlYXR1cmVDYXRlZ29yeUZyb250ZW5kV29ya2Fyb3VuZHNbXSAgICA9ICJGcm9udGVu ZCB3b3JrYXJvdW5kcyI7CkBAIC00Myw2ICs0NCw3IEBAIGNvbnN0ZXhwciBjaGFyIGtGZWF0dXJl Q2F0ZWdvcnlEM0RDb21waWxlcldvcmthcm91bmRzW10gPSAiRDNEIGNvbXBpbGVyIHdvcmthcm91 CiBjb25zdGV4cHIgY2hhciBrRmVhdHVyZUNhdGVnb3J5VnVsa2FuV29ya2Fyb3VuZHNbXSAgICAg ID0gIlZ1bGthbiB3b3JrYXJvdW5kcyI7CiBjb25zdGV4cHIgY2hhciBrRmVhdHVyZUNhdGVnb3J5 VnVsa2FuRmVhdHVyZXNbXSAgICAgICAgID0gIlZ1bGthbiBmZWF0dXJlcyI7CiBjb25zdGV4cHIg Y2hhciBrRmVhdHVyZUNhdGVnb3J5TWV0YWxGZWF0dXJlc1tdICAgICAgICAgID0gIk1ldGFsIGZl YXR1cmVzIjsKK2NvbnN0ZXhwciBjaGFyIGtGZWF0dXJlQ2F0ZWdvcnlNZXRhbFdvcmthcm91bmRz W10gICAgICAgPSAiTWV0YWwgV29ya2Fyb3VuZHMiOwogY29uc3RleHByIGNoYXIga0ZlYXR1cmVD YXRlZ29yeVVua25vd25bXSAgICAgICAgICAgICAgICA9ICJVbmtub3duIjsKIAogaW5saW5lIGNv bnN0IGNoYXIgKkZlYXR1cmVDYXRlZ29yeVRvU3RyaW5nKGNvbnN0IEZlYXR1cmVDYXRlZ29yeSAm ZmMpCkBAIC04MSw2ICs4MywxMCBAQCBpbmxpbmUgY29uc3QgY2hhciAqRmVhdHVyZUNhdGVnb3J5 VG9TdHJpbmcoY29uc3QgRmVhdHVyZUNhdGVnb3J5ICZmYykKICAgICAgICAgICAgIHJldHVybiBr RmVhdHVyZUNhdGVnb3J5TWV0YWxGZWF0dXJlczsKICAgICAgICAgICAgIGJyZWFrOwogCisgICAg ICAgIGNhc2UgRmVhdHVyZUNhdGVnb3J5OjpNZXRhbFdvcmthcm91bmRzOgorICAgICAgICAgICAg cmV0dXJuIGtGZWF0dXJlQ2F0ZWdvcnlNZXRhbFdvcmthcm91bmRzOworICAgICAgICAgICAgYnJl YWs7CisKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiBrRmVhdHVyZUNhdGVn b3J5VW5rbm93bjsKICAgICAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc010bC5oIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc010bC5oCmluZGV4IGJhZjc3ZWEw ODNjMmE0OGJiZmQ0NTM3NzFhMTlkZGRlMWZjNWVlMzUuLmI2MzdiNGFiNDc0OGJmYWU1MjNhNTFl MGRjNjNkZDFmYjJmZjFlNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2lu Y2x1ZGUvcGxhdGZvcm0vRmVhdHVyZXNNdGwuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9pbmNsdWRlL3BsYXRmb3JtL0ZlYXR1cmVzTXRsLmgKQEAgLTEyMCw2ICsxMjAsMTEgQEAgc3Ry dWN0IEZlYXR1cmVzTXRsIDogRmVhdHVyZVNldEJhc2UKICAgICAgICAgICAgICJyZXdyaXRlX3Jv d19tYWpvcl9tYXRyaWNlcyIsIEZlYXR1cmVDYXRlZ29yeTo6TWV0YWxGZWF0dXJlcywKICAgICAg ICAgICAgICJSZXdyaXRlIHJvdyBtYWpvciBtYXRyaWNlcyBpbiBzaGFkZXJzIGFzIGNvbHVtbiBt YWpvci4iLAogICAgICAgICAgICAgJm1lbWJlcnN9OworCisgICAgRmVhdHVyZSBpbnRlbFRoaW5N aXBtYXBXb3JrYXJvdW5kID0geworICAgICAgICAgICAgImludGVsX3RoaW5fbWlwbWFwX3dvcmth cm91bmQiLCBGZWF0dXJlQ2F0ZWdvcnk6Ok1ldGFsV29ya2Fyb3VuZHMsCisgICAgICAgICAgICAi R2VuZXJhdGUgbWlwbWFwcyBmb3IgdGhpbiAoPDUgcGl4ZWwpIHdpZGUgdGV4dHVyZXMgb24gdGhl IENQVSBmb3IgSW50ZWwiLAorICAgICAgICAgICAgJm1lbWJlcnN9OwogfTsKIAogfSAgLy8gbmFt ZXNwYWNlIGFuZ2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGli QU5HTEUvcmVuZGVyZXIvbWV0YWwvRGlzcGxheU10bC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9EaXNwbGF5TXRsLm1tCmluZGV4IDYzMzlm MTYyMGVhZmI0M2Q0YTQ4NWE1ZGU2ZmM1YTE3MjU5OTFhZmIuLjRmMzUxODUyMGRhZTVmOWI0ZWFj MzE2NmQ4YTViMzE0NzI5OTMzZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9EaXNwbGF5TXRsLm1tCisrKyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9EaXNwbGF5TXRsLm1t CkBAIC04NTYsNiArODU2LDggQEAgdm9pZCBEaXNwbGF5TXRsOjppbml0aWFsaXplRmVhdHVyZXMo KQogICAgIEFOR0xFX0ZFQVRVUkVfQ09ORElUSU9OKCgmbUZlYXR1cmVzKSwgcmV3cml0ZVJvd01h am9yTWF0cmljZXMsIHRydWUpOwogICAgIEFOR0xFX0ZFQVRVUkVfQ09ORElUSU9OKCgmbUZlYXR1 cmVzKSwgZW11bGF0ZVRyYW5zZm9ybUZlZWRiYWNrLCB0cnVlKTsKIAorICAgIEFOR0xFX0ZFQVRV UkVfQ09ORElUSU9OKCgmbUZlYXR1cmVzKSxpbnRlbFRoaW5NaXBtYXBXb3JrYXJvdW5kLCBpc0lu dGVsKCkpOworCiAgICAgYW5nbGU6OlBsYXRmb3JtTWV0aG9kcyAqcGxhdGZvcm0gPSBBTkdMRVBs YXRmb3JtQ3VycmVudCgpOwogICAgIHBsYXRmb3JtLT5vdmVycmlkZUZlYXR1cmVzTXRsKHBsYXRm b3JtLCAmbUZlYXR1cmVzKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1RleHR1cmVNdGwubW0gYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvVGV4dHVyZU10bC5tbQppbmRl eCBmMjVkNjhhZTliNTNmYjNiMTc5NzY3OWM1ZDQwY2Q5MWU4ODk5NjlkLi4zMDBiMDFkMWRiODI5 NzY1YWRlNTAyMWNlMjM0ZTE0NDQxYjk0ZTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvVGV4dHVyZU10bC5tbQorKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvVGV4dHVy ZU10bC5tbQpAQCAtMTExOSw2ICsxMTE5LDkgQEAgYW5nbGU6OlJlc3VsdCBUZXh0dXJlTXRsOjpn ZW5lcmF0ZU1pcG1hcChjb25zdCBnbDo6Q29udGV4dCAqY29udGV4dCkKICAgICAvLwogICAgIGJv b2wgc1JHQiA9IG1Gb3JtYXQuYWN0dWFsSW50ZXJuYWxGb3JtYXQoKS5jb2xvckVuY29kaW5nID09 IEdMX1NSR0I7CiAKKyAgICBib29sIG5lZWRzQ1BVUGF0aCA9IGNvbnRleHRNdGwtPmdldERpc3Bs YXkoKS0+Z2V0RmVhdHVyZXMoKS5pbnRlbFRoaW5NaXBtYXBXb3JrYXJvdW5kLmVuYWJsZWQKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJiYgbU5hdGl2ZVRleHR1cmUtPndpZHRoQXQw KCkgPCA1OworCiAgICAgaWYgKGNhcHMud3JpdGFibGUgJiYgbVN0YXRlLmdldFR5cGUoKSA9PSBn bDo6VGV4dHVyZVR5cGU6Ol8zRCkKICAgICB7CiAgICAgICAgIC8vIGh0dHA6Ly9hbmdsZWJ1Zy5j b20vNDkyMS4KQEAgLTExMjcsNyArMTEzMCw3IEBAIGFuZ2xlOjpSZXN1bHQgVGV4dHVyZU10bDo6 Z2VuZXJhdGVNaXBtYXAoY29uc3QgZ2w6OkNvbnRleHQgKmNvbnRleHQpCiAgICAgICAgIEFOR0xF X1RSWShjb250ZXh0TXRsLT5nZXREaXNwbGF5KCktPmdldFV0aWxzKCkuZ2VuZXJhdGVNaXBtYXBD Uyhjb250ZXh0TXRsLCBtTmF0aXZlVGV4dHVyZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNSR0IsICZtTmF0 aXZlTGV2ZWxWaWV3cykpOwogICAgIH0KLSAgICBlbHNlIGlmIChjYXBzLmZpbHRlcmFibGUgJiYg Y2Fwcy5jb2xvclJlbmRlcmFibGUpCisgICAgZWxzZSBpZiAoIW5lZWRzQ1BVUGF0aCAmJiBjYXBz LmZpbHRlcmFibGUgJiYgY2Fwcy5jb2xvclJlbmRlcmFibGUpCiAgICAgewogICAgICAgICBtdGw6 OkJsaXRDb21tYW5kRW5jb2RlciAqYmxpdEVuY29kZXIgPSBjb250ZXh0TXRsLT5nZXRCbGl0Q29t bWFuZEVuY29kZXIoKTsKICAgICAgICAgYmxpdEVuY29kZXItPmdlbmVyYXRlTWlwbWFwc0ZvclRl eHR1cmUobU5hdGl2ZVRleHR1cmUpOwo=