223764 2021-03-25 14:59:52 -0700 Simplify IPCSemaphore.h 2021-04-06 10:14:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 224014 https://bugs.webkit.org/show_bug.cgi?id=224223 InRadar P2 Normal --- 1 mmaxfield mmaxfield fujii ggaren kkinnunen thorton webkit-bug-importer oldest_to_newest 1743932 0 mmaxfield 2021-03-25 14:59:52 -0700 Simplify IPCSemaphore.h 1743934 1 424285 mmaxfield 2021-03-25 15:00:48 -0700 Created attachment 424285 Patch 1744854 2 424285 ggaren 2021-03-29 13:16:50 -0700 Comment on attachment 424285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424285&action=review > Source/WebKit/Platform/IPC/IPCSemaphore.h:62 > -#if OS(DARWIN) > - explicit Semaphore(MachSendRight&&); > - > void signal(); > void wait(); > void waitFor(Timeout); > + > + explicit operator bool() const; > + > +#if OS(DARWIN) > + explicit Semaphore(MachSendRight&&); Is there a non-Darwin implementation of signal(), wait(), and waitFor()? I don't see one in IPCSemaphore.cpp. 1746284 3 webkit-bug-importer 2021-04-01 15:00:15 -0700 <rdar://problem/76123506> 1747496 4 mmaxfield 2021-04-06 10:14:18 -0700 *** This bug has been marked as a duplicate of bug 224014 *** 424285 2021-03-25 15:00:48 -0700 2021-04-06 10:14:27 -0700 Patch bug-223764-20210325150047.patch text/plain 3135 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyOTRjNmIyZjhiNmIwZjky NGIyNjM4NTc5ZThmZGNlYzY0MWM3ZGUuLmVlMzQwNjIyNGY1ZmFkNTgzMGNiYzM0ZGU2Mzc1OGRl MjM3ZTc1YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDMtMjUgIE15bGVzIEMu IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlmeSBJUENT ZW1hcGhvcmUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIzNzY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU29tZSBvZiB0aGUgZnVuY3Rpb25zIGluc2lkZSBPUyhEQVJXSU4pIGFyZW4ndCBhY3R1YWxs eSBEYXJ3aW4tc3BlY2lmaWMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUg aXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0lQQ1NlbWFw aG9yZS5jcHA6CisgICAgICAgIChJUEM6OlNlbWFwaG9yZTo6b3BlcmF0b3IgYm9vbCBjb25zdCk6 CisgICAgICAgICogUGxhdGZvcm0vSVBDL0lQQ1NlbWFwaG9yZS5oOgorICAgICAgICAoSVBDOjpT ZW1hcGhvcmU6Om9wZXJhdG9yIGJvb2wgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIFBsYXRm b3JtL0lQQy9kYXJ3aW4vSVBDU2VtYXBob3JlRGFyd2luLmNwcDoKKyAgICAgICAgKElQQzo6U2Vt YXBob3JlOjpvcGVyYXRvciBib29sIGNvbnN0KToKKwogMjAyMS0wMy0yNSAgQWRpdHlhIEtlZXJ0 aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRGF0ZSBwaWNrZXIgdmll dyBqdW1wcyB0byBjZW50ZXIgd2hlbiBzd2l0Y2hpbmcgYmV0d2VlbiBNb2JpbGVTYWZhcmkgYW5k IGFub3RoZXIgYXBwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9JUENT ZW1hcGhvcmUuY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvSVBDU2VtYXBob3JlLmNw cAppbmRleCBlNDEyMWE0YmVhOWI3Y2Y0ZTZhZDcyN2U5Zjg0NzcwMWMyMTIzOGRkLi4zODFiOWNl Yjg4NGVmNzA2Mzk5NmVmYTM5YWVmZWFkOWE3ZjA1YTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL0lQQy9JUENTZW1hcGhvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vSVBDL0lQQ1NlbWFwaG9yZS5jcHAKQEAgLTQ1LDYgKzQ1LDExIEBAIE9wdGlvbmFsPFNl bWFwaG9yZT4gU2VtYXBob3JlOjpkZWNvZGUoRGVjb2RlciYpCiAgICAgcmV0dXJuIFNlbWFwaG9y ZSB7IH07CiB9CiAKK1NlbWFwaG9yZTo6b3BlcmF0b3IgYm9vbCgpIGNvbnN0Cit7CisgICAgcmV0 dXJuIHRydWU7Cit9CisKIH0KIAogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtL0lQQy9JUENTZW1hcGhvcmUuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0lQ Q1NlbWFwaG9yZS5oCmluZGV4IDg4M2JiMjZiZTdkYjI4ZTExY2NlMGFlOWI4MzFmOGQxZGYwMWNh NTIuLjlhMjQ2MTI1OTlmMjhjMTNkZTU1NDA1ZmRmMzU5Mzg2M2Y3ZjAzYjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0lQQ1NlbWFwaG9yZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm0vSVBDL0lQQ1NlbWFwaG9yZS5oCkBAIC01MiwyMSArNTIsMjEgQEAgcHVi bGljOgogICAgIHZvaWQgZW5jb2RlKEVuY29kZXImKSBjb25zdDsKICAgICBzdGF0aWMgT3B0aW9u YWw8U2VtYXBob3JlPiBkZWNvZGUoRGVjb2RlciYpOwogCi0jaWYgT1MoREFSV0lOKQotICAgIGV4 cGxpY2l0IFNlbWFwaG9yZShNYWNoU2VuZFJpZ2h0JiYpOwotCiAgICAgdm9pZCBzaWduYWwoKTsK ICAgICB2b2lkIHdhaXQoKTsKICAgICB2b2lkIHdhaXRGb3IoVGltZW91dCk7CisKKyAgICBleHBs aWNpdCBvcGVyYXRvciBib29sKCkgY29uc3Q7CisKKyNpZiBPUyhEQVJXSU4pCisgICAgZXhwbGlj aXQgU2VtYXBob3JlKE1hY2hTZW5kUmlnaHQmJik7CiAgICAgTWFjaFNlbmRSaWdodCBjcmVhdGVT ZW5kUmlnaHQoKSBjb25zdDsKLSAgICBleHBsaWNpdCBvcGVyYXRvciBib29sKCkgY29uc3QgeyBy ZXR1cm4gbV9zZW5kUmlnaHQgfHwgbV9zZW1hcGhvcmUgIT0gU0VNQVBIT1JFX05VTEw7IH0KLSNl bHNlCi0gICAgZXhwbGljaXQgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0K ICNlbmRpZgogCiBwcml2YXRlOgotI2lmIE9TKERBUldJTikKICAgICB2b2lkIGRlc3Ryb3koKTsK KworI2lmIE9TKERBUldJTikKICAgICBNYWNoU2VuZFJpZ2h0IG1fc2VuZFJpZ2h0OwogICAgIHNl bWFwaG9yZV90IG1fc2VtYXBob3JlIHsgU0VNQVBIT1JFX05VTEwgfTsKICNlbmRpZgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvZGFyd2luL0lQQ1NlbWFwaG9yZURhcndp bi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9kYXJ3aW4vSVBDU2VtYXBob3JlRGFy d2luLmNwcAppbmRleCA4YmMyZWJjMjdmY2QwNWI5MTQzZDJiOGYxMWRkZGVhNTRmYjJmZWYyLi4y OTMwMzBiM2M5MDA2ZmY4NmVmMWEwZTRjOWM1OGViNTdjY2I5ZjE0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9kYXJ3aW4vSVBDU2VtYXBob3JlRGFyd2luLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9kYXJ3aW4vSVBDU2VtYXBob3JlRGFyd2luLmNw cApAQCAtMTA0LDYgKzEwNCwxMCBAQCBPcHRpb25hbDxTZW1hcGhvcmU+IFNlbWFwaG9yZTo6ZGVj b2RlKERlY29kZXImIGRlY29kZXIpCiAgICAgcmV0dXJuIE9wdGlvbmFsPFNlbWFwaG9yZT4geyBz dGQ6OmluX3BsYWNlLCBXVEZNb3ZlKHNlbmRSaWdodCkgfTsKIH0KIAorU2VtYXBob3JlOjpvcGVy YXRvciBib29sKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9zZW5kUmlnaHQgfHwgbV9zZW1hcGhv cmUgIT0gU0VNQVBIT1JFX05VTEw7Cit9CiAKIHZvaWQgU2VtYXBob3JlOjpkZXN0cm95KCkKIHsK