223752 2021-03-25 10:33:08 -0700 Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac 2021-03-25 15:46:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney benjamin cdumez cmarcelo ews-watchlist jiewen_tan webkit-bug-importer oldest_to_newest 1743812 0 katherine_cheney 2021-03-25 10:33:08 -0700 Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac 1743813 1 424256 katherine_cheney 2021-03-25 10:33:19 -0700 Created attachment 424256 Patch 1743814 2 katherine_cheney 2021-03-25 10:33:22 -0700 <rdar://problem/75808515> 1743815 3 424256 cdumez 2021-03-25 10:33:48 -0700 Comment on attachment 424256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424256&action=review > Source/WebKit/ChangeLog:3 > + Need a short description (OOPS!). OOPS 1743819 4 424257 katherine_cheney 2021-03-25 10:38:16 -0700 Created attachment 424257 Patch 1743821 5 katherine_cheney 2021-03-25 10:39:24 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 424256 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424256&action=review > > > Source/WebKit/ChangeLog:3 > > + Need a short description (OOPS!). > > OOPS ! 1743830 6 424257 jiewen_tan 2021-03-25 11:02:38 -0700 Comment on attachment 424257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS). 1743831 7 424257 jiewen_tan 2021-03-25 11:03:52 -0700 Comment on attachment 424257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 >> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) > > I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS). In PlatformHave.h. Thanks for fixing this issue. 1743833 8 424261 katherine_cheney 2021-03-25 11:08:13 -0700 Created attachment 424261 Patch 1743834 9 katherine_cheney 2021-03-25 11:08:33 -0700 (In reply to Jiewen Tan from comment #6) > Comment on attachment 424257 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424257&action=review > > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 > > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) > > I think it will be better to modify the conditions of enabling > HAVE_ASC_AUTH_UI to include the PLATFORM(IOS). agreed! New patch posted. 1743845 10 424261 jiewen_tan 2021-03-25 11:25:37 -0700 Comment on attachment 424261 Patch LGTM. r=me. 1743926 11 ews-feeder 2021-03-25 14:49:38 -0700 Committed r275062: <https://commits.webkit.org/r275062> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424261. 424256 2021-03-25 10:33:19 -0700 2021-03-25 10:38:14 -0700 Patch bug-223752-20210325103318.patch text/plain 1848 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjM2JlNDJlZTIzMGZmNDE1 ZWEyNDM2N2M5ZmRiNmFhNjlmOTEwZjYuLjRiYmYxMWQyNzQxNzM1ZDlhMjIxY2VkYzJjNGYxMGI4 NzMwMTU2NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDMtMjUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHNob3J0 IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4K KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1ODA4NTE1PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9u L0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5tbToKKyAgICAgICAgKFdl YktpdDo6QXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yOjpBdXRoZW50aWNhdG9yUHJl c2VudGVyQ29vcmRpbmF0b3IpOgorCiAyMDIxLTAzLTI1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbCBCb29rcyBxdWlya3MgYXJlIGZsYWtpbHkg bm90IGFwcGxpZWQgaW4gbW9kZXJuIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvQXV0aGVudGljYXRvclByZXNlbnRlckNv b3JkaW5hdG9yLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24v Q29jb2EvQXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yLm1tCmluZGV4IGVlNmFhZWU0 MWM1M2QxYzkzYjY0OGMxNGVlYzUxZWRiNTZhNDg1MjguLjY2M2NjZWJmYmEyN2Q0MDI2ZTVhNDky NzVhZmZkZjU2NTMyNjc1M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YkF1dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9B dXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3IubW0KQEAgLTQwLDcgKzQwLDcgQEAgdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CiBBdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3I6 OkF1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvcihjb25zdCBBdXRoZW50aWNhdG9yTWFu YWdlciYgbWFuYWdlciwgY29uc3QgU3RyaW5nJiBycElkLCBjb25zdCBUcmFuc3BvcnRTZXQmIHRy YW5zcG9ydHMsIENsaWVudERhdGFUeXBlIHR5cGUpCiAgICAgOiBtX21hbmFnZXIobWFrZVdlYWtQ dHIobWFuYWdlcikpCiB7Ci0jaWYgSEFWRShBU0NfQVVUSF9VSSkKKyNpZiBIQVZFKEFTQ19BVVRI X1VJKSAmJiBQTEFURk9STShJT1MpCiAgICAgbV9jb250ZXh0ID0gYWRvcHROUyhbYWxsb2NBU0NB dXRob3JpemF0aW9uUHJlc2VudGF0aW9uQ29udGV4dEluc3RhbmNlKCkgaW5pdFdpdGhSZXF1ZXN0 Q29udGV4dDpudWxscHRyIGFwcElkZW50aWZpZXI6bnVsbHB0cl0pOwogICAgIGlmIChbZ2V0QVND QXV0aG9yaXphdGlvblByZXNlbnRhdGlvbkNvbnRleHRDbGFzcygpIGluc3RhbmNlc1Jlc3BvbmRU b1NlbGVjdG9yOkBzZWxlY3RvcihzZXRTZXJ2aWNlTmFtZTopXSkKICAgICAgICAgW21fY29udGV4 dCBzZXRTZXJ2aWNlTmFtZTpycElkXTsK 424257 2021-03-25 10:38:16 -0700 2021-03-25 11:08:10 -0700 Patch bug-223752-20210325103815.patch text/plain 2020 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwNWQzMzQ0Nzg4MDBkYTUz YmYwMGI5MzQ2YmM5MDlkNGQzNTMzOTUuLjRkODFhOTdlNTU1NDM4OTg5NjdiOGI2MDk4N2M3ZDUy YjViNWQ4OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDMtMjUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBjYWxscyBp biBBdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3I6OnNlbGVjdEFzc2VydGlvblJlc3Bv bnNlIGFyZSBub3QgeWV0IGF2YWlsYWJsZSBmb3IgbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM3NTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzc1ODA4NTE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhlbnRpY2F0b3JQcmVz ZW50ZXJDb29yZGluYXRvci5tbToKKyAgICAgICAgKFdlYktpdDo6QXV0aGVudGljYXRvclByZXNl bnRlckNvb3JkaW5hdG9yOjpBdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3IpOgorCiAy MDIxLTAzLTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjI3MjM3Nik6IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6IHNl c3Npb25JRC5pc0VwaGVtZXJhbCgpIHx8ICFwYXRoLmlzRW1wdHkoKSBpbiBXZWJLaXQ6Ok5ldHdv cmtQcm9jZXNzOjpzd1NlcnZlckZvclNlc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJD b29yZGluYXRvci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9u L0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5tbQppbmRleCBlZTZhYWVl NDFjNTNkMWM5M2I2NDhjMTRlZWM1MWVkYjU2YTQ4NTI4Li42NjNjY2ViZmJhMjdkNDAyNmU1YTQ5 Mjc1YWZmZGY1NjUzMjY3NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9BdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3Iu bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2Ev QXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yLm1tCkBAIC00MCw3ICs0MCw3IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogQXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9y OjpBdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3IoY29uc3QgQXV0aGVudGljYXRvck1h bmFnZXImIG1hbmFnZXIsIGNvbnN0IFN0cmluZyYgcnBJZCwgY29uc3QgVHJhbnNwb3J0U2V0JiB0 cmFuc3BvcnRzLCBDbGllbnREYXRhVHlwZSB0eXBlKQogICAgIDogbV9tYW5hZ2VyKG1ha2VXZWFr UHRyKG1hbmFnZXIpKQogewotI2lmIEhBVkUoQVNDX0FVVEhfVUkpCisjaWYgSEFWRShBU0NfQVVU SF9VSSkgJiYgUExBVEZPUk0oSU9TKQogICAgIG1fY29udGV4dCA9IGFkb3B0TlMoW2FsbG9jQVND QXV0aG9yaXphdGlvblByZXNlbnRhdGlvbkNvbnRleHRJbnN0YW5jZSgpIGluaXRXaXRoUmVxdWVz dENvbnRleHQ6bnVsbHB0ciBhcHBJZGVudGlmaWVyOm51bGxwdHJdKTsKICAgICBpZiAoW2dldEFT Q0F1dGhvcml6YXRpb25QcmVzZW50YXRpb25Db250ZXh0Q2xhc3MoKSBpbnN0YW5jZXNSZXNwb25k VG9TZWxlY3RvcjpAc2VsZWN0b3Ioc2V0U2VydmljZU5hbWU6KV0pCiAgICAgICAgIFttX2NvbnRl eHQgc2V0U2VydmljZU5hbWU6cnBJZF07Cg== 424261 2021-03-25 11:08:13 -0700 2021-03-25 15:46:36 -0700 Patch bug-223752-20210325110812.patch text/plain 1242 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYyOTQwZDMxODQ3ZmYxZmIyZGE0M2Rl ZTM1NDJlMTAxZWZlOTE1NzcuLjFmM2QxYTYxZWQ1ZTU0MTlmZGEzOWUwMmQzNjg1ZjAyMDM5OTkw NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDMtMjUgIEthdGUgQ2hlbmV5ICA8a2F0aGVy aW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBjYWxscyBpbiBBdXRoZW50aWNh dG9yUHJlc2VudGVyQ29vcmRpbmF0b3I6OnNlbGVjdEFzc2VydGlvblJlc3BvbnNlIGFyZSBub3Qg eWV0IGF2YWlsYWJsZSBmb3IgbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjM3NTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1ODA4NTE1Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1Bs YXRmb3JtSGF2ZS5oOgorCiAyMDIxLTAzLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgRG8gbm90IGRvIHByb2Nlc3MgcHJlLXdhcm1pbmcgd2hlbiB0aGUgc3lz dGVtIGlzIHVuZGVyIG1lbW9yeSBwcmVzc3VyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv UGxhdGZvcm1IYXZlLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAppbmRleCA1ZmE4 OWFiMDU4MGI4NTBiMDEyZWY5NGQ2YTUzODUzNzdlNjk4NDQ3Li40ODA4NWRlZjNiY2E3NzliNThi MzVjYTcxZGQyYjk3MmQwNzFjNzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bUhhdmUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaApAQCAtODU0LDcgKzg1 NCw3IEBACiAjZGVmaW5lIEhBVkVfTElCWFNMVF9GSVhfRk9SX1JBREFSXzcxODY0MTQwIDEKICNl bmRpZgogCi0jaWYgX19oYXNfaW5jbHVkZSg8QXV0aGVudGljYXRpb25TZXJ2aWNlc0NvcmUvQVND QXV0aG9yaXphdGlvblByZXNlbnRlci5oPikKKyNpZiBfX2hhc19pbmNsdWRlKDxBdXRoZW50aWNh dGlvblNlcnZpY2VzQ29yZS9BU0NBdXRob3JpemF0aW9uUHJlc2VudGVyLmg+KSAmJiBQTEFURk9S TShJT1MpCiAjZGVmaW5lIEhBVkVfQVNDX0FVVEhfVUkgMQogI2VuZGlmCiAK