223725 2021-03-24 19:45:18 -0700 WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally. 2021-03-24 19:54:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist saam webkit-bug-importer oldest_to_newest 1743648 0 mark.lam 2021-03-24 19:45:18 -0700 If the OS does not support the flag, then we should not require it. rdar://75813316 1743649 1 424211 mark.lam 2021-03-24 19:49:13 -0700 Created attachment 424211 proposed patch. 1743651 2 424211 saam 2021-03-24 19:51:00 -0700 Comment on attachment 424211 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424211&action=review > Source/WTF/wtf/WTFConfig.cpp:81 > // FIXME: Remove this when the oldest OS we support simulator on has VM_FLAGS_PERMANENT Please remove this comment too 1743652 3 mark.lam 2021-03-24 19:54:00 -0700 Thanks for the review. Landed in r275003: <http://trac.webkit.org/r275003>. 424211 2021-03-24 19:49:13 -0700 2021-03-24 19:51:00 -0700 proposed patch. bug-223725.patch text/plain 1644 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzUwMDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTI0ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBXVEY6OnNldFBlcm1pc3Npb25zT2ZDb25maWdQYWdlKCkg c2hvdWxkIGFsbG93IGl0cyBWTV9GTEFHU19QRVJNQU5FTlQgd29ya2Fyb3VuZCB1bmNvbmRpdGlv bmFsbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjM3MjUKKyAgICAgICAgcmRhcjovLzc1ODEzMzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIE9TIGRvZXMgbm90IHN1cHBvcnQgdGhlIGZs YWcsIHRoZW4gd2Ugc2hvdWxkIG5vdCByZXF1aXJlIGl0LgorCisgICAgICAgICogd3RmL1dURkNv bmZpZy5jcHA6CisgICAgICAgIChXVEY6OnNldFBlcm1pc3Npb25zT2ZDb25maWdQYWdlKToKKwog MjAyMS0wMy0yNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAg IFVzZSBTdGF0aWNTdHJpbmdJbXBsIGluc3RlYWQgb2YgU3RyaW5nSW1wbDo6Y3JlYXRlU3RhdGlj U3RyaW5nSW1wbCBpZiBpdCBpcyBub3QgZHluYW1pYyBzdHJpbmcgY29udGVudApJbmRleDogU291 cmNlL1dURi93dGYvV1RGQ29uZmlnLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9X VEZDb25maWcuY3BwCShyZXZpc2lvbiAyNzQ5NTcpCisrKyBTb3VyY2UvV1RGL3d0Zi9XVEZDb25m aWcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAo QykgMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMp IDIwMjAtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTc3LDcgKzc3LDcgQEAgdm9pZCBzZXRQZXJtaXNzaW9uc09m Q29uZmlnUGFnZSgpCiAKICAgICAgICAgYXV0byByZXN1bHQgPSBhdHRlbXB0Vk1NYXBwaW5nKCk7 CiAKLSNpZiBIQVZFKFZNX0ZMQUdTX1BFUk1BTkVOVCkgJiYgUExBVEZPUk0oSU9TX0ZBTUlMWV9T SU1VTEFUT1IpCisjaWYgSEFWRShWTV9GTEFHU19QRVJNQU5FTlQpCiAgICAgICAgIC8vIEZJWE1F OiBSZW1vdmUgdGhpcyB3aGVuIHRoZSBvbGRlc3QgT1Mgd2Ugc3VwcG9ydCBzaW11bGF0b3Igb24g aGFzIFZNX0ZMQUdTX1BFUk1BTkVOVAogICAgICAgICBpZiAocmVzdWx0ICE9IEtFUk5fU1VDQ0VT UykgewogICAgICAgICAgICAgZmxhZ3MgJj0gflZNX0ZMQUdTX1BFUk1BTkVOVDsK