223714 2021-03-24 15:09:58 -0700 Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content 2021-03-25 16:23:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo darin ews-watchlist saam webkit-bug-importer oldest_to_newest 1743564 0 ysuzuki 2021-03-24 15:09:58 -0700 Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content 1743566 1 424190 ysuzuki 2021-03-24 15:11:30 -0700 Created attachment 424190 Patch 1743646 2 ysuzuki 2021-03-24 19:31:53 -0700 Committed r275002 (235740@main): <https://commits.webkit.org/235740@main> 1743647 3 webkit-bug-importer 2021-03-24 19:32:16 -0700 <rdar://problem/75818017> 1743969 4 424190 darin 2021-03-25 16:23:48 -0700 Comment on attachment 424190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424190&action=review > Source/WTF/wtf/URL.cpp:858 > +static StaticStringImpl aboutBlankString { "about:blank" }; Why are these outside the functions? > Source/WTF/wtf/URL.cpp:869 > +static StaticStringImpl aboutSrcDocString { "about:srcdoc" }; Ditto. 424190 2021-03-24 15:11:30 -0700 2021-03-24 15:12:58 -0700 Patch bug-223714-20210324151129.patch text/plain 2487 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE0MDJlY2VkOGNiNjRlMDkzZDA4ZDdm ZDQ3OTM5NDZlNDAzNWRjYjguLjMwYjQ2MzhmYTYwNGQyNzg2MGI5ZWM1NDcyMGVjMDk0MTNiMDJh NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDMtMjQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgU3RhdGljU3RyaW5nSW1wbCBpbnN0ZWFkIG9m IFN0cmluZ0ltcGw6OmNyZWF0ZVN0YXRpY1N0cmluZ0ltcGwgaWYgaXQgaXMgbm90IGR5bmFtaWMg c3RyaW5nIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyMzcxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIHNob3VsZCBqdXN0IHVzZSBTdGF0aWNTdHJpbmdJbXBsIGluc3RlYWQgb2YgU3Ry aW5nSW1wbDo6Y3JlYXRlU3RhdGljU3RyaW5nSW1wbCBpZiB0aGUgc3RyaW5nIGNvbnRlbnQgaXMK KyAgICAgICAgbm90IGR5bmFtaWNhbGx5IGFsbG9jYXRlZCBvbmUuIEtlZXAgaW4gbWluZCB0aGF0 IHRoaXMgVVJMIGNvZGUgaXMgc3Ryb25nbHkgYXNzdW1pbmcgdGhhdCBpbnRlcm5hbCBTdHJpbmdJ bXBsCisgICAgICAgIGlzIHN0YXRpYyBzbyB0aGF0IHRoaXMgc3RyaW5nIChhbmQgVVJMKSBjYW4g YmUgdXNlZCBpbiBtdWx0aXBsZSB0aHJlYWRzLiBBbmQgU3RhdGljU3RyaW5nSW1wbCBtZWV0cyB0 aGlzIHJlcXVpcmVtZW50LgorCisgICAgICAgICogd3RmL1VSTC5jcHA6CisgICAgICAgIChXVEY6 OmFib3V0QmxhbmtVUkwpOgorICAgICAgICAoV1RGOjphYm91dFNyY0RvY1VSTCk6CisKIDIwMjEt MDMtMjQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRyZXNz IHVuZGVmaW5lZCBiZWhhdmlvciBmb3VuZCBieSBVQlNhbiBpbiBTdHJpbmdUb0ludGVnZXJDb252 ZXJzaW9uLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1VSTC5jcHAgYi9Tb3VyY2UvV1RG L3d0Zi9VUkwuY3BwCmluZGV4IGNiODMwNzUwYjllOTdkYzc0M2U0NzQyMmVlN2ZjMjIyYjM3Nzc0 MzIuLmJmMmE1MzM3NmM2YTg4MTE4Y2M3ZmQ3ZDIxYzRmY2U0NzUzMDUxNDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1VSTC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvVVJMLmNwcApAQCAt ODU0LDI0ICs4NTQsMjUgQEAgYm9vbCBwcm90b2NvbElzSW5IVFRQRmFtaWx5KFN0cmluZ1ZpZXcg dXJsKQogICAgICAgICAmJiAodXJsWzRdID09ICc6JyB8fCAoaXNBU0NJSUFscGhhQ2FzZWxlc3NF cXVhbCh1cmxbNF0sICdzJykgJiYgbGVuZ3RoID49IDYgJiYgdXJsWzVdID09ICc6JykpOwogfQog CisKK3N0YXRpYyBTdGF0aWNTdHJpbmdJbXBsIGFib3V0QmxhbmtTdHJpbmcgeyAiYWJvdXQ6Ymxh bmsiIH07CiBjb25zdCBVUkwmIGFib3V0QmxhbmtVUkwoKQogewogICAgIHN0YXRpYyBMYXp5TmV2 ZXJEZXN0cm95ZWQ8VVJMPiBzdGF0aWNCbGFua1VSTDsKICAgICBzdGF0aWMgc3RkOjpvbmNlX2Zs YWcgb25jZUZsYWc7CiAgICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFsmXSB7Ci0gICAgICAg IHN0YXRpYyBjb25zdGV4cHIgY29uc3QgY2hhciogYWJvdXRCbGFuayA9ICJhYm91dDpibGFuayI7 Ci0gICAgICAgIHN0YXRpY0JsYW5rVVJMLmNvbnN0cnVjdChVUkwoKSwgU3RyaW5nSW1wbDo6Y3Jl YXRlU3RhdGljU3RyaW5nSW1wbChhYm91dEJsYW5rLCBzdHJsZW4oYWJvdXRCbGFuaykpKTsKKyAg ICAgICAgc3RhdGljQmxhbmtVUkwuY29uc3RydWN0KFVSTCgpLCAmYWJvdXRCbGFua1N0cmluZyk7 CiAgICAgfSk7CiAgICAgcmV0dXJuIHN0YXRpY0JsYW5rVVJMOwogfQogCitzdGF0aWMgU3RhdGlj U3RyaW5nSW1wbCBhYm91dFNyY0RvY1N0cmluZyB7ICJhYm91dDpzcmNkb2MiIH07CiBjb25zdCBV UkwmIGFib3V0U3JjRG9jVVJMKCkKIHsKICAgICBzdGF0aWMgTGF6eU5ldmVyRGVzdHJveWVkPFVS TD4gc3RhdGljU3JjRG9jVVJMOwogICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlRmxhZzsK ICAgICBzdGQ6OmNhbGxfb25jZShvbmNlRmxhZywgWyZdIHsKLSAgICAgICAgc3RhdGljIGNvbnN0 ZXhwciBjb25zdCBjaGFyKiBhYm91dFNyY0RvYyA9ICJhYm91dDpzcmNkb2MiOwotICAgICAgICBz dGF0aWNTcmNEb2NVUkwuY29uc3RydWN0KFVSTCgpLCBTdHJpbmdJbXBsOjpjcmVhdGVTdGF0aWNT dHJpbmdJbXBsKGFib3V0U3JjRG9jLCBzdHJsZW4oYWJvdXRTcmNEb2MpKSk7CisgICAgICAgIHN0 YXRpY1NyY0RvY1VSTC5jb25zdHJ1Y3QoVVJMKCksICZhYm91dFNyY0RvY1N0cmluZyk7CiAgICAg fSk7CiAgICAgcmV0dXJuIHN0YXRpY1NyY0RvY1VSTDsKIH0K