22371 2008-11-19 17:49:45 -0800 Add a test for accessing form element items by index 2008-11-20 15:52:17 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam pam oldest_to_newest 99402 0 pam 2008-11-19 17:49:45 -0800 This applies to things like radio-button options. 99403 1 25296 pam 2008-11-19 18:02:50 -0800 Created attachment 25296 New test + result Simple test, but apparently it wasn't directly covered by any others when we noticed the need. 99476 2 25296 darin 2008-11-20 07:44:30 -0800 Comment on attachment 25296 New test + result Tests like this should be written with the JavaScript test wrapper whenever possible. Also, it's helpful to test more than just the fact that a value is not undefined when testing something like this. For an example, look at something like fast/dom/HTMLFormElement/elements-not-in-document.html -- tests like that one are more valuable. r=me 99509 3 25319 pam 2008-11-20 11:06:39 -0800 Created attachment 25319 Test using the JS test wrapper I'd rather not rewrite all 86 tests to use the wrapper, but only testing against undefined was indeed pretty lame. 99520 4 25319 darin 2008-11-20 11:41:18 -0800 Comment on attachment 25319 Test using the JS test wrapper I wasn't aware there were 86 tests. I guess that's the downside of getting review only after writing all the tests. I try to make the comments promptly so they can be dealt with early. r=me 99526 5 pam 2008-11-20 12:29:11 -0800 (In reply to comment #4) > (From update of attachment 25319 [review]) > I wasn't aware there were 86 tests. That's a quick grep count; call it +/- 10, with resources and such. > I guess that's the downside of getting review only after writing all the tests. > I try to make the comments promptly so they can be dealt with early. Absolutely, and I certainly appreciate your quick and understanding reviews. There are several downsides to trying to submit tests that were written by other people for problems that were fixed long ago, but hopefully having the tests at all is still worthwhile. 99553 6 pam 2008-11-20 15:52:17 -0800 Landed in r38640. 25296 2008-11-19 18:02:50 -0800 2008-11-20 11:06:39 -0800 New test + result 22371a.txt text/plain 1962 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NjA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MTkgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjM3MQorICAgICAgICBBZGQgYSB0ZXN0IGZvciBhY2Nlc3NpbmcgZm9y bSBlbGVtZW50IGl0ZW1zIGJ5IGluZGV4LgorCisgICAgICAgICogZmFzdC9kb20vSFRNTEZvcm1F bGVtZW50L2h0bWxmb3JtZWxlbWVudC1pbmRleGVkLWdldHRlci1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9ybWVsZW1lbnQtaW5k ZXhlZC1nZXR0ZXIuaHRtbDogQWRkZWQuCisKIDIwMDgtMTEtMTkgIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9ybWVsZW1lbnQtaW5kZXhlZC1nZXR0 ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9o dG1sZm9ybWVsZW1lbnQtaW5kZXhlZC1nZXR0ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L2h0bWxmb3JtZWxlbWVudC1pbmRleGVkLWdldHRl ci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0IHZl cmlmaWVzIHRoYXQgZWxlbWVudHMgY2FuIGJlIGZldGNoZWQgYnkgaW5kZXggZnJvbSBIVE1MRm9y bUVsZW1lbnRzLiBZb3Ugc2hvdWxkIHNlZSBhIGxhYmVsZWQgcmFkaW8gYnV0dG9uIGJlbG93LCBm b2xsb3dlZCBieSAiUGFzc2VkLiIKKworSFRNTElucHV0RWxlbWVudAorUGFzc2VkLgpJbmRleDog ZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L2h0bWxmb3JtZWxlbWVudC1pbmRleGVkLWdldHRlci5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9ybWVsZW1l bnQtaW5kZXhlZC1nZXR0ZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL0hUTUxGb3Jt RWxlbWVudC9odG1sZm9ybWVsZW1lbnQtaW5kZXhlZC1nZXR0ZXIuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwyOCBAQAorPGh0bWw+Cis8Ym9keT4KKworPHA+CitUaGlzIHRlc3QgdmVyaWZp ZXMgdGhhdCBlbGVtZW50cyBjYW4gYmUgZmV0Y2hlZCBieSBpbmRleCBmcm9tIEhUTUxGb3JtRWxl bWVudHMuCitZb3Ugc2hvdWxkIHNlZSBhIGxhYmVsZWQgcmFkaW8gYnV0dG9uIGJlbG93LCBmb2xs b3dlZCBieSAiUGFzc2VkLiIKKzwvcD4KKworPGZvcm0gaWQ9J2YnPgorICA8aW5wdXQgdHlwZT0i cmFkaW8iIG5hbWU9ImEiIHZhbHVlPSJhIj5IVE1MSW5wdXRFbGVtZW50PC9pbnB1dD4KKzwvZm9y bT4KKworPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCit2YXIgZiA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdmJyk7CisKK2lmIChmWzBdKSB7CisgIGRvY3VtZW50LndyaXRlKCJQYXNz ZWQuIik7Cit9IGVsc2UgeworICBkb2N1bWVudC53cml0ZSgiRmFpbGVkLiIpOworfQorPC9zY3Jp cHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K 25319 2008-11-20 11:06:39 -0800 2008-11-20 11:41:18 -0800 Test using the JS test wrapper 22371b.txt text/plain 2208 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NjI0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MjAgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzcxCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIGFjY2Vz c2luZyBmb3JtIGVsZW1lbnQgaXRlbXMgYnkgaW5kZXguCisKKyAgICAgICAgKiBmYXN0L2RvbS9I VE1MRm9ybUVsZW1lbnQvaHRtbGZvcm1lbGVtZW50LWluZGV4ZWQtZ2V0dGVyLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L2h0bWxmb3JtZWxl bWVudC1pbmRleGVkLWdldHRlci5odG1sOiBBZGRlZC4KKwogMjAwOC0xMS0yMCAgQ2FtZXJvbiBa d2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYg R2FyZW4uCkluZGV4OiBmYXN0L2RvbS9IVE1MRm9ybUVsZW1lbnQvaHRtbGZvcm1lbGVtZW50LWlu ZGV4ZWQtZ2V0dGVyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2RvbS9IVE1MRm9y bUVsZW1lbnQvaHRtbGZvcm1lbGVtZW50LWluZGV4ZWQtZ2V0dGVyLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9ybWVsZW1lbnQtaW5k ZXhlZC1nZXR0ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitU aGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBlbGVtZW50cyBjYW4gYmUgZmV0Y2hlZCBieSBpbmRleCBm cm9tIEhUTUxGb3JtRWxlbWVudHMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIGZvcm1bMF0gaXMgbXlfaW5wdXQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorSFRNTElucHV0RWxlbWVudApJbmRleDogZmFzdC9kb20vSFRNTEZv cm1FbGVtZW50L2h0bWxmb3JtZWxlbWVudC1pbmRleGVkLWdldHRlci5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9ybWVsZW1lbnQtaW5kZXhlZC1nZXR0 ZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9odG1sZm9y bWVsZW1lbnQtaW5kZXhlZC1nZXR0ZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNCBA QAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMv cmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8Zm9ybSBpZD0n Zic+CisgIDxpbnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0iYSIgdmFsdWU9ImEiIGlkPSJpIj5IVE1M SW5wdXRFbGVtZW50PC9pbnB1dD4KKzwvZm9ybT4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdU aGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBlbGVtZW50cyBjYW4gYmUgZmV0Y2hlZCBieSBpbmRleCBm cm9tIEhUTUxGb3JtRWxlbWVudHMuJyk7CisKK3ZhciBmb3JtID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2YnKTsKK3ZhciBteV9pbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpJyk7 CitzaG91bGRCZSgiZm9ybVswXSIsICJteV9pbnB1dCIpOwordmFyIHN1Y2Nlc3NmdWxseVBhcnNl ZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K