223698 2021-03-24 10:13:48 -0700 Web Inspector: REGRESSION (r269359): Timelines: TypeError:​ this.deselect is not a function 2021-03-24 12:31:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 rcaliman rcaliman bburg ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1743374 0 rcaliman 2021-03-24 10:13:48 -0700 STR: - Open WebInspector > Timelines - Click the "Close" button for any of the sidebar items: Network Requests, Layout & Rendering, JavaScript & Events, CPU 1743375 1 rcaliman 2021-03-24 10:14:39 -0700 Regressed by https://bugs.webkit.org/show_bug.cgi?id=196956 1743377 2 webkit-bug-importer 2021-03-24 10:16:04 -0700 <rdar://problem/75790983> 1743416 3 rcaliman 2021-03-24 11:06:20 -0700 Error log: ``` TypeError:​ this.deselect is not a function. (In 'this.deselect()​', 'this.deselect' is undefined)​ (at TimelineTreeElement.js:​80:​26)​ ?​ @ TimelineTreeElement.js:​80:​26 dispatch @ Object.js:​129:​35 dispatchEventToListeners @ Object.js:​137:​17 _clicked @ TreeElementStatusButton.js:​78:​38 _clicked @ [native code] ``` 1743417 4 424160 rcaliman 2021-03-24 11:07:01 -0700 Created attachment 424160 Patch 1743438 5 424160 bburg 2021-03-24 11:44:46 -0700 Comment on attachment 424160 Patch r=me 1743475 6 ews-feeder 2021-03-24 12:31:26 -0700 Committed r274960: <https://commits.webkit.org/r274960> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424160. 424160 2021-03-24 11:07:01 -0700 2021-03-24 12:31:27 -0700 Patch bug-223698-20210324190700.patch text/plain 1729 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZiZTJkODE2ZGQ1OTlkNDQ1MDYxM2UzMTJiOGU3 ZDEyOTIyY2Q1NDQuLmQ0NTExZmM0ZDA5MTQ0NWU2ZDk2ODYxNjVmN2I1M2VjYWFmNTc5ZTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTI0ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSRUdSRVNTSU9OIChyMjY5MzU5KTogVGltZWxpbmVzOiBUeXBlRXJyb3I6IHRoaXMuZGVzZWxl Y3QgaXMgbm90IGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMzY5OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzU3OTA5ODM+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIGlu ZGl2aWR1YWwgdGltZWxpbmUgdmlld3MgY2FuIGJlIGNsb3NlZCB0byByZXR1cm4gdG8gdGhlIFRp bWVsaW5lcyBvdmVydmlldy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdJLlRpbWVsaW5lVHJlZUVsZW1lbnQucHJvdG90 eXBlLl9zaG93Q2xvc2VCdXR0b24pOgorCiAyMDIxLTAzLTE5ICBCSiBCdXJnICA8YmJ1cmdAYXBw bGUuY29tPgogCiAgICAgICAgIFVuY2F1Z2h0IEV4Y2VwdGlvbjogUmFuZ2VFcnJvcjogQXJyYXkg c2l6ZSBpcyBub3QgYSBzbWFsbCBlbm91Z2ggcG9zaXRpdmUgaW50ZWdlci4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVHJlZUVs ZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVRyZWVFbGVtZW50LmpzCmluZGV4IGQ1ODhjMTIyZTcyYmRjY2IyMDBmZmJhNjU3ZjYxZjJh YTk4NDI2NzguLjViMTkxZjY3ZDNmY2ZlM2IyNDgyODIyMGI0OTA2MjQ5MGM3YWViODEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5l VHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVUcmVlRWxlbWVudC5qcwpAQCAtNzgsNyArNzgsNyBAQCBXSS5UaW1lbGlu ZVRyZWVFbGVtZW50ID0gY2xhc3MgVGltZWxpbmVUcmVlRWxlbWVudCBleHRlbmRzIFdJLkdlbmVy YWxUcmVlRWxlbWVudAogICAgICAgICBsZXQgYnV0dG9uID0gbmV3IFdJLlRyZWVFbGVtZW50U3Rh dHVzQnV0dG9uKFdJLkltYWdlVXRpbGl0aWVzLnVzZVNWR1N5bWJvbCgiSW1hZ2VzL0Nsb3NlTGFy Z2Uuc3ZnIiwgImNsb3NlLWJ1dHRvbiIsIHRvb2x0aXApKTsKICAgICAgICAgYnV0dG9uLmFkZEV2 ZW50TGlzdGVuZXIoV0kuVHJlZUVsZW1lbnRTdGF0dXNCdXR0b24uRXZlbnQuQ2xpY2tlZCwgZnVu Y3Rpb24oZXZlbnQpIHsKICAgICAgICAgICAgIHRoaXMuZGVzZWxlY3QoKTsKLSAgICAgICAgfSwg YnV0dG9uKTsKKyAgICAgICAgfSwgdGhpcyk7CiAgICAgICAgIHRoaXMuc3RhdHVzID0gYnV0dG9u LmVsZW1lbnQ7CiAgICAgfQogCg==