223696 2021-03-24 09:46:44 -0700 Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member call on null pointer of type 'WebCore::ArchiveResource' 2021-03-26 15:42:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176131 InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ews-watchlist ggaren mifenton sam webkit-bug-importer oldest_to_newest 1743357 0 cdumez 2021-03-24 09:46:44 -0700 Address the following bug found by UBSan: Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member call on null pointer of type 'WebCore::ArchiveResource' 1743359 1 424145 cdumez 2021-03-24 09:53:40 -0700 Created attachment 424145 Patch 1743847 2 cdumez 2021-03-25 11:30:21 -0700 Patch is ready to review. 1744313 3 424145 achristensen 2021-03-26 13:40:28 -0700 Comment on attachment 424145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424145&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:-1278 > - const String& mimeType = resource->mimeType(); basically just null checking resource here. 1744316 4 ews-feeder 2021-03-26 13:44:34 -0700 commit-queue failed to commit attachment 424145 to WebKit repository. To retry, please set cq+ flag again. 1744353 5 ews-feeder 2021-03-26 15:41:43 -0700 Committed r275118: <https://commits.webkit.org/r275118> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424145. 1744354 6 webkit-bug-importer 2021-03-26 15:42:13 -0700 <rdar://problem/75904798> 424145 2021-03-24 09:53:40 -0700 2021-03-26 15:41:45 -0700 Patch bug-223696-20210324095339.patch text/plain 2685 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQwMWQ3MzZiZWY2M2M5 YzNlODQ1N2E3ZjdiNDliMDA5OTBjZjNhMS4uODQ2OTUxNWFhMDRhYTQ5NmRiN2E5OGJkNjk0Mjgw MTQ2MDBjYThlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAzLTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tOjEyNzg6NDQ6IHJ1bnRpbWUgZXJyb3I6IG1lbWJl ciBjYWxsIG9uIG51bGwgcG9pbnRlciBvZiB0eXBlICdXZWJDb3JlOjpBcmNoaXZlUmVzb3VyY2Un CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM2OTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVn IGZvdW5kIGJ5IFVCU2FuLgorCisgICAgICAgICogZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVy Lm1tOgorICAgICAgICAoSFRNTENvbnZlcnRlcjo6X2FkZEF0dGFjaG1lbnRGb3JFbGVtZW50KToK KyAgICAgICAgLSBEcm9wIGR1cGxpY2F0ZSBjYWxsIHRvIGRhdGFTb3VyY2UtPnN1YnJlc291cmNl KHVybCkgYXMgaXQgZG9lc24ndCBzZWVtIGl0IGNhbiByZXR1cm4gc29tZXRoaW5nIGVsc2UKKyAg ICAgICAgICB0aGFuIG51bGwgaWYgaXQgcmV0dXJuZWQgbnVsbCB0aGUgZmlyc3QgdGltZSBhcm91 bmQuCisgICAgICAgIC0gTWFrZSBzdXJlIHJlc291cmNlIGlzIG51bGwtY2hlY2tlZCBiZWZvcmUg d2UgZGVyZWZlcmVuY2UgaXQgdG8gZ2V0IHRoZSBNSU1FIHR5cGUuCisKIDIwMjEtMDMtMjQgIEFu dG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3VwcG9ydCBhbmlt YXRpb24gb2YgdGhlIHRhYi1zaXplIENTUyBwcm9wZXJ0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tCmluZGV4IDhjYWZhN2MzNmU2ZGQ2MDUwOTI3N2Rl MGFjZmQyYzAzMTU2OGQwYzIuLjA2ODI2ZjEyNDE4N2JkYmQ0ZjFhNDljNDM3MGVjNmVmNGQwZDhl ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvSFRNTENvbnZlcnRl ci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIubW0K QEAgLTEyNzEsMTYgKzEyNzEsMTMgQEAgQk9PTCBIVE1MQ29udmVydGVyOjpfYWRkQXR0YWNobWVu dEZvckVsZW1lbnQoRWxlbWVudCYgZWxlbWVudCwgTlNVUkwgKnVybCwgQk9PTAogICAgICAgICAg ICAgZmlsZVdyYXBwZXIgPSBhZG9wdE5TKFtbTlNGaWxlV3JhcHBlciBhbGxvY10gaW5pdFdpdGhV Ukw6dXJsIG9wdGlvbnM6MCBlcnJvcjpOVUxMXSk7CiAgICAgfQogICAgIGlmICghZmlsZVdyYXBw ZXIgJiYgZGF0YVNvdXJjZSkgewotICAgICAgICBSZWZQdHI8QXJjaGl2ZVJlc291cmNlPiByZXNv dXJjZSA9IGRhdGFTb3VyY2UtPnN1YnJlc291cmNlKHVybCk7Ci0gICAgICAgIGlmICghcmVzb3Vy Y2UpCi0gICAgICAgICAgICByZXNvdXJjZSA9IGRhdGFTb3VyY2UtPnN1YnJlc291cmNlKHVybCk7 Ci0KLSAgICAgICAgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSA9IHJlc291cmNlLT5taW1lVHlwZSgp OwotICAgICAgICBpZiAodXNlUGxhY2Vob2xkZXIgJiYgcmVzb3VyY2UgJiYgbWltZVR5cGUgPT0g InRleHQvaHRtbCIpCi0gICAgICAgICAgICBub3RGb3VuZCA9IFlFUzsKLSAgICAgICAgaWYgKHJl c291cmNlICYmICFub3RGb3VuZCkgewotICAgICAgICAgICAgZmlsZVdyYXBwZXIgPSBhZG9wdE5T KFtbTlNGaWxlV3JhcHBlciBhbGxvY10gaW5pdFJlZ3VsYXJGaWxlV2l0aENvbnRlbnRzOnJlc291 cmNlLT5kYXRhKCkuY3JlYXRlTlNEYXRhKCkuZ2V0KCldKTsKLSAgICAgICAgICAgIFtmaWxlV3Jh cHBlciBzZXRQcmVmZXJyZWRGaWxlbmFtZTpzdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZSh1 cmwsIG1pbWVUeXBlKV07CisgICAgICAgIGlmIChhdXRvIHJlc291cmNlID0gZGF0YVNvdXJjZS0+ c3VicmVzb3VyY2UodXJsKSkgeworICAgICAgICAgICAgYXV0byYgbWltZVR5cGUgPSByZXNvdXJj ZS0+bWltZVR5cGUoKTsKKyAgICAgICAgICAgIGlmICghdXNlUGxhY2Vob2xkZXIgfHwgbWltZVR5 cGUgIT0gInRleHQvaHRtbCIpIHsKKyAgICAgICAgICAgICAgICBmaWxlV3JhcHBlciA9IGFkb3B0 TlMoW1tOU0ZpbGVXcmFwcGVyIGFsbG9jXSBpbml0UmVndWxhckZpbGVXaXRoQ29udGVudHM6cmVz b3VyY2UtPmRhdGEoKS5jcmVhdGVOU0RhdGEoKS5nZXQoKV0pOworICAgICAgICAgICAgICAgIFtm aWxlV3JhcHBlciBzZXRQcmVmZXJyZWRGaWxlbmFtZTpzdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1F VHlwZSh1cmwsIG1pbWVUeXBlKV07CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAg ICBub3RGb3VuZCA9IFlFUzsKICAgICAgICAgfQogICAgIH0KICNpZiAhUExBVEZPUk0oSU9TX0ZB TUlMWSkK