223686 2021-03-24 04:08:51 -0700 git-webkit find doesn't work well with unicode characters in author name 2021-04-09 14:56:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain ap jbedard ryanhaddad webkit-bug-importer zhifei_fang oldest_to_newest 1743269 0 aakash_jain 2021-03-24 04:08:51 -0700 git-webkit find doesn't work well with unicode characters in author name https://build.webkit.org/#/builders/28/builds/566 python Tools/Scripts/git-webkit find r274645 Title: Nullptr crash in RenderStyle::shapeOutside() Traceback (most recent call last): File "Tools/Scripts/git-webkit", line 49, in <module> subversion='https://svn.webkit.org/repository/webkit', File "/Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 84, in main subversion=subversion, File "/Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py", line 118, in main return Info.main(args, repository=repository, reference=args.argument[0], **kwargs) File "/Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py", line 87, in main print(u'Author: {}'.format(commit.author)) UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 10: ordinal not in range(128) 1743270 1 aakash_jain 2021-03-24 04:09:18 -0700 Author name which git-webkit couldn't handle properly was: Frédéric Wang 1743271 2 aakash_jain 2021-03-24 04:11:42 -0700 Steps to reproduce (on python 2): >>> u'Author: {}'.format('Fréd') Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2: ordinal not in range(128) 1743917 3 jbedard 2021-03-25 14:26:37 -0700 I can't reproduce this problem on trunk: python Tools/Scripts/git-webkit find r274645 Title: Nullptr crash in RenderStyle::shapeOutside() Author: Frédéric Wang <fred.wang@free.fr> Date: Thu Mar 18 07:44:01 2021 Revision: 274645 Identifier: 235470@trunk The issue is that there aren't any commits in the last week that could have fixed this problem 1745577 4 webkit-bug-importer 2021-03-31 04:09:12 -0700 <rdar://problem/76047116> 1747875 5 aakash_jain 2021-04-07 07:30:03 -0700 This issue still happening, probably for every commit by authors containing non-ascii characters in their name. e.g.: https://ews-build.webkit.org/#/builders/8/builds/49976 https://ews-build.webkit.org/#/builders/9/builds/44389 https://ews-build.webkit.org/#/builders/36/builds/32660 https://ews-build.webkit.org/#/builders/47/builds/13126 https://ews-build.webkit.org/#/builders/48/builds/13220 https://ews-build.webkit.org/#/builders/49/builds/12750 https://ews-build.webkit.org/#/builders/50/builds/12986 https://ews-build.webkit.org/#/builders/51/builds/10740 https://ews-build.webkit.org/#/builders/52/builds/12394 https://ews-build.webkit.org/#/builders/53/builds/12048 https://ews-build.webkit.org/#/builders/55/builds/6174 https://ews-build.webkit.org/#/builders/58/builds/6215 https://ews-build.webkit.org/#/builders/59/builds/5290 https://ews-build.webkit.org/#/builders/61/builds/1718 https://ews-build.webkit.org/#/builders/61/builds/1717 UnicodeEncodeError: 'ascii' codec can't encode character u'\xf1' in position 19: ordinal not in range(128) These builds were for r275596 by 'Enrique Ocaña González' 1747879 6 425391 aakash_jain 2021-04-07 07:50:46 -0700 Created attachment 425391 Patch 1747880 7 jbedard 2021-04-07 07:52:27 -0700 Confused by my inability to reproduce, but a ? Seems better than blowing up. 1747923 8 ap 2021-04-07 09:39:34 -0700 Is there a plan for how to fix it for good, so that names are visible? 1747949 9 aakash_jain 2021-04-07 10:13:55 -0700 (In reply to Jonathan Bedard from comment #7) > Confused by my inability to reproduce, but a ? Seems better than blowing up. I am also unable to reproduce this. This works fine with the problematic commit on my local machine. I even tried on an ews machine which indicated this failure, and I wasn't able to reproduce. 1747951 10 aakash_jain 2021-04-07 10:17:41 -0700 (In reply to Alexey Proskuryakov from comment #8) > Is there a plan for how to fix it for good, so that names are visible? This issue doesn't happen on Python 3. Also, we are not able to reproduce, so seems like some corner case which fails only in buildbot (and in buildbot we anyways hide this build-step, and only show the commit-identifier). So, people aren't likely to hit this problem on their machines. Automation doesn't show the author name anyways. We can prioritize the real fix if we notice this problem anywhere else, where it has any visible impact. 1747956 11 ews-feeder 2021-04-07 10:26:09 -0700 Committed r275612 (236257@main): <https://commits.webkit.org/236257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425391. 1747967 12 ap 2021-04-07 10:48:47 -0700 If no one is going to see this, it's better to say something like "cannot print the name, please file a bug if seeing this locally", not just "?". 1747974 13 aakash_jain 2021-04-07 11:03:29 -0700 Reopening to attach another patch. 1747976 14 425420 aakash_jain 2021-04-07 11:05:48 -0700 Created attachment 425420 [fast-cq] Follow-up Patch 1748875 15 ews-feeder 2021-04-09 14:56:14 -0700 Committed r275778 (236351@main): <https://commits.webkit.org/236351@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425420. 425391 2021-04-07 07:50:46 -0700 2021-04-09 08:01:59 -0700 Patch bug-223686-20210407105045.patch text/plain 1646 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTYwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTA0LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBnaXQtd2Via2l0IGZpbmQgZG9lc24ndCB3b3JrIHdlbGwgd2l0aCB1bmlj b2RlIGNoYXJhY3RlcnMgaW4gYXV0aG9yIG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzY4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Vi a2l0c2NtcHkvcHJvZ3JhbS9maW5kLnB5OgorICAgICAgICAoSW5mby5tYWluKTogQWRkZWQgYSB0 cnkgZXhjZXB0IGJsb2NrIHdoaWxlIHByaW50aW5nIGF1dGhvciwgc2luY2UgdGhlIHNjcmlwdCBz aG91bGQgc3RpbGwgcHJpbnQgcmVzdCBvZiB0aGUgaW5mby4KKwogMjAyMS0wNC0wNyAgSm9uYXRo YW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjc0 MzY2KTogd2Via2l0c2NtcHkudGVzdC5zdm5fdW5pdHRlc3QuVGVzdFJlbW90ZVN2bi50ZXN0X2lu Zm8gZmFpbHMgaW4gbm9uLVBEVCB0aW1lem9uZXMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFt L2ZpbmQucHkJKHJldmlzaW9uIDI3NTYwNSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weQkod29ya2luZyBjb3B5KQpAQCAt ODQsNyArODQsMTAgQEAgY2xhc3MgSW5mbyhDb21tYW5kKToKIAogICAgICAgICBpZiBjb21taXQu bWVzc2FnZToKICAgICAgICAgICAgIHByaW50KHUnVGl0bGU6IHt9Jy5mb3JtYXQoY29tbWl0Lm1l c3NhZ2Uuc3BsaXRsaW5lcygpWzBdKSkKLSAgICAgICAgcHJpbnQodSdBdXRob3I6IHt9Jy5mb3Jt YXQoY29tbWl0LmF1dGhvcikpCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHByaW50KHUnQXV0 aG9yOiB7fScuZm9ybWF0KGNvbW1pdC5hdXRob3IpKQorICAgICAgICBleGNlcHQgKFVuaWNvZGVF bmNvZGVFcnJvciwgVW5pY29kZURlY29kZUVycm9yKToKKyAgICAgICAgICAgIHByaW50KCdBdXRo b3I6ID8nKQogICAgICAgICBwcmludChkYXRldGltZS5mcm9tdGltZXN0YW1wKGNvbW1pdC50aW1l c3RhbXApLnN0cmZ0aW1lKCdEYXRlOiAlYSAlYiAlZCAlSDolTTolUyAlWScpKQogICAgICAgICBp ZiBhcmdzLnZlcmJvc2UgPiAwIG9yIGNvbW1pdC5yZXZpc2lvbjoKICAgICAgICAgICAgIHByaW50 KCdSZXZpc2lvbjoge30nLmZvcm1hdChjb21taXQucmV2aXNpb24gb3IgJ04vQScpKQo= 425420 2021-04-07 11:05:48 -0700 2021-04-09 14:56:15 -0700 [fast-cq] Follow-up Patch bug-223686-20210407140547.patch text/plain 1497 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTYxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTA0LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBnaXQtd2Via2l0IGZpbmQgZG9lc24ndCB3b3JrIHdlbGwgd2l0aCB1bmlj b2RlIGNoYXJhY3RlcnMgaW4gYXV0aG9yIG5hbWUgKGZvbGxvdy11cCBmaXgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM2ODYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVz L3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weToKKyAgICAgICAgKEluZm8u bWFpbik6IFVwZGF0ZWQgdGhlIGVycm9yIG1lc3NhZ2UuCisKIDIwMjEtMDQtMDcgIEpvbmF0aGFu IEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtidWlsZC53ZWJraXQub3Jn XSBDb21taXQgcXVldWUgc2hvdWxkIHBvc3QgdGhlIGlkZW50aWZpZXIKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS9wcm9ncmFtL2ZpbmQucHkJKHJldmlzaW9uIDI3NTYxMykKKysrIFRvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vZmluZC5weQkod29ya2lu ZyBjb3B5KQpAQCAtODcsNyArODcsNyBAQCBjbGFzcyBJbmZvKENvbW1hbmQpOgogICAgICAgICB0 cnk6CiAgICAgICAgICAgICBwcmludCh1J0F1dGhvcjoge30nLmZvcm1hdChjb21taXQuYXV0aG9y KSkKICAgICAgICAgZXhjZXB0IChVbmljb2RlRW5jb2RlRXJyb3IsIFVuaWNvZGVEZWNvZGVFcnJv cik6Ci0gICAgICAgICAgICBwcmludCgnQXV0aG9yOiA/JykKKyAgICAgICAgICAgIHByaW50KCdF cnJvcjogVW5hYmxlIHRvICBwcmludCBjb21taXQgYXV0aG9yIG5hbWUsIHBsZWFzZSBmaWxlIGEg YnVnIGlmIHNlZWluZyB0aGlzIGxvY2FsbHkuJykKICAgICAgICAgcHJpbnQoZGF0ZXRpbWUuZnJv bXRpbWVzdGFtcChjb21taXQudGltZXN0YW1wKS5zdHJmdGltZSgnRGF0ZTogJWEgJWIgJWQgJUg6 JU06JVMgJVknKSkKICAgICAgICAgaWYgYXJncy52ZXJib3NlID4gMCBvciBjb21taXQucmV2aXNp b246CiAgICAgICAgICAgICBwcmludCgnUmV2aXNpb246IHt9Jy5mb3JtYXQoY29tbWl0LnJldmlz aW9uIG9yICdOL0EnKSkK