223684 2021-03-24 02:43:16 -0700 [WPE] Build error in ARMv7 invalid 'static_cast' for GLNativeWindowType 2021-03-24 04:02:19 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223577 P2 Normal --- 1 psaavedra psaavedra alex aperez bugs-noreply cgarcia cmarcelo ews-watchlist gyuyoung.kim luiz pnormand ryuan.choi sergio simon.fraser zeno oldest_to_newest 1743242 0 psaavedra 2021-03-24 02:43:16 -0700 I'm getting the a similar issue building wpewebkit (main) for ARMv7 than the one reported in https://bugs.webkit.org/show_bug.cgi?id=223577#c2: ``` /home/bot/yocto-rpi3-manual/builds/raspberrypi3-mesa-wpe-nightly/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/trunk+gitAUTOINC+e90a458604-r0/git/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:93:23: error: invalid 'static_cast' from type 'uintptr_t' {aka 'unsigned int'} to type 'GLNativeWindowType' {aka 'void*'} ``` GLNativeWindowType is defined in Source/WebCore/platform/graphics/GLContext.h like this: ``` #if USE(EGL) && !PLATFORM(GTK) #if PLATFORM(WPE) // FIXME: For now default to the GBM EGL platform, but this should really be // somehow deducible from the build configuration. #define __GBM__ 1 #endif // PLATFORM(WPE) #include <EGL/eglplatform.h> typedef EGLNativeWindowType GLNativeWindowType; #else // !USE(EGL) || PLATFORM(GTK) typedef uint64_t GLNativeWindowType; #endif ``` From https://bug-178090-attachments.webkit.org/attachment.cgi?id=323356: + EGLNativeWindowType can be aliased to a different type depending (at least) on the EGL + implementation, its build options, and the libepoxy build options. Using "static_cast" + works when it is a numeric value and the width of the value needs to be optionally + extended to 64 bits (e.g. the EGL type is "int" in a 32-bit CPU) but not for pointers, + and using "reinterpret_cast" works when the size of a pointer is 64 bits but not in other + cases. Therefore it seems reasonable to use a plain C cast expression to solve this + particular situation. ... + // EGLNativeWindowType changes depending on the EGL implementation: reinterpret_cast works + // for pointers (only if they are 64-bit wide and not for other cases), and static_cast for + // numeric types (and when needed they get extended to 64-bit) but not for pointers. Using + // a plain C cast expression in this one instance works in all cases. + static_assert(sizeof(EGLNativeWindowType) <= sizeof(uint64_t), "EGLNativeWindowType must not be longer than 64 bits."); + return (uint64_t) wpe_renderer_backend_egl_target_get_native_window(m_backend); The build has not problems by replicating the solution from 178090: ``` diff --git a/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp b/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp index f56cb9ce80f9..92d2f8476355 100644 --- a/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp +++ b/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp @@ -90,7 +90,8 @@ void ThreadedCompositor::createGLContext() auto windowType = reinterpret_cast<GLNativeWindowType>(m_nativeSurfaceHandle); #else // On 32-bit platforms GLNativeWindowType is an integer type, which cannot be casted with reinterpret_cast. - auto windowType = static_cast<GLNativeWindowType>(m_nativeSurfaceHandle); + static_assert(sizeof(GLNativeWindowType) <= sizeof(uint64_t), "GLNativeWindowType must not be longer than 64 bits."); + auto windowType = (GLNativeWindowType) m_nativeSurfaceHandle; #endif m_context = GLContext::createContextForWindow(windowType, &PlatformDisplay::sharedDisplayForCompositing()); if (m_context) ``` 1743246 1 424116 psaavedra 2021-03-24 02:46:18 -0700 Created attachment 424116 patch 1743252 2 424117 psaavedra 2021-03-24 03:04:42 -0700 Created attachment 424117 patch 1743268 3 ews-feeder 2021-03-24 04:02:15 -0700 Committed r274937: <https://commits.webkit.org/r274937> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424117. 424116 2021-03-24 02:46:18 -0700 2021-03-24 03:04:25 -0700 patch bug-223684-20210324104616.patch text/plain 1862 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgwY2EzNWQ2ZThiZmUzZmZh MWEwZjNmNDYyNGRjMjA2Zjk0YWM0Y2MuLjI3OTc5Y2VhNTU4ZmRlMzNiM2FkZWU3NWMzYTVmNWMy ZDlkZGUwMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDMtMjQgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZXJy b3IgaW4gQVJNdjcgaW52YWxpZCAnc3RhdGljX2Nhc3QnIGZvciBHTE5hdGl2ZVdpbmRvd1R5cGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzY4NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVk L0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVkQ29tcG9zaXRv ci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRocmVhZGVkQ29tcG9zaXRvcjo6Y3JlYXRlR0xDb250 ZXh0KToKKwogMjAyMS0wMy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgRGlzcGxheVJlZnJlc2hNb25pdG9yRmFjdG9yeS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21w b3NpdG9yL1RocmVhZGVkQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29y ZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3Bw CmluZGV4IGY1NmNiOWNlODBmOTk1NzY1N2NmMWUxYWE2MDNkNjJhMzc1ZjZjODAuLjkyZDJmODQ3 NjM1NWZlYzg5Mjc1M2QwYWQ0ZTIzOWIzZmYyMmMwYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVk Q29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFw aGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcApAQCAtOTAsNyAr OTAsOCBAQCB2b2lkIFRocmVhZGVkQ29tcG9zaXRvcjo6Y3JlYXRlR0xDb250ZXh0KCkKICAgICBh dXRvIHdpbmRvd1R5cGUgPSByZWludGVycHJldF9jYXN0PEdMTmF0aXZlV2luZG93VHlwZT4obV9u YXRpdmVTdXJmYWNlSGFuZGxlKTsKICNlbHNlCiAgICAgLy8gT24gMzItYml0IHBsYXRmb3JtcyBH TE5hdGl2ZVdpbmRvd1R5cGUgaXMgYW4gaW50ZWdlciB0eXBlLCB3aGljaCBjYW5ub3QgYmUgY2Fz dGVkIHdpdGggcmVpbnRlcnByZXRfY2FzdC4KLSAgICBhdXRvIHdpbmRvd1R5cGUgPSBzdGF0aWNf Y2FzdDxHTE5hdGl2ZVdpbmRvd1R5cGU+KG1fbmF0aXZlU3VyZmFjZUhhbmRsZSk7CisgICAgc3Rh dGljX2Fzc2VydChzaXplb2YoR0xOYXRpdmVXaW5kb3dUeXBlKSA8PSBzaXplb2YodWludDY0X3Qp LCAiR0xOYXRpdmVXaW5kb3dUeXBlIG11c3Qgbm90IGJlIGxvbmdlciB0aGFuIDY0IGJpdHMuIik7 CisgICAgYXV0byB3aW5kb3dUeXBlID0gKEdMTmF0aXZlV2luZG93VHlwZSkgbV9uYXRpdmVTdXJm YWNlSGFuZGxlOwogI2VuZGlmCiAgICAgbV9jb250ZXh0ID0gR0xDb250ZXh0OjpjcmVhdGVDb250 ZXh0Rm9yV2luZG93KHdpbmRvd1R5cGUsICZQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXlG b3JDb21wb3NpdGluZygpKTsKICAgICBpZiAobV9jb250ZXh0KQo= 424117 2021-03-24 03:04:42 -0700 2021-03-24 04:02:17 -0700 patch bug-223684-20210324110441.patch text/plain 3356 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgwY2EzNWQ2ZThiZmUzZmZh MWEwZjNmNDYyNGRjMjA2Zjk0YWM0Y2MuLjlkZjg0NzBmY2Q4ZTAxNDhiMDU0MDlkY2UwODQzOWNl M2U0NDBjY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzIgQEAKKzIwMjEtMDMtMjQgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZXJy b3IgaW4gQVJNdjcgaW52YWxpZCAnc3RhdGljX2Nhc3QnIGZvciBHTE5hdGl2ZVdpbmRvd1R5cGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzY4NAor CisgICAgICAgIEZpeGVzIHRoaXMgZXJyb3I6CisKKyAgICAgICAgICBlcnJvcjogaW52YWxpZCAn c3RhdGljX2Nhc3QnIGZyb20gdHlwZSAndWludHB0cl90JyB7YWthICd1bnNpZ25lZAorICAgICAg ICAgIGludCd9IHRvIHR5cGUgJ0dMTmF0aXZlV2luZG93VHlwZScge2FrYSAndm9pZConfQorCisg ICAgICAgIDsgYW4gaW52YWxpZCAnc3RhdGljX2Nhc3QnIGZyb20gdHlwZSBlcnJvciBmb3IgQVJN djcgKHJwaTMgYW5kIG1lc2EgZHJpdmVyKQorICAgICAgICBieSB1c2luZyB0aGUgc2FtZSBzb2x1 dGlvbiBjaG9zZW4gaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3OTUxMToKKworICAgICAgICAgIEVHTE5hdGl2ZVdpbmRvd1R5cGUgY2FuIGJlIGFs aWFzZWQgdG8gYSBkaWZmZXJlbnQgdHlwZSBkZXBlbmRpbmcgKGF0IGxlYXN0KSBvbiB0aGUgRUdM CisgICAgICAgICAgaW1wbGVtZW50YXRpb24sIGl0cyBidWlsZCBvcHRpb25zLCBhbmQgdGhlIGxp YmVwb3h5IGJ1aWxkIG9wdGlvbnMuICBVc2luZyAic3RhdGljX2Nhc3QiCisgICAgICAgICAgd29y a3Mgd2hlbiBpdCBpcyBhIG51bWVyaWMgdmFsdWUgYW5kIHRoZSB3aWR0aCBvZiB0aGUgdmFsdWUg bmVlZHMgdG8gYmUgb3B0aW9uYWxseQorICAgICAgICAgIGV4dGVuZGVkIHRvIDY0IGJpdHMgKGUu Zy4gdGhlIEVHTCB0eXBlIGlzICJpbnQiIGluIGEgMzItYml0IENQVSkgYnV0IG5vdCBmb3IgcG9p bnRlcnMsCisgICAgICAgICAgYW5kIHVzaW5nICJyZWludGVycHJldF9jYXN0IiB3b3JrcyB3aGVu IHRoZSBzaXplIG9mIGEgcG9pbnRlciBpcyA2NCBiaXRzIGJ1dCBub3QgaW4gb3RoZXIKKyAgICAg ICAgICBjYXNlcy4gVGhlcmVmb3JlIGl0IHNlZW1zIHJlYXNvbmFibGUgdG8gdXNlIGEgcGxhaW4g QyBjYXN0IGV4cHJlc3Npb24gdG8gc29sdmUgdGhpcworICAgICAgICAgIHBhcnRpY3VsYXIgc2l0 dWF0aW9uLgorCisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNzQ4 Njkvd2Via2l0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFk ZWRDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGhyZWFkZWRDb21wb3NpdG9yOjpj cmVhdGVHTENvbnRleHQpOgorCiAyMDIxLTAzLTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JGYWN0b3J5 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90 aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVkQ29t cG9zaXRvci5jcHAKaW5kZXggZjU2Y2I5Y2U4MGY5OTU3NjU3Y2YxZTFhYTYwM2Q2MmEzNzVmNmM4 MC4uMzY2NTllNDY3ZmVjM2UzZTk3YjgxMjdhZWU5YmM5MGEyMzIzNDQxZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0 b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29y ZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3Bw CkBAIC04NiwxMiArODYsMTIgQEAgdm9pZCBUaHJlYWRlZENvbXBvc2l0b3I6OmNyZWF0ZUdMQ29u dGV4dCgpCiAKICAgICBBU1NFUlQobV9uYXRpdmVTdXJmYWNlSGFuZGxlKTsKIAotI2lmIENQVShB RERSRVNTNjQpCi0gICAgYXV0byB3aW5kb3dUeXBlID0gcmVpbnRlcnByZXRfY2FzdDxHTE5hdGl2 ZVdpbmRvd1R5cGU+KG1fbmF0aXZlU3VyZmFjZUhhbmRsZSk7Ci0jZWxzZQotICAgIC8vIE9uIDMy LWJpdCBwbGF0Zm9ybXMgR0xOYXRpdmVXaW5kb3dUeXBlIGlzIGFuIGludGVnZXIgdHlwZSwgd2hp Y2ggY2Fubm90IGJlIGNhc3RlZCB3aXRoIHJlaW50ZXJwcmV0X2Nhc3QuCi0gICAgYXV0byB3aW5k b3dUeXBlID0gc3RhdGljX2Nhc3Q8R0xOYXRpdmVXaW5kb3dUeXBlPihtX25hdGl2ZVN1cmZhY2VI YW5kbGUpOwotI2VuZGlmCisgICAgLy8gR0xOYXRpdmVXaW5kb3dUeXBlIGRlcGVuZHMgb24gdGhl IEVHTCBpbXBsZW1lbnRhdGlvbjogcmVpbnRlcnByZXRfY2FzdCB3b3JrcworICAgIC8vIGZvciBw b2ludGVycyAob25seSBpZiB0aGV5IGFyZSA2NC1iaXQgd2lkZSBhbmQgbm90IGZvciBvdGhlciBj YXNlcyksIGFuZCBzdGF0aWNfY2FzdCBmb3IKKyAgICAvLyBudW1lcmljIHR5cGVzIChhbmQgd2hl biBuZWVkZWQgdGhleSBnZXQgZXh0ZW5kZWQgdG8gNjQtYml0KSBidXQgbm90IGZvciBwb2ludGVy cy4gVXNpbmcKKyAgICAvLyBhIHBsYWluIEMgY2FzdCBleHByZXNzaW9uIGluIHRoaXMgb25lIGlu c3RhbmNlIHdvcmtzIGluIGFsbCBjYXNlcy4KKyAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihHTE5h dGl2ZVdpbmRvd1R5cGUpIDw9IHNpemVvZih1aW50NjRfdCksICJHTE5hdGl2ZVdpbmRvd1R5cGUg bXVzdCBub3QgYmUgbG9uZ2VyIHRoYW4gNjQgYml0cy4iKTsKKyAgICBhdXRvIHdpbmRvd1R5cGUg PSAoR0xOYXRpdmVXaW5kb3dUeXBlKSBtX25hdGl2ZVN1cmZhY2VIYW5kbGU7CiAgICAgbV9jb250 ZXh0ID0gR0xDb250ZXh0OjpjcmVhdGVDb250ZXh0Rm9yV2luZG93KHdpbmRvd1R5cGUsICZQbGF0 Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXlGb3JDb21wb3NpdGluZygpKTsKICAgICBpZiAobV9j b250ZXh0KQogICAgICAgICBtX2NvbnRleHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwo=