223667 2021-03-23 19:02:39 -0700 Metal ANGLE non-blockers: Fix webgl/1.0.3/conformance/uniforms/uniform-default-values.html, Stencil debug layer assertions 2021-03-25 23:27:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220076 1 kpiddington webkit-unassigned dino ews-watchlist graouts kondapallykalyan webkit-bug-importer oldest_to_newest 1743114 0 kpiddington 2021-03-23 19:02:39 -0700 Metal ANGLE non-blockers: Fix webgl/1.0.3/conformance/uniforms/uniform-default-values.html, Stencil debug layer assertions 1743116 1 424090 kpiddington 2021-03-23 19:05:13 -0700 Created attachment 424090 Patch 1743117 2 ews-watchlist 2021-03-23 19:06:09 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1743676 3 dino 2021-03-24 23:10:50 -0700 Committed r275012 (235745@main): <https://commits.webkit.org/235745@main> 1743677 4 webkit-bug-importer 2021-03-24 23:11:14 -0700 <rdar://problem/75823624> 424090 2021-03-23 19:05:13 -0700 2021-03-24 15:32:18 -0700 Patch bug-223667-20210323190512.patch text/plain 6885 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTM1NWJjMjI2YTFjOGY4ODliNzY4Y2E4MGY1ZmQ1NjZhZjk0NjI3NC4uNTJmZGQzNGM5N2Nk OWNlODI5YWVlNjNlYWNjZGQ4OGM4YzRkNWNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTAzLTIzICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWV0YWwgQU5HTEUgbm9uLWJsb2NrZXJzOiBGaXgg d2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvdW5pZm9ybXMvdW5pZm9ybS1kZWZhdWx0LXZhbHVlcy5o dG1sLCBTdGVuY2lsIGRlYnVnIGxheWVyIGFzc2VydGlvbnMKKwlPbiBSZWxlYXNlLCB1bmlmb3Jt RGVmYXVsdFZhbHVlcyB3YXMgcmVzZXR0aW5nIHByb2dyYW0gbWVtb3J5IGVpdGhlciBlYXJseSwg b3Igb2RkbHkuIFNpbmNlIHByb2dyYW0gcmVmbGVjdGlvbiBzaG91bGQgYmUgY29uc3RhbnQKKyAg ICAgICAgcGVyIFNoYWRlciBhbnl3YXksIGRyb3AgdGhlICdyZXNldCcgYWZ0ZXIgYXNzaWduaW5n IHJlZmxlY3Rpb24gZGF0YS4KKworCUluIGFkZGl0aW9uLCBjbGFtcCBzdGVuY2lsIHJlY3Rhbmds ZSB0byBhbHdheXMgYmUgd2l0aGluIGZyYW1lYnVmZmVyIGJvdW5kcy4gQ29kZSB0YWtlbiBmcm9t IHVwc3RyZWFtIEFOR0xFLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjM2NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Qcm9ncmFtTXRsLm1tOgor ICAgICAgICAocng6OlByb2dyYW1NdGw6OmxpbmtJbXBsRGlyZWN0KToKKyAgICAgICAgKiBzcmMv bGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1hbmRfYnVmZmVyLm1tOgorICAgICAgICAo cng6Om10bDo6UmVuZGVyQ29tbWFuZEVuY29kZXI6OmluaXRBdHRhY2htZW50V3JpdGVEZXBlbmRl bmN5QW5kU2Npc3NvclJlY3QpOgorICAgICAgICAocng6Om10bDo6UmVuZGVyQ29tbWFuZEVuY29k ZXI6OnJlc3RhcnQpOgorICAgICAgICAocng6Om10bDo6UmVuZGVyQ29tbWFuZEVuY29kZXI6OnNl dFNjaXNzb3JSZWN0KToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRs X2dsc2xhbmdfbXRsX3V0aWxzLm1tOgorICAgICAgICAocng6Om10bDo6VHJhbnNsYXRlZFNoYWRl ckluZm86OnJlc2V0KToKKyAgICAgICAgKHJ4OjptdGw6Okdsc2xhbmdHZXRNU0wpOgorCiAyMDIx LTAzLTIzICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAg QU5HTEUgaXMgbWlzc2luZyB0aGUgZXhwbGljaXQgY29udGV4dCBoZWFkZXJzCmRpZmYgLS1naXQg YS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRs X2NvbW1hbmRfYnVmZmVyLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF L3JlbmRlcmVyL21ldGFsL210bF9jb21tYW5kX2J1ZmZlci5tbQppbmRleCA3ZWQwZTIxMjA4Y2Mw ODgyMjgxMTQ5MTE1N2ZkZTY4NDVjNGRjYTdhLi4zZjFmY2MxN2QxMWEwMTExNjVkNzY3OTdhOTMy NWQ1ZmExZmM1MDExIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGli QU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1hbmRfYnVmZmVyLm1tCisrKyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbWFuZF9i dWZmZXIubW0KQEAgLTExMjgsNiArMTEyOCwyNCBAQCB2b2lkIFJlbmRlckNvbW1hbmRFbmNvZGVy OjplbmRFbmNvZGluZ0ltcGwoYm9vbCBjb25zaWRlckRpc2NhcmRTaW11bGF0aW9uKQogICAgIG1T dGF0ZUNhY2hlLnJlc2V0KCk7CiB9CiAKKworaW5saW5lIHZvaWQgUmVuZGVyQ29tbWFuZEVuY29k ZXI6OmluaXRBdHRhY2htZW50V3JpdGVEZXBlbmRlbmN5QW5kU2Npc3NvclJlY3QoCisgICAgY29u c3QgUmVuZGVyUGFzc0F0dGFjaG1lbnREZXNjICZhdHRhY2htZW50KQoreworICAgIFRleHR1cmVS ZWYgdGV4dHVyZSA9IGF0dGFjaG1lbnQudGV4dHVyZSgpOworICAgIGlmICh0ZXh0dXJlKQorICAg IHsKKyAgICAgICAgY21kQnVmZmVyKCkuc2V0V3JpdGVEZXBlbmRlbmN5KHRleHR1cmUpOworCisg ICAgICAgIGNvbnN0IE1pcG1hcE5hdGl2ZUxldmVsICZtaXBMZXZlbCA9IGF0dGFjaG1lbnQubGV2 ZWwoKTsKKworICAgICAgICBtUmVuZGVyUGFzc01heFNjaXNzb3JSZWN0LndpZHRoID0KKyAgICAg ICAgICAgIHN0ZDo6bWluPE5TVUludGVnZXI+KG1SZW5kZXJQYXNzTWF4U2Npc3NvclJlY3Qud2lk dGgsIHRleHR1cmUtPndpZHRoKG1pcExldmVsKSk7CisgICAgICAgIG1SZW5kZXJQYXNzTWF4U2Np c3NvclJlY3QuaGVpZ2h0ID0KKyAgICAgICAgICAgIHN0ZDo6bWluPE5TVUludGVnZXI+KG1SZW5k ZXJQYXNzTWF4U2Npc3NvclJlY3QuaGVpZ2h0LCB0ZXh0dXJlLT5oZWlnaHQobWlwTGV2ZWwpKTsK KyAgICB9Cit9CisKIGlubGluZSB2b2lkIFJlbmRlckNvbW1hbmRFbmNvZGVyOjppbml0V3JpdGVE ZXBlbmRlbmN5KGNvbnN0IFRleHR1cmVSZWYgJnRleHR1cmUpCiB7CiAgICAgaWYgKHRleHR1cmUp CkBAIC0xMjQ4LDE2ICsxMjY2LDE5IEBAIFJlbmRlckNvbW1hbmRFbmNvZGVyICZSZW5kZXJDb21t YW5kRW5jb2Rlcjo6cmVzdGFydChjb25zdCBSZW5kZXJQYXNzRGVzYyAmZGVzYykKICAgICBtUmVu ZGVyUGFzc0Rlc2MgPSBkZXNjOwogICAgIG1SZWNvcmRpbmcgICAgICA9IHRydWU7CiAgICAgbUhh c0RyYXdDYWxscyAgID0gZmFsc2U7Ci0KKyAgICBtUmVuZGVyUGFzc01heFNjaXNzb3JSZWN0ID0g ey54ICAgICAgPSAwLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLnkgICAgICA9 IDAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAud2lkdGggID0gc3RkOjpudW1l cmljX2xpbWl0czxOU1VJbnRlZ2VyPjo6bWF4KCksCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAuaGVpZ2h0ID0gc3RkOjpudW1lcmljX2xpbWl0czxOU1VJbnRlZ2VyPjo6bWF4KCl9 OwogICAgIC8vIG1hc2sgd3JpdGluZyBkZXBlbmRlbmN5ICYgc2V0IGFwcHJvcHJpYXRlIHN0b3Jl IG9wdGlvbnMKICAgICBmb3IgKHVpbnQzMl90IGkgPSAwOyBpIDwgbVJlbmRlclBhc3NEZXNjLm51 bUNvbG9yQXR0YWNobWVudHM7ICsraSkKICAgICB7Ci0gICAgICAgIGluaXRXcml0ZURlcGVuZGVu Y3kobVJlbmRlclBhc3NEZXNjLmNvbG9yQXR0YWNobWVudHNbaV0udGV4dHVyZSgpKTsKKyAgICAg ICAgaW5pdEF0dGFjaG1lbnRXcml0ZURlcGVuZGVuY3lBbmRTY2lzc29yUmVjdChtUmVuZGVyUGFz c0Rlc2MuY29sb3JBdHRhY2htZW50c1tpXSk7CiAgICAgfQogCi0gICAgaW5pdFdyaXRlRGVwZW5k ZW5jeShtUmVuZGVyUGFzc0Rlc2MuZGVwdGhBdHRhY2htZW50LnRleHR1cmUoKSk7CisgICAgaW5p dEF0dGFjaG1lbnRXcml0ZURlcGVuZGVuY3lBbmRTY2lzc29yUmVjdChtUmVuZGVyUGFzc0Rlc2Mu ZGVwdGhBdHRhY2htZW50KTsKIAotICAgIGluaXRXcml0ZURlcGVuZGVuY3kobVJlbmRlclBhc3NE ZXNjLnN0ZW5jaWxBdHRhY2htZW50LnRleHR1cmUoKSk7CisgICAgaW5pdEF0dGFjaG1lbnRXcml0 ZURlcGVuZGVuY3lBbmRTY2lzc29yUmVjdChtUmVuZGVyUGFzc0Rlc2Muc3RlbmNpbEF0dGFjaG1l bnQpOwogCiAgICAgLy8gQ29udmVydCB0byBPYmplY3RpdmUtQyBkZXNjcmlwdG9yCiAgICAgbVJl bmRlclBhc3NEZXNjLmNvbnZlcnRUb01ldGFsRGVzYyhtQ2FjaGVkUmVuZGVyUGFzc0Rlc2NPYmpD KTsKQEAgLTEzODgsMTMgKzE0MDksMjUgQEAgUmVuZGVyQ29tbWFuZEVuY29kZXIgJlJlbmRlckNv bW1hbmRFbmNvZGVyOjpzZXRWaWV3cG9ydChjb25zdCBNVExWaWV3cG9ydCAmdmlld3AKIAogUmVu ZGVyQ29tbWFuZEVuY29kZXIgJlJlbmRlckNvbW1hbmRFbmNvZGVyOjpzZXRTY2lzc29yUmVjdChj b25zdCBNVExTY2lzc29yUmVjdCAmcmVjdCkKIHsKLSAgICBpZiAobVN0YXRlQ2FjaGUuc2Npc3Nv clJlY3QudmFsaWQoKSAmJiBtU3RhdGVDYWNoZS5zY2lzc29yUmVjdC52YWx1ZSgpID09IHJlY3Qp CisgICAgTlNVSW50ZWdlciBjbGFtcGVkV2lkdGggPSAgcmVjdC54ID4gbVJlbmRlclBhc3NNYXhT Y2lzc29yUmVjdC53aWR0aCA/IDAgOiBtUmVuZGVyUGFzc01heFNjaXNzb3JSZWN0LndpZHRoIC0g cmVjdC54OworICAgIE5TVUludGVnZXIgY2xhbXBlZEhlaWdodCA9IHJlY3QueSA+IG1SZW5kZXJQ YXNzTWF4U2Npc3NvclJlY3QuaGVpZ2h0ID8gMCA6IG1SZW5kZXJQYXNzTWF4U2Npc3NvclJlY3Qu aGVpZ2h0IC0gcmVjdC55OworCisgICAgTVRMU2Npc3NvclJlY3QgY2xhbXBlZFJlY3QgPSB7Cisg ICAgICAgIHJlY3QueCwgcmVjdC55LCBzdGQ6Om1pbihyZWN0LndpZHRoLCBjbGFtcGVkV2lkdGgp LCBzdGQ6Om1pbihyZWN0LmhlaWdodCwgY2xhbXBlZEhlaWdodCkgfTsKKworICAgIGlmIChtU3Rh dGVDYWNoZS5zY2lzc29yUmVjdC52YWxpZCgpICYmIG1TdGF0ZUNhY2hlLnNjaXNzb3JSZWN0LnZh bHVlKCkgPT0gY2xhbXBlZFJlY3QpCisgICAgeworICAgICAgICByZXR1cm4gKnRoaXM7CisgICAg fQorICAgIAorICAgIGlmIChBTkdMRV9VTkxJS0VMWShjbGFtcGVkUmVjdC53aWR0aCA9PSAwIHx8 IGNsYW1wZWRSZWN0LmhlaWdodCA9PSAwKSkKICAgICB7CisgICAgICAgIC8vQW4gZW1wdHkgcmVj dGFuZ2xlIGlzbid0IGEgdmFsaWQgc2Npc3Nvci4KICAgICAgICAgcmV0dXJuICp0aGlzOwogICAg IH0KLSAgICBtU3RhdGVDYWNoZS5zY2lzc29yUmVjdCA9IHJlY3Q7CisgICAgbVN0YXRlQ2FjaGUu c2Npc3NvclJlY3QgPSBjbGFtcGVkUmVjdDsKIAotICAgIG1Db21tYW5kcy5wdXNoKENtZFR5cGU6 OlNldFNjaXNzb3JSZWN0KS5wdXNoKHJlY3QpOworICAgIG1Db21tYW5kcy5wdXNoKENtZFR5cGU6 OlNldFNjaXNzb3JSZWN0KS5wdXNoKGNsYW1wZWRSZWN0KTsKIAogICAgIHJldHVybiAqdGhpczsK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5k ZXJlci9tZXRhbC9tdGxfZ2xzbGFuZ19tdGxfdXRpbHMubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRsX3V0aWxzLm1t CmluZGV4IGNlMGEzYmUzODViYWEwZWQzNGZmYzU1MGViZGE1NmJiMzczYjU4MTIuLjcwZDc2ZGIx NzJjMGExNzYxNmI0YzNkYzg4MzNmZDE2NTM5OTAzMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xzbGFuZ19tdGxf dXRpbHMubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRl cmVyL21ldGFsL210bF9nbHNsYW5nX210bF91dGlscy5tbQpAQCAtNDYsOCArNDYsOCBAQCB2b2lk IFRyYW5zbGF0ZWRTaGFkZXJJbmZvOjpyZXNldCgpCiAgICAgZm9yIChtdGw6OlNhbXBsZXJCaW5k aW5nICZiaW5kaW5nIDogYWN0dWFsU2FtcGxlckJpbmRpbmdzKQogICAgIHsKICAgICAgICAgYmlu ZGluZy50ZXh0dXJlQmluZGluZyA9IG10bDo6a01heFNoYWRlclNhbXBsZXJzOworICAgICAgICBi aW5kaW5nLnNhbXBsZXJCaW5kaW5nID0gMDsKICAgICB9Ci0KICAgICBmb3IgKHVpbnQzMl90ICZi aW5kaW5nIDogYWN0dWFsVUJPQmluZGluZ3MpCiAgICAgewogICAgICAgICBiaW5kaW5nID0gbXRs OjprTWF4U2hhZGVyQnVmZmVyczsKQEAgLTQyOCw3ICs0MjgsNyBAQCBhbmdsZTo6UmVzdWx0IEds c2xhbmdHZXRNU0woY29uc3QgZ2w6OkNvbnRleHQgKmdsQ29udGV4dCwKICAgICAgICAgKCptc2xD b2RlT3V0KVt0eXBlXSAgICAgICAgICAgICAgICAgICAgICAgICA9IHNvdXJjZTsKICAgICAgICAg KCptc2xTaGFkZXJJbmZvT3V0KVt0eXBlXS5tZXRhbFNoYWRlclNvdXJjZSA9IHNvdXJjZTsKICAg ICAgICAgZ2w6OlNoYWRlciAqc2hhZGVyICAgICAgICAgICAgICAgICAgICAgICAgPSBwcm9ncmFt U3RhdGUuZ2V0QXR0YWNoZWRTaGFkZXIodHlwZSk7Ci0gICAgICAgIHNoOjpUcmFuc2xhdG9yTWV0 YWxSZWZsZWN0aW9uICpyZWZsZWN0aW9uID0gZ2V0UmVmbGVjdGlvbkZyb21TaGFkZXIoc2hhZGVy KTsKKyAgICAgICAgY29uc3Qgc2g6OlRyYW5zbGF0b3JNZXRhbFJlZmxlY3Rpb24gKnJlZmxlY3Rp b24gPSBnZXRSZWZsZWN0aW9uRnJvbVNoYWRlcihzaGFkZXIpOwogICAgICAgICBpZihyZWZsZWN0 aW9uLT5oYXNVQk9zKQogICAgICAgICB7CiAgICAgICAgICAgICAoKm1zbFNoYWRlckluZm9PdXQp W3R5cGVdLmhhc1VCT0FyZ3VtZW50QnVmZmVyID0gdHJ1ZTsKQEAgLTQ1NCw3ICs0NTQsNiBAQCBh bmdsZTo6UmVzdWx0IEdsc2xhbmdHZXRNU0woY29uc3QgZ2w6OkNvbnRleHQgKmdsQ29udGV4dCwK ICAgICAgICAgICAgIEdldEFzc2lnbmVkU2FtcGxlckJpbmRpbmdzKHJlZmxlY3Rpb24sIG9yaWdp bmFsU2FtcGxlckJpbmRpbmdzLCBzdHJ1Y3RTYW1wbGVycywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZtc2xTaGFkZXJJbmZvT3V0LT5hdCh0eXBlKS5hY3R1YWxTYW1w bGVyQmluZGluZ3MpOwogICAgICAgICB9Ci0gICAgICAgIHJlZmxlY3Rpb24tPnJlc2V0KCk7CiAg ICAgfQogICAgIHJldHVybiBhbmdsZTo6UmVzdWx0OjpDb250aW51ZTsKIH0K