223649 2021-03-23 11:48:14 -0700 Don't require VM_FLAGS_PERMANENT on the simulator builds 2021-03-23 13:55:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1742925 0 saam 2021-03-23 11:48:14 -0700 ... 1742926 1 webkit-bug-importer 2021-03-23 11:48:30 -0700 <rdar://problem/75747788> 1742940 2 424048 saam 2021-03-23 12:14:57 -0700 Created attachment 424048 patch 1742954 3 424048 ap 2021-03-23 12:28:46 -0700 Comment on attachment 424048 patch View in context: https://bugs.webkit.org/attachment.cgi?id=424048&action=review > Source/WTF/wtf/WTFConfig.cpp:80 > +#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR) I'd add FIXME: Remove the fallback when the oldest host OS that we support for Simulator has VM_FLAGS_PERMANENT. > Source/WTF/wtf/WTFConfig.cpp:82 > + flags = VM_FLAGS_FIXED | VM_FLAGS_OVERWRITE; It should be safer against potential future code modifications to clear VM_FLAGS_PERMANENT here, not to double-guess what it was set to ten lines above. 1742969 4 424048 saam 2021-03-23 13:08:13 -0700 Comment on attachment 424048 patch View in context: https://bugs.webkit.org/attachment.cgi?id=424048&action=review >> Source/WTF/wtf/WTFConfig.cpp:80 >> +#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR) > > I'd add FIXME: Remove the fallback when the oldest host OS that we support for Simulator has VM_FLAGS_PERMANENT. Sounds good >> Source/WTF/wtf/WTFConfig.cpp:82 >> + flags = VM_FLAGS_FIXED | VM_FLAGS_OVERWRITE; > > It should be safer against potential future code modifications to clear VM_FLAGS_PERMANENT here, not to double-guess what it was set to ten lines above. Sounds good 1742972 5 424054 saam 2021-03-23 13:12:58 -0700 Created attachment 424054 patch for landing 1742995 6 ews-feeder 2021-03-23 13:55:25 -0700 Committed r274898: <https://commits.webkit.org/r274898> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424054. 424048 2021-03-23 12:14:57 -0700 2021-03-23 13:12:58 -0700 patch a-backup.diff text/plain 2275 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzQ4ODcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTIzICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHJlcXVpcmUgVk1fRkxBR1NfUEVSTUFORU5U IG9uIHRoZSBzaW11bGF0b3IgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjM2NDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1NzQ3Nzg4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNl IFZNX0ZMQUdTX1BFUk1BTkVOVCBtdXN0IGJlIHN1cHBvcnRlZCBieSB0aGUga2VybmVsLCBsZXQn cyBtYWtlCisgICAgICAgIGl0IHNvIHRoYXQgdGhlIHZtX21hcCB0aGF0IHBhc3NlcyB0aGlzIGZs YWcgaW4gY2FuIGZhaWwgd2hlbiBydW5uaW5nCisgICAgICAgIG9uIHRoZSBzaW11bGF0b3IuIFRo aXMgaXMgdG8gc3VwcG9ydCB0aGUgdXNlIGNhc2Ugb2YgcnVubmluZyBhIG5ld2VyCisgICAgICAg IHNpbXVsYXRvciBvbiBhbiBvbGRlciBPUy4gV2hlbiB0aGUgY2FsbCB0byB2bV9tYXAgZmFpbHMg d2hlbiBydW5uaW5nCisgICAgICAgIG9uIHRoZSBzaW11bGF0b3IsIHdlIHRyeSBhZ2FpbiB3aXRo b3V0IHRoZSBWTV9GTEFHU19QRVJNQU5FTlQgZmxhZy4KKworICAgICAgICAqIHd0Zi9XVEZDb25m aWcuY3BwOgorICAgICAgICAoV1RGOjpzZXRQZXJtaXNzaW9uc09mQ29uZmlnUGFnZSk6CisKIDIw MjEtMDMtMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICB3dGYv dGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6NTQ6MTA0OiBydW50aW1lIGVycm9yOiBu ZWdhdGlvbiBvZiAtMjE0NzQ4MzY0OCBjYW5ub3QgYmUgcmVwcmVzZW50ZWQgaW4gdHlwZSAnaW50 JzsgY2FzdCB0byBhbiB1bnNpZ25lZCB0eXBlIHRvIG5lZ2F0ZSB0aGlzIHZhbHVlIHRvIGl0c2Vs ZgpJbmRleDogU291cmNlL1dURi93dGYvV1RGQ29uZmlnLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9XVEZDb25maWcuY3BwCShyZXZpc2lvbiAyNzQ4ODYpCisrKyBTb3VyY2UvV1RG L3d0Zi9XVEZDb25maWcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MSw3ICs3MSwxOSBAQCB2b2lk IHNldFBlcm1pc3Npb25zT2ZDb25maWdQYWdlKCkKICAgICAgICAgZmxhZ3MgfD0gVk1fRkxBR1Nf UEVSTUFORU5UOwogI2VuZGlmCiAKLSAgICAgICAgYXV0byByZXN1bHQgPSBtYWNoX3ZtX21hcCht YWNoX3Rhc2tfc2VsZigpLCAmYWRkciwgQ29uZmlnU2l6ZVRvUHJvdGVjdCwgcGFnZVNpemUoKSAt IDEsIGZsYWdzLCBNRU1PUllfT0JKRUNUX05VTEwsIDAsIGZhbHNlLCBWTV9QUk9UX1JFQUQgfCBW TV9QUk9UX1dSSVRFLCBWTV9QUk9UX1JFQUQgfCBWTV9QUk9UX1dSSVRFLCBWTV9JTkhFUklUX0RF RkFVTFQpOworICAgICAgICBhdXRvIGF0dGVtcHRWTU1hcHBpbmcgPSBbJl0geworICAgICAgICAg ICAgcmV0dXJuIG1hY2hfdm1fbWFwKG1hY2hfdGFza19zZWxmKCksICZhZGRyLCBDb25maWdTaXpl VG9Qcm90ZWN0LCBwYWdlU2l6ZSgpIC0gMSwgZmxhZ3MsIE1FTU9SWV9PQkpFQ1RfTlVMTCwgMCwg ZmFsc2UsIFZNX1BST1RfUkVBRCB8IFZNX1BST1RfV1JJVEUsIFZNX1BST1RfUkVBRCB8IFZNX1BS T1RfV1JJVEUsIFZNX0lOSEVSSVRfREVGQVVMVCk7CisgICAgICAgIH07CisKKyAgICAgICAgYXV0 byByZXN1bHQgPSBhdHRlbXB0Vk1NYXBwaW5nKCk7CisKKyNpZiBIQVZFKFZNX0ZMQUdTX1BFUk1B TkVOVCkgJiYgUExBVEZPUk0oSU9TX0ZBTUlMWV9TSU1VTEFUT1IpCisgICAgICAgIGlmIChyZXN1 bHQgIT0gS0VSTl9TVUNDRVNTKSB7CisgICAgICAgICAgICBmbGFncyA9IFZNX0ZMQUdTX0ZJWEVE IHwgVk1fRkxBR1NfT1ZFUldSSVRFOworICAgICAgICAgICAgcmVzdWx0ID0gYXR0ZW1wdFZNTWFw cGluZygpOworICAgICAgICB9CisjZW5kaWYKKwogICAgICAgICBSRUxFQVNFX0FTU0VSVChyZXN1 bHQgPT0gS0VSTl9TVUNDRVNTKTsKICAgICB9KTsKICNlbmRpZiAvLyBPUyhEQVJXSU4pCg== 424054 2021-03-23 13:12:58 -0700 2021-03-23 13:55:26 -0700 patch for landing a-backup.diff text/plain 2362 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzQ4ODcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTIzICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHJlcXVpcmUgVk1fRkxBR1NfUEVSTUFORU5U IG9uIHRoZSBzaW11bGF0b3IgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjM2NDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1NzQ3Nzg4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAg U2luY2UgVk1fRkxBR1NfUEVSTUFORU5UIG11c3QgYmUgc3VwcG9ydGVkIGJ5IHRoZSBrZXJuZWws IGxldCdzIG1ha2UKKyAgICAgICAgaXQgc28gdGhhdCB0aGUgdm1fbWFwIHRoYXQgcGFzc2VzIHRo aXMgZmxhZyBpbiBjYW4gZmFpbCB3aGVuIHJ1bm5pbmcKKyAgICAgICAgb24gdGhlIHNpbXVsYXRv ci4gVGhpcyBpcyB0byBzdXBwb3J0IHRoZSB1c2UgY2FzZSBvZiBydW5uaW5nIGEgbmV3ZXIKKyAg ICAgICAgc2ltdWxhdG9yIG9uIGFuIG9sZGVyIE9TLiBXaGVuIHRoZSBjYWxsIHRvIHZtX21hcCBm YWlscyB3aGVuIHJ1bm5pbmcKKyAgICAgICAgb24gdGhlIHNpbXVsYXRvciwgd2UgdHJ5IGFnYWlu IHdpdGhvdXQgdGhlIFZNX0ZMQUdTX1BFUk1BTkVOVCBmbGFnLgorCisgICAgICAgICogd3RmL1dU RkNvbmZpZy5jcHA6CisgICAgICAgIChXVEY6OnNldFBlcm1pc3Npb25zT2ZDb25maWdQYWdlKToK KwogMjAyMS0wMy0yMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IHd0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaDo1NDoxMDQ6IHJ1bnRpbWUgZXJy b3I6IG5lZ2F0aW9uIG9mIC0yMTQ3NDgzNjQ4IGNhbm5vdCBiZSByZXByZXNlbnRlZCBpbiB0eXBl ICdpbnQnOyBjYXN0IHRvIGFuIHVuc2lnbmVkIHR5cGUgdG8gbmVnYXRlIHRoaXMgdmFsdWUgdG8g aXRzZWxmCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9XVEZDb25maWcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XVEYvd3RmL1dURkNvbmZpZy5jcHAJKHJldmlzaW9uIDI3NDg4NikKKysrIFNvdXJj ZS9XVEYvd3RmL1dURkNvbmZpZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxLDcgKzcxLDIwIEBA IHZvaWQgc2V0UGVybWlzc2lvbnNPZkNvbmZpZ1BhZ2UoKQogICAgICAgICBmbGFncyB8PSBWTV9G TEFHU19QRVJNQU5FTlQ7CiAjZW5kaWYKIAotICAgICAgICBhdXRvIHJlc3VsdCA9IG1hY2hfdm1f bWFwKG1hY2hfdGFza19zZWxmKCksICZhZGRyLCBDb25maWdTaXplVG9Qcm90ZWN0LCBwYWdlU2l6 ZSgpIC0gMSwgZmxhZ3MsIE1FTU9SWV9PQkpFQ1RfTlVMTCwgMCwgZmFsc2UsIFZNX1BST1RfUkVB RCB8IFZNX1BST1RfV1JJVEUsIFZNX1BST1RfUkVBRCB8IFZNX1BST1RfV1JJVEUsIFZNX0lOSEVS SVRfREVGQVVMVCk7CisgICAgICAgIGF1dG8gYXR0ZW1wdFZNTWFwcGluZyA9IFsmXSB7CisgICAg ICAgICAgICByZXR1cm4gbWFjaF92bV9tYXAobWFjaF90YXNrX3NlbGYoKSwgJmFkZHIsIENvbmZp Z1NpemVUb1Byb3RlY3QsIHBhZ2VTaXplKCkgLSAxLCBmbGFncywgTUVNT1JZX09CSkVDVF9OVUxM LCAwLCBmYWxzZSwgVk1fUFJPVF9SRUFEIHwgVk1fUFJPVF9XUklURSwgVk1fUFJPVF9SRUFEIHwg Vk1fUFJPVF9XUklURSwgVk1fSU5IRVJJVF9ERUZBVUxUKTsKKyAgICAgICAgfTsKKworICAgICAg ICBhdXRvIHJlc3VsdCA9IGF0dGVtcHRWTU1hcHBpbmcoKTsKKworI2lmIEhBVkUoVk1fRkxBR1Nf UEVSTUFORU5UKSAmJiBQTEFURk9STShJT1NfRkFNSUxZX1NJTVVMQVRPUikKKyAgICAgICAgLy8g RklYTUU6IFJlbW92ZSB0aGlzIHdoZW4gdGhlIG9sZGVzdCBPUyB3ZSBzdXBwb3J0IHNpbXVsYXRv ciBvbiBoYXMgVk1fRkxBR1NfUEVSTUFORU5UCisgICAgICAgIGlmIChyZXN1bHQgIT0gS0VSTl9T VUNDRVNTKSB7CisgICAgICAgICAgICBmbGFncyAmPSB+Vk1fRkxBR1NfUEVSTUFORU5UOworICAg ICAgICAgICAgcmVzdWx0ID0gYXR0ZW1wdFZNTWFwcGluZygpOworICAgICAgICB9CisjZW5kaWYK KwogICAgICAgICBSRUxFQVNFX0FTU0VSVChyZXN1bHQgPT0gS0VSTl9TVUNDRVNTKTsKICAgICB9 KTsKICNlbmRpZiAvLyBPUyhEQVJXSU4pCg==