223639 2021-03-23 09:15:42 -0700 Crash in WebCore::positionInParentBeforeNode(..) 2021-03-30 18:36:01 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yaranamavenkataramana webkit-unassigned bfulgham ews-feeder product-security rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1742831 0 yaranamavenkataramana 2021-03-23 09:15:42 -0700 Crash when there is a selectall and insert image is executed. #0 0x2ec93327a in WebCore::positionInParentBeforeNode(WebCore::Node*)+0x4a (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x493127a) #1 0x2eccc8314 in WebCore::ReplaceSelectionCommand::doApply()+0x2644 (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x4cc6314) #2 0x2ecaa3860 in WebCore::CompositeEditCommand::apply()+0x250 (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x4aa1860) #3 0x2ecc4923b in WebCore::executeInsertFragment(WebCore::Frame&, WTF::Ref<WebCore::DocumentFragment, WTF::RawPtrTraits<WebCore::DocumentFragment> >&&)+0x1ab (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x4c4723b) #4 0x2ecc496f7 in WebCore::executeInsertNode(WebCore::Frame&, WTF::Ref<WebCore::Node, WTF::RawPtrTraits<WebCore::Node> >&&)+0x197 (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x4c476f7) #5 0x2ecc3ec43 in WebCore::executeInsertImage(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+0x1c3 (/Users/user/dev/wk/ak/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x4c3cc43) #6 0x2ec72668e in WebCore::Document::execCommand(WTF::String const&, bool, WTF rdar://75426958 1742876 1 424032 yaranamavenkataramana 2021-03-23 10:02:24 -0700 Created attachment 424032 Patch 1743076 2 424032 rniwa 2021-03-23 17:04:48 -0700 Comment on attachment 424032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424032&action=review > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1144 > + Node* br = endingSelection().start().deprecatedNode(); > + if (br != nullptr) { Please use RefPtr. Also we don't compare against nullptr: https://webkit.org/code-style-guidelines/#zero-comparison So this should be: if (auto br = makeRefPtr(endingSelection().start().deprecatedNode())) > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1146 > + // Insert content between the two blockquotes, but remove the br (since it was just a placeholder). Can we just delete this code? It's pretty obvious from the code below. There is no need to repeat the code in a comment. > LayoutTests/editing/inserting/edit-style-and-insert-image.html:8 > +testRunner.dumpAsText(); Please indent this by 4 spaces for better readability. 1743823 3 424258 yaranamavenkataramana 2021-03-25 10:55:07 -0700 Created attachment 424258 Patch 1744485 4 424258 rniwa 2021-03-27 04:07:56 -0700 Comment on attachment 424258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424258&action=review > LayoutTests/editing/inserting/edit-style-and-insert-image.html:4 > +<p>This tests Pass.</p> This text isn't printed in the output because of the code we're running. Also, we want something likely more descriptive than that. Something like this: This tests InsertImage after setting content property on the document element.<br> WebKit should not crash.<br> <br> PASS > LayoutTests/editing/inserting/edit-style-and-insert-image.html:11 > +document.execCommand('InsertImage'); Let's reset the style on documentElement here. 1745208 5 424668 yaranamavenkataramana 2021-03-30 11:47:32 -0700 Created attachment 424668 Patch 1745443 6 ews-feeder 2021-03-30 18:36:00 -0700 Committed r275253: <https://commits.webkit.org/r275253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424668. 424032 2021-03-23 10:02:24 -0700 2021-03-25 10:55:05 -0700 Patch bug-223639-20210323100223.patch text/plain 4415 yaranamavenkataramana U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFmNzJlODJjZmE3Y2Y0 YWJjZDk1YWEyYzAzNWViMDAxMWY2ZTZlMS4uNDk0NmFhNWQxZWU4ZWYxOGQwOGExY2MzN2EwMjZl ZDFhNjBlZjZkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTIzICBWZW5r eSBEYXNzICA8eWFyYW5hbWF2ZW5rYXRhcmFtYW5hQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs cHRyIGNyYXNoIGluIENyYXNoIGluIFdlYkNvcmU6OnBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB3aGVyZSBhIE5VTEwgY2hlY2sgaXMgbWlzc2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzYzOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB0aGVyZSBpcyBhIG51bGwgY2hlY2sgbWlzc2luZyBvbiBhIHBvaW50ZXIgLSBoZW5jZSB0 aGUgY3Jhc2guCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv ZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVw bGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVj dGlvbkNvbW1hbmQ6OmRvQXBwbHkpOgorCiAyMDIxLTAzLTE5ICBYYWJpZXIgUm9kcmlndWV6IENh bHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bRU1FXSBS ZW1vdmUgRFJNIHJlc291cmNlcyByZWxlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IDFhZmFmMDhhMzcxNTBjYmY3NmQ4 YjQ1YWI0YjVjYzFkNTc5ZmMyNzQuLmEzYjMwYTdmOTlhN2IyM2VlODEwZjQ3MWQ2ZDE3MDg4OWI1 NDMwNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCkBAIC0xMTM5LDEyICsxMTM5LDE0IEBAIHZvaWQgUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6OmRvQXBwbHkoKQogICAgIC8vIGJyZWFraW5nIHRoZSBibG9ja3F1b3RlIHdpbGwg cHJldmVudCB0aGUgY29udGVudCBmcm9tIGFjdHVhbGx5IGJlaW5nIGluc2VydGVkIGluIHRoZSB0 YWJsZS4KICAgICBpZiAoc2hvdWxkSGFuZGxlTWFpbEJsb2NrcXVvdGUgJiYgbV9wcmV2ZW50TmVz dGluZyAmJiAhKGVuY2xvc2luZ05vZGVPZlR5cGUoaW5zZXJ0aW9uUG9zLCAmaXNUYWJsZVN0cnVj dHVyZU5vZGUpKSkgewogICAgICAgICBhcHBseUNvbW1hbmRUb0NvbXBvc2l0ZShCcmVha0Jsb2Nr cXVvdGVDb21tYW5kOjpjcmVhdGUoZG9jdW1lbnQoKSkpOyAKLSAgICAgICAgLy8gVGhpcyB3aWxs IGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuIAotICAgICAgICBOb2RlKiBiciA9IGVuZGlu Z1NlbGVjdGlvbigpLnN0YXJ0KCkuZGVwcmVjYXRlZE5vZGUoKTsgCi0gICAgICAgIEFTU0VSVChi ci0+aGFzVGFnTmFtZShiclRhZykpOyAKLSAgICAgICAgLy8gSW5zZXJ0IGNvbnRlbnQgYmV0d2Vl biB0aGUgdHdvIGJsb2NrcXVvdGVzLCBidXQgcmVtb3ZlIHRoZSBiciAoc2luY2UgaXQgd2FzIGp1 c3QgYSBwbGFjZWhvbGRlcikuIAotICAgICAgICBpbnNlcnRpb25Qb3MgPSBwb3NpdGlvbkluUGFy ZW50QmVmb3JlTm9kZShicik7Ci0gICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgLy8g VGhpcyB3aWxsIGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuCisgICAgICAgIE5vZGUqIGJy ID0gZW5kaW5nU2VsZWN0aW9uKCkuc3RhcnQoKS5kZXByZWNhdGVkTm9kZSgpOworICAgICAgICBp ZiAoYnIgIT0gbnVsbHB0cikgeworICAgICAgICAgICAgQVNTRVJUKGJyLT5oYXNUYWdOYW1lKGJy VGFnKSk7CisgICAgICAgICAgICAvLyBJbnNlcnQgY29udGVudCBiZXR3ZWVuIHRoZSB0d28gYmxv Y2txdW90ZXMsIGJ1dCByZW1vdmUgdGhlIGJyIChzaW5jZSBpdCB3YXMganVzdCBhIHBsYWNlaG9s ZGVyKS4KKyAgICAgICAgICAgIGluc2VydGlvblBvcyA9IHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVO b2RlKGJyKTsKKyAgICAgICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgfQogICAgIH0K ICAgICAKICAgICAvLyBJbnNlcnRpbmcgY29udGVudCBjb3VsZCBjYXVzZSB3aGl0ZXNwYWNlIHRv IGNvbGxhcHNlLCBlLmcuIGluc2VydGluZyA8ZGl2PmZvbzwvZGl2PiBpbnRvIGhlbGxvXiB3b3Js ZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA3MTkwYjFhYzQ3MWM0ODFhMzg1ZWU1ZTgwOTU2NGUzN2ZjOGFmY2M0Li40NzM4 OGI2NjUyMWNkNmMzOTkxOGU2MjBlZWNlZDVmNDNlYmZjZmU2IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMjEtMDMtMjMgIFZlbmt5IERhc3MgIDx5YXJhbmFtYXZlbmthdGFyYW1hbmFAYXBwbGUu Y29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2ggaW4gQ3Jhc2ggaW4gV2ViQ29yZTo6cG9zaXRp b25JblBhcmVudEJlZm9yZU5vZGUoLi4pIHdoZXJlIGEgTlVMTCBjaGVjayBpcyBtaXNzaW5nLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjM5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEg cmVncmVzc2lvbiB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9lZGl0 LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBl ZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbDogQWRkZWQu CisKIDIwMjEtMDMtMTkgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgV2ViR0wgMi4wLjEgdGVzdCBkcml2ZXJzIGFuZCB0ZXN0IGV4cGVjdGF0aW9u cyB0byB0aGUgcmVwb3NpdG9yeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNl cnRpbmcvZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUtYW5kLWluc2VydC1pbWFnZS1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uOGIxMzc4OTE3OTFmZTk2OTI3YWQ3OGU2NGIwYWFkN2JkZWQwOGJk YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQt c3R5bGUtYW5kLWluc2VydC1pbWFnZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNl cnQtaW1hZ2UuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUt YW5kLWluc2VydC1pbWFnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRhMTU2Y2U0MjA3MjRiYzUzYzljMTI5 MTVjZDY0NGFjZjdiZDVkMDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5n L2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbApAQCAtMCwwICsxLDE0 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHkgY29udGVudGVkaXRhYmxlPgorPHA+ VGhpcyB0ZXN0cyBQYXNzLjwvcD4KKzxibG9ja3F1b3RlIHR5cGU9ImNpdGUiPjxpbnB1dD48L2Js b2NrcXVvdGU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQordGVzdFJ1bm5lci5k dW1wQXNUZXh0KCk7CitnZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihkb2N1bWVudC5xdWVyeVNl bGVjdG9yKCdpbnB1dCcpLCAxKTsKK2RvY3VtZW50LmRvY3VtZW50RWxlbWVudC5zdHlsZSA9ICdj b250ZW50OiB1cmwoKTsnCitkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0SW1hZ2UnKTsKKzwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo= 424258 2021-03-25 10:55:07 -0700 2021-03-30 11:47:30 -0700 Patch bug-223639-20210325105506.patch text/plain 4299 yaranamavenkataramana U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFmNzJlODJjZmE3Y2Y0 YWJjZDk1YWEyYzAzNWViMDAxMWY2ZTZlMS4uNDk0NmFhNWQxZWU4ZWYxOGQwOGExY2MzN2EwMjZl ZDFhNjBlZjZkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTIzICBWZW5r eSBEYXNzICA8eWFyYW5hbWF2ZW5rYXRhcmFtYW5hQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs cHRyIGNyYXNoIGluIENyYXNoIGluIFdlYkNvcmU6OnBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB3aGVyZSBhIE5VTEwgY2hlY2sgaXMgbWlzc2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzYzOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB0aGVyZSBpcyBhIG51bGwgY2hlY2sgbWlzc2luZyBvbiBhIHBvaW50ZXIgLSBoZW5jZSB0 aGUgY3Jhc2guCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv ZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVw bGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVj dGlvbkNvbW1hbmQ6OmRvQXBwbHkpOgorCiAyMDIxLTAzLTE5ICBYYWJpZXIgUm9kcmlndWV6IENh bHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bRU1FXSBS ZW1vdmUgRFJNIHJlc291cmNlcyByZWxlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IDFhZmFmMDhhMzcxNTBjYmY3NmQ4 YjQ1YWI0YjVjYzFkNTc5ZmMyNzQuLjYxYTA5MWQxNDlmZjg1MGI5ZjgwN2MxMjdhMjZkM2M1MWVh ZGQ0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCkBAIC0xMTM5LDEyICsxMTM5LDEyIEBAIHZvaWQgUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6OmRvQXBwbHkoKQogICAgIC8vIGJyZWFraW5nIHRoZSBibG9ja3F1b3RlIHdpbGwg cHJldmVudCB0aGUgY29udGVudCBmcm9tIGFjdHVhbGx5IGJlaW5nIGluc2VydGVkIGluIHRoZSB0 YWJsZS4KICAgICBpZiAoc2hvdWxkSGFuZGxlTWFpbEJsb2NrcXVvdGUgJiYgbV9wcmV2ZW50TmVz dGluZyAmJiAhKGVuY2xvc2luZ05vZGVPZlR5cGUoaW5zZXJ0aW9uUG9zLCAmaXNUYWJsZVN0cnVj dHVyZU5vZGUpKSkgewogICAgICAgICBhcHBseUNvbW1hbmRUb0NvbXBvc2l0ZShCcmVha0Jsb2Nr cXVvdGVDb21tYW5kOjpjcmVhdGUoZG9jdW1lbnQoKSkpOyAKLSAgICAgICAgLy8gVGhpcyB3aWxs IGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuIAotICAgICAgICBOb2RlKiBiciA9IGVuZGlu Z1NlbGVjdGlvbigpLnN0YXJ0KCkuZGVwcmVjYXRlZE5vZGUoKTsgCi0gICAgICAgIEFTU0VSVChi ci0+aGFzVGFnTmFtZShiclRhZykpOyAKLSAgICAgICAgLy8gSW5zZXJ0IGNvbnRlbnQgYmV0d2Vl biB0aGUgdHdvIGJsb2NrcXVvdGVzLCBidXQgcmVtb3ZlIHRoZSBiciAoc2luY2UgaXQgd2FzIGp1 c3QgYSBwbGFjZWhvbGRlcikuIAotICAgICAgICBpbnNlcnRpb25Qb3MgPSBwb3NpdGlvbkluUGFy ZW50QmVmb3JlTm9kZShicik7Ci0gICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgLy8g VGhpcyB3aWxsIGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuCisgICAgICAgIGlmIChhdXRv IGJyID0gbWFrZVJlZlB0cihlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpLmRlcHJlY2F0ZWROb2Rl KCkpKSB7CisgICAgICAgICAgICBBU1NFUlQoYnItPmhhc1RhZ05hbWUoYnJUYWcpKTsKKyAgICAg ICAgICAgIGluc2VydGlvblBvcyA9IHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2RlKGJyLmdldCgp KTsKKyAgICAgICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgfQogICAgIH0KICAgICAK ICAgICAvLyBJbnNlcnRpbmcgY29udGVudCBjb3VsZCBjYXVzZSB3aGl0ZXNwYWNlIHRvIGNvbGxh cHNlLCBlLmcuIGluc2VydGluZyA8ZGl2PmZvbzwvZGl2PiBpbnRvIGhlbGxvXiB3b3JsZC4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCA3MTkwYjFhYzQ3MWM0ODFhMzg1ZWU1ZTgwOTU2NGUzN2ZjOGFmY2M0Li40NzM4OGI2NjUy MWNkNmMzOTkxOGU2MjBlZWNlZDVmNDNlYmZjZmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjEtMDMtMjMgIFZlbmt5IERhc3MgIDx5YXJhbmFtYXZlbmthdGFyYW1hbmFAYXBwbGUuY29tPgor CisgICAgICAgIE51bGxwdHIgY3Jhc2ggaW4gQ3Jhc2ggaW4gV2ViQ29yZTo6cG9zaXRpb25JblBh cmVudEJlZm9yZU5vZGUoLi4pIHdoZXJlIGEgTlVMTCBjaGVjayBpcyBtaXNzaW5nLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjM5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEgcmVncmVz c2lvbiB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxl LWFuZC1pbnNlcnQtaW1hZ2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5n L2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbDogQWRkZWQuCisKIDIw MjEtMDMtMTkgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgV2ViR0wgMi4wLjEgdGVzdCBkcml2ZXJzIGFuZCB0ZXN0IGV4cGVjdGF0aW9ucyB0byB0 aGUgcmVwb3NpdG9yeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv ZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUtYW5kLWluc2VydC1pbWFnZS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOGIxMzc4OTE3OTFmZTk2OTI3YWQ3OGU2NGIwYWFkN2JkZWQwOGJkYwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUt YW5kLWluc2VydC1pbWFnZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1h Z2UuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUtYW5kLWlu c2VydC1pbWFnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA1MmRmODE2MDQ5NmZkNTU5NjQ1OTNlNzBlOWM5 NmNkMjMxY2UzMDEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbApAQCAtMCwwICsxLDE0IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHkgY29udGVudGVkaXRhYmxlPgorPHA+VGhpcyB0 ZXN0cyBQYXNzLjwvcD4KKzxibG9ja3F1b3RlIHR5cGU9ImNpdGUiPjxpbnB1dD48L2Jsb2NrcXVv dGU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oZG9jdW1lbnQucXVlcnlTZWxl Y3RvcignaW5wdXQnKSwgMSk7Citkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuc3R5bGUgPSAnY29u dGVudDogdXJsKCk7JworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydEltYWdlJyk7Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 424668 2021-03-30 11:47:32 -0700 2021-03-30 18:36:00 -0700 Patch bug-223639-20210330114731.patch text/plain 4425 yaranamavenkataramana U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFmNzJlODJjZmE3Y2Y0 YWJjZDk1YWEyYzAzNWViMDAxMWY2ZTZlMS4uNDk0NmFhNWQxZWU4ZWYxOGQwOGExY2MzN2EwMjZl ZDFhNjBlZjZkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTIzICBWZW5r eSBEYXNzICA8eWFyYW5hbWF2ZW5rYXRhcmFtYW5hQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs cHRyIGNyYXNoIGluIENyYXNoIGluIFdlYkNvcmU6OnBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB3aGVyZSBhIE5VTEwgY2hlY2sgaXMgbWlzc2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzYzOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2Rl KC4uKSB0aGVyZSBpcyBhIG51bGwgY2hlY2sgbWlzc2luZyBvbiBhIHBvaW50ZXIgLSBoZW5jZSB0 aGUgY3Jhc2guCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv ZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVw bGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVj dGlvbkNvbW1hbmQ6OmRvQXBwbHkpOgorCiAyMDIxLTAzLTE5ICBYYWJpZXIgUm9kcmlndWV6IENh bHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl1bRU1FXSBS ZW1vdmUgRFJNIHJlc291cmNlcyByZWxlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IDFhZmFmMDhhMzcxNTBjYmY3NmQ4 YjQ1YWI0YjVjYzFkNTc5ZmMyNzQuLjYxYTA5MWQxNDlmZjg1MGI5ZjgwN2MxMjdhMjZkM2M1MWVh ZGQ0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwCkBAIC0xMTM5LDEyICsxMTM5LDEyIEBAIHZvaWQgUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6OmRvQXBwbHkoKQogICAgIC8vIGJyZWFraW5nIHRoZSBibG9ja3F1b3RlIHdpbGwg cHJldmVudCB0aGUgY29udGVudCBmcm9tIGFjdHVhbGx5IGJlaW5nIGluc2VydGVkIGluIHRoZSB0 YWJsZS4KICAgICBpZiAoc2hvdWxkSGFuZGxlTWFpbEJsb2NrcXVvdGUgJiYgbV9wcmV2ZW50TmVz dGluZyAmJiAhKGVuY2xvc2luZ05vZGVPZlR5cGUoaW5zZXJ0aW9uUG9zLCAmaXNUYWJsZVN0cnVj dHVyZU5vZGUpKSkgewogICAgICAgICBhcHBseUNvbW1hbmRUb0NvbXBvc2l0ZShCcmVha0Jsb2Nr cXVvdGVDb21tYW5kOjpjcmVhdGUoZG9jdW1lbnQoKSkpOyAKLSAgICAgICAgLy8gVGhpcyB3aWxs IGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuIAotICAgICAgICBOb2RlKiBiciA9IGVuZGlu Z1NlbGVjdGlvbigpLnN0YXJ0KCkuZGVwcmVjYXRlZE5vZGUoKTsgCi0gICAgICAgIEFTU0VSVChi ci0+aGFzVGFnTmFtZShiclRhZykpOyAKLSAgICAgICAgLy8gSW5zZXJ0IGNvbnRlbnQgYmV0d2Vl biB0aGUgdHdvIGJsb2NrcXVvdGVzLCBidXQgcmVtb3ZlIHRoZSBiciAoc2luY2UgaXQgd2FzIGp1 c3QgYSBwbGFjZWhvbGRlcikuIAotICAgICAgICBpbnNlcnRpb25Qb3MgPSBwb3NpdGlvbkluUGFy ZW50QmVmb3JlTm9kZShicik7Ci0gICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgLy8g VGhpcyB3aWxsIGxlYXZlIGEgYnIgYmV0d2VlbiB0aGUgc3BsaXQuCisgICAgICAgIGlmIChhdXRv IGJyID0gbWFrZVJlZlB0cihlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpLmRlcHJlY2F0ZWROb2Rl KCkpKSB7CisgICAgICAgICAgICBBU1NFUlQoYnItPmhhc1RhZ05hbWUoYnJUYWcpKTsKKyAgICAg ICAgICAgIGluc2VydGlvblBvcyA9IHBvc2l0aW9uSW5QYXJlbnRCZWZvcmVOb2RlKGJyLmdldCgp KTsKKyAgICAgICAgICAgIHJlbW92ZU5vZGUoKmJyKTsKKyAgICAgICAgfQogICAgIH0KICAgICAK ICAgICAvLyBJbnNlcnRpbmcgY29udGVudCBjb3VsZCBjYXVzZSB3aGl0ZXNwYWNlIHRvIGNvbGxh cHNlLCBlLmcuIGluc2VydGluZyA8ZGl2PmZvbzwvZGl2PiBpbnRvIGhlbGxvXiB3b3JsZC4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCA3MTkwYjFhYzQ3MWM0ODFhMzg1ZWU1ZTgwOTU2NGUzN2ZjOGFmY2M0Li40NzM4OGI2NjUy MWNkNmMzOTkxOGU2MjBlZWNlZDVmNDNlYmZjZmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjEtMDMtMjMgIFZlbmt5IERhc3MgIDx5YXJhbmFtYXZlbmthdGFyYW1hbmFAYXBwbGUuY29tPgor CisgICAgICAgIE51bGxwdHIgY3Jhc2ggaW4gQ3Jhc2ggaW4gV2ViQ29yZTo6cG9zaXRpb25JblBh cmVudEJlZm9yZU5vZGUoLi4pIHdoZXJlIGEgTlVMTCBjaGVjayBpcyBtaXNzaW5nLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjM5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEgcmVncmVz c2lvbiB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxl LWFuZC1pbnNlcnQtaW1hZ2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5n L2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbDogQWRkZWQuCisKIDIw MjEtMDMtMTkgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgV2ViR0wgMi4wLjEgdGVzdCBkcml2ZXJzIGFuZCB0ZXN0IGV4cGVjdGF0aW9ucyB0byB0 aGUgcmVwb3NpdG9yeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv ZWRpdC1zdHlsZS1hbmQtaW5zZXJ0LWltYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUtYW5kLWluc2VydC1pbWFnZS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOGIxMzc4OTE3OTFmZTk2OTI3YWQ3OGU2NGIwYWFkN2JkZWQwOGJkYwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUt YW5kLWluc2VydC1pbWFnZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1h Z2UuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2VkaXQtc3R5bGUtYW5kLWlu c2VydC1pbWFnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEzYTg2MzM4YjAwMmRmOTk5MmU1NTg3ZGRiNjJj ZDhhMTNlYmExM2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9lZGl0LXN0eWxlLWFuZC1pbnNlcnQtaW1hZ2UuaHRtbApAQCAtMCwwICsxLDE4IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHkgY29udGVudGVkaXRhYmxlPgorPHA+VGhpcyB0 ZXN0cyBQYXNzLjwvcD4KKzxibG9ja3F1b3RlIHR5cGU9ImNpdGUiPjxpbnB1dD48L2Jsb2NrcXVv dGU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworZ2V0U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oZG9jdW1lbnQucXVlcnlTZWxl Y3RvcignaW5wdXQnKSwgMSk7Citkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuc3R5bGUgPSAnY29u dGVudDogdXJsKCk7JworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydEltYWdlJyk7Cis8L3Nj cmlwdD4KK1RoaXMgdGVzdHMgSW5zZXJ0SW1hZ2UgYWZ0ZXIgc2V0dGluZyBjb250ZW50IHByb3Bl cnR5IG9uIHRoZSBkb2N1bWVudCBlbGVtZW50Ljxicj4KK1dlYktpdCBzaG91bGQgbm90IGNyYXNo Ljxicj4KKzxicj4KK1BBU1MKKzwvYm9keT4KKzwvaHRtbD4K