223625 2021-03-22 22:18:00 -0700 r271034 added code in constant folding phase that's unreachable given current invariants of our ICs and PutByIdStatus 2021-03-24 09:57:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1742677 0 saam 2021-03-22 22:18:00 -0700 ... 1743011 1 424066 saam 2021-03-23 14:31:46 -0700 Created attachment 424066 patch 1743064 2 424066 ysuzuki 2021-03-23 16:31:53 -0700 Comment on attachment 424066 patch r=me 1743362 3 ews-feeder 2021-03-24 09:56:46 -0700 Committed r274942: <https://commits.webkit.org/r274942> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424066. 1743363 4 webkit-bug-importer 2021-03-24 09:57:22 -0700 <rdar://problem/75790104> 424066 2021-03-23 14:31:46 -0700 2021-03-24 09:56:47 -0700 patch c-backup.diff text/plain 4441 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc0OTAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDIxLTAzLTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHIyNzEwMzQgYWRkZWQgY29kZSBpbiBjb25zdGFudCBmb2xkaW5nIHBoYXNlIHRoYXQncyB1bnJl YWNoYWJsZSBnaXZlbiBjdXJyZW50IGludmFyaWFudHMgb2Ygb3VyIElDcyBhbmQgUHV0QnlJZFN0 YXR1cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIz NjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGNvZGUgd2FzIGRvaW5nIGEgbG90IG9mIHdyb25nIHRoaW5ncyBieSBtYWtpbmcgYmFkIGFzc3Vt cHRpb25zIGFib3V0IHRoZQorICAgICAgICBpbnZhcmlhbnRzIG9mIFB1dEJ5SWRWYXJpYW50cy4g UmVwbGFjZSBQdXRCeUlkVmFyaWFudHMgbmV2ZXIgaGF2ZSBvYmplY3QKKyAgICAgICAgcHJvcGVy dHkgY29uZGl0aW9uIHNldHMsIHNpbmNlIHdlIGFsd2F5cyByZXBsYWNlIG9uIHRoZSBzZWxmIG9i amVjdCAoYW5kIGRvbid0CisgICAgICAgIGxvb2sgYXQgdGhlIHByb3RvdHlwZSBjaGFpbikuIFRo aXMgcGF0Y2ggY2xlYXJzIHVwIHRoZSBjb2RlIHRvIG1ha2UgaXQKKyAgICAgICAgY2xlYXJlciB3 aGF0IHRoZSBpbnZhcmlhbnRzIGFyZS4KKyAgICAgICAgCisgICAgICAgIFdpdGggcmVzcGVjdCB0 byB0aGUgb3JpZ2luYWwgZml4IGFib3V0IG5vdCBlbWl0dGluZyBhIFB1dEJ5T2Zmc2V0IGZvciBh CisgICAgICAgIFJlcGxhY2Ugb24gYSBTdHJ1Y3R1cmUgdGhhdCBoYXMgYW4gdW5maXJlZCByZXBs YWNlbWVudCB3YXRjaHBvaW50IHNldCwKKyAgICAgICAgdGhhdCB3YXMgYWxyZWFkeSBoYW5kbGVk IGJ5IHRoZSBQdXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yIHZhcmlhbnQgd2UncmUKKyAgICAgICAg Y2FsbGluZyBpbnNpZGUgb2YgY29uc3RhbnQgZm9sZGluZy4gSXQgd2lsbCByZXR1cm4gVGFrZXNT bG93UGF0aGlmIGl0CisgICAgICAgIGVuY291bnRlcnMgYSBSZXBsYWNlIHdoZXJlIHRoZSBTdHJ1 Y3R1cmUgc3RpbGwgaGFzIGFuIHVuZmlyZWQgd2F0Y2hwb2ludC4KKworICAgICAgICAqIGRmZy9E RkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Q29uc3RhbnRG b2xkaW5nUGhhc2U6OnRyeUZvbGRBc1B1dEJ5T2Zmc2V0KToKKwogMjAyMS0wMy0yMyAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFVzZSBFcnJvcklu c3RhbmNlIGZvciBBZ2dyZWdhdGVFcnJvcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAJKHJldmlzaW9uIDI3NDg0 MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDE5LDI4ICsxNDE5LDIyIEBAIHByaXZhdGU6CiAgICAg ICAgIFJlZ2lzdGVyZWRTdHJ1Y3R1cmVTZXQgbmV3U2V0OwogICAgICAgICBUcmFuc2l0aW9uVmVj dG9yIHRyYW5zaXRpb25zOwogICAgICAgICBmb3IgKGNvbnN0IFB1dEJ5SWRWYXJpYW50JiB2YXJp YW50IDogc3RhdHVzLnZhcmlhbnRzKCkpIHsKLSAgICAgICAgICAgIGZvciAoY29uc3QgT2JqZWN0 UHJvcGVydHlDb25kaXRpb24mIGNvbmRpdGlvbiA6IHZhcmlhbnQuY29uZGl0aW9uU2V0KCkpIHsK LSAgICAgICAgICAgICAgICBpZiAobV9ncmFwaC53YXRjaENvbmRpdGlvbihjb25kaXRpb24pKQot ICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICAgICAgICAgIFN0cnVjdHVy ZSogc3RydWN0dXJlID0gY29uZGl0aW9uLm9iamVjdCgpLT5zdHJ1Y3R1cmUobV9ncmFwaC5tX3Zt KTsKLSAgICAgICAgICAgICAgICBpZiAoIWNvbmRpdGlvbi5zdHJ1Y3R1cmVFbnN1cmVzVmFsaWRp dHkoc3RydWN0dXJlKSkKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAg ICAgICAgaWYgKHZhcmlhbnQua2luZCgpID09IFB1dEJ5SWRWYXJpYW50OjpSZXBsYWNlKSB7Ci0g ICAgICAgICAgICAgICAgICAgIGF1dG8qIHdhdGNocG9pbnRzID0gc3RydWN0dXJlLT5wcm9wZXJ0 eVJlcGxhY2VtZW50V2F0Y2hwb2ludFNldChjb25kaXRpb24ub2Zmc2V0KCkpOwotICAgICAgICAg ICAgICAgICAgICBpZiAoIXdhdGNocG9pbnRzIHx8IHdhdGNocG9pbnRzLT5pc1N0aWxsVmFsaWQo KSkKKyAgICAgICAgICAgIGlmICh2YXJpYW50LmtpbmQoKSA9PSBQdXRCeUlkVmFyaWFudDo6VHJh bnNpdGlvbikgeworICAgICAgICAgICAgICAgIGZvciAoY29uc3QgT2JqZWN0UHJvcGVydHlDb25k aXRpb24mIGNvbmRpdGlvbiA6IHZhcmlhbnQuY29uZGl0aW9uU2V0KCkpIHsKKyAgICAgICAgICAg ICAgICAgICAgaWYgKG1fZ3JhcGgud2F0Y2hDb25kaXRpb24oY29uZGl0aW9uKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgICAgICAgICAgICAgIFN0cnVjdHVy ZSogc3RydWN0dXJlID0gY29uZGl0aW9uLm9iamVjdCgpLT5zdHJ1Y3R1cmUobV9ncmFwaC5tX3Zt KTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCFjb25kaXRpb24uc3RydWN0dXJlRW5zdXJlc1Zh bGlkaXR5KHN0cnVjdHVyZSkpCiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAg ICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9k ZSgKLSAgICAgICAgICAgICAgICAgICAgaW5kZXhJbkJsb2NrLCBTcGVjTm9uZSwgQ2hlY2tTdHJ1 Y3R1cmUsIG5vZGUtPm9yaWdpbiwKLSAgICAgICAgICAgICAgICAgICAgT3BJbmZvKG1fZ3JhcGgu YWRkU3RydWN0dXJlU2V0KHN0cnVjdHVyZSkpLAotICAgICAgICAgICAgICAgICAgICBtX2luc2Vy dGlvblNldC5pbnNlcnRDb25zdGFudEZvclVzZSgKLSAgICAgICAgICAgICAgICAgICAgICAgIGlu ZGV4SW5CbG9jaywgbm9kZS0+b3JpZ2luLCBjb25kaXRpb24ub2JqZWN0KCksIEtub3duQ2VsbFVz ZSkpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5p bnNlcnROb2RlKAorICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXhJbkJsb2NrLCBTcGVjTm9u ZSwgQ2hlY2tTdHJ1Y3R1cmUsIG5vZGUtPm9yaWdpbiwKKyAgICAgICAgICAgICAgICAgICAgICAg IE9wSW5mbyhtX2dyYXBoLmFkZFN0cnVjdHVyZVNldChzdHJ1Y3R1cmUpKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0YW50Rm9yVXNlKAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGluZGV4SW5CbG9jaywgbm9kZS0+b3JpZ2luLCBjb25kaXRp b24ub2JqZWN0KCksIEtub3duQ2VsbFVzZSkpOworICAgICAgICAgICAgICAgIH0KIAotICAgICAg ICAgICAgaWYgKHZhcmlhbnQua2luZCgpID09IFB1dEJ5SWRWYXJpYW50OjpUcmFuc2l0aW9uKSB7 CiAgICAgICAgICAgICAgICAgQVNTRVJUKHByaXZhdGVGaWVsZFB1dEtpbmQuaXNOb25lKCkgfHwg cHJpdmF0ZUZpZWxkUHV0S2luZC5pc0RlZmluZSgpKTsKICAgICAgICAgICAgICAgICBSZWdpc3Rl cmVkU3RydWN0dXJlIG5ld1N0cnVjdHVyZSA9IG1fZ3JhcGgucmVnaXN0ZXJTdHJ1Y3R1cmUodmFy aWFudC5uZXdTdHJ1Y3R1cmUoKSk7CiAgICAgICAgICAgICAgICAgdHJhbnNpdGlvbnMuYXBwZW5k KApAQCAtMTQ1MCw2ICsxNDQ0LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgQVNTRVJUKHZhcmlhbnQua2luZCgpID09IFB1dEJ5SWRWYXJpYW50OjpS ZXBsYWNlKTsKICAgICAgICAgICAgICAgICBBU1NFUlQocHJpdmF0ZUZpZWxkUHV0S2luZC5pc05v bmUoKSB8fCBwcml2YXRlRmllbGRQdXRLaW5kLmlzU2V0KCkpOworICAgICAgICAgICAgICAgIERG R19BU1NFUlQobV9ncmFwaCwgbm9kZSwgdmFyaWFudC5jb25kaXRpb25TZXQoKS5pc0VtcHR5KCkp OwogICAgICAgICAgICAgICAgIG5ld1NldC5tZXJnZSgqbV9ncmFwaC5hZGRTdHJ1Y3R1cmVTZXQo dmFyaWFudC5vbGRTdHJ1Y3R1cmUoKSkpOwogICAgICAgICAgICAgfQogICAgICAgICB9Cg==