223614 2021-03-22 17:16:10 -0700 wtf/text/IntegerToStringConversion.h:54:104: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself 2021-03-23 09:55:20 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176131 InRadar P2 Normal --- 1 cdumez cdumez benjamin cmarcelo darin ddkilzer ews-watchlist ggaren sam webkit-bug-importer oldest_to_newest 1742591 0 cdumez 2021-03-22 17:16:10 -0700 numberToStringSigned() relies on undefined behavior and may return inaccurate results with inputs such as INT_MIN. 1742597 1 423967 cdumez 2021-03-22 17:21:06 -0700 Created attachment 423967 Patch 1742608 2 423972 cdumez 2021-03-22 17:39:38 -0700 Created attachment 423972 Patch 1742802 3 424020 cdumez 2021-03-23 08:32:06 -0700 Created attachment 424020 Patch 1742821 4 424020 darin 2021-03-23 09:01:34 -0700 Comment on attachment 424020 Patch I understand how this quiets the undefined behavior sanitizer, but I am sort of surprised that this actually avoids undefined behavior. I am surprised that the unary minus operation is defined so usefully on unsigned types. 1742824 5 cdumez 2021-03-23 09:04:53 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 424020 [details] > Patch > > I understand how this quiets the undefined behavior sanitizer, but I am sort > of surprised that this actually avoids undefined behavior. I am surprised > that the unary minus operation is defined so usefully on unsigned types. I followed the advice from UBSan: "cast to an unsigned type to negate this value to itself". 1742869 6 ews-feeder 2021-03-23 09:54:11 -0700 Committed r274878: <https://commits.webkit.org/r274878> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424020. 1742870 7 webkit-bug-importer 2021-03-23 09:55:20 -0700 <rdar://problem/75742118> 423967 2021-03-22 17:21:06 -0700 2021-03-22 17:39:36 -0700 Patch bug-223614-20210322172105.patch text/plain 4083 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMwODM3MGY4OTY0MzQ4NDA4OGNkZDIy ZGM2MDllYmFjZDAzODQ0MTYuLmM0ZGU0ZjZkYWM1MjBlN2Q4ZDIxMzRkMmRkYzYyZTdlN2Q0MzFm MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDMtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICB3dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9u Lmg6NTQ6MTA0OiBydW50aW1lIGVycm9yOiBuZWdhdGlvbiBvZiAtMjE0NzQ4MzY0OCBjYW5ub3Qg YmUgcmVwcmVzZW50ZWQgaW4gdHlwZSAnaW50JzsgY2FzdCB0byBhbiB1bnNpZ25lZCB0eXBlIHRv IG5lZ2F0ZSB0aGlzIHZhbHVlIHRvIGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgbnVtYmVyVG9TdHJpbmdTaWduZWQoKSB3YXMgY2FsbGluZyAt bnVtYmVyIHdoZW4gbnVtYmVyIGlzIG5lZ2F0aXZlLiBUaGlzIGNvdWxkIHRyaWdnZXIgdW5kZWZp bmVkIGJlaGF2aW9yCisgICAgICAgIHNpbmNlIC1udW1iZXIgbWF5IG5vdCBiZSByZXByZXNlbnRh YmxlIGluIHRoZSBpbnB1dCB0eXBlLiBGb3IgZXhhbXBsZSwgaWYgdGhlIHR5cGUgd2FzIGludCBh bmQgbnVtYmVyIHdhcworICAgICAgICBJTlRfTUlOLCAtSU5UX01JTiB3b3VsZCBvdmVyZmxvdyBh bmQgdGhlIHJlc3VsdCB3b3VsZCBiZSB1bmRlZmluZWQuIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3 ZSBub3cgY2FzdAorICAgICAgICBudW1iZXIgdG8gdGhlIGRlc3RpbmF0aW9uICp1bnNpZ25lZCog dHlwZSAqYmVmb3JlKiBuZWdhdGluZyBpdC4KKworICAgICAgICAqIHd0Zi90ZXh0L0ludGVnZXJU b1N0cmluZ0NvbnZlcnNpb24uaDoKKyAgICAgICAgKFdURjo6bnVtYmVyVG9TdHJpbmdTaWduZWQp OgorCiAyMDIxLTAzLTIyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdW51c2VkIEpTIGFuZCBDU1MgZmlsZXMgb2YgbWVkaWEgY29udHJvbHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5o IGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5kZXgg Yzc1NDY2NzUyNTQwMWFkYWYwNTQ3NzY1MjhkZTM3MTY1MDFmMTNmNC4uMjJhY2VmY2M4YmJjZmZj MTMzMjA3NWE3ODZhYmM0YmUzZGI0ZmNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4 dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKQEAgLTUxLDcgKzUxLDcgQEAgdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgU2lnbmVkSW50ZWdlclR5cGU+CiBpbmxpbmUgdHlwZW5hbWUgSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvblRyYWl0PFQ+OjpSZXR1cm5UeXBlIG51bWJlclRvU3RyaW5n U2lnbmVkKFNpZ25lZEludGVnZXJUeXBlIG51bWJlciwgdHlwZW5hbWUgSW50ZWdlclRvU3RyaW5n Q29udmVyc2lvblRyYWl0PFQ+OjpBZGRpdGlvbmFsQXJndW1lbnRUeXBlKiBhZGRpdGlvbmFsQXJn dW1lbnQgPSBudWxscHRyKQogewogICAgIGlmIChudW1iZXIgPCAwKQotICAgICAgICByZXR1cm4g bnVtYmVyVG9TdHJpbmdJbXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25l ZEludGVnZXJUeXBlPiwgTmVnYXRpdmVOdW1iZXI+KC1udW1iZXIsIGFkZGl0aW9uYWxBcmd1bWVu dCk7CisgICAgICAgIHJldHVybiBudW1iZXJUb1N0cmluZ0ltcGw8VCwgdHlwZW5hbWUgc3RkOjpt YWtlX3Vuc2lnbmVkX3Q8U2lnbmVkSW50ZWdlclR5cGU+LCBOZWdhdGl2ZU51bWJlcj4oLXN0YXRp Y19jYXN0PHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPj4o bnVtYmVyKSwgYWRkaXRpb25hbEFyZ3VtZW50KTsKICAgICByZXR1cm4gbnVtYmVyVG9TdHJpbmdJ bXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPiwg UG9zaXRpdmVOdW1iZXI+KG51bWJlciwgYWRkaXRpb25hbEFyZ3VtZW50KTsKIH0KIApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGRjOGJlNzNhMGMz YjNlMTRlY2UxMDgwN2ViYmM5MTk4M2U4ZTNkZmMuLjU5ZWUwY2ViMTNiYjdiOGFmOGMxMTc0NTQ2 YTVhNTFhZjBhNmQ1MjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wMy0yMiAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgorCisgICAgICAgIHd0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNp b24uaDo1NDoxMDQ6IHJ1bnRpbWUgZXJyb3I6IG5lZ2F0aW9uIG9mIC0yMTQ3NDgzNjQ4IGNhbm5v dCBiZSByZXByZXNlbnRlZCBpbiB0eXBlICdpbnQnOyBjYXN0IHRvIGFuIHVuc2lnbmVkIHR5cGUg dG8gbmVnYXRlIHRoaXMgdmFsdWUgdG8gaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM2MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdCdWlsZGVyLmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIxLTAzLTIyICBEZXZpbiBSb3Vzc28gIDxkcm91c3Nv QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIEpTIGFuZCBDU1MgZmlsZXMgb2Yg bWVkaWEgY29udHJvbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1N0cmluZ0J1aWxkZXIuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5n QnVpbGRlci5jcHAKaW5kZXggZmE0YzU5YmM5MGQyNjQxYzVhYzFiZjA0Y2RiMzJlZTMxZDBhOWFh Yy4uZTZiNDRmMDdmNWE2ZGQ2MTUxOGEzMmE1ZGQ5M2RmZGU5YjRkNTc0MCAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKQEAgLTMwLDggKzMw LDEwIEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIldURlN0cmluZ1V0 aWxpdGllcy5oIgogCisjaW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbmNsdWRlICJX VEZTdHJpbmdVdGlsaXRpZXMuaCIKKyNpbmNsdWRlIDxzc3RyZWFtPgogI2luY2x1ZGUgPHd0Zi91 bmljb2RlL0NoYXJhY3Rlck5hbWVzLmg+CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKQEAg LTExOCw2ICsxMjAsMjAgQEAgVEVTVChTdHJpbmdCdWlsZGVyVGVzdCwgQXBwZW5kKQogICAgIH0K IH0KIAorVEVTVChTdHJpbmdCdWlsZGVyVGVzdCwgQXBwZW5kSW50TWluKQoreworICAgIGNvbnN0 ZXhwciBpbnQgaW50TWluID0gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptaW4oKTsKKyAgICBT dHJpbmdCdWlsZGVyIGJ1aWxkZXI7CisgICAgYnVpbGRlci5hcHBlbmROdW1iZXIoaW50TWluKTsK KworICAgIHN0ZDo6c3RyaW5nc3RyZWFtIHN0cmluZ1N0cmVhbTsKKyAgICBzdHJpbmdTdHJlYW0g PDwgaW50TWluOworICAgIHN0ZDo6c3RyaW5nIGV4cGVjdGVkU3RyaW5nOworICAgIHN0cmluZ1N0 cmVhbSA+PiBleHBlY3RlZFN0cmluZzsKKworICAgIGV4cGVjdEJ1aWxkZXJDb250ZW50KFN0cmlu ZyhleHBlY3RlZFN0cmluZy5jX3N0cigpKSwgYnVpbGRlcik7Cit9CisKIFRFU1QoU3RyaW5nQnVp bGRlclRlc3QsIFZhcmlhZGljQXBwZW5kKQogewogICAgIHsK 423972 2021-03-22 17:39:38 -0700 2021-03-23 08:32:04 -0700 Patch bug-223614-20210322173937.patch text/plain 5112 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMwODM3MGY4OTY0MzQ4NDA4OGNkZDIy ZGM2MDllYmFjZDAzODQ0MTYuLmM0ZGU0ZjZkYWM1MjBlN2Q4ZDIxMzRkMmRkYzYyZTdlN2Q0MzFm MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDMtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICB3dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9u Lmg6NTQ6MTA0OiBydW50aW1lIGVycm9yOiBuZWdhdGlvbiBvZiAtMjE0NzQ4MzY0OCBjYW5ub3Qg YmUgcmVwcmVzZW50ZWQgaW4gdHlwZSAnaW50JzsgY2FzdCB0byBhbiB1bnNpZ25lZCB0eXBlIHRv IG5lZ2F0ZSB0aGlzIHZhbHVlIHRvIGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgbnVtYmVyVG9TdHJpbmdTaWduZWQoKSB3YXMgY2FsbGluZyAt bnVtYmVyIHdoZW4gbnVtYmVyIGlzIG5lZ2F0aXZlLiBUaGlzIGNvdWxkIHRyaWdnZXIgdW5kZWZp bmVkIGJlaGF2aW9yCisgICAgICAgIHNpbmNlIC1udW1iZXIgbWF5IG5vdCBiZSByZXByZXNlbnRh YmxlIGluIHRoZSBpbnB1dCB0eXBlLiBGb3IgZXhhbXBsZSwgaWYgdGhlIHR5cGUgd2FzIGludCBh bmQgbnVtYmVyIHdhcworICAgICAgICBJTlRfTUlOLCAtSU5UX01JTiB3b3VsZCBvdmVyZmxvdyBh bmQgdGhlIHJlc3VsdCB3b3VsZCBiZSB1bmRlZmluZWQuIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3 ZSBub3cgY2FzdAorICAgICAgICBudW1iZXIgdG8gdGhlIGRlc3RpbmF0aW9uICp1bnNpZ25lZCog dHlwZSAqYmVmb3JlKiBuZWdhdGluZyBpdC4KKworICAgICAgICAqIHd0Zi90ZXh0L0ludGVnZXJU b1N0cmluZ0NvbnZlcnNpb24uaDoKKyAgICAgICAgKFdURjo6bnVtYmVyVG9TdHJpbmdTaWduZWQp OgorCiAyMDIxLTAzLTIyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdW51c2VkIEpTIGFuZCBDU1MgZmlsZXMgb2YgbWVkaWEgY29udHJvbHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5o IGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5kZXgg Yzc1NDY2NzUyNTQwMWFkYWYwNTQ3NzY1MjhkZTM3MTY1MDFmMTNmNC4uMjJhY2VmY2M4YmJjZmZj MTMzMjA3NWE3ODZhYmM0YmUzZGI0ZmNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4 dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKQEAgLTUxLDcgKzUxLDcgQEAgdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgU2lnbmVkSW50ZWdlclR5cGU+CiBpbmxpbmUgdHlwZW5hbWUgSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvblRyYWl0PFQ+OjpSZXR1cm5UeXBlIG51bWJlclRvU3RyaW5n U2lnbmVkKFNpZ25lZEludGVnZXJUeXBlIG51bWJlciwgdHlwZW5hbWUgSW50ZWdlclRvU3RyaW5n Q29udmVyc2lvblRyYWl0PFQ+OjpBZGRpdGlvbmFsQXJndW1lbnRUeXBlKiBhZGRpdGlvbmFsQXJn dW1lbnQgPSBudWxscHRyKQogewogICAgIGlmIChudW1iZXIgPCAwKQotICAgICAgICByZXR1cm4g bnVtYmVyVG9TdHJpbmdJbXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25l ZEludGVnZXJUeXBlPiwgTmVnYXRpdmVOdW1iZXI+KC1udW1iZXIsIGFkZGl0aW9uYWxBcmd1bWVu dCk7CisgICAgICAgIHJldHVybiBudW1iZXJUb1N0cmluZ0ltcGw8VCwgdHlwZW5hbWUgc3RkOjpt YWtlX3Vuc2lnbmVkX3Q8U2lnbmVkSW50ZWdlclR5cGU+LCBOZWdhdGl2ZU51bWJlcj4oLXN0YXRp Y19jYXN0PHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPj4o bnVtYmVyKSwgYWRkaXRpb25hbEFyZ3VtZW50KTsKICAgICByZXR1cm4gbnVtYmVyVG9TdHJpbmdJ bXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPiwg UG9zaXRpdmVOdW1iZXI+KG51bWJlciwgYWRkaXRpb25hbEFyZ3VtZW50KTsKIH0KIApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGRjOGJlNzNhMGMz YjNlMTRlY2UxMDgwN2ViYmM5MTk4M2U4ZTNkZmMuLjU5ZWUwY2ViMTNiYjdiOGFmOGMxMTc0NTQ2 YTVhNTFhZjBhNmQ1MjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wMy0yMiAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgorCisgICAgICAgIHd0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNp b24uaDo1NDoxMDQ6IHJ1bnRpbWUgZXJyb3I6IG5lZ2F0aW9uIG9mIC0yMTQ3NDgzNjQ4IGNhbm5v dCBiZSByZXByZXNlbnRlZCBpbiB0eXBlICdpbnQnOyBjYXN0IHRvIGFuIHVuc2lnbmVkIHR5cGUg dG8gbmVnYXRlIHRoaXMgdmFsdWUgdG8gaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM2MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdCdWlsZGVyLmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIxLTAzLTIyICBEZXZpbiBSb3Vzc28gIDxkcm91c3Nv QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIEpTIGFuZCBDU1MgZmlsZXMgb2Yg bWVkaWEgY29udHJvbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1N0cmluZ0J1aWxkZXIuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5n QnVpbGRlci5jcHAKaW5kZXggZmE0YzU5YmM5MGQyNjQxYzVhYzFiZjA0Y2RiMzJlZTMxZDBhOWFh Yy4uM2RiNjAzYmZkYjA3OWI2ZWUyMGI1NGIxNDhjNjE5YzFlOGExYmY2OSAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKQEAgLTMwLDggKzMw LDkgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiV1RGU3RyaW5nVXRp bGl0aWVzLmgiCiAKKyNpbmNsdWRlICJXVEZTdHJpbmdVdGlsaXRpZXMuaCIKKyNpbmNsdWRlIDxz c3RyZWFtPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rlck5hbWVzLmg+CiAKIG5hbWVz cGFjZSBUZXN0V2ViS2l0QVBJIHsKQEAgLTExOCw2ICsxMTksMjAgQEAgVEVTVChTdHJpbmdCdWls ZGVyVGVzdCwgQXBwZW5kKQogICAgIH0KIH0KIAorVEVTVChTdHJpbmdCdWlsZGVyVGVzdCwgQXBw ZW5kSW50TWluKQoreworICAgIGNvbnN0ZXhwciBpbnQgaW50TWluID0gc3RkOjpudW1lcmljX2xp bWl0czxpbnQ+OjptaW4oKTsKKyAgICBTdHJpbmdCdWlsZGVyIGJ1aWxkZXI7CisgICAgYnVpbGRl ci5hcHBlbmROdW1iZXIoaW50TWluKTsKKworICAgIHN0ZDo6c3RyaW5nc3RyZWFtIHN0cmluZ1N0 cmVhbTsKKyAgICBzdHJpbmdTdHJlYW0gPDwgaW50TWluOworICAgIHN0ZDo6c3RyaW5nIGV4cGVj dGVkU3RyaW5nOworICAgIHN0cmluZ1N0cmVhbSA+PiBleHBlY3RlZFN0cmluZzsKKworICAgIGV4 cGVjdEJ1aWxkZXJDb250ZW50KFN0cmluZyhleHBlY3RlZFN0cmluZy5jX3N0cigpKSwgYnVpbGRl cik7Cit9CisKIFRFU1QoU3RyaW5nQnVpbGRlclRlc3QsIFZhcmlhZGljQXBwZW5kKQogewogICAg IHsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5j cHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwCmluZGV4IDYx ZDI4MGU5YWM3OTVkYzFiMGM3MmU0NzMzMDgwYjg2MjY3YmFiZTUuLjM3MDliZDcyOGY1YjhjOWFl NGRiMzczYjI2MzdlOWY1NTIzN2JlMjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL1dURlN0cmluZy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X VEYvV1RGU3RyaW5nLmNwcApAQCAtMjUsOCArMjUsMTAgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5o IgogCisjaW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbmNsdWRlICJXVEZTdHJpbmdV dGlsaXRpZXMuaCIKICNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8c3N0cmVhbT4KICNpbmNs dWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNp bmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTIyNiw2ICsyMjgsMTkgQEAgVEVTVChX VEYsIFN0cmluZ051bWJlcikKICAgICBFWFBFQ1RfU1RSRVEoIjEuMWUrMzAiLCB0ZXN0U3RyaW5n TnVtYmVyKDEuMWUzMCkpOwogfQogCitURVNUKFdURiwgU3RyaW5nTnVtYmVySW50TWluKQorewor ICAgIGNvbnN0ZXhwciBpbnQgaW50TWluID0gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptaW4o KTsKKyAgICBTdHJpbmcgcmVzdWx0ID0gU3RyaW5nOjpudW1iZXIoaW50TWluKTsKKworICAgIHN0 ZDo6c3RyaW5nc3RyZWFtIHN0cmluZ1N0cmVhbTsKKyAgICBzdHJpbmdTdHJlYW0gPDwgaW50TWlu OworICAgIHN0ZDo6c3RyaW5nIGV4cGVjdGVkU3RyaW5nOworICAgIHN0cmluZ1N0cmVhbSA+PiBl eHBlY3RlZFN0cmluZzsKKworICAgIEVYUEVDVF9UUlVFKHJlc3VsdCA9PSBTdHJpbmcoZXhwZWN0 ZWRTdHJpbmcuY19zdHIoKSkpOworfQorCiBURVNUKFdURiwgU3RyaW5nUmVwbGFjZVdpdGhMaXRl cmFsKQogewogICAgIC8vIENhc2VzIGZvciA4Qml0IHNvdXJjZS4K 424020 2021-03-23 08:32:06 -0700 2021-03-23 09:54:12 -0700 Patch bug-223614-20210323083205.patch text/plain 5067 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGMwODM3MGY4OTY0MzQ4NDA4OGNkZDIy ZGM2MDllYmFjZDAzODQ0MTYuLjc5OTI5NjY0MjNjNzk0NWYxOTY0YmNiZmIzYjU4OTk3OGI3ZGI5 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDMtMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICB3dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9u Lmg6NTQ6MTA0OiBydW50aW1lIGVycm9yOiBuZWdhdGlvbiBvZiAtMjE0NzQ4MzY0OCBjYW5ub3Qg YmUgcmVwcmVzZW50ZWQgaW4gdHlwZSAnaW50JzsgY2FzdCB0byBhbiB1bnNpZ25lZCB0eXBlIHRv IG5lZ2F0ZSB0aGlzIHZhbHVlIHRvIGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgbnVtYmVyVG9TdHJpbmdTaWduZWQoKSB3YXMgY2FsbGluZyAt bnVtYmVyIHdoZW4gbnVtYmVyIGlzIG5lZ2F0aXZlLiBUaGlzIGNvdWxkIHRyaWdnZXIgdW5kZWZp bmVkIGJlaGF2aW9yCisgICAgICAgIHNpbmNlIC1udW1iZXIgbWF5IG5vdCBiZSByZXByZXNlbnRh YmxlIGluIHRoZSBpbnB1dCB0eXBlLiBGb3IgZXhhbXBsZSwgaWYgdGhlIHR5cGUgd2FzIGludCBh bmQgbnVtYmVyIHdhcworICAgICAgICBJTlRfTUlOLCAtSU5UX01JTiB3b3VsZCBvdmVyZmxvdyBh bmQgdGhlIHJlc3VsdCB3b3VsZCBiZSB1bmRlZmluZWQuIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3 ZSBub3cgY2FzdAorICAgICAgICBudW1iZXIgdG8gdGhlIGRlc3RpbmF0aW9uICp1bnNpZ25lZCog dHlwZSAqYmVmb3JlKiBuZWdhdGluZyBpdC4KKworICAgICAgICAqIHd0Zi90ZXh0L0ludGVnZXJU b1N0cmluZ0NvbnZlcnNpb24uaDoKKyAgICAgICAgKFdURjo6bnVtYmVyVG9TdHJpbmdTaWduZWQp OgorCiAyMDIxLTAzLTIyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdW51c2VkIEpTIGFuZCBDU1MgZmlsZXMgb2YgbWVkaWEgY29udHJvbHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5o IGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5kZXgg Yzc1NDY2NzUyNTQwMWFkYWYwNTQ3NzY1MjhkZTM3MTY1MDFmMTNmNC4uMjJhY2VmY2M4YmJjZmZj MTMzMjA3NWE3ODZhYmM0YmUzZGI0ZmNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4 dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKQEAgLTUxLDcgKzUxLDcgQEAgdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgU2lnbmVkSW50ZWdlclR5cGU+CiBpbmxpbmUgdHlwZW5hbWUgSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvblRyYWl0PFQ+OjpSZXR1cm5UeXBlIG51bWJlclRvU3RyaW5n U2lnbmVkKFNpZ25lZEludGVnZXJUeXBlIG51bWJlciwgdHlwZW5hbWUgSW50ZWdlclRvU3RyaW5n Q29udmVyc2lvblRyYWl0PFQ+OjpBZGRpdGlvbmFsQXJndW1lbnRUeXBlKiBhZGRpdGlvbmFsQXJn dW1lbnQgPSBudWxscHRyKQogewogICAgIGlmIChudW1iZXIgPCAwKQotICAgICAgICByZXR1cm4g bnVtYmVyVG9TdHJpbmdJbXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25l ZEludGVnZXJUeXBlPiwgTmVnYXRpdmVOdW1iZXI+KC1udW1iZXIsIGFkZGl0aW9uYWxBcmd1bWVu dCk7CisgICAgICAgIHJldHVybiBudW1iZXJUb1N0cmluZ0ltcGw8VCwgdHlwZW5hbWUgc3RkOjpt YWtlX3Vuc2lnbmVkX3Q8U2lnbmVkSW50ZWdlclR5cGU+LCBOZWdhdGl2ZU51bWJlcj4oLXN0YXRp Y19jYXN0PHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPj4o bnVtYmVyKSwgYWRkaXRpb25hbEFyZ3VtZW50KTsKICAgICByZXR1cm4gbnVtYmVyVG9TdHJpbmdJ bXBsPFQsIHR5cGVuYW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PFNpZ25lZEludGVnZXJUeXBlPiwg UG9zaXRpdmVOdW1iZXI+KG51bWJlciwgYWRkaXRpb25hbEFyZ3VtZW50KTsKIH0KIApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGViNzNiOGZiNmQw OTJhNDE2N2FkZTA1MGJiNzRhN2M3ZTAzM2M0NTUuLjU0N2EyMGQyMTc5ZDI4YmViZDQ4NmYyNGFl YjJkNTQ1MmQ0N2QwY2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wMy0yMyAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgorCisgICAgICAgIHd0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNp b24uaDo1NDoxMDQ6IHJ1bnRpbWUgZXJyb3I6IG5lZ2F0aW9uIG9mIC0yMTQ3NDgzNjQ4IGNhbm5v dCBiZSByZXByZXNlbnRlZCBpbiB0eXBlICdpbnQnOyBjYXN0IHRvIGFuIHVuc2lnbmVkIHR5cGUg dG8gbmVnYXRlIHRoaXMgdmFsdWUgdG8gaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM2MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdCdWlsZGVyLmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIxLTAzLTIyICBDYW1lcm9uIE1jQ29ybWFjayAgPGhl eWNhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG9yZGVyaW5nIG9mIG15IGVtYWlsIGFkZHJl c3NlcyBpbiBjb250cmlidXRvcnMuanNvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9TdHJpbmdCdWlsZGVyLmNwcAppbmRleCBmYTRjNTliYzkwZDI2NDFjNWFjMWJmMDRjZGIz MmVlMzFkMGE5YWFjLi4zZGI2MDNiZmRiMDc5YjZlZTIwYjU0YjE0OGM2MTljMWU4YTFiZjY5IDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdCdWlsZGVyLmNw cAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdCdWlsZGVyLmNwcApA QCAtMzAsOCArMzAsOSBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJX VEZTdHJpbmdVdGlsaXRpZXMuaCIKIAorI2luY2x1ZGUgIldURlN0cmluZ1V0aWxpdGllcy5oIgor I2luY2x1ZGUgPHNzdHJlYW0+CiAjaW5jbHVkZSA8d3RmL3VuaWNvZGUvQ2hhcmFjdGVyTmFtZXMu aD4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewpAQCAtMTE4LDYgKzExOSwyMCBAQCBURVNU KFN0cmluZ0J1aWxkZXJUZXN0LCBBcHBlbmQpCiAgICAgfQogfQogCitURVNUKFN0cmluZ0J1aWxk ZXJUZXN0LCBBcHBlbmRJbnRNaW4pCit7CisgICAgY29uc3RleHByIGludCBpbnRNaW4gPSBzdGQ6 Om51bWVyaWNfbGltaXRzPGludD46Om1pbigpOworICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsK KyAgICBidWlsZGVyLmFwcGVuZE51bWJlcihpbnRNaW4pOworCisgICAgc3RkOjpzdHJpbmdzdHJl YW0gc3RyaW5nU3RyZWFtOworICAgIHN0cmluZ1N0cmVhbSA8PCBpbnRNaW47CisgICAgc3RkOjpz dHJpbmcgZXhwZWN0ZWRTdHJpbmc7CisgICAgc3RyaW5nU3RyZWFtID4+IGV4cGVjdGVkU3RyaW5n OworCisgICAgZXhwZWN0QnVpbGRlckNvbnRlbnQoU3RyaW5nKGV4cGVjdGVkU3RyaW5nLmNfc3Ry KCkpLCBidWlsZGVyKTsKK30KKwogVEVTVChTdHJpbmdCdWlsZGVyVGVzdCwgVmFyaWFkaWNBcHBl bmQpCiB7CiAgICAgewpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv V1RGU3RyaW5nLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5j cHAKaW5kZXggNjFkMjgwZTlhYzc5NWRjMWIwYzcyZTQ3MzMwODBiODYyNjdiYWJlNS4uODA4YTY0 MzQ0MGQxNTAwYmI4ZThlOTIzZDQ4ZWE1YjQxMWRhMTIzNSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpbmNsdWRl ICJXVEZTdHJpbmdVdGlsaXRpZXMuaCIKICNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8c3N0 cmVhbT4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NT dHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTIyNiw2ICsyMjcs MTkgQEAgVEVTVChXVEYsIFN0cmluZ051bWJlcikKICAgICBFWFBFQ1RfU1RSRVEoIjEuMWUrMzAi LCB0ZXN0U3RyaW5nTnVtYmVyKDEuMWUzMCkpOwogfQogCitURVNUKFdURiwgU3RyaW5nTnVtYmVy SW50TWluKQoreworICAgIGNvbnN0ZXhwciBpbnQgaW50TWluID0gc3RkOjpudW1lcmljX2xpbWl0 czxpbnQ+OjptaW4oKTsKKyAgICBTdHJpbmcgcmVzdWx0ID0gU3RyaW5nOjpudW1iZXIoaW50TWlu KTsKKworICAgIHN0ZDo6c3RyaW5nc3RyZWFtIHN0cmluZ1N0cmVhbTsKKyAgICBzdHJpbmdTdHJl YW0gPDwgaW50TWluOworICAgIHN0ZDo6c3RyaW5nIGV4cGVjdGVkU3RyaW5nOworICAgIHN0cmlu Z1N0cmVhbSA+PiBleHBlY3RlZFN0cmluZzsKKworICAgIEVYUEVDVF9UUlVFKHJlc3VsdCA9PSBT dHJpbmcoZXhwZWN0ZWRTdHJpbmcuY19zdHIoKSkpOworfQorCiBURVNUKFdURiwgU3RyaW5nUmVw bGFjZVdpdGhMaXRlcmFsKQogewogICAgIC8vIENhc2VzIGZvciA4Qml0IHNvdXJjZS4K