223611 2021-03-22 16:16:40 -0700 [webkitscmpy] Base GitHub mock links on provided remote 2021-03-22 17:47:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221860 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu webkit-bug-importer oldest_to_newest 1742542 0 jbedard 2021-03-22 16:16:40 -0700 Mock links in GitHub responses should be based on the remote provided. 1742543 1 webkit-bug-importer 2021-03-22 16:16:51 -0700 <rdar://problem/75713760> 1742546 2 423958 jbedard 2021-03-22 16:20:44 -0700 Created attachment 423958 Patch 1742562 3 423958 aakash_jain 2021-03-22 16:34:15 -0700 Comment on attachment 423958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 > + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' now that project contains complete url (starting from github.example.com), should the src still start with /? 1742565 4 423958 jbedard 2021-03-22 16:37:21 -0700 Comment on attachment 423958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 >> + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' > > now that project contains complete url (starting from github.example.com), should the src still start with /? That's why line 229 does "self.remote.split('/')[1:]", we don't want the github.example.com bit, just the team name/repository name 1742613 5 ews-feeder 2021-03-22 17:47:28 -0700 Committed r274830: <https://commits.webkit.org/r274830> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423958. 423958 2021-03-22 16:20:44 -0700 2021-03-22 17:47:28 -0700 Patch bug-223611-20210322162043.patch text/plain 4881 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDgxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIxLTAzLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIEJhc2UgR2l0SHViIG1vY2sgbGlua3Mgb24gcHJv dmlkZWQgcmVtb3RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjM2MTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1NzEzNzYwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0c2NtcHkvc2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRz L2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisg ICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3Mv cmVtb3RlL2dpdF9odWIucHk6CisgICAgICAgIChHaXRIdWIuX19pbml0X18pOiBTdGFuZGFyZGl6 ZSBtb2NrIEdpdEh1YiBwYXRoLgorICAgICAgICAoR2l0SHViLl9wYXJlbnRzX29mX3JlcXVlc3Qp OiBCYXNlIGxpbmsgcGF0aCBvbiBHaXRIdWIgcmVtb3RlLgorICAgICAgICAqIFNjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZ2l0X3VuaXR0ZXN0LnB5OgorICAg ICAgICAoVGVzdEdpdEh1Yik6CisKIDIwMjEtMDMtMjIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgSlMgYW5kIENTUyBmaWxlcyBvZiBt ZWRpYSBjb250cm9scwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv c2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2Nt cHkvc2V0dXAucHkJKHJldmlzaW9uIDI3NDgxMykKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVz L3dlYmtpdHNjbXB5L3NldHVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBAIGRl ZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0c2NtcHknLAotICAgIHZlcnNp b249JzAuMTMuNScsCisgICAgdmVyc2lvbj0nMC4xMy42JywKICAgICBkZXNjcmlwdGlvbj0nTGli cmFyeSBkZXNpZ25lZCB0byBpbnRlcmFjdCB3aXRoIGdpdCBhbmQgc3ZuIHJlcG9zaXRvcmllcy4n LAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCksCiAgICAgY2xhc3NpZmllcnM9WwpJbmRl eDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0 X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv d2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI3NDgxMykKKysrIFRvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CSh3b3JraW5n IGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoKICAgICAgICAgIlBs ZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBwaXAgaW5zdGFsbCB3ZWJraXRjb3JlcHkg LS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXggVVJMPmAiCiAgICAgKQogCi12ZXJzaW9u ID0gVmVyc2lvbigwLCAxMywgNSkKK3ZlcnNpb24gPSBWZXJzaW9uKDAsIDEzLCA2KQogCiBBdXRv SW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1LCAwKSkp CiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMnLCBWZXJzaW9uKDEsIDUp KSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5 L21vY2tzL3JlbW90ZS9naXRfaHViLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tzL3JlbW90ZS9naXRfaHViLnB5CShy ZXZpc2lvbiAyNzQ4MTMpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93 ZWJraXRzY21weS9tb2Nrcy9yZW1vdGUvZ2l0X2h1Yi5weQkod29ya2luZyBjb3B5KQpAQCAtMzIs NyArMzIsNyBAQCBjbGFzcyBHaXRIdWIobW9ja3MuUmVxdWVzdHMpOgogICAgIHRvcCA9IE5vbmUK IAogICAgIGRlZiBfX2luaXRfXygKLSAgICAgICAgc2VsZiwgcmVtb3RlPSdnaXRodWIuZXhhbXBs ZS5jb20vV2ViS2l0L3dlYmtpdCcsIGRhdGFmaWxlPU5vbmUsCisgICAgICAgIHNlbGYsIHJlbW90 ZT0nZ2l0aHViLmV4YW1wbGUuY29tL1dlYktpdC9XZWJLaXQnLCBkYXRhZmlsZT1Ob25lLAogICAg ICAgICBkZWZhdWx0X2JyYW5jaD0nbWFpbicsIGdpdF9zdm49RmFsc2UsCiAgICAgKToKICAgICAg ICAgaWYgbm90IHNjbXJlbW90ZS5HaXRIdWIuaXNfd2Vic2VydmVyKCdodHRwczovL3t9Jy5mb3Jt YXQocmVtb3RlKSk6CkBAIC0yMDgsMTEgKzIwOCwxMSBAQCBjbGFzcyBHaXRIdWIobW9ja3MuUmVx dWVzdHMpOgogICAgICAgICAgICAgJyAgICA8ZGl2IGNsYXNzPSJCb3gtaGVhZGVyIEJveC1oZWFk ZXItLWJsdWUgcG9zaXRpb24tcmVsYXRpdmUiPlxuJwogICAgICAgICAgICAgJyAgICAgICAgPGgy IGNsYXNzPSJzci1vbmx5Ij5MYXRlc3QgY29tbWl0PC9oMj5cbicKICAgICAgICAgICAgICcgICAg ICAgIDxkaXYgY2xhc3M9Ii4uLiIgZGF0YS1pc3N1ZS1hbmQtcHItaG92ZXJjYXJkcy1lbmFibGVk PlxuJwotICAgICAgICAgICAgJyAgICAgICAgICAgIDxpbmNsdWRlLWZyYWdtZW50IHNyYz0iL1dl YktpdC93ZWJraXQvdHJlZS1jb21taXQve3JlZn0iIGFyaWEtbGFiZWw9IkxvYWRpbmcgbGF0ZXN0 IGNvbW1pdCI+XG4nCisgICAgICAgICAgICAnICAgICAgICAgICAgPGluY2x1ZGUtZnJhZ21lbnQg c3JjPSIve3Byb2plY3R9L3RyZWUtY29tbWl0L3tyZWZ9IiBhcmlhLWxhYmVsPSJMb2FkaW5nIGxh dGVzdCBjb21taXQiPlxuJwogICAgICAgICAgICAgJyAgICAgICAgICAgIDwvaW5jbHVkZS1mcmFn bWVudD5cbicKICAgICAgICAgICAgICcgICAgICAgIDx1bCBjbGFzcz0ibGlzdC1zdHlsZS1ub25l IGQtZmxleCI+XG4nCiAgICAgICAgICAgICAnICAgICAgICAgICAgPGxpIGNsYXNzPSJtbC0wIG1s LW1kLTMiPlxuJwotICAgICAgICAgICAgJyAgICAgICAgICAgICAgICA8YSBkYXRhLXBqYXggaHJl Zj0iL1dlYktpdC93ZWJraXQvY29tbWl0cy97cmVmfSI+XG4nCisgICAgICAgICAgICAnICAgICAg ICAgICAgICAgIDxhIGRhdGEtcGpheCBocmVmPSIve3Byb2plY3R9L2NvbW1pdHMve3JlZn0iPlxu JwogICAgICAgICAgICAgJyAgICAgICAgICAgICAgICAgICAgPHN2ZyBjbGFzcz0ib2N0aWNvbiBv Y3RpY29uLWhpc3RvcnkgdGV4dC1ncmF5Ij48cGF0aD48L3BhdGg+PC9zdmc+XG4nCiAgICAgICAg ICAgICAnICAgICAgICAgICAgICAgICAgICA8c3BhbiBjbGFzcz0iZC1ub25lIGQtc20taW5saW5l Ij5cbicKICAgICAgICAgICAgICcgICAgICAgICAgICAgICAgICAgICAgICA8c3Ryb25nPntjb3Vu dH08L3N0cm9uZz5cbicKQEAgLTIyNiw2ICsyMjYsNyBAQCBjbGFzcyBHaXRIdWIobW9ja3MuUmVx dWVzdHMpOgogICAgICAgICAgICAgJzwvZGl2PlxuJwogICAgICAgICAgICAgJy4uLlxuJwogICAg ICAgICAgICAgJzwvaHRtbD5cbicuZm9ybWF0KAorICAgICAgICAgICAgICAgIHByb2plY3Q9Jy8n LmpvaW4oc2VsZi5yZW1vdGUuc3BsaXQoJy8nKVsxOl0pLAogICAgICAgICAgICAgICAgIHJlZj1j b21taXQuaGFzaCwKICAgICAgICAgICAgICAgICBjb3VudD1jb21taXQuaWRlbnRpZmllciArIChj b21taXQuYnJhbmNoX3BvaW50IG9yIDApLAogICAgICAgICAgICAgKSwgdXJsPXVybApJbmRleDog VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvdGVzdC9naXRf dW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvdGVzdC9naXRfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI3NDgxMykK KysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3Qv Z2l0X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yODUsNyArMjg1LDcgQEAgY2xhc3Mg VGVzdEdpdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKIAogY2xhc3MgVGVzdEdpdEh1Yih1bml0dGVz dC5UZXN0Q2FzZSk6Ci0gICAgcmVtb3RlID0gJ2h0dHBzOi8vZ2l0aHViLmV4YW1wbGUuY29tL1dl YktpdC93ZWJraXQnCisgICAgcmVtb3RlID0gJ2h0dHBzOi8vZ2l0aHViLmV4YW1wbGUuY29tL1dl YktpdC9XZWJLaXQnCiAKICAgICBkZWYgdGVzdF9kZXRlY3Rpb24oc2VsZik6CiAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwocmVtb3RlLkdpdEh1Yi5pc193ZWJzZXJ2ZXIoJ2h0dHBzOi8vZ2l0aHVi LmV4YW1wbGUuY29tL1dlYktpdC93ZWJraXQnKSwgVHJ1ZSkK