<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223604</bug_id>
          
          <creation_ts>2021-03-22 15:02:11 -0700</creation_ts>
          <short_desc>Distinction between m_webPageID and m_identifier in WebPageProxy is extremely unclear</short_desc>
          <delta_ts>2021-03-29 15:03:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1742493</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-03-22 15:02:11 -0700</bug_when>
    <thetext>WebPageProxy has two identifiers, m_webPageID and m_identifier in WebPageProxy is extremely unclear. There are no comments indicating how these are different, or how they should be used, and the names make them seem identical.

My understanding is that m_webPageID can mutate on process swap, so it should probably have a more clear name, like identifierOfCurrentWebPage, or something like that, and there should be documentation explaining this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1744940</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-29 15:03:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/75975008&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>