223581 2021-03-22 09:18:26 -0700 Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2681:9: runtime error: load of value nnn, which is not a valid value for type 'BOOL' (aka 'signed char') 2021-03-22 15:23:34 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176131 InRadar P2 Normal --- 1 cdumez cdumez darin ggaren kkinnunen simon.fraser thorton webkit-bug-importer oldest_to_newest 1742261 0 cdumez 2021-03-22 09:18:26 -0700 Fix bug found by UBSAN in WebViewImpl::pluginFocusOrWindowFocusChanged(). 1742262 1 423897 cdumez 2021-03-22 09:22:35 -0700 Created attachment 423897 Patch 1742273 2 423902 cdumez 2021-03-22 10:03:49 -0700 Created attachment 423902 Patch 1742413 3 ews-feeder 2021-03-22 13:15:10 -0700 Committed r274786: <https://commits.webkit.org/r274786> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423902. 1742414 4 webkit-bug-importer 2021-03-22 13:16:17 -0700 <rdar://problem/75705715> 1742515 5 423902 darin 2021-03-22 15:23:34 -0700 Comment on attachment 423902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423902&action=review > Source/WebKit/ChangeLog:10 > + The code was implicitly casting an uint64_t identifier into a BOOL variable. The intention was > + to check whether the identifier is 0 or not. To silence the UBSAN error, we now use the bool > + type instead of BOOL (since BOOL is defined as a signed char on some platforms). On platforms where BOOL is signed char, the original code will work wrong any time the low 8 bits of the pointer are zero! I feel like we are concentrating too much on "placating" UBSan and too little on fixing the bug UBSan found in our commentary. 423897 2021-03-22 09:22:35 -0700 2021-03-22 10:03:47 -0700 Patch bug-223581-20210322092234.patch text/plain 1979 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5Zjc3OTRjOTVlYjMwZWQ2 ZGU0ZDA0YjIzNDZiODI1NDkyZDczNzMuLmVlMWNhNWRjNDgyZjMzZjMyMjdjMzFjNGRlZmRmYjJj ZDEzZmViYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDMtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9XZWJWaWV3SW1wbC5tbToyNjgxOjk6IHJ1bnRpbWUgZXJyb3I6IGxvYWQgb2YgdmFs dWUgbm5uLCB3aGljaCBpcyBub3QgYSB2YWxpZCB2YWx1ZSBmb3IgdHlwZSAnQk9PTCcgKGFrYSAn c2lnbmVkIGNoYXInKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIzNTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIGNvZGUgd2FzIGltcGxpY2l0bHkgY2FzdGluZyBhbiB1aW50NjRfdCBpZGVudGlm aWVyIGludG8gYSBCT09MIHZhcmlhYmxlLiBUaGUgaW50ZW50aW9uIHdhcworICAgICAgICB0byBj aGVjayB3aGV0aGVyIHRoZSBpZGVudGlmaWVyIGlzIDAgb3Igbm90LiBUbyBzaWxlbmNlIHRoZSBV QlNBTiBlcnJvciwgd2Ugbm93IHVzZSB0aGUgYm9vbAorICAgICAgICB0eXBlIGluc3RlYWQgb2Yg Qk9PTCAoc2luY2UgQk9PTCBpcyBkZWZpbmVkIGFzIGEgc2lnbmVkIGNoYXIgb24gc29tZSBwbGF0 Zm9ybXMpLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6cGx1Z2luRm9jdXNPcldpbmRvd0ZvY3VzQ2hhbmdl ZCk6CisKIDIwMjEtMDMtMTkgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5j b20+CiAKICAgICAgICAgQ2Fubm90IGxvZ2luIHRvIG1pY3Jvc29mdG9ubGluZS5jb20gd2l0aG91 dCBhbGxvd2luZyBzdG9yYWdlIGFjY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9XZWJWaWV3SW1wbC5tbQppbmRleCBhMDc3NzNjYTk3NWJjNmU4MmMwNTYwMzgxZDQ2Mzg2NjU1 M2YwNDNkLi43ZDQ3YzhiMzA0MDg2OWEyMDkxOTk1OTAwMmMwZDE3NTU4ZTQzZjM2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMjY2MSw3ICsy NjYxLDcgQEAgYm9vbCBXZWJWaWV3SW1wbDo6dHJ5SGFuZGxlUGx1Z2luQ29tcGxleFRleHRJbnB1 dEtleURvd24oTlNFdmVudCAqZXZlbnQpCiB2b2lkIFdlYlZpZXdJbXBsOjpwbHVnaW5Gb2N1c09y V2luZG93Rm9jdXNDaGFuZ2VkKGJvb2wgcGx1Z2luSGFzRm9jdXNBbmRXaW5kb3dIYXNGb2N1cywg dWludDY0X3QgcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIpCiB7CiAgICAgQVNTRVJU KGhhc1Byb2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZpbGVnZTo6Q2FuQ29tbXVuaWNhdGVXaXRo V2luZG93U2VydmVyKSk7Ci0gICAgQk9PTCBpbnB1dFNvdXJjZUNoYW5nZWQgPSBtX3BsdWdpbkNv bXBsZXhUZXh0SW5wdXRJZGVudGlmaWVyOworICAgIGJvb2wgaW5wdXRTb3VyY2VDaGFuZ2VkID0g bV9wbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmllcjsKIAogICAgIGlmIChwbHVnaW5IYXNG b2N1c0FuZFdpbmRvd0hhc0ZvY3VzKSB7CiAgICAgICAgIC8vIENoZWNrIGlmIHdlJ3JlIGFscmVh ZHkgYWxsb3dpbmcgdGV4dCBpbnB1dCBmb3IgdGhpcyBwbHVnLWluLgo= 423902 2021-03-22 10:03:49 -0700 2021-03-22 13:15:11 -0700 Patch bug-223581-20210322100348.patch text/plain 1979 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5Zjc3OTRjOTVlYjMwZWQ2 ZGU0ZDA0YjIzNDZiODI1NDkyZDczNzMuLmFhN2MzNDA1NTUyMmUzMzA3NmE1OGExNjc3OTkxM2Ri ODNjYjYwN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDMtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9XZWJWaWV3SW1wbC5tbToyNjgxOjk6IHJ1bnRpbWUgZXJyb3I6IGxvYWQgb2YgdmFs dWUgbm5uLCB3aGljaCBpcyBub3QgYSB2YWxpZCB2YWx1ZSBmb3IgdHlwZSAnQk9PTCcgKGFrYSAn c2lnbmVkIGNoYXInKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIzNTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAg ICAgIFRoZSBjb2RlIHdhcyBpbXBsaWNpdGx5IGNhc3RpbmcgYW4gdWludDY0X3QgaWRlbnRpZmll ciBpbnRvIGEgQk9PTCB2YXJpYWJsZS4gVGhlIGludGVudGlvbiB3YXMKKyAgICAgICAgdG8gY2hl Y2sgd2hldGhlciB0aGUgaWRlbnRpZmllciBpcyAwIG9yIG5vdC4gVG8gc2lsZW5jZSB0aGUgVUJT QU4gZXJyb3IsIHdlIG5vdyB1c2UgdGhlIGJvb2wKKyAgICAgICAgdHlwZSBpbnN0ZWFkIG9mIEJP T0wgKHNpbmNlIEJPT0wgaXMgZGVmaW5lZCBhcyBhIHNpZ25lZCBjaGFyIG9uIHNvbWUgcGxhdGZv cm1zKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToKKyAgICAg ICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBsdWdpbkZvY3VzT3JXaW5kb3dGb2N1c0NoYW5nZWQp OgorCiAyMDIxLTAzLTE5ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgogCiAgICAgICAgIENhbm5vdCBsb2dpbiB0byBtaWNyb3NvZnRvbmxpbmUuY29tIHdpdGhvdXQg YWxsb3dpbmcgc3RvcmFnZSBhY2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V2ViVmlld0ltcGwubW0KaW5kZXggYTA3NzczY2E5NzViYzZlODJjMDU2MDM4MWQ0NjM4NjY1NTNm MDQzZC4uNjMzM2U3ZmI1YzMzNGJlZmFmZjQxZjQwMzYxOTMyMzczN2YzYjBhZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KQEAgLTI2NjEsNyArMjY2 MSw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OnRyeUhhbmRsZVBsdWdpbkNvbXBsZXhUZXh0SW5wdXRL ZXlEb3duKE5TRXZlbnQgKmV2ZW50KQogdm9pZCBXZWJWaWV3SW1wbDo6cGx1Z2luRm9jdXNPcldp bmRvd0ZvY3VzQ2hhbmdlZChib29sIHBsdWdpbkhhc0ZvY3VzQW5kV2luZG93SGFzRm9jdXMsIHVp bnQ2NF90IHBsdWdpbkNvbXBsZXhUZXh0SW5wdXRJZGVudGlmaWVyKQogewogICAgIEFTU0VSVCho YXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0aFdp bmRvd1NlcnZlcikpOwotICAgIEJPT0wgaW5wdXRTb3VyY2VDaGFuZ2VkID0gbV9wbHVnaW5Db21w bGV4VGV4dElucHV0SWRlbnRpZmllcjsKKyAgICBib29sIGlucHV0U291cmNlQ2hhbmdlZCA9ICEh bV9wbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmllcjsKIAogICAgIGlmIChwbHVnaW5IYXNG b2N1c0FuZFdpbmRvd0hhc0ZvY3VzKSB7CiAgICAgICAgIC8vIENoZWNrIGlmIHdlJ3JlIGFscmVh ZHkgYWxsb3dpbmcgdGV4dCBpbnB1dCBmb3IgdGhpcyBwbHVnLWluLgo=