223573 2021-03-22 06:24:25 -0700 RealtimeMediaSource does not need to be a WeakPtr 2021-03-22 13:30:24 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1742208 0 youennf 2021-03-22 06:24:25 -0700 RealtimeMediaSource does not need to be a WeakPtr 1742210 1 youennf 2021-03-22 06:24:51 -0700 <rdar://75583258> 1742211 2 423876 youennf 2021-03-22 06:26:17 -0700 Created attachment 423876 Patch 1742435 3 ews-feeder 2021-03-22 13:30:22 -0700 Committed r274789: <https://commits.webkit.org/r274789> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423876. 423876 2021-03-22 06:26:17 -0700 2021-03-22 13:30:23 -0700 Patch bug-223573-20210322142616.patch text/plain 6384 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI5NDgxMWU5ZmQ1MTYw YTQ3OTE2NzY3ZGQ4Zjk3ZWNjZjM3YjE2YS4uMjlmYjRiMTBkMDA0NWU2NDRhNjM4NDYxMzk2ODE2 YzQ4Yjg3NWJjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAzLTIyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU1lZGlhU291 cmNlIGRvZXMgbm90IG5lZWQgdG8gYmUgYSBXZWFrUHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM1NzMKKyAgICAgICAgPHJkYXI6Ly83NTU4MzI1 OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgdXNlIG9mIFdlYWtQdHIgYW5kIHJlZiB0aGUgc291cmNlIGluc3RlYWQuCisgICAgICAgIENv dmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVh bS9SZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVh bHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlOjpPbkNoYW5nZWQpOgorICAgICAgICAqIHBsYXRmb3Jt L21lZGlhc3RyZWFtL1JlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZWFsdGltZUluY29taW5nVmlkZW9Tb3VyY2U6Ok9uQ2hhbmdlZCk6CisgICAgICAg ICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZWFsdGltZU1lZGlhU291cmNlOjp1cGRhdGVIYXNTdGFydGVkUHJvZHVjaW5n RGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJj ZS5oOgorCiAyMDIxLTAzLTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBObyBhdWRpbyBvdXRwdXQgd2hlbiB1bnBsdWdnZWQgd2lyZWQgaGVhZHNldCBkdXJp bmcgYSBjYWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNkYWZiOWJjZTQ4MTVhZDJhNGQ0MGI4NTE0YWMyZjNmZDAy ZjNjZjEuLmU5MDEzN2YyY2VjMzlhMWU2M2QyZmE0OTY0Njc3ZGMzNzg2YjkxYTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDMtMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgorCisgICAgICAgIFJlYWx0aW1lTWVkaWFTb3VyY2UgZG9lcyBub3QgbmVlZCB0byBi ZSBhIFdlYWtQdHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyMzU3MworICAgICAgICA8cmRhcjovLzc1NTgzMjU4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1NwZWVjaFJlY29nbml0 aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZS5oOgorCiAyMDIxLTAzLTIyICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBObyBhdWRpbyBvdXRwdXQgd2hlbiB1 bnBsdWdnZWQgd2lyZWQgaGVhZHNldCBkdXJpbmcgYSBjYWxsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVJbmNvbWlu Z0F1ZGlvU291cmNlLmNwcAppbmRleCAwOGM1NzM5YzM4NGZkNDM1YmY1ZjI0NWI0Mjk0YjVhM2Yz MjY4OGZjLi5jMTk0ZWQ2NWZjODgxZTNkNTI1YTYyY2FjZjA3NWZmMDgwMWRmMjM1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZUluY29taW5n QXVkaW9Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZS5jcHAKQEAgLTY0LDEyICs2NCw5IEBAIHZvaWQg UmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlOjpzdG9wUHJvZHVjaW5nRGF0YSgpCiAKIHZvaWQg UmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlOjpPbkNoYW5nZWQoKQogewotICAgIGNhbGxPbk1h aW5UaHJlYWQoW3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIodGhpcyldIHsKLSAgICAgICAg aWYgKCF3ZWFrVGhpcykKLSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICBpZiAobV9hdWRp b1RyYWNrLT5zdGF0ZSgpID09IHdlYnJ0Yzo6TWVkaWFTdHJlYW1UcmFja0ludGVyZmFjZTo6a0Vu ZGVkKQotICAgICAgICAgICAgZW5kKCk7CisgICAgY2FsbE9uTWFpblRocmVhZChbcHJvdGVjdGVk VGhpcyA9IG1ha2VSZWYoKnRoaXMpXSB7CisgICAgICAgIGlmIChwcm90ZWN0ZWRUaGlzLT5tX2F1 ZGlvVHJhY2stPnN0YXRlKCkgPT0gd2VicnRjOjpNZWRpYVN0cmVhbVRyYWNrSW50ZXJmYWNlOjpr RW5kZWQpCisgICAgICAgICAgICBwcm90ZWN0ZWRUaGlzLT5lbmQoKTsKICAgICB9KTsKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVJ bmNvbWluZ1ZpZGVvU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL1JlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZS5jcHAKaW5kZXggYTk0Y2EzNTRlY2FmMDU1 N2Y1YWMwOGQ3OTVkZmQzZDBlMDAyNDk5Mi4uZTY0ZjYwZTA0ODAzOWUwNzVmNTlhZTJiZjM5MmQy YWU1OGI4ZmE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vUmVhbHRpbWVJbmNvbWluZ1ZpZGVvU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZUluY29taW5nVmlkZW9Tb3VyY2UuY3BwCkBAIC02 OCwxMiArNjgsOSBAQCB2b2lkIFJlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZTo6c3RvcFByb2R1 Y2luZ0RhdGEoKQogCiB2b2lkIFJlYWx0aW1lSW5jb21pbmdWaWRlb1NvdXJjZTo6T25DaGFuZ2Vk KCkKIHsKLSAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRy KHRoaXMpXSB7Ci0gICAgICAgIGlmICghd2Vha1RoaXMpCi0gICAgICAgICAgICByZXR1cm47Ci0K LSAgICAgICAgaWYgKG1fdmlkZW9UcmFjay0+c3RhdGUoKSA9PSB3ZWJydGM6Ok1lZGlhU3RyZWFt VHJhY2tJbnRlcmZhY2U6OmtFbmRlZCkKLSAgICAgICAgICAgIGVuZCgpOworICAgIGNhbGxPbk1h aW5UaHJlYWQoW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0geworICAgICAgICBpZiAo cHJvdGVjdGVkVGhpcy0+bV92aWRlb1RyYWNrLT5zdGF0ZSgpID09IHdlYnJ0Yzo6TWVkaWFTdHJl YW1UcmFja0ludGVyZmFjZTo6a0VuZGVkKQorICAgICAgICAgICAgcHJvdGVjdGVkVGhpcy0+ZW5k KCk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAKaW5kZXggZWJiMjI0M2MxMWJm MTMyMjUxNmY3ODEzMzAxYTNlZWJiMzA1MzdhZS4uMTIxNmJkNDkyMjM3YThjNTFjZjA4MzM3MTA0 Mjg3NjViOGNmZjRiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAKQEAgLTE3NSwxMyArMTc1LDEx IEBAIHZvaWQgUmVhbHRpbWVNZWRpYVNvdXJjZTo6dXBkYXRlSGFzU3RhcnRlZFByb2R1Y2luZ0Rh dGEoKQogICAgIGlmIChtX2hhc1N0YXJ0ZWRQcm9kdWNpbmdEYXRhKQogICAgICAgICByZXR1cm47 CiAKLSAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHRo aXMpXSB7Ci0gICAgICAgIGlmICghd2Vha1RoaXMpCisgICAgY2FsbE9uTWFpblRocmVhZChbcHJv dGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpXSB7CisgICAgICAgIGlmIChwcm90ZWN0ZWRUaGlz LT5tX2hhc1N0YXJ0ZWRQcm9kdWNpbmdEYXRhKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAg ICBpZiAobV9oYXNTdGFydGVkUHJvZHVjaW5nRGF0YSkKLSAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgbV9oYXNTdGFydGVkUHJvZHVjaW5nRGF0YSA9IHRydWU7Ci0gICAgICAgIGZvckVhY2hP YnNlcnZlcihbJl0oYXV0byYgb2JzZXJ2ZXIpIHsKKyAgICAgICAgcHJvdGVjdGVkVGhpcy0+bV9o YXNTdGFydGVkUHJvZHVjaW5nRGF0YSA9IHRydWU7CisgICAgICAgIHByb3RlY3RlZFRoaXMtPmZv ckVhY2hPYnNlcnZlcihbJl0oYXV0byYgb2JzZXJ2ZXIpIHsKICAgICAgICAgICAgIG9ic2VydmVy Lmhhc1N0YXJ0ZWRQcm9kdWNpbmdEYXRhKCk7CiAgICAgICAgIH0pOwogICAgIH0pOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNv dXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRp YVNvdXJjZS5oCmluZGV4IGE2Nzc0MjE3NDQ2NmI0ODMxODAyYjU0MjI1MWE2YjkwMzg0MGMxOTQu LjJjYzhiZThlZTI0NTc4NmI0MGM0MTY1ZmNmZjcyOGVkNjg2ZTk0YmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291 cmNlLmgKQEAgLTY5LDcgKzY5LDYgQEAgc3RydWN0IENhcHR1cmVTb3VyY2VPckVycm9yOwogCiBj bGFzcyBXRUJDT1JFX0VYUE9SVCBSZWFsdGltZU1lZGlhU291cmNlCiAgICAgOiBwdWJsaWMgVGhy ZWFkU2FmZVJlZkNvdW50ZWQ8UmVhbHRpbWVNZWRpYVNvdXJjZSwgV1RGOjpEZXN0cnVjdGlvblRo cmVhZDo6TWFpblJ1bkxvb3A+Ci0gICAgLCBwdWJsaWMgQ2FuTWFrZVdlYWtQdHI8UmVhbHRpbWVN ZWRpYVNvdXJjZSwgV2Vha1B0ckZhY3RvcnlJbml0aWFsaXphdGlvbjo6RWFnZXI+CiAjaWYgIVJF TEVBU0VfTE9HX0RJU0FCTEVECiAgICAgLCBwdWJsaWMgTG9nZ2VySGVscGVyCiAjZW5kaWYKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1NwZWVjaFJlY29nbml0aW9uUmVtb3Rl UmVhbHRpbWVNZWRpYVNvdXJjZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3BlZWNoUmVj b2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmgKaW5kZXggYTFlMjdhZDVmZDcwMzhl ZDJlZGVlYjMyYzE1YjUwOTEwZGFkNTFlMC4uNzhiZmU1YjY0YjIwZGQwOTAxYjk5YWE3M2MzNWM5 MDcwMjFkOWIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3BlZWNoUmVj b2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmgKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvU3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmgKQEAg LTQ2LDcgKzQ2LDcgQEAgY2xhc3MgV2ViQXVkaW9CdWZmZXJMaXN0OwogbmFtZXNwYWNlIFdlYktp dCB7CiBjbGFzcyBTcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2VNYW5h Z2VyOwogICAgIAotY2xhc3MgU3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291 cmNlIDogcHVibGljIFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2UgeworY2xhc3MgU3BlZWNo UmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlIDogcHVibGljIFdlYkNvcmU6OlJl YWx0aW1lTWVkaWFTb3VyY2UsIHB1YmxpYyBDYW5NYWtlV2Vha1B0cjxTcGVlY2hSZWNvZ25pdGlv blJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2U+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFdl YkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2U+IGNyZWF0ZShTcGVlY2hSZWNvZ25pdGlvblJlbW90 ZVJlYWx0aW1lTWVkaWFTb3VyY2VNYW5hZ2VyJiwgY29uc3QgV2ViQ29yZTo6Q2FwdHVyZURldmlj ZSYpOwogICAgIH5TcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2UoKTsK