223553 2021-03-20 03:35:09 -0700 [JSC] Intl.Locale should not assume is8Bit 2021-03-22 13:10:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1742003 0 ysuzuki 2021-03-20 03:35:09 -0700 [JSC] Intl.Locale should not assume is8Bit 1742004 1 423808 ysuzuki 2021-03-20 03:36:53 -0700 Created attachment 423808 Patch 1742038 2 423808 ross.kirsling 2021-03-20 17:01:06 -0700 Comment on attachment 423808 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review r=me. This comes as a shock to me, since we have in fact verified all the characters of these strings by this point. :( > Source/JavaScriptCore/runtime/IntlLocale.cpp:180 > + Vector<char, 32> rawValue; > + rawValue.resize(value.length() + 1); Is this different from using the constructor param? 1742406 3 423808 ysuzuki 2021-03-22 13:05:53 -0700 Comment on attachment 423808 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review >> Source/JavaScriptCore/runtime/IntlLocale.cpp:180 >> + rawValue.resize(value.length() + 1); > > Is this different from using the constructor param? No. Changed :) 1742409 4 ysuzuki 2021-03-22 13:09:24 -0700 Committed r274784 (235588@main): <https://commits.webkit.org/235588@main> 1742410 5 webkit-bug-importer 2021-03-22 13:10:24 -0700 <rdar://problem/75705456> 423808 2021-03-20 03:36:53 -0700 2021-03-20 17:01:06 -0700 Patch bug-223553-20210320033652.patch text/plain 4627 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx M2Y0YWE4ZTI0OGU2OGE2ZWRhYzQ3YjNiY2MyODcyZmEwY2MyNjdjLi5lNDlkMjZjOWEyZDViODhi M2U0MjQ4YTNhMTAyYWE3NmYzNjJlYTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wMy0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEludGwuTG9jYWxlIHNob3VsZCBub3QgYXNzdW1lIGlzOEJpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNTUzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaXM4Qml0IG9y IG5vdCBpcyBub3QgZ3VhcmFudGVlZCBpZiBpdCBpcyBhbiB1c2VyLWlucHV0LiBGb3IgZXhhbXBs ZSwgInRlc3Tml6XmnKzoqp4iLnN1YnN0cmluZygwLCAzKSBzaG91bGQgYmUgbm9uIDhCaXQgc3Ry aW5nLgorICAgICAgICBJbnRsLkxvY2FsZSBoYXMgc2V2ZXJhbCBwbGFjZXMgdGhhdCBhc3N1bWVk IHRoYXQgaW5wdXQgc2hvdWxkIGJlIDhCaXQgaWYgdGhleSBhcmUgQVNDSUkuIFRoaXMgcGF0Y2gg Zml4ZXMgaXQuCisKKyAgICAgICAgKiBydW50aW1lL0ludGxMb2NhbGUuY3BwOgorICAgICAgICAo SlNDOjpMb2NhbGVJREJ1aWxkZXI6Om92ZXJyaWRlTGFuZ3VhZ2VTY3JpcHRSZWdpb24pOgorICAg ICAgICAoSlNDOjpMb2NhbGVJREJ1aWxkZXI6OnNldEtleXdvcmRWYWx1ZSk6CisKIDIwMjEtMDMt MTkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEJyYW5kZWRTdHJ1 Y3R1cmUgc2hvdWxkIGtlZXAgaXRzIG1lbWJlcnMgYWxpdmUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsTG9jYWxlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0ludGxMb2NhbGUuY3BwCmluZGV4IGM1Zjg5YjdmNDRiYmY2YTViYTg0NTM2 NGE5MjViMTY2ZDNiMWY1ZDcuLmJiMDEwOTBkNzI5OGY1NmI5MjgzMjI0OWEzZmZjNDNmNzE1NDRj OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxMb2NhbGUu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxMb2NhbGUuY3BwCkBA IC0xNTAsMTUgKzE1MCwyMSBAQCB2b2lkIExvY2FsZUlEQnVpbGRlcjo6b3ZlcnJpZGVMYW5ndWFn ZVNjcmlwdFJlZ2lvbihTdHJpbmdWaWV3IGxhbmd1YWdlLCBTdHJpbmdWaQogICAgICAgICBlbHNl CiAgICAgICAgICAgICBoYXNBcHBlbmRlZCA9IHRydWU7CiAKLSAgICAgICAgQVNTRVJUKHN1YnRh Zy5pczhCaXQoKSAmJiBzdWJ0YWcuaXNBbGxBU0NJSSgpKTsKLSAgICAgICAgYnVmZmVyLmFwcGVu ZChyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihzdWJ0YWcuY2hhcmFjdGVyczgoKSksIHN1 YnRhZy5sZW5ndGgoKSk7CisgICAgICAgIEFTU0VSVChzdWJ0YWcuaXNBbGxBU0NJSSgpKTsKKyAg ICAgICAgaWYgKHN1YnRhZy5pczhCaXQoKSkKKyAgICAgICAgICAgIGJ1ZmZlci5hcHBlbmQoc3Vi dGFnLmNoYXJhY3RlcnM4KCksIHN1YnRhZy5sZW5ndGgoKSk7CisgICAgICAgIGVsc2UKKyAgICAg ICAgICAgIGJ1ZmZlci5hcHBlbmQoc3VidGFnLmNoYXJhY3RlcnMxNigpLCBzdWJ0YWcubGVuZ3Ro KCkpOwogICAgIH0KIAogICAgIGlmIChlbmRPZkxhbmd1YWdlU2NyaXB0UmVnaW9uVmFyaWFudCAh PSBsZW5ndGgpIHsKICAgICAgICAgYXV0byByZXN0ID0gbG9jYWxlSURWaWV3LnJpZ2h0KGxlbmd0 aCAtIGVuZE9mTGFuZ3VhZ2VTY3JpcHRSZWdpb25WYXJpYW50KTsKIAotICAgICAgICBBU1NFUlQo cmVzdC5pczhCaXQoKSAmJiByZXN0LmlzQWxsQVNDSUkoKSk7Ci0gICAgICAgIGJ1ZmZlci5hcHBl bmQocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4ocmVzdC5jaGFyYWN0ZXJzOCgpKSwgcmVz dC5sZW5ndGgoKSk7CisgICAgICAgIEFTU0VSVChyZXN0LmlzQWxsQVNDSUkoKSk7CisgICAgICAg IGlmIChyZXN0LmlzOEJpdCgpKQorICAgICAgICAgICAgYnVmZmVyLmFwcGVuZChyZXN0LmNoYXJh Y3RlcnM4KCksIHJlc3QubGVuZ3RoKCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBidWZm ZXIuYXBwZW5kKHJlc3QuY2hhcmFjdGVyczE2KCksIHJlc3QubGVuZ3RoKCkpOwogICAgIH0KIAog ICAgIGJ1ZmZlci5hcHBlbmQoJ1wwJyk7CkBAIC0xNjksOCArMTc1LDE0IEBAIHZvaWQgTG9jYWxl SURCdWlsZGVyOjpzZXRLZXl3b3JkVmFsdWUoQVNDSUlMaXRlcmFsIGtleSwgU3RyaW5nVmlldyB2 YWx1ZSkKIHsKICAgICBBU1NFUlQobV9idWZmZXIuc2l6ZSgpKTsKIAotICAgIEFTU0VSVCh2YWx1 ZS5pczhCaXQoKSAmJiB2YWx1ZS5pc0FsbEFTQ0lJKCkpOwotICAgIENTdHJpbmcgcmF3VmFsdWUg eyByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPih2YWx1ZS5jaGFyYWN0ZXJzOCgpKSwgdmFs dWUubGVuZ3RoKCkgfTsKKyAgICBBU1NFUlQodmFsdWUuaXNBbGxBU0NJSSgpKTsKKyAgICBWZWN0 b3I8Y2hhciwgMzI+IHJhd1ZhbHVlOworICAgIHJhd1ZhbHVlLnJlc2l6ZSh2YWx1ZS5sZW5ndGgo KSArIDEpOworICAgIGlmICh2YWx1ZS5pczhCaXQoKSkKKyAgICAgICAgU3RyaW5nSW1wbDo6Y29w eUNoYXJhY3RlcnMocmVpbnRlcnByZXRfY2FzdDxMQ2hhcio+KHJhd1ZhbHVlLmRhdGEoKSksIHZh bHVlLmNoYXJhY3RlcnM4KCksIHZhbHVlLmxlbmd0aCgpKTsKKyAgICBlbHNlCisgICAgICAgIFN0 cmluZ0ltcGw6OmNvcHlDaGFyYWN0ZXJzKHJlaW50ZXJwcmV0X2Nhc3Q8TENoYXIqPihyYXdWYWx1 ZS5kYXRhKCkpLCB2YWx1ZS5jaGFyYWN0ZXJzMTYoKSwgdmFsdWUubGVuZ3RoKCkpOworICAgIHJh d1ZhbHVlW3ZhbHVlLmxlbmd0aCgpXSA9ICdcMCc7CiAKICAgICBVRXJyb3JDb2RlIHN0YXR1cyA9 IFVfWkVST19FUlJPUjsKICAgICBhdXRvIGxlbmd0aCA9IHVsb2Nfc2V0S2V5d29yZFZhbHVlKGtl eS5jaGFyYWN0ZXJzKCksIHJhd1ZhbHVlLmRhdGEoKSwgbV9idWZmZXIuZGF0YSgpLCBtX2J1ZmZl ci5zaXplKCksICZzdGF0dXMpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rl c3RzL0NoYW5nZUxvZwppbmRleCBlMTY1Zjg3NzA3NWM4M2VjYjIzZTJiZTk4ZmEyNWIyMTg5NWJj MzkwLi4zNzU2OTI1MDhiY2Q2OThkZDUzNTNkNWFiYWZlNzBjM2VjZGYzYTI4IDEwMDY0NAotLS0g YS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTAzLTIwICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAg ICAgICAgW0pTQ10gSW50bC5Mb2NhbGUgc2hvdWxkIG5vdCBhc3N1bWUgaXM4Qml0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM1NTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9pbnRsLWxv Y2FsZS1ub24tOGJpdC5qczogQWRkZWQuCisgICAgICAgIChzaG91bGRCZSk6CisKIDIwMjEtMDMt MTkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEJyYW5kZWRTdHJ1 Y3R1cmUgc2hvdWxkIGtlZXAgaXRzIG1lbWJlcnMgYWxpdmUuCmRpZmYgLS1naXQgYS9KU1Rlc3Rz L3N0cmVzcy9pbnRsLWxvY2FsZS1ub24tOGJpdC5qcyBiL0pTVGVzdHMvc3RyZXNzL2ludGwtbG9j YWxlLW5vbi04Yml0LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI4YWRmODAyZWQzOTgzOTI2NmFmNDk1ZGZlMWFm NjIxZTRhNDBmMjYKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9pbnRsLWxvY2Fs ZS1ub24tOGJpdC5qcwpAQCAtMCwwICsxLDE4IEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWws IGV4cGVjdGVkKSB7CisgICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93 IG5ldyBFcnJvcihgZXhwZWN0ZWQgJHtleHBlY3RlZH0gYnV0IGdvdCAke2FjdHVhbH1gKTsKK30K KworY29uc3Qgb3B0aW9ucyA9IHsKKyAgICBjYWxlbmRhcjogJ2J1ZGRoaXN0JywKKyAgICBjYXNl Rmlyc3Q6ICdsb3dlcicsCisgICAgY29sbGF0aW9uOiAnZW9y5pel5pys6KqeJy5zdWJzdHJpbmco MCwgMyksCisgICAgaG91ckN5Y2xlOiAnaDExJywKKyAgICBudW1lcmljOiBmYWxzZSwKKyAgICBu dW1iZXJpbmdTeXN0ZW06ICd0aGFpJywKKyAgICBsYW5ndWFnZTogJ2phJywKKyAgICBzY3JpcHQ6 ICdIYW50JywKKyAgICByZWdpb246ICdLUicKK307Citjb25zdCBleHBlY3RlZCA9ICdqYS1IYW50 LUtSLXUtY2EtYnVkZGhpc3QtY28tZW9yLWhjLWgxMS1rZi1sb3dlci1rbi1mYWxzZS1udS10aGFp JzsKK3Nob3VsZEJlKG5ldyBJbnRsLkxvY2FsZSgnZW4nLCBvcHRpb25zKS50b1N0cmluZygpLCBl eHBlY3RlZCk7Cg==