223532 2021-03-19 12:34:34 -0700 Uncaught Exception: RangeError: Array size is not a small enough positive integer. 2021-03-19 14:22:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED favorites:// InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1741842 0 bburg 2021-03-19 12:34:34 -0700 Uncaught Exception in Web Inspector. Steps to Reproduce: 1. Timelines Tab > Start Recording 2. Export / Save Recording 3. Load saved recording 4. Select CPU instrument => uncaught exception Uncaught Exceptions: ----------------------- - RangeError: Array size is not a small enough positive integer. (at CPUTimelineView.js:1274:32) _computeStatisticsData @ CPUTimelineView.js:1274:32 layout @ CPUTimelineView.js:459:59 _layoutSubtree @ View.js:293:20 updateLayout @ View.js:159:28 showTimelineViewForTimeline @ TimelineRecordingContentView.js:153:37 _timelineSelected @ TimelineRecordingContentView.js:799:45 dispatch @ Object.js:129:35 dispatchEventToListeners @ Object.js:137:17 _timelinesTreeSelectionDidChange @ TimelineOverview.js:896:38 dispatch @ Object.js:129:35 dispatchEventToListeners @ Object.js:137:17 _dispatchSelectionDidChangeEvent @ TreeOutline.js:1083:38 selectionControllerSelectionDidChange @ TreeOutline.js:755:46 _updateSelectedItems @ SelectionController.js:458:65 selectItem @ SelectionController.js:155:34 handleItemMouseDown @ SelectionController.js:322:28 _handleMouseDown @ TreeOutline.js:1067:54 _handleMouseDown @ [native code] ----------------------- Notes: Inspected URL: favorites:// Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) 1741844 1 bburg 2021-03-19 12:39:02 -0700 Relevant code: let millisecondStartTime = Math.round(startTime * 1000); let millisecondEndTime = Math.round(endTime * 1000); let millisecondDuration = millisecondEndTime - millisecondStartTime; let samples = new Array(millisecondDuration); For some reason `endTime` is 0 here, so the overall duration is negative and the Array constructor throws. 1741876 2 webkit-bug-importer 2021-03-19 13:55:19 -0700 <rdar://problem/75635080> 1741887 3 423776 bburg 2021-03-19 14:12:03 -0700 Created attachment 423776 Patch v1.0 1741888 4 423776 hi 2021-03-19 14:14:44 -0700 Comment on attachment 423776 Patch v1.0 rs=me 1741892 5 bburg 2021-03-19 14:22:17 -0700 Committed r274737 (235555@main): <https://commits.webkit.org/235555@main> 423776 2021-03-19 14:12:03 -0700 2021-03-19 14:17:50 -0700 Patch v1.0 bug-223532-20210319141202.patch text/plain 2386 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw NTgwMzM4NTg3MDAyMWNiZTlkMjhmOGJjNTEzZTIyNzE1ODA4NDk3Li42MTU3Y2EzZjUyZmEzNTZl ZWI3OTY4ZjRmNDExZjI3OWE0ODJjOTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEg KzEsMjMgQEAKKzIwMjEtMDMtMTkgIEJKIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAg ICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBSYW5nZUVycm9yOiBBcnJheSBzaXplIGlzIG5vdCBhIHNt YWxsIGVub3VnaCBwb3NpdGl2ZSBpbnRlZ2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNTMyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTYz NTA4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGZpeGVzIHRoZSBicm9rZW4gQ1BVIGluc3RydW1lbnQgd2hlbiB2aWV3aW5nIGEg SlNPTiB0aW1lbGluZSByZWNvcmRuZy4KKworICAgICAgICBUaGlzIGV4Y2VwdGlvbiBpcyB0aHJv d24gd2hlbiB2aWV3aW5nIGEgdGltZWxpbmUgcmVjb3JkaW5nIHRoYXQgaGFzIGJlZW4KKyAgICAg ICAgaW1wb3J0ZWQgZnJvbSBKU09OIGZpbGUuIEFzaWRlIGZyb20gdGhlIGV4Y2VwdGlvbiwgdGhl IGNvZGUgaXMgZnVuY3Rpb25hbGx5CisgICAgICAgIGJyb2tlbiBpbiB0aGlzIHNpdHVhdGlvbiBz aW5jZSBwYXNzaW5nIGEgbmVnYXRpdmUgbnVtYmVyIHRvIEFycmF5KCkgZG9lc24ndCB3b3JrLgor CisgICAgICAgIEkgdGVzdGVkIHRoaXMgY2hhbmdlIG1hbnVhbGx5IGFuZCBzZWxlY3Rpb24gcmFu Z2VzIG5vdyBiZWhhdmUgYXMgZXhwZWN0ZWQsIGFuZAorICAgICAgICBoYXZlIG5vdCByZWdyZXNz ZWQgaW4gb3RoZXIgaW5zdHJ1bWVudHMgLyBVSS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvQ1BVVGltZWxpbmVWaWV3LmpzOgorICAgICAgICBCYXNlZCBvbiBteSBpbnZlc3RpZ2F0 aW9uLCB0aGUgdmlzaWJsZUVuZFRpbWUgaXMgaW5jb3JyZWN0bHkgY29tcHV0ZWQgd2hlbgorICAg ICAgICBzaG93aW5nIGEgSlNPTiB0aW1lbGluZSByZWNvcmRpbmcgYmVjYXVzZSB0aGUgY3VycmVu dFRpbWUgcHJvcGVydHkgaXMgYWx3YXlzICcwJy4KKyAgICAgICAgSWYgdGhpcyBpcyB0aGUgY2Fz ZSwgdGhlbiBsZXQncyBhc3N1bWUgdGhhdCB0aGUgZW50aXJlIHJhbmdlIHNob3VsZCBiZSBkaXNw bGF5ZWQuCisKID09IFJvbGxlZCBvdmVyIHRvIENoYW5nZUxvZy0yMDIxLTAzLTE4ID09CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DUFVUaW1l bGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D UFVUaW1lbGluZVZpZXcuanMKaW5kZXggNDhhNjBkNjVmY2U2ZjAxMDFhMTE5YjgwNzAxNWQ4MmE3 ZmU4ZjJjNy4uZjI3MWQ2MDlhYWUyNWY3ZDZiMGZiMDJhOTcyNTI0M2IzNDRmZGJjNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxp bmVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NQVVRpbWVsaW5lVmlldy5qcwpAQCAtNDM3LDcgKzQzNyw5IEBAIFdJLkNQVVRpbWVsaW5lVmll dyA9IGNsYXNzIENQVVRpbWVsaW5lVmlldyBleHRlbmRzIFdJLlRpbWVsaW5lVmlldwogCiAgICAg ICAgIGxldCBncmFwaFN0YXJ0VGltZSA9IHRoaXMuc3RhcnRUaW1lOwogICAgICAgICBsZXQgZ3Jh cGhFbmRUaW1lID0gdGhpcy5lbmRUaW1lOwotICAgICAgICBsZXQgdmlzaWJsZUVuZFRpbWUgPSBN YXRoLm1pbih0aGlzLmVuZFRpbWUsIHRoaXMuY3VycmVudFRpbWUpOworCisgICAgICAgIC8vIFdo ZW4gdmlld2luZyBhIHRpbWVsaW5lIHJlY29yZGluZyBmcm9tIEpTT04sIHRoaXMuY3VycmVudFRp bWUgaXMgYWx3YXlzIDAuCisgICAgICAgIGxldCB2aXNpYmxlRW5kVGltZSA9IE1hdGgubWluKHRo aXMuZW5kVGltZSwgdGhpcy5jdXJyZW50VGltZSkgfHwgdGhpcy5lbmRUaW1lOwogICAgICAgICBs ZXQgdmlzaWJsZUR1cmF0aW9uID0gdmlzaWJsZUVuZFRpbWUgLSBncmFwaFN0YXJ0VGltZTsKIAog ICAgICAgICBsZXQgZGlzY29udGludWl0aWVzID0gdGhpcy5fcmVjb3JkaW5nLmRpc2NvbnRpbnVp dGllc0luVGltZVJhbmdlKGdyYXBoU3RhcnRUaW1lLCB2aXNpYmxlRW5kVGltZSk7Cg==