<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223528</bug_id>
          
          <creation_ts>2021-03-19 11:15:24 -0700</creation_ts>
          <short_desc>Update filter-build-webkit</short_desc>
          <delta_ts>2022-03-01 02:25:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Blaze Burg">bburg</reporter>
          <assigned_to name="Blaze Burg">bburg</assigned_to>
          <cc>bburg</cc>
    
    <cc>darin</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1741796</commentid>
    <comment_count>0</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2021-03-19 11:15:24 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741797</commentid>
    <comment_count>1</comment_count>
      <attachid>423750</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2021-03-19 11:19:29 -0700</bug_when>
    <thetext>Created attachment 423750
Patch v1.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741804</commentid>
    <comment_count>2</comment_count>
      <attachid>423750</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-03-19 11:24:34 -0700</bug_when>
    <thetext>Comment on attachment 423750
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423750&amp;action=review

&gt; Tools/Scripts/filter-build-webkit:352
&gt; +    return 1 if $line =~ /^ld: warning: linking with (.+) but not using any symbols from it/;
&gt; +    return 1 if $line =~ /^ld: warning: dylib \(.*\) was built for newer .* version (.*) than being linked (.*)$/;

Do we really want to filter these?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741935</commentid>
    <comment_count>3</comment_count>
      <attachid>423750</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2021-03-19 15:35:32 -0700</bug_when>
    <thetext>Comment on attachment 423750
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423750&amp;action=review

&gt;&gt; Tools/Scripts/filter-build-webkit:352
&gt;&gt; +    return 1 if $line =~ /^ld: warning: dylib \(.*\) was built for newer .* version (.*) than being linked (.*)$/;
&gt; 
&gt; Do we really want to filter these?

I&apos;ll remove the ld: warning: lines, as they may be actionable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741940</commentid>
    <comment_count>4</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2021-03-19 15:44:51 -0700</bug_when>
    <thetext>Committed r274744 (235561@main): &lt;https://commits.webkit.org/235561@main&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741941</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-19 15:45:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/75639935&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741978</commentid>
    <comment_count>6</comment_count>
      <attachid>423750</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2021-03-19 18:40:55 -0700</bug_when>
    <thetext>Comment on attachment 423750
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423750&amp;action=review

A few comments nitpicking some of our regular expressions

&gt; Tools/Scripts/filter-build-webkit:360
&gt;      return 1 if $line =~ /.* com.apple.actool.compilation-results .*/;

Strange that we used .* at the beginning and end; not needed and goes without saying.

&gt; Tools/Scripts/filter-build-webkit:362
&gt;      return 1 if $line =~ /.*\/Assets.car/;
&gt;      return 1 if $line =~ /.*\/assetcatalog_generated_info.plist/;

Strange that we used .* at the beginning; not needed and goes without saying.

&gt; Tools/Scripts/filter-build-webkit:366
&gt; +    return 1 if $line =~ /^Unlocking &apos;.*\.keychain-db&apos;$/;

probably want this to be .+\.

&gt; Tools/Scripts/filter-build-webkit:369
&gt; +    return 1 if $line =~ /^The list of exported symbols did not change.$/;

That period is a single character match, not a period. Need \. for a period.

&gt; Tools/Scripts/filter-build-webkit:372
&gt; +    return 1 if $line =~ /^Adding .*?entitlements/;

This should just be .* there&apos;s no need to add the ?. The ? makes it non-greedy, which has no effect in this case. It’s already optional, because * means 0 or more matches.

&gt; Tools/Scripts/filter-build-webkit:375
&gt; +    return 1 if $line =~ /^.* will not be code signed because its settings don&apos;t specify a development team.$/;

Start should probably be .+, and should probably be \.$</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423750</attachid>
            <date>2021-03-19 11:19:29 -0700</date>
            <delta_ts>2022-03-01 02:25:37 -0800</delta_ts>
            <desc>Patch v1.0</desc>
            <filename>bug-223528-20210319111928.patch</filename>
            <type>text/plain</type>
            <size>7004</size>
            <attacher name="Blaze Burg">bburg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NzE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzUxNDgwYzg5YTk0M2FmZjFlMmZmNzZkOGViNzMwMmJl
Y2U2NDg5MC4uODM0NTA0NzQ2NTM1YTYxZWMxZjI4YjM4N2YwZDM0NzM1ZDQyZWMxYSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4
IEBACisyMDIxLTAzLTE5ICBCSiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFVw
ZGF0ZSBmaWx0ZXItYnVpbGQtd2Via2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMjM1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAtIFJlbW92ZSBhIGJ1bmNoIG9mIGluZm9ybWF0aW9uYWwgbWVzc2Fn
ZXMgdGhhdCBjbG9nIHVwIG91dHB1dC4KKyAgICAgICAgLSBSZW1vdmUgc29tZSBsaW5rZXIvbG9h
ZGVyIHdhcm5pbmdzIHRoYXQgYXJlIG5vbi1hY3Rpb25hYmxlLgorICAgICAgICAtIEdlbmVyYWxp
emUgYSBmZXcgZXhpc3RpbmcgZmlsdGVycyB0byB3b3JrIHdpdGggbW9yZSB0YXJnZXRzLgorICAg
ICAgICAtIFJlbW92ZSBzdXBlci1ub2lzeSBhbmQgbWVhbmluZ2xlc3MgZGV2aWNlIHByZXBhcmF0
aW9uIHdhcm5pbmdzLgorCisgICAgICAgICogU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0Ogor
ICAgICAgICAoc2hvdWxkSWdub3JlTGluZSk6CisKIDIwMjEtMDMtMTkgIENhaW8gTGltYSAgPHRp
Y2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFVwZGF0ZSBDYWlvJ3Mgc3RhdHVzIHRvIHJl
dmlld2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQgYi9U
b29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKaW5kZXggNmFlNGI0Zjg0MDFmMmZjMjBi
NjgwMzg4NjkwMWI5YWE1ZDNlZDM5Ny4uOGYxODkzNjM2MWVmZTc2NmE5MzZmZWU4ZDFiZGY2OWRk
OGI4ODM4NiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0Cisr
KyBiL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdApAQCAtODMsNiArODMsNyBAQCBv
dXIgJG91dHB1dEZvcm1hdCA9ICJ0ZXh0IjsKIG91ciAkdW5maWx0ZXJlZE91dHB1dFBhdGggPSAi
YnVpbGQubG9nIjsKIG91ciAkdXNlQ29sb3IgPSAtdCBTVERPVVQ7CiBvdXIgJGluRW50aXRsZW1l
bnRzID0gMDsKK291ciAkaW5EZXZpY2VQcmVwYXJhdGlvbldhcm5pbmdzID0gMDsKIAogc3ViIHVz
YWdlQW5kRXhpdCgpCiB7CkBAIC0xNDcsNyArMTQ4LDcgQEAgZm9yIChteSAkcHJldmlvdXNMaW5l
ID0gIiIsIG15ICRsaW5lID0gPD47ICRsaW5lOyAkcHJldmlvdXNMaW5lID0gJGxpbmUsICRsaW5l
ID0KICAgICAgICAgcHJpbnRMaW5lKCRsaW5lLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNpZiAo
JGxpbmUgPX4gL1wqXCogQlVJTEQgU1VDQ0VFREVEIFwqXCovKSB7CiAgICAgICAgIHByaW50TGlu
ZSgiQnVpbGQgU3VjY2VlZGVkIiwgU1RZTEVfU1VDQ0VTUyk7Ci0gICAgfSBlbHNpZiAoJGxpbmUg
PX4gL14oXGVcWzFtKT8oUGhhc2VTY3JpcHRFeGVjdXRpb258UnVsZVNjcmlwdEV4ZWN1dGlvbnxD
bENvbXBpbGV8Q29tcGlsZUN8RGlzdHJpYnV0ZWQtQ29tcGlsZUN8TGR8UEJYQ3B8Q3BSZXNvdXJj
ZXxDb3B5UE5HRmlsZXxDb3B5VGlmZkZpbGV8Q3BIZWFkZXJ8UHJlcHJvY2Vzc3xQcm9jZXNzaW5n
fFByb2Nlc3NJbmZvUGxpc3RGaWxlfFByb2Nlc3NQQ0h8UHJvY2Vzc1BDSFwrXCt8VG91Y2h8TGli
dG9vbHxDb3B5U3RyaW5nc0ZpbGV8TWlnfENyZWF0ZVVuaXZlcnNhbEJpbmFyeXxBbmFseXplfEFu
YWx5emVTaGFsbG93fFByb2Nlc3NQcm9kdWN0UGFja2FnaW5nfENvZGVTaWdufFZhbGlkYXRlfFN5
bUxpbmt8VXBkYXRpbmd8Q29tcGlsZURUcmFjZVNjcmlwdHxDb21waWxlWElCfFN0cmlwTklCfENv
cHlQbGlzdEZpbGV8R2VuZXJhdGVEU1lNRmlsZXxHZW5lcmF0ZVRBUEl8Q29tcGlsZVN0b3J5Ym9h
cmR8RXh0ZXJuYWxCdWlsZFRvb2xFeGVjdXRpb258Q3JlYXRlQnVpbGREaXJlY3Rvcnl8V3JpdGVB
dXhpbGlhcnlGaWxlfFJlZ2lzdGVyV2l0aExhdW5jaFNlcnZpY2VzfFJlZ2lzdGVyRXhlY3V0aW9u
UG9saWN5RXhjZXB0aW9ufE1rRGlyfFN0cmlwfE1ldGFsTGlua3xDb21waWxlTWV0YWxGaWxlKShc
ZVxbMG0pPyAoIlteIl0rInwoXFx8KD88PVxcKVxzfFxTKSspPy8pIHsKKyAgICB9IGVsc2lmICgk
bGluZSA9fiAvXihcZVxbMW0pPyhQaGFzZVNjcmlwdEV4ZWN1dGlvbnxSdWxlU2NyaXB0RXhlY3V0
aW9ufENsQ29tcGlsZXxDb21waWxlQ3xEaXN0cmlidXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJl
c291cmNlfENvcHlQTkdGaWxlfENvcHlUaWZmRmlsZXxDcEhlYWRlcnxQcmVwcm9jZXNzfFByb2Nl
c3Npbmd8UHJvY2Vzc0luZm9QbGlzdEZpbGV8UHJvY2Vzc1BDSHxQcm9jZXNzUENIXCtcK3xUb3Vj
aHxMaWJ0b29sfENvcHlTdHJpbmdzRmlsZXxNaWd8Q3JlYXRlVW5pdmVyc2FsQmluYXJ5fEFuYWx5
emV8QW5hbHl6ZVNoYWxsb3d8UHJvY2Vzc1Byb2R1Y3RQYWNrYWdpbmd8Q29kZVNpZ258VmFsaWRh
dGV8U3ltTGlua3xVcGRhdGluZ3xDb21waWxlRFRyYWNlU2NyaXB0fENvbXBpbGVYSUJ8U3RyaXBO
SUJ8Q29weVBsaXN0RmlsZXxHZW5lcmF0ZURTWU1GaWxlfEdlbmVyYXRlVEFQSXxDb21waWxlU3Rv
cnlib2FyZHxFeHRlcm5hbEJ1aWxkVG9vbEV4ZWN1dGlvbnxDcmVhdGVCdWlsZERpcmVjdG9yeXxX
cml0ZUF1eGlsaWFyeUZpbGV8UmVnaXN0ZXJXaXRoTGF1bmNoU2VydmljZXN8UmVnaXN0ZXJFeGVj
dXRpb25Qb2xpY3lFeGNlcHRpb258TWtEaXJ8U3RyaXB8TWV0YWxMaW5rfENvbXBpbGVNZXRhbEZp
bGV8VmFsaWRhdGVFbWJlZGRlZEJpbmFyeSkoXGVcWzBtKT8gKCJbXiJdKyJ8KFxcfCg/PD1cXClc
c3xcUykrKT8vKSB7CiAgICAgICAgIG15ICgkY29tbWFuZCwgJHBhdGgpID0gKCQyLCBiYXNlbmFt
ZSgkNCkpOwogICAgICAgICAkcGF0aCA9fiBzLygifFxcfFwuW2FoXSQpLy9nOwogICAgICAgICBw
cmludExpbmUoIiRjb21tYW5kICRwYXRoIiwgU1RZTEVfUExBSU4pOwpAQCAtMzAwLDYgKzMwMSwx
NyBAQCBzdWIgc2hvdWxkSWdub3JlTGluZSgkJCkKICAgICAgICAgcmV0dXJuIDEKICAgICB9CiAK
KyAgICAjIGlQaG9uZSBwcmVwYXJhdGlvbiBlcnJvcnMgYWx3YXlzIHN0YXJ0IGFuZCBlbmQgd2l0
aCBsaW5lcyBjb250YWluaW5nICdpUGhvbmVDb25uZWN0OicuCisgICAgaWYgKCRpbkRldmljZVBy
ZXBhcmF0aW9uV2FybmluZ3MpIHsKKyAgICAgICAgJGluRGV2aWNlUHJlcGFyYXRpb25XYXJuaW5n
cyA9IDAgaWYgJGxpbmUgPX4gLz09IEVORDogVW5kZXJseWluZyBkZXZpY2UgcHJlcGFyYXRpb24g
d2FybmluZ3MgPT0vOworICAgICAgICByZXR1cm4gMQorICAgIH0KKworICAgIGlmICgkbGluZSA9
fiAvaVBob25lQ29ubmVjdDovKSB7CisgICAgICAgICRpbkRldmljZVByZXBhcmF0aW9uV2Fybmlu
Z3MgPSAxOworICAgICAgICByZXR1cm4gMQorICAgIH0KKwogICAgIHJldHVybiAxIGlmICRsaW5l
ID1+IC9eXHMqJC87CiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15Db21tYW5kIGxpbmUgaW52
b2NhdGlvbjovOwogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eQnVpbGQgc2V0dGluZ3MgZnJv
bSBjb21tYW5kIGxpbmU6LzsKQEAgLTMxMyw3ICszMjUsNyBAQCBzdWIgc2hvdWxkSWdub3JlTGlu
ZSgkJCkKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXm5vdGU6IFVzaW5nIGVhZ2VyIGNvbXBp
bGF0aW9uLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXm5vdGU6IEV4ZWN1dGlvbiBwb2xp
Y3kgZXhjZXB0aW9uIHJlZ2lzdHJhdGlvbiBmYWlsZWQgYW5kIHdhcyBza2lwcGVkOiBFcnJvciBE
b21haW49TlNQT1NJWEVycm9yRG9tYWluIENvZGU9MSAiT3BlcmF0aW9uIG5vdCBwZXJtaXR0ZWQi
LzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXm5vdGU6IGRldGVjdGVkIGVuY29kaW5nIG9m
IGlucHV0IGZpbGUgYXMgVW5pY29kZSBcKC4qXCkvOwotICAgIHJldHVybiAxIGlmICRsaW5lID1+
IC9tYWtlKFxbXGQrXF0pPzogTm90aGluZyB0byBiZSBkb25lIGZvciBgYWxsJ1wuLzsKKyAgICBy
ZXR1cm4gMSBpZiAkbGluZSA9fiAvbWFrZShcW1xkK1xdKT86IE5vdGhpbmcgdG8gYmUgZG9uZSBm
b3IvOwogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eSmF2YVNjcmlwdENvcmVcL2NyZWF0ZV9o
YXNoX3RhYmxlLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvSmF2YVNjcmlwdENvcmUuZnJh
bWV3b3JrXC9Qcml2YXRlSGVhZGVyc1wvY3JlYXRlX2hhc2hfdGFibGUvOwogICAgIHJldHVybiAx
IGlmICRsaW5lID1+IC9eSmF2YVNjcmlwdENvcmVcL3BjcmVcL2RmdGFibGVzLzsKQEAgLTMzMywx
MCArMzQ1LDE0IEBAIHN1YiBzaG91bGRJZ25vcmVMaW5lKCQkKQogICAgIHJldHVybiAxIGlmICRs
aW5lID1+IC9PbmUgb2YgdGhlIHR3byB3aWxsIGJlIHVzZWRcLiBXaGljaCBvbmUgaXMgdW5kZWZp
bmVkXC4vOwogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9UaGUgTGVnYWN5IEJ1aWxkIFN5c3Rl
bSB3aWxsIGJlIHJlbW92ZWQgaW4gYSBmdXR1cmUgcmVsZWFzZS87CiAgICAgcmV0dXJuIDEgaWYg
JGxpbmUgPX4gL15cKCAoeGNvZGVidWlsZHxpZikgLzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9
fiAvXndhcm5pbmc6IGNhbid0IGZpbmQgYWRkaXRpb25hbCBTREsvOworICAgIHJldHVybiAxIGlm
ICRsaW5lID1+IC9ed2FybmluZzogbm8gdW1icmVsbGEgaGVhZGVyIGZvdW5kIGZvciB0YXJnZXQg
Jy4qJywgbW9kdWxlIG1hcCB3aWxsIG5vdCBiZSBnZW5lcmF0ZWQkLzsKICAgICByZXR1cm4gMSBp
ZiAkbGluZSA9fiAvXndhcm5pbmdcOiBkZXRlY3RlZCBpbnRlcm5hbCBpbnN0YWxsLCBwYXNzaW5n
IGVudGl0bGVtZW50cyB0byBzaW11bGF0b3IgYW55d2F5XC4vOworICAgIHJldHVybiAxIGlmICRs
aW5lID1+IC9ebGQ6IHdhcm5pbmc6IGxpbmtpbmcgd2l0aCAoLispIGJ1dCBub3QgdXNpbmcgYW55
IHN5bWJvbHMgZnJvbSBpdC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15sZDogd2Fybmlu
ZzogZHlsaWIgXCguKlwpIHdhcyBidWlsdCBmb3IgbmV3ZXIgLiogdmVyc2lvbiAoLiopIHRoYW4g
YmVpbmcgbGlua2VkICguKikkLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvbWF5IG5vdCBm
dW5jdGlvbiBpbiB0aGUgU2ltdWxhdG9yIGJlY2F1c2UgQWQgSG9jLzsKICAgICByZXR1cm4gMSBp
ZiAkbGluZSA9fiAvXC91c3JcL2JpblwvY2xhbmcgLio/IFw+IFxTKy5zYi87Ci0gICAgcmV0dXJu
IDEgaWYgJGxpbmUgPX4gLyB4Y29kZWJ1aWxkXFtbMC05XSs6WzAtOWEtZl0rXF1ccytEVlRBc3Nl
cnRpb25zOiBXYXJuaW5nIGluIC4qWENDbGFuZ1Jlc3VsdHNQb3N0cHJvY2Vzc29yLm0vOworICAg
IHJldHVybiAxIGlmICRsaW5lID1+IC8geGNvZGVidWlsZFxbWzAtOV0rOlswLTlhLWZdK1xdXHMr
RFZUQXNzZXJ0aW9uczogV2FybmluZyBpbiAuKi87CiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4g
L14oRGV0YWlsc3xPYmplY3R8TWV0aG9kfEZ1bmN0aW9ufFRocmVhZCk6LzsKICAgICByZXR1cm4g
MSBpZiAkbGluZSA9fiAvXlBsZWFzZSBmaWxlIGEgYnVnIGF0IC87CiAgICAgcmV0dXJuIDEgaWYg
JGxpbmUgPX4gL2NyZWF0ZWQgYnkgYW4gdW5zdXBwb3J0ZWQgWENEZXBlbmRlbmN5R3JhcGggYnVp
bGQkLzsKQEAgLTM0NCw3ICszNjAsMTkgQEAgc3ViIHNob3VsZElnbm9yZUxpbmUoJCQpCiAgICAg
cmV0dXJuIDEgaWYgJGxpbmUgPX4gLy4qIGNvbS5hcHBsZS5hY3Rvb2wuY29tcGlsYXRpb24tcmVz
dWx0cyAuKi87CiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gLy4qXC9Bc3NldHMuY2FyLzsKICAg
ICByZXR1cm4gMSBpZiAkbGluZSA9fiAvLipcL2Fzc2V0Y2F0YWxvZ19nZW5lcmF0ZWRfaW5mby5w
bGlzdC87Ci0KKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXm1vdW50OiAuKyBmYWlsZWQgd2l0
aC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15Vc2luZyAuKyBwcm9kdWN0aW9uIGVudmly
b25tZW50LiQvOworICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9yZXBsYWNpbmcgZXhpc3Rpbmcg
c2lnbmF0dXJlJC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15VbmxvY2tpbmcgJy4qXC5r
ZXljaGFpbi1kYickLzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxkKyBsb2NhbGl6YWJs
ZSBzdHJpbmdzJC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15cZCsgcGx1cmFsIHJ1bGVz
JC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15UaGUgbGlzdCBvZiBleHBvcnRlZCBzeW1i
b2xzIGRpZCBub3QgY2hhbmdlLiQvOworICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eZGl0dG86
IENhbm5vdCBnZXQgdGhlIHJlYWwgcGF0aCBmb3Igc291cmNlLzsKKyAgICByZXR1cm4gMSBpZiAk
bGluZSA9fiAvXkR1cGxpY2F0ZSBFbnRyeSBXYXMgU2tpcHBlZDovOworICAgIHJldHVybiAxIGlm
ICRsaW5lID1+IC9eQWRkaW5nIC4qP2VudGl0bGVtZW50cy87CisgICAgcmV0dXJuIDEgaWYgJGxp
bmUgPX4gL15NYWtpbmcgYXBwIGJ1bmRsZSBsYXVuY2hhYmxlLzsKKyAgICByZXR1cm4gMSBpZiAk
bGluZSA9fiAvXkZpbmlzaGVkIGFkZGluZyBlbnRpdGxlbWVudHNcLiQvOworICAgIHJldHVybiAx
IGlmICRsaW5lID1+IC9eLiogd2lsbCBub3QgYmUgY29kZSBzaWduZWQgYmVjYXVzZSBpdHMgc2V0
dGluZ3MgZG9uJ3Qgc3BlY2lmeSBhIGRldmVsb3BtZW50IHRlYW0uJC87CiAKICAgICBpZiAoJHBs
YXRmb3JtIGVxICJ3aW4iKSB7CiAgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eXHMqKHRv
dWNofHBlcmx8Y2F0fHJtIC1mfGRlbHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8Z3BlcmZ8ZWNo
b3xzZWR8aWYgXFsgXC1mfFdlYkNvcmVcL2dlbmVyYXRlLWV4cG9ydC1maWxlKSAvOwo=
</data>
<flag name="review"
          id="443221"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>