223525 2021-03-19 10:44:44 -0700 EWS is not able to process patches containing non-utf characters 2021-09-03 08:01:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223522 https://bugs.webkit.org/show_bug.cgi?id=222618 https://bugs.webkit.org/show_bug.cgi?id=225118 https://bugs.webkit.org/show_bug.cgi?id=229866 InRadar P2 Normal --- 1 aakash_jain webkit-unassigned ap cgambrell ryanhaddad webkit-bug-importer oldest_to_newest 1741779 0 aakash_jain 2021-03-19 10:44:44 -0700 EWS django app is not able to send attachment 423743 (on Bug 223522) to buildbot. 1741799 1 aakash_jain 2021-03-19 11:21:29 -0700 Relevant logs from ews-app. using 'pb' connect method Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/twisted/internet/base.py", line 999, in runUntilCurrent call.func(*call.args, **call.kw) File "/usr/local/lib/python3.6/site-packages/buildbot/util/eventual.py", line 48, in _turn cb(*args, **kwargs) File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 477, in callback self._startRunCallbacks(result) File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 580, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 662, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python3.6/site-packages/buildbot/clients/tryclient.py", line 937, in trapSystemExit why.trap(SystemExit) File "/usr/local/lib/python3.6/site-packages/twisted/python/failure.py", line 450, in trap self.raiseException() File "/usr/local/lib/python3.6/site-packages/twisted/python/failure.py", line 475, in raiseException raise self.value.with_traceback(self.tb) File "/usr/local/lib/python3.6/site-packages/twisted/internet/defer.py", line 662, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python3.6/site-packages/buildbot/clients/tryclient.py", line 917, in <lambda> d.addCallback(lambda res: self.createJob()) File "/usr/local/lib/python3.6/site-packages/buildbot/clients/tryclient.py", line 582, in createJob diff = f.read() File "/usr/lib64/python3.6/codecs.py", line 321, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcf in position 3764: invalid continuation byte 1741898 2 aakash_jain 2021-03-19 14:32:51 -0700 That patch contains non utf-8 characters. That character is at https://github.com/WebKit/WebKit/blob/main/LayoutTests/http/tests/workers/text-encoding.html#L51 Seems like a Buildbot bug, filed: https://github.com/buildbot/buildbot/issues/5933 1744235 3 webkit-bug-importer 2021-03-26 10:45:14 -0700 <rdar://problem/75892243> 1755938 4 aakash_jain 2021-05-01 07:39:44 -0700 Fix for https://github.com/buildbot/buildbot/issues/5933 has been posted in https://github.com/buildbot/buildbot/pull/6001. The fix is applied to ews-build.webkit.org and seems to be working fine. 1755939 5 aakash_jain 2021-05-01 07:43:28 -0700 Verified on Patch 427184 on bug 225118, which was failing earlier. EWS is now able to process it.