223499 2021-03-18 22:13:17 -0700 libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots 2021-03-19 15:20:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ap dino ews-watchlist graouts kondapallykalyan webkit-bug-importer oldest_to_newest 1741591 0 achristensen 2021-03-18 22:13:17 -0700 libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots 1741592 1 423692 achristensen 2021-03-18 22:15:25 -0700 Created attachment 423692 Patch 1741593 2 ews-watchlist 2021-03-18 22:16:33 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1741814 3 achristensen 2021-03-19 11:41:15 -0700 I verified this puts the dylib at /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib in the root. WebCore roots build to /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework so I think that's the right location. WK_USE_ALTERNATE_FRAMEWORKS_DIR is only YES in iosmac builds because only WK_ALTERNATE_FRAMEWORKS_DIR_iosmac is defined in the ANGLE project, so this shouldn't break anything else. 1741922 4 achristensen 2021-03-19 15:19:26 -0700 r274742 1741923 5 webkit-bug-importer 2021-03-19 15:20:16 -0700 <rdar://problem/75638888> 423692 2021-03-18 22:15:25 -0700 2021-03-19 14:15:40 -0700 Patch bug-223499-20210318221524.patch text/plain 2159 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOTVlZTRjNTg3YjRjN2E4ZjFjOWNlNWNhMjUwMDQ5YzNmNjA0Y2ZkNS4uYTcxYTY0NjkwZTgx ZGE1NTJjY2Y4Y2UxMjNmMGFjODIwNGYxMjM2MyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAzLTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgbGliQU5HTEUtc2hhcmVkLmR5bGliIG5lZWRz IElOU1RBTExfUEFUSCB3aGVuIGJ1aWxkaW5nIENhdGFseXN0IHJvb3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0OTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJTlNUQUxMX1BBVEggd2FzIGVtcHR5 LCBzbyBubyBkeWxpYiB3YXMgYmVpbmcgaW5jbHVkZWQgaW4gdGhlIHJvb3QuCisgICAgICAgIFRo aXMgaXMgbmVlZGVkIHRvIGZpeCB0aGUgQ2F0YWx5c3QgYnVpbGQgYWZ0ZXIgYnVnIDIxODUzOQor CisgICAgICAgICogQ29uZmlndXJhdGlvbnMvQU5HTEUtZHluYW1pYy54Y2NvbmZpZzoKKwogMjAy MS0wMy0wNiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgTWV0YWwt QU5HTEUgY2FuIEFTU0VSVCBiZWNhdXNlIE1UTCBzaWduYWwgZXZlbnQgY29kZSBpcyBjb21waWxl ZCBvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25z L0FOR0xFLWR5bmFtaWMueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1 cmF0aW9ucy9BTkdMRS1keW5hbWljLnhjY29uZmlnCmluZGV4IGJkNTExMmJjYWJjMTk4ODVhZTdh NTJjNmY2N2Q0YWJjM2Q0NzUyOTAuLjcxMDU1YTY0ZTNmMzk0NWMxNTg5OTFmMDRmMTVjMTBjMzlk NzA2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25z L0FOR0xFLWR5bmFtaWMueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29u ZmlndXJhdGlvbnMvQU5HTEUtZHluYW1pYy54Y2NvbmZpZwpAQCAtMTksNyArMTksNyBAQCBBTkdM RV9TVEFUSUNfTElCX09USEVSX0xERkxBR1MgPSAtV2wsLWZvcmNlX2xvYWQsIiQoQlVJTFRfUFJP RFVDVFNfRElSKS9saWJBTkdMRQogSU5TVEFMTF9QQVRIID0gJChOT1JNQUxfV0VCQ09SRV9GUkFN RVdPUktTX0RJUikvV2ViQ29yZS5mcmFtZXdvcmsvRnJhbWV3b3JrczsKIElOU1RBTExfUEFUSFtz ZGs9bWFjb3N4Kl0gPSAkKElOU1RBTExfUEFUSF9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElS XyQoV0tfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUikpOwogSU5TVEFMTF9QQVRIX1VTRV9B TFRFUk5BVEVfRlJBTUVXT1JLU19ESVJfTk8gPSAkKE5PUk1BTF9XRUJDT1JFX0ZSQU1FV09SS1Nf RElSKS9XZWJDb3JlLmZyYW1ld29yay9WZXJzaW9ucy9BL0ZyYW1ld29ya3M7Ci1JTlNUQUxMX1BB VEhfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUl9ZRVMgPSAkKFdLX09WRVJSSURFX0ZSQU1F V09SS1NfRElSKTsKK0lOU1RBTExfUEFUSF9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX1lF UyA9ICQoV0tfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSKS8kKFNZU1RFTV9MSUJSQVJZX0RJUikv UHJpdmF0ZUZyYW1ld29ya3MvV2ViQ29yZS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9GcmFtZXdvcmtz OwogCiBEWUxJQl9JTlNUQUxMX05BTUVfQkFTRVtzZGs9bWFjb3N4Kl0gPSAkKERZTElCX0lOU1RB TExfTkFNRV9CQVNFX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVJfJChXS19VU0VfQUxURVJO QVRFX0ZSQU1FV09SS1NfRElSKSk7CiBEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9VU0VfQUxURVJO QVRFX0ZSQU1FV09SS1NfRElSX05PID0gJChEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9XS19SRUxP Q0FUQUJMRV9GUkFNRVdPUktTXyQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLUykpOwo=