22349 2008-11-18 18:07:12 -0800 Loader::Host::didReceiveResponse doesn't clear the client for 304 redirects 2008-11-19 12:46:14 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 brettw brettw oldest_to_newest 99266 0 brettw 2008-11-18 18:07:12 -0800 When Loader::Host::didReceiveResponse sees a 304 redirect, it magically removes the load from the list of pending loads, since the load is effectively complete (the cached version is good enough). This means the Host doesn't have a reference to the load that was a 304, but that load is still active. Under CFNet, didFinishLoading is called immediately after the didReceiveResponse without going back to the message loop. At this time, the Host object (which is the client of the subresource load) is still active and it works OK. Other platforms' network stack (and this might not even be guaranteed by CFNet) have different timing. On Chromium, our network stack sends the finished loading after you go back to the message loop. This gives a chance for the Host cleaner-uppper to run, which happens on a timer. This can lead to the Host getting deleted before the finished callback is run. The Host should just clear out the callback when it gets a 304 so there isn't this inconsistent state. 99306 1 25268 brettw 2008-11-19 08:22:24 -0800 Created attachment 25268 Patch Patch as we discussed on IRC. 99330 2 koivisto 2008-11-19 09:54:53 -0800 r=me 99366 3 brettw 2008-11-19 12:46:14 -0800 Fixed in r38601 25268 2008-11-19 08:22:24 -0800 2008-11-19 09:54:37 -0800 Patch clearclient.diff text/plain 1301 brettw ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGMyZGExYi4uZDdjNjdjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0xMS0xOSAgQnJldHQgV2lsc29u ICA8YnJldHR3QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIzNDkKKworICAgICAgICBDbGVhciB0aGUgc3VicmVzb3VyY2UgbG9hZGVyIGNsaWVudCB3aGVu IHRoZSBjbGllbnQgaXMgcmVtb3ZlZCBpbgorICAgICAgICByZXNwb25zZSB0byBhIDMwNCAobm90 IG1vZGlmaWVkKS4gVGhpcyBwcmV2ZW50cyBhbiBpbmNvbnNpc3RlbnQgc3RhdGUKKyAgICAgICAg d2hlcmUgdGhlIGxvYWRlciB0aGlua3MgaXQncyBhY3RpdmUgYW5kIHRoZSBsb2FkZXI6Okhvc3Qg ZG9lc24ndC4KKworICAgICAgICAqIGxvYWRlci9sb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TG9hZGVyOjpIb3N0OjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDA4LTExLTEyICBBbHAg VG9rZXIgIDxhbHBAbnVhbnRpLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXhlcyBmb3IgcjM4MzQ2 LiBGbG9hdFF1YWQuY3BwIGlzIG1pc3Npbmc6CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9s b2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcAppbmRleCA4NGI4NjQ2Li4yODg5 ZjI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9sb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUv bG9hZGVyL2xvYWRlci5jcHAKQEAgLTM3OSw2ICszNzksNyBAQCB2b2lkIExvYWRlcjo6SG9zdDo6 ZGlkUmVjZWl2ZVJlc3BvbnNlKFN1YnJlc291cmNlTG9hZGVyKiBsb2FkZXIsIGNvbnN0IFJlc291 cmNlUgogICAgICAgICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA9PSAzMDQpIHsKICAg ICAgICAgICAgIC8vIDMwNCBOb3QgbW9kaWZpZWQgLyBVc2UgbG9jYWwgY29weQogICAgICAgICAg ICAgbV9yZXF1ZXN0c0xvYWRpbmcucmVtb3ZlKGxvYWRlcik7CisgICAgICAgICAgICBsb2FkZXIt PmNsZWFyQ2xpZW50KCk7CiAgICAgICAgICAgICByZXF1ZXN0LT5kb2NMb2FkZXIoKS0+ZGVjcmVt ZW50UmVxdWVzdENvdW50KCk7CiAKICAgICAgICAgICAgIC8vIEV4aXN0aW5nIHJlc291cmNlIGlz IG9rLCBqdXN0IHVzZSBpdCB1cGRhdGluZyB0aGUgZXhwaXJhdGlvbiB0aW1lLgo=