223482 2021-03-18 14:41:41 -0700 Crash under WebsiteDataStore::terminateNetworkProcess() 2021-03-18 16:22:08 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen webkit-bug-importer youennf oldest_to_newest 1741435 0 cdumez 2021-03-18 14:41:41 -0700 Crash under WebsiteDataStore::terminateNetworkProcess(): 26 WebKit: WebKit::WebsiteDataStore::terminateNetworkProcess() <== 26 WebKit: WKWebsiteDataStoreTerminateNetworkProcess 26 WebKitTestRunner: WTR::TestController::terminateNetworkProcess() 26 WebKitTestRunner: WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*) 26 WebKitTestRunner: WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*, OpaqueWKMessageListener const*) 26 WebKitTestRunner: WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener(OpaqueWKPage const*, OpaqueWKString const*, void const*, OpaqueWKMessageListener const*, void const*) 26 WebKit: WebKit::WebPageInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle(WebKit::WebPageProxy*, WTF::String const&, API::Object*, WTF::CompletionHandler<void (WTF::RefPtr<API::Object, WTF::RawPtrTraits<API::Object>, WTF::DefaultRefDerefTraits<API::Object> >)>&&) 1741436 1 cdumez 2021-03-18 14:41:59 -0700 <rdar://75326967> 1741444 2 423662 cdumez 2021-03-18 14:58:08 -0700 Created attachment 423662 Patch 1741445 3 423662 darin 2021-03-18 14:59:29 -0700 Comment on attachment 423662 Patch RefPtr, not Ref? 1741448 4 cdumez 2021-03-18 15:00:51 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 423662 [details] > Patch > > RefPtr, not Ref? Because then I think I'd have to use WTF::map() and a lambda? Since my input container contains raw pointers. Would you prefer me to do that? It was a bit more code so I did not bother. 1741454 5 darin 2021-03-18 15:14:33 -0700 (In reply to Chris Dumez from comment #4) > Would you prefer me to do that? No. 1741489 6 ews-feeder 2021-03-18 16:22:05 -0700 Committed r274683: <https://commits.webkit.org/r274683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423662. 423662 2021-03-18 14:58:08 -0700 2021-03-18 16:22:07 -0700 Patch bug-223482-20210318145807.patch text/plain 1947 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5NzZkM2RhNjNiYjMyNWVh NDgxYzBkY2Y3OWMwNmVkNGFlYmFjOTcuLjFkNTYxZDhjNjkwZGVmYjJjZGQ3MDcxOWU0Zjc1MmRm MzVmZTgxN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMTggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJzaXRlRGF0 YVN0b3JlOjp0ZXJtaW5hdGVOZXR3b3JrUHJvY2VzcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0ODIKKyAgICAgICAgPHJkYXI6Ly83NTMyNjk2 Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxs aW5nIFdlYlByb2Nlc3NQb29sOjp0ZXJtaW5hdGVTZXJ2aWNlV29ya2VycygpIG1heSBkZXN0cm95 IHRoZSBXZWJQcm9jZXNzUG9vbCwgd2hpY2ggd291bGQKKyAgICAgICAgcmVtb3ZlIHRoZSBXZWJQ cm9jZXNzUG9vbCBmcm9tIHRoZSBXZWJQcm9jZXNzUG9vbDo6YWxsUHJvY2Vzc1Bvb2xzKCkgdmVj dG9yIHdlJ3JlIGl0ZXJhdGluZworICAgICAgICBvbi4gVG8gbWFrZSB0aGlzIHNhZmUsIEkgbm93 IGNvcHkgdGhlIFdlYlByb2Nlc3NQb29sIGludG8gYSBzZXBhcmF0ZSB2ZWN0b3IgYW5kIGhvbGQg YSBSZWZQdHIKKyAgICAgICAgdG8gdGhlbS4gSSBub3cgaXRlcmF0ZSBvdmVyIHRoaXMgbmV3IHZl Y3RvciBpbnN0ZWFkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVE YXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjp0ZXJtaW5h dGVOZXR3b3JrUHJvY2Vzcyk6CisKIDIwMjEtMDMtMTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFj dGVyLWdyYW51bGFyaXR5LXJlY3QuaHRtbCBmYWlscyBvbiBjZXJ0YWluIGludGVybmFsIGNvbmZp Z3VyYXRpb25zIGFmdGVyIHIyNzQ2MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKaW5kZXggODc4MThlYzAyNzBj MjEzNDk0MzI3NTY2ZDBmMTI0ODYyOTllNGExOC4uZjczMjk3ZGViNjkyZTI2YmIxZjVmNmFlODEw YjZlNGVjNWFkYmZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0 ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTE3MzQsNyArMTczNCw4IEBAIHZv aWQgV2Vic2l0ZURhdGFTdG9yZTo6bmV0d29ya1Byb2Nlc3NDcmFzaGVkKE5ldHdvcmtQcm9jZXNz UHJveHkmKQogCiB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OnRlcm1pbmF0ZU5ldHdvcmtQcm9jZXNz KCkKIHsKLSAgICBmb3IgKGF1dG8qIHByb2Nlc3NQb29sIDogV2ViUHJvY2Vzc1Bvb2w6OmFsbFBy b2Nlc3NQb29scygpKQorICAgIGF1dG8gcHJvY2Vzc1Bvb2xzID0gY29weVRvVmVjdG9yT2Y8UmVm UHRyPFdlYlByb2Nlc3NQb29sPj4oV2ViUHJvY2Vzc1Bvb2w6OmFsbFByb2Nlc3NQb29scygpKTsK KyAgICBmb3IgKGF1dG8mIHByb2Nlc3NQb29sIDogcHJvY2Vzc1Bvb2xzKQogICAgICAgICBwcm9j ZXNzUG9vbC0+dGVybWluYXRlU2VydmljZVdvcmtlcnMoKTsKIAogICAgIGlmICghbV9uZXR3b3Jr UHJvY2VzcykK