22348 2008-11-18 17:29:15 -0800 -webkit-autofill pseudo style not always respected 2008-11-19 13:07:52 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bolsinga simon.fraser ddkilzer oldest_to_newest 99255 0 bolsinga 2008-11-18 17:29:15 -0800 This happens in Safari 3.2 and TOT. Open the attached form. Go to Edit->AutoFill Form. Only the first name field is en-yellowed. I think all of them should be, as each is getting the -webkit-autofill pseudo style set via HTMLInputElement::setAutofilled(true). If I hack up this property to always be true, the attached page will load with all en-yellowed fields. I verified in the debugger that autofill is not being set to false. 99256 1 25254 bolsinga 2008-11-18 17:30:08 -0800 Created attachment 25254 forms that will not en-yellow after autofill command 99262 2 bolsinga 2008-11-18 17:50:58 -0800 <rdar://problem/6383673> 99263 3 koivisto 2008-11-18 17:54:57 -0800 <rdar://problem/6383673> 99264 4 ddkilzer 2008-11-18 17:57:23 -0800 <rdar://problem/6383673> 99274 5 mrowe 2008-11-18 21:26:41 -0800 <rdar://problem/6383673> 99357 6 simon.fraser 2008-11-19 12:12:40 -0800 I have a fix. 99362 7 25286 simon.fraser 2008-11-19 12:24:06 -0800 Created attachment 25286 Patch, changelog It's hard to make a testcase since there's no way to set the -webkit-autofill pseudostyle from JS (that I know of), and making autofill happen is a Safari-level thing. 99363 8 25286 darin 2008-11-19 12:31:28 -0800 Comment on attachment 25286 Patch, changelog > virtual bool isControl() const { return false; } // Eventually the notion of what is a control will be extensible. > virtual bool isEnabled() const { return true; } > virtual bool isChecked() const { return false; } > + virtual bool isAutofilled() const { return false; } > virtual bool isIndeterminate() const { return false; } > virtual bool isReadOnlyControl() const { return false; } > virtual bool isTextControl() const { return false; } Not sure why you chose this point in the list to add it. Not alphabetical. Between checked and indeterminate seems a strange choice, since those two are closely related. > if (e && e->hasTagName(inputTag)) > - return static_cast<HTMLInputElement*>(e)->autofilled(); > + return static_cast<HTMLInputElement*>(e)->isAutofilled(); If we're going to make isAutofilled virtual, then we should remove the hasTagName check here. It's just there as a type check so we can call the non-virtual function. We could also have put that check inside the code in canShareStyleWithElement. > +void HTMLInputElement::setAutofilled(bool b) > +{ > + if (b != m_autofilled) { > + m_autofilled = b; > + setChanged(); > + } > +} We normally use early return for something like this rather than nesting both lines inside an if statement. r=me as is, but you could consider refining too 99371 9 simon.fraser 2008-11-19 13:07:52 -0800 Refined and committed: Committed r38602 M WebCore/dom/Node.h M WebCore/ChangeLog M WebCore/html/HTMLInputElement.cpp M WebCore/html/HTMLInputElement.h M WebCore/css/CSSStyleSelector.cpp r38602 = 5c9b448d855fb099fc4e0ab58c0327463a6c5ffd (trunk) 25254 2008-11-18 17:30:08 -0800 2008-11-18 17:30:08 -0800 forms that will not en-yellow after autofill command forms.html text/html 692 bolsinga PGZvcm0+CkZpcnN0IG5hbWU6IAo8aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0iZmlyc3RuYW1lIj4K PGJyPgpNaWRkbGUgbmFtZTogCjxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJtaWRkbGVuYW1lIj4K PGJyPgpMYXN0IG5hbWU6IAo8aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0ibGFzdG5hbWUiPgo8YnI+ Ck5hbWU6IAo8aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0ibmFtZSI+Cjxicj4KSm9iIFRpdGxlOiAK PGlucHV0IHR5cGU9InRleHQiIG5hbWU9ImpvYnRpdGxlIj4KPGJyPgplbWFpbDogCjxpbnB1dCB0 eXBlPSJ0ZXh0IiBuYW1lPSJlbWFpbCI+Cjxicj4Kc3RyZWV0OiAKPGlucHV0IHR5cGU9InRleHQi IG5hbWU9InN0cmVldCI+Cjxicj4KY2l0eTogCjxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJjaXR5 Ij4KPGJyPgpTdGF0ZTogCjxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJzdGF0ZSI+Cjxicj4KWklQ OiAKPGlucHV0IHR5cGU9InRleHQiIG5hbWU9InppcCI+Cjxicj4KQ291bnRyeTogCjxpbnB1dCB0 eXBlPSJ0ZXh0IiBuYW1lPSJjb3VudHJ5Ij4KPGJyPgpwaG9uZTogCjxpbnB1dCB0eXBlPSJ0ZXh0 IiBuYW1lPSJwaG9uZSI+Cjxicj4Kb3JnOiAKPGlucHV0IHR5cGU9InRleHQiIG5hbWU9ImNvbXBh bnkiPgo8YnI+CmJpcnRoZGF5OiAKPGlucHV0IHR5cGU9InRleHQiIG5hbWU9ImJpcnRoZGF5Ij4K PC9mb3JtPgo= 25286 2008-11-19 12:24:06 -0800 2008-11-19 12:31:28 -0800 Patch, changelog 22348_patcht.xt text/plain 4047 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGQ0N2VjNS4uOWNkZTFjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOC0xMS0xOSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIzNDgKKyAgICAgICAgCisgICAgICAgIE5lZWQgdG8gZWR1Y2F0ZSBzdHlsZSBzaGFyaW5n IGFib3V0IGF1dG9maWxsLCBzbyB0aGF0IHN0eWxlIGRvZXMgbm90CisgICAgICAgIGdldCBzaGFy ZWQgYmV0d2VlbiBpbnB1dCBlbGVtZW50cyB0aGF0IGFyZSBhdXRvZmlsbGVkLCBhbmQgdGhvc2UK KyAgICAgICAgdGhhdCBhcmUgbm90LiBTZXR0aW5nIGF1dG9maWxsIHNob3VsZCBhbHNvIGRvIGEg c2V0Q2hhbmdlZCBvbiB0aGUgbm9kZS4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmNhblNoYXJlU3R5bGVX aXRoRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpTZWxlY3Rv ckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IpOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisgICAg ICAgIChXZWJDb3JlOjpOb2RlOjppc0F1dG9maWxsZWQpOgorICAgICAgICAqIGh0bWwvSFRNTElu cHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpzZXRB dXRvZmlsbGVkKToKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzQXV0b2ZpbGxlZCk6CisKIDIwMDgtMTEtMTkg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rv ci5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCAxNWU4MWYyLi5h MGQ3M2FkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysg Yi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtOTI2LDcgKzkyNiw4IEBAIGJv b2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KE5vZGUqIG4pCiAg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgaWYgKGlzQ29udHJvbCAm JiAocy0+aXNFbmFibGVkKCkgIT0gbV9lbGVtZW50LT5pc0VuYWJsZWQoKSkgfHwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHMtPmlzSW5kZXRlcm1pbmF0ZSgpICE9IG1fZWxlbWVudC0+ aXNJbmRldGVybWluYXRlKCkpIHx8Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzLT5p c0NoZWNrZWQoKSAhPSBtX2VsZW1lbnQtPmlzQ2hlY2tlZCgpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKHMtPmlzQ2hlY2tlZCgpICE9IG1fZWxlbWVudC0+aXNDaGVja2VkKCkpIHx8 CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzLT5pc0F1dG9maWxsZWQoKSAhPSBtX2Vs ZW1lbnQtPmlzQXV0b2ZpbGxlZCgpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgICAgICAKICAgICAgICAgICAgIGlmIChzdHlsZS0+dHJhbnNpdGlvbnMoKSB8fCBzdHls ZS0+YW5pbWF0aW9ucygpKQpAQCAtMjE3MSw3ICsyMTcyLDcgQEAgYm9vbCBDU1NTdHlsZVNlbGVj dG9yOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IoQ1NTU2VsZWN0b3IqIHNlbCwg RWxlbWUKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgQ1NTU2VsZWN0 b3I6OlBzZXVkb0F1dG9maWxsOgogICAgICAgICAgICAgICAgIGlmIChlICYmIGUtPmhhc1RhZ05h bWUoaW5wdXRUYWcpKQotICAgICAgICAgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SFRN TElucHV0RWxlbWVudCo+KGUpLT5hdXRvZmlsbGVkKCk7CisgICAgICAgICAgICAgICAgICAgIHJl dHVybiBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oZSktPmlzQXV0b2ZpbGxlZCgpOwog ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNl dWRvTGluazoKICAgICAgICAgICAgICAgICBpZiAocHNldWRvU3RhdGUgPT0gUHNldWRvVW5rbm93 biB8fCBwc2V1ZG9TdGF0ZSA9PSBQc2V1ZG9BbnlMaW5rKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9k b20vTm9kZS5oIGIvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDVjYmUwM2YuLjgwOTRlNmUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmgKQEAg LTI5MCw2ICsyOTAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGlzQ29udHJvbCgpIGNv bnN0IHsgcmV0dXJuIGZhbHNlOyB9IC8vIEV2ZW50dWFsbHkgdGhlIG5vdGlvbiBvZiB3aGF0IGlz IGEgY29udHJvbCB3aWxsIGJlIGV4dGVuc2libGUuCiAgICAgdmlydHVhbCBib29sIGlzRW5hYmxl ZCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNDaGVja2VkKCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNBdXRvZmlsbGVkKCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNJbmRldGVybWluYXRl KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNSZWFkT25seUNv bnRyb2woKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBpc1RleHRD b250cm9sKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw cAppbmRleCA1ZDA0MWUyLi5jOTRiYmI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBA IC0xNTM1LDYgKzE1MzUsMTQgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpzZXRVc2VNYXAoY29u c3QgU3RyaW5nICZ2YWx1ZSkKICAgICBzZXRBdHRyaWJ1dGUodXNlbWFwQXR0ciwgdmFsdWUpOwog fQogCit2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldEF1dG9maWxsZWQoYm9vbCBiKQoreworICAg IGlmIChiICE9IG1fYXV0b2ZpbGxlZCkgeworICAgICAgICBtX2F1dG9maWxsZWQgPSBiOworICAg ICAgICBzZXRDaGFuZ2VkKCk7CisgICAgfQorfQorCiBGaWxlTGlzdCogSFRNTElucHV0RWxlbWVu dDo6ZmlsZXMoKQogewogICAgIGlmIChpbnB1dFR5cGUoKSAhPSBGSUxFKQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmgKaW5kZXggNWJkMzI0ZC4uMGY3MjZkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5o CkBAIC0xODYsOCArMTg2LDggQEAgcHVibGljOgogICAgIFN0cmluZyB1c2VNYXAoKSBjb25zdDsK ICAgICB2b2lkIHNldFVzZU1hcChjb25zdCBTdHJpbmcmKTsKIAotICAgIGJvb2wgYXV0b2ZpbGxl ZCgpIGNvbnN0IHsgcmV0dXJuIG1fYXV0b2ZpbGxlZDsgfQotICAgIHZvaWQgc2V0QXV0b2ZpbGxl ZChib29sIGIgPSB0cnVlKSB7IG1fYXV0b2ZpbGxlZCA9IGI7IH0KKyAgICB2aXJ0dWFsIGJvb2wg aXNBdXRvZmlsbGVkKCkgY29uc3QgeyByZXR1cm4gbV9hdXRvZmlsbGVkOyB9CisgICAgdm9pZCBz ZXRBdXRvZmlsbGVkKGJvb2wgYiA9IHRydWUpOwogCiAgICAgRmlsZUxpc3QqIGZpbGVzKCk7CiAK