223466 2021-03-18 12:20:00 -0700 Avoid heap allocation under PannerNode::processSampleAccurateValues() 2021-03-18 15:54:17 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223226 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1741324 0 cdumez 2021-03-18 12:20:00 -0700 Avoid heap allocation under PannerNode::processSampleAccurateValues(): Thread 19 Crashed:: offline renderer 0 com.apple.JavaScriptCore 0x0000000217bb82ce 0x217bb6000 + 8910 1 com.apple.JavaScriptCore 0x000000021935ad5b 0x217bb6000 + 24792411 2 com.apple.JavaScriptCore 0x0000000217bf5a0b 0x217bb6000 + 260619 3 com.apple.WebCore 0x00000001fab93ed5 WTF::RefCounted<WebCore::AudioListener, std::__1::default_delete<WebCore::AudioListener> >::operator new(unsigned long) + 21 (RefCounted.h:185) 4 com.apple.WebCore 0x00000001fab84e6b WebCore::AudioListener::create(WebCore::BaseAudioContext&) + 43 (AudioListener.h:49) 5 com.apple.WebCore 0x00000001fab84d2f WebCore::BaseAudioContext::listener() + 143 (BaseAudioContext.cpp:372) 6 com.apple.WebCore 0x00000001fabe4e90 WebCore::PannerNode::listener() + 32 (PannerNode.cpp:269) 7 com.apple.WebCore 0x00000001fabe5162 WebCore::PannerNode::processSampleAccurateValues(WebCore::AudioBus*, WebCore::AudioBus const*, unsigned long) + 402 (PannerNode.cpp:194) 8 com.apple.WebCore 0x00000001fabe4c82 WebCore::PannerNode::process(unsigned long) + 514 (PannerNode.cpp:141) 9 com.apple.WebCore 0x00000001fab2948e WebCore::AudioNode::processIfNecessary(unsigned long) + 462 (AudioNode.cpp:474) 10 com.apple.WebCore 0x00000001fab2bd37 WebCore::AudioNodeOutput::pull(WebCore::AudioBus*, unsigned long) + 407 (AudioNodeOutput.cpp:120) 11 com.apple.WebCore 0x00000001fab2bb06 WebCore::AudioNodeInput::sumAllConnections(WebCore::AudioBus*, unsigned long) + 566 (AudioNodeInput.cpp:193) 12 com.apple.WebCore 0x00000001fab24347 WebCore::AudioNodeInput::pull(WebCore::AudioBus*, unsigned long) + 295 (AudioNodeInput.cpp:221) 13 com.apple.WebCore 0x00000001fab23ee5 WebCore::AudioDestinationNode::render(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long, WebCore::AudioIOPosition const&) + 469 (AudioDestinationNode.cpp:94) 14 com.apple.WebCore 0x00000001fabe0d2d WebCore::OfflineAudioDestinationNode::offlineRender() + 877 (OfflineAudioDestinationNode.cpp:163) 15 com.apple.WebCore 0x00000001fac00a43 WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_2::operator()() + 35 (OfflineAudioDestinationNode.cpp:103) 16 com.apple.WebCore 0x00000001fac0241e WTF::Detail::CallableWrapper<WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_2, void>::call() + 30 (Function.h:52) 17 com.apple.JavaScriptCore 0x0000000217be08c2 0x217bb6000 + 174274 18 com.apple.JavaScriptCore 0x0000000217c955c8 0x217bb6000 + 914888 19 com.apple.JavaScriptCore 0x0000000217ca16f8 0x217bb6000 + 964344 20 libsystem_pthread.dylib 0x00007fff2041f954 0x7fff20419000 + 26964 21 libsystem_pthread.dylib 0x00007fff2041b4a7 0x7fff20419000 + 9383 1741362 1 423640 cdumez 2021-03-18 13:11:03 -0700 Created attachment 423640 Patch 1741468 2 ews-feeder 2021-03-18 15:53:57 -0700 Committed r274679: <https://commits.webkit.org/r274679> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423640. 1741469 3 webkit-bug-importer 2021-03-18 15:54:17 -0700 <rdar://problem/75594894> 423640 2021-03-18 13:11:03 -0700 2021-03-18 15:53:58 -0700 Patch bug-223466-20210318131102.patch text/plain 10749 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc4MTE4YmFlMGIyNWI0 OTRiNDc2MzFjMmJhZDBmYTUyM2RiYzRkMC4uZTUxNDUxOTY3Y2QyOGQ4YjcyYTM5OTQ2MzU4NGNl MjgzYjQ2YTkzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIHVuZGVyIFBhbm5lck5vZGU6OnByb2Nlc3NTYW1wbGVBY2N1cmF0ZVZhbHVlcygpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0NjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgQmFz ZUF1ZGlvQ29udGV4dDo6bV9saXN0ZW5lciBnZXRzIGluaXRpYWxpemVkIGluIHRoZSBjb25zdHJ1 Y3RvcgorICAgICAgICAob24gdGhlIG1haW4gdGhyZWFkKSBpbnN0ZWFkIG9mIGRvaW5nIGl0IGxh emlseSBpbiB0aGUgbGlzdGVuZXIoKSBnZXR0ZXIKKyAgICAgICAgKHdoaWNoIG1heSBnZXQgY2Fs bGVkIG9uIHRoZSBhdWRpbyB0aHJlYWQpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9B dWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpjcmVhdGUp OgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpBdWRpb0NvbnRleHQpOgorICAgICAg ICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpB dWRpb0NvbnRleHQ6OkF1ZGlvQ29udGV4dCk6CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9C YXNlQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJhc2VBdWRpb0NvbnRleHQ6 OkJhc2VBdWRpb0NvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6V2ViQ29yZTo6QmFzZUF1ZGlv Q29udGV4dDo6bGlzdGVuZXIpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQmFzZUF1ZGlv Q29udGV4dC5oOgorICAgICAgICAoV2ViQ29yZTo6QmFzZUF1ZGlvQ29udGV4dDo6QmFzZUF1ZGlv Q29udGV4dCk6CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok9mZmxpbmVBdWRpb0NvbnRleHQ6Ok9mZmxpbmVBdWRp b0NvbnRleHQpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vV2ViS2l0QXVkaW9Db250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdEF1ZGlvQ29udGV4dDo6V2ViS2l0QXVkaW9D b250ZXh0KToKKwogMjAyMS0wMy0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIEF2b2lkIGhlYXAgYWxsb2NhdGlvbiB1bmRlciBCYXNlQXVkaW9Db250ZXh0Ojpz b3VyY2VOb2RlRGlkRmluaXNoUGxheWJhY2soKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IDQzY2JjYzk4ODg2OTgxZWNhNjM4ZDJi YTM2ZTU2OTY5NzM1Y2VmOTAuLmEwODMwOWYwMThmMWEzZTczOWIzN2I1YWQ1YTIwZDJjZGE1Njlk NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250 ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4 dC5jcHAKQEAgLTEwMCwxNCArMTAwLDE0IEBAIEV4Y2VwdGlvbk9yPFJlZjxBdWRpb0NvbnRleHQ+ PiBBdWRpb0NvbnRleHQ6OmNyZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQsIEF1ZGlvQ29uCiAgICAg aWYgKGNvbnRleHRPcHRpb25zLnNhbXBsZVJhdGUuaGFzVmFsdWUoKSAmJiAhaXNTdXBwb3J0ZWRT YW1wbGVSYXRlKGNvbnRleHRPcHRpb25zLnNhbXBsZVJhdGUudmFsdWUoKSkpCiAgICAgICAgIHJl dHVybiBFeGNlcHRpb24geyBTeW50YXhFcnJvciwgInNhbXBsZVJhdGUgaXMgbm90IGluIHJhbmdl Il9zIH07CiAgICAgCi0gICAgYXV0byBhdWRpb0NvbnRleHQgPSBhZG9wdFJlZigqbmV3IEF1ZGlv Q29udGV4dChkb2N1bWVudCwgY29udGV4dE9wdGlvbnMpKTsKKyAgICBhdXRvIGF1ZGlvQ29udGV4 dCA9IGFkb3B0UmVmKCpuZXcgQXVkaW9Db250ZXh0KGRvY3VtZW50LCBJc0xlZ2FjeVdlYktpdEF1 ZGlvQ29udGV4dDo6Tm8sIGNvbnRleHRPcHRpb25zKSk7CiAgICAgYXVkaW9Db250ZXh0LT5zdXNw ZW5kSWZOZWVkZWQoKTsKICAgICByZXR1cm4gYXVkaW9Db250ZXh0OwogfQogCiAvLyBDb25zdHJ1 Y3RvciBmb3IgcmVuZGVyaW5nIHRvIHRoZSBhdWRpbyBoYXJkd2FyZS4KLUF1ZGlvQ29udGV4dDo6 QXVkaW9Db250ZXh0KERvY3VtZW50JiBkb2N1bWVudCwgY29uc3QgQXVkaW9Db250ZXh0T3B0aW9u cyYgY29udGV4dE9wdGlvbnMpCi0gICAgOiBCYXNlQXVkaW9Db250ZXh0KGRvY3VtZW50LCBjb250 ZXh0T3B0aW9ucykKK0F1ZGlvQ29udGV4dDo6QXVkaW9Db250ZXh0KERvY3VtZW50JiBkb2N1bWVu dCwgSXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRleHQgaXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRleHQs IGNvbnN0IEF1ZGlvQ29udGV4dE9wdGlvbnMmIGNvbnRleHRPcHRpb25zKQorICAgIDogQmFzZUF1 ZGlvQ29udGV4dChkb2N1bWVudCwgaXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRleHQsIGNvbnRleHRP cHRpb25zKQogICAgICwgbV9tZWRpYVNlc3Npb24oUGxhdGZvcm1NZWRpYVNlc3Npb246OmNyZWF0 ZShQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXIoKSwgKnRoaXMpKQog ewogICAgIGNvbnN0cnVjdENvbW1vbigpOwpAQCAtMTIwLDggKzEyMCw4IEBAIEF1ZGlvQ29udGV4 dDo6QXVkaW9Db250ZXh0KERvY3VtZW50JiBkb2N1bWVudCwgY29uc3QgQXVkaW9Db250ZXh0T3B0 aW9ucyYgY29udGV4CiB9CiAKIC8vIE9ubHkgbmVlZGVkIGZvciBXZWJLaXRPZmZsaW5lQXVkaW9D b250ZXh0LgotQXVkaW9Db250ZXh0OjpBdWRpb0NvbnRleHQoRG9jdW1lbnQmIGRvY3VtZW50LCB1 bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzLCBmbG9hdCBzYW1wbGVSYXRlLCBSZWZQdHI8QXVkaW9C dWZmZXI+JiYgcmVuZGVyVGFyZ2V0KQotICAgIDogQmFzZUF1ZGlvQ29udGV4dChkb2N1bWVudCwg bnVtYmVyT2ZDaGFubmVscywgc2FtcGxlUmF0ZSwgV1RGTW92ZShyZW5kZXJUYXJnZXQpKQorQXVk aW9Db250ZXh0OjpBdWRpb0NvbnRleHQoRG9jdW1lbnQmIGRvY3VtZW50LCBJc0xlZ2FjeVdlYktp dEF1ZGlvQ29udGV4dCBpc0xlZ2FjeVdlYktpdEF1ZGlvQ29udGV4dCwgdW5zaWduZWQgbnVtYmVy T2ZDaGFubmVscywgZmxvYXQgc2FtcGxlUmF0ZSwgUmVmUHRyPEF1ZGlvQnVmZmVyPiYmIHJlbmRl clRhcmdldCkKKyAgICA6IEJhc2VBdWRpb0NvbnRleHQoZG9jdW1lbnQsIGlzTGVnYWN5V2ViS2l0 QXVkaW9Db250ZXh0LCBudW1iZXJPZkNoYW5uZWxzLCBzYW1wbGVSYXRlLCBXVEZNb3ZlKHJlbmRl clRhcmdldCkpCiAgICAgLCBtX21lZGlhU2Vzc2lvbihQbGF0Zm9ybU1lZGlhU2Vzc2lvbjo6Y3Jl YXRlKFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLCAqdGhpcykp CiB7CiAgICAgY29uc3RydWN0Q29tbW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb0NvbnRleHQuaAppbmRleCBmMWM0YjViYTM2NTc0MTE1M2YzZmRhOWYxYTll YjU1MTcxYTQ2YzJlLi5jNTVhNTI5NmQ2NzQ1ZThiYjEwYjE1YjI5ZmQ5NDNmOWE2NWNiNjU2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmgKQEAg LTg4LDggKzg4LDggQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlQmVoYXZpb3JSZXN0cmljdGlv bihCZWhhdmlvclJlc3RyaWN0aW9ucyByZXN0cmljdGlvbikgeyBtX3Jlc3RyaWN0aW9ucyAmPSB+ cmVzdHJpY3Rpb247IH0KIAogcHJvdGVjdGVkOgotICAgIGV4cGxpY2l0IEF1ZGlvQ29udGV4dChE b2N1bWVudCYsIGNvbnN0IEF1ZGlvQ29udGV4dE9wdGlvbnMmID0geyB9KTsKLSAgICBBdWRpb0Nv bnRleHQoRG9jdW1lbnQmLCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzLCBmbG9hdCBzYW1wbGVS YXRlLCBSZWZQdHI8QXVkaW9CdWZmZXI+JiYgcmVuZGVyVGFyZ2V0KTsKKyAgICBleHBsaWNpdCBB dWRpb0NvbnRleHQoRG9jdW1lbnQmLCBJc0xlZ2FjeVdlYktpdEF1ZGlvQ29udGV4dCwgY29uc3Qg QXVkaW9Db250ZXh0T3B0aW9ucyYgPSB7IH0pOworICAgIEF1ZGlvQ29udGV4dChEb2N1bWVudCYs IElzTGVnYWN5V2ViS2l0QXVkaW9Db250ZXh0LCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzLCBm bG9hdCBzYW1wbGVSYXRlLCBSZWZQdHI8QXVkaW9CdWZmZXI+JiYgcmVuZGVyVGFyZ2V0KTsKIAog ICAgIGJvb2wgd2lsbEJlZ2luUGxheWJhY2soKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vQmFzZUF1ZGlvQ29udGV4dC5jcHAKaW5kZXggNTdlYzUxOGFhMWU4 ZmRlMjI1NzVhZDljMmZmNDA1MDIyODM2NGExZS4uMDU2M2YyNzgzMGJhZTg0ZTBjZWE5ZGI2Yzdh YjA0Njg5NTdiNjE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp by9CYXNlQXVkaW9Db250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL0Jhc2VBdWRpb0NvbnRleHQuY3BwCkBAIC0xMTgsMTMgKzExOCwxNCBAQCBib29sIEJhc2VB dWRpb0NvbnRleHQ6OmlzU3VwcG9ydGVkU2FtcGxlUmF0ZShmbG9hdCBzYW1wbGVSYXRlKQogdW5z aWduZWQgQmFzZUF1ZGlvQ29udGV4dDo6c19oYXJkd2FyZUNvbnRleHRDb3VudCA9IDA7CiAKIC8v IENvbnN0cnVjdG9yIGZvciByZW5kZXJpbmcgdG8gdGhlIGF1ZGlvIGhhcmR3YXJlLgotQmFzZUF1 ZGlvQ29udGV4dDo6QmFzZUF1ZGlvQ29udGV4dChEb2N1bWVudCYgZG9jdW1lbnQsIGNvbnN0IEF1 ZGlvQ29udGV4dE9wdGlvbnMmIGNvbnRleHRPcHRpb25zKQorQmFzZUF1ZGlvQ29udGV4dDo6QmFz ZUF1ZGlvQ29udGV4dChEb2N1bWVudCYgZG9jdW1lbnQsIElzTGVnYWN5V2ViS2l0QXVkaW9Db250 ZXh0IGlzTGVnYWN5V2ViS2l0QXVkaW9Db250ZXh0LCBjb25zdCBBdWRpb0NvbnRleHRPcHRpb25z JiBjb250ZXh0T3B0aW9ucykKICAgICA6IEFjdGl2ZURPTU9iamVjdChkb2N1bWVudCkKICNpZiAh UkVMRUFTRV9MT0dfRElTQUJMRUQKICAgICAsIG1fbG9nZ2VyKGRvY3VtZW50LmxvZ2dlcigpKQog ICAgICwgbV9sb2dJZGVudGlmaWVyKHVuaXF1ZUxvZ0lkZW50aWZpZXIoKSkKICNlbmRpZgogICAg ICwgbV93b3JrbGV0KEF1ZGlvV29ya2xldDo6Y3JlYXRlKCp0aGlzKSkKKyAgICAsIG1fbGlzdGVu ZXIoaXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRleHQgPT0gSXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRl eHQ6OlllcyA/IFJlZjxBdWRpb0xpc3RlbmVyPihXZWJLaXRBdWRpb0xpc3RlbmVyOjpjcmVhdGUo KnRoaXMpKSA6IEF1ZGlvTGlzdGVuZXI6OmNyZWF0ZSgqdGhpcykpCiB7CiAgICAgLy8gQWNjb3Jk aW5nIHRvIHNwZWMgQXVkaW9Db250ZXh0IG11c3QgZGllIG9ubHkgYWZ0ZXIgcGFnZSBuYXZpZ2F0 ZS4KICAgICAvLyBMZXRzIG1hcmsgaXQgYXMgQWN0aXZlRE9NT2JqZWN0IHdpdGggcGVuZGluZyBh Y3Rpdml0eSBhbmQgdW5tYXJrIGl0IGluIGNsZWFyIG1ldGhvZC4KQEAgLTE0Niw3ICsxNDcsNyBA QCBCYXNlQXVkaW9Db250ZXh0OjpCYXNlQXVkaW9Db250ZXh0KERvY3VtZW50JiBkb2N1bWVudCwg Y29uc3QgQXVkaW9Db250ZXh0T3B0aW9ucwogfQogCiAvLyBDb25zdHJ1Y3RvciBmb3Igb2ZmbGlu ZSAobm9uLXJlYWx0aW1lKSByZW5kZXJpbmcuCi1CYXNlQXVkaW9Db250ZXh0OjpCYXNlQXVkaW9D b250ZXh0KERvY3VtZW50JiBkb2N1bWVudCwgdW5zaWduZWQgbnVtYmVyT2ZDaGFubmVscywgZmxv YXQgc2FtcGxlUmF0ZSwgUmVmUHRyPEF1ZGlvQnVmZmVyPiYmIHJlbmRlclRhcmdldCkKK0Jhc2VB dWRpb0NvbnRleHQ6OkJhc2VBdWRpb0NvbnRleHQoRG9jdW1lbnQmIGRvY3VtZW50LCBJc0xlZ2Fj eVdlYktpdEF1ZGlvQ29udGV4dCBpc0xlZ2FjeVdlYktpdEF1ZGlvQ29udGV4dCwgdW5zaWduZWQg bnVtYmVyT2ZDaGFubmVscywgZmxvYXQgc2FtcGxlUmF0ZSwgUmVmUHRyPEF1ZGlvQnVmZmVyPiYm IHJlbmRlclRhcmdldCkKICAgICA6IEFjdGl2ZURPTU9iamVjdChkb2N1bWVudCkKICNpZiAhUkVM RUFTRV9MT0dfRElTQUJMRUQKICAgICAsIG1fbG9nZ2VyKGRvY3VtZW50LmxvZ2dlcigpKQpAQCAt MTU1LDYgKzE1Niw3IEBAIEJhc2VBdWRpb0NvbnRleHQ6OkJhc2VBdWRpb0NvbnRleHQoRG9jdW1l bnQmIGRvY3VtZW50LCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzCiAgICAgLCBtX3dvcmtsZXQo QXVkaW9Xb3JrbGV0OjpjcmVhdGUoKnRoaXMpKQogICAgICwgbV9pc09mZmxpbmVDb250ZXh0KHRy dWUpCiAgICAgLCBtX3JlbmRlclRhcmdldChXVEZNb3ZlKHJlbmRlclRhcmdldCkpCisgICAgLCBt X2xpc3RlbmVyKGlzTGVnYWN5V2ViS2l0QXVkaW9Db250ZXh0ID09IElzTGVnYWN5V2ViS2l0QXVk aW9Db250ZXh0OjpZZXMgPyBSZWY8QXVkaW9MaXN0ZW5lcj4oV2ViS2l0QXVkaW9MaXN0ZW5lcjo6 Y3JlYXRlKCp0aGlzKSkgOiBBdWRpb0xpc3RlbmVyOjpjcmVhdGUoKnRoaXMpKQogewogICAgIEZG VEZyYW1lOjppbml0aWFsaXplKCk7CiAKQEAgLTM2NSwxMyArMzY3LDcgQEAgdm9pZCBCYXNlQXVk aW9Db250ZXh0OjpkZWNvZGVBdWRpb0RhdGEoUmVmPEFycmF5QnVmZmVyPiYmIGF1ZGlvRGF0YSwg UmVmUHRyPEF1ZGkKIAogQXVkaW9MaXN0ZW5lciYgV2ViQ29yZTo6QmFzZUF1ZGlvQ29udGV4dDo6 bGlzdGVuZXIoKQogewotICAgIGlmICghbV9saXN0ZW5lcikgewotICAgICAgICBpZiAoaXNXZWJL aXRBdWRpb0NvbnRleHQoKSkKLSAgICAgICAgICAgIG1fbGlzdGVuZXIgPSBXZWJLaXRBdWRpb0xp c3RlbmVyOjpjcmVhdGUoKnRoaXMpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX2xpc3Rl bmVyID0gQXVkaW9MaXN0ZW5lcjo6Y3JlYXRlKCp0aGlzKTsKLSAgICB9Ci0gICAgcmV0dXJuICpt X2xpc3RlbmVyOworICAgIHJldHVybiBtX2xpc3RlbmVyOwogfQogCiBFeGNlcHRpb25PcjxSZWY8 QXVkaW9CdWZmZXJTb3VyY2VOb2RlPj4gQmFzZUF1ZGlvQ29udGV4dDo6Y3JlYXRlQnVmZmVyU291 cmNlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQmFzZUF1 ZGlvQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9D b250ZXh0LmgKaW5kZXggN2YxMzQ1MzRmZmM2MDI4OTBkNDVmMzE3ZWMzNTgzZThmNDg1MmViNy4u OWQ5YTRhOWM4OTYzNGU5NzVkM2JlYmVhYjUxMDkyMTJkYmQ3NGI5MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmgKQEAgLTI5MSw4 ICsyOTEsOSBAQCBwdWJsaWM6CiAgICAgY29uc3QgSGFzaE1hcDxTdHJpbmcsIFZlY3RvcjxBdWRp b1BhcmFtRGVzY3JpcHRvcj4+JiBwYXJhbWV0ZXJEZXNjcmlwdG9yTWFwKCkgY29uc3QgeyByZXR1 cm4gbV9wYXJhbWV0ZXJEZXNjcmlwdG9yTWFwOyB9CiAKIHByb3RlY3RlZDoKLSAgICBleHBsaWNp dCBCYXNlQXVkaW9Db250ZXh0KERvY3VtZW50JiwgY29uc3QgQXVkaW9Db250ZXh0T3B0aW9ucyYg PSB7IH0pOwotICAgIEJhc2VBdWRpb0NvbnRleHQoRG9jdW1lbnQmLCB1bnNpZ25lZCBudW1iZXJP ZkNoYW5uZWxzLCBmbG9hdCBzYW1wbGVSYXRlLCBSZWZQdHI8QXVkaW9CdWZmZXI+JiYgcmVuZGVy VGFyZ2V0KTsKKyAgICBlbnVtIGNsYXNzIElzTGVnYWN5V2ViS2l0QXVkaW9Db250ZXh0IDogYm9v bCB7IE5vLCBZZXMgfTsKKyAgICBleHBsaWNpdCBCYXNlQXVkaW9Db250ZXh0KERvY3VtZW50Jiwg SXNMZWdhY3lXZWJLaXRBdWRpb0NvbnRleHQsIGNvbnN0IEF1ZGlvQ29udGV4dE9wdGlvbnMmID0g eyB9KTsKKyAgICBCYXNlQXVkaW9Db250ZXh0KERvY3VtZW50JiwgSXNMZWdhY3lXZWJLaXRBdWRp b0NvbnRleHQsIHVuc2lnbmVkIG51bWJlck9mQ2hhbm5lbHMsIGZsb2F0IHNhbXBsZVJhdGUsIFJl ZlB0cjxBdWRpb0J1ZmZlcj4mJiByZW5kZXJUYXJnZXQpOwogICAgIAogICAgIHZvaWQgY2xlYXJQ ZW5kaW5nQWN0aXZpdHkoKTsKICAgICB2b2lkIG1ha2VQZW5kaW5nQWN0aXZpdHkoKTsKQEAgLTM4 Myw3ICszODQsNyBAQCBwcml2YXRlOgogCiAgICAgUmVmUHRyPEF1ZGlvQnVmZmVyPiBtX3JlbmRl clRhcmdldDsKICAgICBSZWZQdHI8QXVkaW9EZXN0aW5hdGlvbk5vZGU+IG1fZGVzdGluYXRpb25O b2RlOwotICAgIFJlZlB0cjxBdWRpb0xpc3RlbmVyPiBtX2xpc3RlbmVyOworICAgIFJlZjxBdWRp b0xpc3RlbmVyPiBtX2xpc3RlbmVyOwogCiAgICAgdW5zaWduZWQgbV9jb25uZWN0aW9uQ291bnQg eyAwIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2Zm bGluZUF1ZGlvQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09m ZmxpbmVBdWRpb0NvbnRleHQuY3BwCmluZGV4IDA2YTQ1OTE4N2FjNjE2ZGEwMGFmNGU0Njg0OTg5 NTkwZTZjOTIzMGIuLjZhMGM5YTQyNDE4ODhhNzdmZjQ5MmUxYzU4ZWQ5MTgyMDFkOTdmMGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlvQ29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9PZmZsaW5lQXVk aW9Db250ZXh0LmNwcApAQCAtMzksNyArMzksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBXVEZf TUFLRV9JU09fQUxMT0NBVEVEX0lNUEwoT2ZmbGluZUF1ZGlvQ29udGV4dCk7CiAKIGlubGluZSBP ZmZsaW5lQXVkaW9Db250ZXh0OjpPZmZsaW5lQXVkaW9Db250ZXh0KERvY3VtZW50JiBkb2N1bWVu dCwgdW5zaWduZWQgbnVtYmVyT2ZDaGFubmVscywgdW5zaWduZWQgbGVuZ3RoLCBmbG9hdCBzYW1w bGVSYXRlLCBSZWZQdHI8QXVkaW9CdWZmZXI+JiYgcmVuZGVyVGFyZ2V0KQotICAgIDogQmFzZUF1 ZGlvQ29udGV4dChkb2N1bWVudCwgbnVtYmVyT2ZDaGFubmVscywgc2FtcGxlUmF0ZSwgV1RGTW92 ZShyZW5kZXJUYXJnZXQpKQorICAgIDogQmFzZUF1ZGlvQ29udGV4dChkb2N1bWVudCwgSXNMZWdh Y3lXZWJLaXRBdWRpb0NvbnRleHQ6Ok5vLCBudW1iZXJPZkNoYW5uZWxzLCBzYW1wbGVSYXRlLCBX VEZNb3ZlKHJlbmRlclRhcmdldCkpCiAgICAgLCBtX2xlbmd0aChsZW5ndGgpCiB7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1dlYktpdEF1ZGlvQ29udGV4 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1dlYktpdEF1ZGlvQ29udGV4 dC5jcHAKaW5kZXggZDI0OWViMjEwYzNlNzc3M2QzMDY5MmMxYWUzMDJlMjg0MTBlNzRkNi4uYzhh YjE2ZDk3MzY2Njg4Yzc0NjNkZWZlOTE5NDA4Njc2YjJkYjk5MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9XZWJLaXRBdWRpb0NvbnRleHQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vV2ViS2l0QXVkaW9Db250ZXh0LmNwcApAQCAt NzksMTMgKzc5LDEzIEBAIEV4Y2VwdGlvbk9yPFJlZjxXZWJLaXRBdWRpb0NvbnRleHQ+PiBXZWJL aXRBdWRpb0NvbnRleHQ6OmNyZWF0ZShEb2N1bWVudCYgZG9jdW1lCiAKIC8vIENvbnN0cnVjdG9y IGZvciByZW5kZXJpbmcgdG8gdGhlIGF1ZGlvIGhhcmR3YXJlLgogV2ViS2l0QXVkaW9Db250ZXh0 OjpXZWJLaXRBdWRpb0NvbnRleHQoRG9jdW1lbnQmIGRvY3VtZW50KQotICAgIDogQXVkaW9Db250 ZXh0KGRvY3VtZW50KQorICAgIDogQXVkaW9Db250ZXh0KGRvY3VtZW50LCBJc0xlZ2FjeVdlYktp dEF1ZGlvQ29udGV4dDo6WWVzKQogewogfQogCiAvLyBDb25zdHJ1Y3RvciBmb3Igb2ZmbGluZSAo bm9uLXJlYWx0aW1lKSByZW5kZXJpbmcuCiBXZWJLaXRBdWRpb0NvbnRleHQ6OldlYktpdEF1ZGlv Q29udGV4dChEb2N1bWVudCYgZG9jdW1lbnQsIGZsb2F0IHNhbXBsZVJhdGUsIFJlZjxBdWRpb0J1 ZmZlcj4mJiByZW5kZXJUYXJnZXQpCi0gICAgOiBBdWRpb0NvbnRleHQoZG9jdW1lbnQsIHJlbmRl clRhcmdldC0+bnVtYmVyT2ZDaGFubmVscygpLCBzYW1wbGVSYXRlLCBXVEZNb3ZlKHJlbmRlclRh cmdldCkpCisgICAgOiBBdWRpb0NvbnRleHQoZG9jdW1lbnQsIElzTGVnYWN5V2ViS2l0QXVkaW9D b250ZXh0OjpZZXMsIHJlbmRlclRhcmdldC0+bnVtYmVyT2ZDaGFubmVscygpLCBzYW1wbGVSYXRl LCBXVEZNb3ZlKHJlbmRlclRhcmdldCkpCiB7CiB9CiAK