223461 2021-03-18 11:35:38 -0700 Avoid heap allocation under BaseAudioContext::sourceNodeDidFinishPlayback() 2021-03-18 13:59:37 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223226 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1741291 0 cdumez 2021-03-18 11:35:38 -0700 Avoid heap allocation under BaseAudioContext::sourceNodeDidFinishPlayback(). 1741292 1 423624 cdumez 2021-03-18 11:40:15 -0700 Created attachment 423624 Patch 1741402 2 ews-feeder 2021-03-18 13:58:29 -0700 Committed r274672: <https://commits.webkit.org/r274672> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423624. 1741404 3 webkit-bug-importer 2021-03-18 13:59:37 -0700 <rdar://problem/75589472> 423624 2021-03-18 11:40:15 -0700 2021-03-18 13:58:31 -0700 Patch bug-223461-20210318114015.patch text/plain 6831 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODgxYjc0YWJiOWRkNzg3 MzVhNjk1ZjljZjI4OTExNDQ1N2ZhNmIzMC4uYzFlYjhmZjZkZDE1NGI4NzU2ZjA1NzNmMGNhMzlj ZDFlZGJkY2IzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIHVuZGVyIEJhc2VBdWRpb0NvbnRleHQ6OnNvdXJjZU5vZGVEaWRGaW5pc2hQbGF5YmFjaygp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0NjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCYXNlQXVk aW9Db250ZXh0Ojpzb3VyY2VOb2RlRGlkRmluaXNoUGxheWJhY2soKSB3YXMgYXBwZW5kaW5nIHRv IGEgbV9maW5pc2hlZFNvdXJjZU5vZGVzCisgICAgICAgIFZlY3Rvciwgd2hpY2ggd291bGQgY2F1 c2UgaGVhcCBhbGxvY2F0aW9ucyBvbiB0aGUgYXVkaW8gdGhyZWFkLiBUbyBhdm9pZCBzdWNoIGhl YXAKKyAgICAgICAgYWxsb2NhdGlvbnMgKHdoaWNoIGFyZSBiYWQgZm9yIHBlcmZvcm1hbmNlKSwg d2Ugbm93IHNldCBhICJpc0ZpbmlzaGVkU291cmNlTm9kZSIgZmxhZworICAgICAgICBvbiB0aGUg QXVkaW9Ob2RlLiBXaGVuIEJhc2VBdWRpb0NvbnRleHQ6OmRlcmVmRmluaXNoZWRTb3VyY2VOb2Rl cygpLCBpdCByZWxpZXMgb24KKyAgICAgICAgdGhpcyBuZXcgaXNGaW5pc2hlZFNvdXJjZU5vZGUg ZmxhZyBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBtX2ZpbmlzaGVkU291cmNlTm9kZXMgVmVjdG9yLgor CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaDoKKyAgICAgICAgKFdlYkNv cmU6OkF1ZGlvTm9kZTo6aXNGaW5pc2hlZFNvdXJjZU5vZGUgY29uc3QpOgorICAgICAgICAoV2Vi Q29yZTo6QXVkaW9Ob2RlOjpzZXRJc0ZpbmlzaGVkU291cmNlTm9kZSk6CisgICAgICAgICogTW9k dWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJh c2VBdWRpb0NvbnRleHQ6On5CYXNlQXVkaW9Db250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OkJh c2VBdWRpb0NvbnRleHQ6OnVuaW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJDb3JlOjppc0Zpbmlz aGVkU291cmNlTm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpCYXNlQXVkaW9Db250ZXh0OjpkZXJl ZkZpbmlzaGVkU291cmNlTm9kZXMpOgorICAgICAgICAoV2ViQ29yZTo6QmFzZUF1ZGlvQ29udGV4 dDo6c291cmNlTm9kZURpZEZpbmlzaFBsYXliYWNrKToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1 ZGlvL0Jhc2VBdWRpb0NvbnRleHQuaDoKKwogMjAyMS0wMy0xOCAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGhlYXAgYWxsb2NhdGlvbiB1bmRlciBBdWRp b1dvcmtsZXROb2RlOjpwcm9jZXNzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvTm9kZS5oCmluZGV4IGZkMmUwMGE4ZDczNWNkZTA5Y2NmOGQ4MDcwODc5NTQzYjVhNDY2 ZGEuLmUxYTVjYzJlZmNjMmZjNDc2Zjk2YzQ1Y2YxMzMyMmMxMzEzNGIwM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaApAQCAtMTkxLDYgKzE5MSw5IEBA IHB1YmxpYzoKICAgICBDaGFubmVsSW50ZXJwcmV0YXRpb24gY2hhbm5lbEludGVycHJldGF0aW9u KCkgY29uc3QgeyByZXR1cm4gbV9jaGFubmVsSW50ZXJwcmV0YXRpb247IH0KICAgICB2aXJ0dWFs IEV4Y2VwdGlvbk9yPHZvaWQ+IHNldENoYW5uZWxJbnRlcnByZXRhdGlvbihDaGFubmVsSW50ZXJw cmV0YXRpb24pOwogCisgICAgYm9vbCBpc0ZpbmlzaGVkU291cmNlTm9kZSgpIGNvbnN0IHsgcmV0 dXJuIG1faXNGaW5pc2hlZFNvdXJjZU5vZGU7IH0KKyAgICB2b2lkIHNldElzRmluaXNoZWRTb3Vy Y2VOb2RlKCkgeyBtX2lzRmluaXNoZWRTb3VyY2VOb2RlID0gdHJ1ZTsgfQorCiBwcm90ZWN0ZWQ6 CiAgICAgLy8gSW5wdXRzIGFuZCBvdXRwdXRzIG11c3QgYmUgY3JlYXRlZCBiZWZvcmUgdGhlIEF1 ZGlvTm9kZSBpcyBpbml0aWFsaXplZC4KICAgICB2b2lkIGFkZElucHV0KCk7CkBAIC0yNDgsNiAr MjUxLDcgQEAgcHJpdmF0ZToKICAgICAKICAgICBib29sIG1faXNNYXJrZWRGb3JEZWxldGlvbiB7 IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzRGlzYWJsZWQgeyBmYWxzZSB9OworICAgIGJvb2wgbV9p c0ZpbmlzaGVkU291cmNlTm9kZSB7IGZhbHNlIH07CiAKICNpZiBERUJVR19BVURJT05PREVfUkVG RVJFTkNFUwogICAgIHN0YXRpYyBib29sIHNfaXNOb2RlQ291bnRJbml0aWFsaXplZDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQmFzZUF1ZGlvQ29udGV4dC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0Jhc2VBdWRpb0NvbnRleHQuY3Bw CmluZGV4IGIwYTcyYWZkZjRhNGYxNmUzOGIzZjNjYWE1MjI3YjY5M2FmYzNmY2YuLjU3ZWM1MThh YTFlOGZkZTIyNTc1YWQ5YzJmZjQwNTAyMjgzNjRhMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQmFzZUF1ZGlvQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmNwcApAQCAtMTcxLDcgKzE3 MSw2IEBAIEJhc2VBdWRpb0NvbnRleHQ6On5CYXNlQXVkaW9Db250ZXh0KCkKICAgICBBU1NFUlQo bV9pc1N0b3BTY2hlZHVsZWQpOwogICAgIEFTU0VSVChtX25vZGVzVG9EZWxldGUuaXNFbXB0eSgp KTsKICAgICBBU1NFUlQobV9yZWZlcmVuY2VkU291cmNlTm9kZXMuaXNFbXB0eSgpKTsKLSAgICBB U1NFUlQobV9maW5pc2hlZFNvdXJjZU5vZGVzLmlzRW1wdHkoKSk7CiAgICAgQVNTRVJUKG1fYXV0 b21hdGljUHVsbE5vZGVzLmlzRW1wdHkoKSk7CiAgICAgaWYgKG1fYXV0b21hdGljUHVsbE5vZGVz TmVlZFVwZGF0aW5nKQogICAgICAgICBtX3JlbmRlcmluZ0F1dG9tYXRpY1B1bGxOb2Rlcy5yZXNp emUobV9hdXRvbWF0aWNQdWxsTm9kZXMuc2l6ZSgpKTsKQEAgLTI0NCw3ICsyNDMsNyBAQCB2b2lk IEJhc2VBdWRpb0NvbnRleHQ6OnVuaW5pdGlhbGl6ZSgpCiAgICAgICAgIEF1dG9Mb2NrZXIgbG9j a2VyKCp0aGlzKTsKICAgICAgICAgLy8gVGhpcyBzaG91bGQgaGF2ZSBiZWVuIGNhbGxlZCBmcm9t IGhhbmRsZVBvc3RSZW5kZXJUYXNrcygpIGF0IHRoZSBlbmQgb2YgcmVuZGVyaW5nLgogICAgICAg ICAvLyBIb3dldmVyLCBpbiBjYXNlIG9mIGxvY2sgY29udGVudGlvbiwgdGhlIHRyeUxvY2soKSBj YWxsIGNvdWxkIGhhdmUgZmFpbGVkIGluIGhhbmRsZVBvc3RSZW5kZXJUYXNrcygpLAotICAgICAg ICAvLyBsZWF2aW5nIG5vZGVzIGluIG1fZmluaXNoZWRTb3VyY2VOb2Rlcy4gTm93IHRoYXQgdGhl IGF1ZGlvIHRocmVhZCBpcyBnb25lLCBtYWtlIHN1cmUgd2UgZGVyZWYgdGhvc2Ugbm9kZXMKKyAg ICAgICAgLy8gbGVhdmluZyBub2RlcyBpbiBtX3JlZmVyZW5jZWRTb3VyY2VOb2Rlcy4gTm93IHRo YXQgdGhlIGF1ZGlvIHRocmVhZCBpcyBnb25lLCBtYWtlIHN1cmUgd2UgZGVyZWYgdGhvc2Ugbm9k ZXMKICAgICAgICAgLy8gYmVmb3JlIHRoZSBCYXNlQXVkaW9Db250ZXh0IGdldHMgZGVzdHJveWVk LgogICAgICAgICBkZXJlZkZpbmlzaGVkU291cmNlTm9kZXMoKTsKICAgICB9CkBAIC01NzUsMTQg KzU3NCwyMSBAQCBFeGNlcHRpb25PcjxSZWY8SUlSRmlsdGVyTm9kZT4+IEJhc2VBdWRpb0NvbnRl eHQ6OmNyZWF0ZUlJUkZpbHRlcihTY3JpcHRFeGVjdXRpbwogICAgIHJldHVybiBJSVJGaWx0ZXJO b2RlOjpjcmVhdGUoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCwgKnRoaXMsIFdURk1vdmUob3B0aW9u cykpOwogfQogCitzdGF0aWMgYm9vbCBpc0ZpbmlzaGVkU291cmNlTm9kZShjb25zdCBBdWRpb0Nv bm5lY3Rpb25SZWZQdHI8QXVkaW9Ob2RlPiYgbm9kZSkKK3sKKyAgICByZXR1cm4gbm9kZS0+aXNG aW5pc2hlZFNvdXJjZU5vZGUoKTsKK30KKwogdm9pZCBCYXNlQXVkaW9Db250ZXh0OjpkZXJlZkZp bmlzaGVkU291cmNlTm9kZXMoKQogewogICAgIEFTU0VSVChpc0dyYXBoT3duZXIoKSk7CiAgICAg QVNTRVJUKGlzQXVkaW9UaHJlYWQoKSB8fCBpc0F1ZGlvVGhyZWFkRmluaXNoZWQoKSk7Ci0gICAg Zm9yIChhdXRvJiBub2RlIDogbV9maW5pc2hlZFNvdXJjZU5vZGVzKQotICAgICAgICBkZXJlZlNv dXJjZU5vZGUoKm5vZGUpOwogCi0gICAgbV9maW5pc2hlZFNvdXJjZU5vZGVzLmNsZWFyKCk7Cisg ICAgaWYgKCFtX2hhc0ZpbmlzaGVkQXVkaW9Tb3VyY2VOb2RlcykKKyAgICAgICAgcmV0dXJuOwor CisgICAgbV9yZWZlcmVuY2VkU291cmNlTm9kZXMucmVtb3ZlQWxsTWF0Y2hpbmcoaXNGaW5pc2hl ZFNvdXJjZU5vZGUpOworICAgIG1faGFzRmluaXNoZWRBdWRpb1NvdXJjZU5vZGVzID0gZmFsc2U7 CiB9CiAKIHZvaWQgQmFzZUF1ZGlvQ29udGV4dDo6cmVmU291cmNlTm9kZShBdWRpb05vZGUmIG5v ZGUpCkBAIC0xMDU1LDcgKzEwNjEsOCBAQCB2b2lkIEJhc2VBdWRpb0NvbnRleHQ6OnNvdXJjZU5v ZGVEaWRGaW5pc2hQbGF5YmFjayhBdWRpb05vZGUmIG5vZGUpCiB7CiAgICAgQVNTRVJUKGlzQXVk aW9UaHJlYWQoKSk7CiAKLSAgICBtX2ZpbmlzaGVkU291cmNlTm9kZXMuYXBwZW5kKCZub2RlKTsK KyAgICBub2RlLnNldElzRmluaXNoZWRTb3VyY2VOb2RlKCk7CisgICAgbV9oYXNGaW5pc2hlZEF1 ZGlvU291cmNlTm9kZXMgPSB0cnVlOwogfQogCiB2b2lkIEJhc2VBdWRpb0NvbnRleHQ6Ondvcmts ZXRJc1JlYWR5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v QmFzZUF1ZGlvQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNl QXVkaW9Db250ZXh0LmgKaW5kZXggODVjNzc0ZmRhZGVhZGJlYmQ4YzdhMWMyMjcxM2EwNzc1NTU0 ZmZkMi4uN2YxMzQ1MzRmZmM2MDI4OTBkNDVmMzE3ZWMzNTgzZThmNDg1MmViNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmgKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9CYXNlQXVkaW9Db250ZXh0LmgKQEAg LTMxOSw5ICszMTksOSBAQCBwcml2YXRlOgogICAgIHZvaWQgd29ya2xldElzUmVhZHkoKTsKIAog ICAgIC8vIFdoZW4gc291cmNlIG5vZGVzIGJlZ2luIHBsYXlpbmcsIHRoZSBCYXNlQXVkaW9Db250 ZXh0IGtlZXBzIHRoZW0gYWxpdmUgaW5zaWRlIG1fcmVmZXJlbmNlZFNvdXJjZU5vZGVzLgotICAg IC8vIFdoZW4gdGhlIG5vZGVzIHN0b3AgcGxheWluZywgdGhleSBnZXQgYWRkZWQgdG8gbV9maW5p c2hlZFNvdXJjZU5vZGVzLiBBZnRlciBlYWNoIHJlbmRlcmluZyBxdWFudHVtLAotICAgIC8vIHdl IGNhbGwgZGVyZWZTb3VyY2VOb2RlKCkgb24gZXZlcnkgbm9kZSBpbiBtX2ZpbmlzaGVkU291cmNl Tm9kZXMgc2luY2Ugd2Ugbm8gbG9uZ2VyIG5lZWQgdG8ga2VlcCB0aGVtCi0gICAgLy8gYWxpdmUu CisgICAgLy8gV2hlbiB0aGUgbm9kZXMgc3RvcCBwbGF5aW5nLCBhIGZsYWcgZ2V0cyBzZXQgb24g dGhlIEF1ZGlvTm9kZSBhY2NvcmRpbmdseS4gQWZ0ZXIgZWFjaCByZW5kZXJpbmcgcXVhbnR1bSwK KyAgICAvLyB3ZSBjYWxsIGRlcmVmRmluaXNoZWRTb3VyY2VOb2RlcygpIHRvIHJlbW92ZSB0aG9z ZSBub2RlcyBmcm9tIG1fcmVmZXJlbmNlZFNvdXJjZU5vZGVzIHNpbmNlIHdlIG5vIGxvbmdlcgor ICAgIC8vIG5lZWQgdG8ga2VlcCB0aGVtIGFsaXZlLgogICAgIHZvaWQgcmVmU291cmNlTm9kZShB dWRpb05vZGUmKTsKICAgICB2b2lkIGRlcmVmU291cmNlTm9kZShBdWRpb05vZGUmKTsKIApAQCAt MzUwLDkgKzM1MCw2IEBAIHByaXZhdGU6CiAKICAgICBSZWY8QXVkaW9Xb3JrbGV0PiBtX3dvcmts ZXQ7CiAKLSAgICAvLyBPbmx5IGFjY2Vzc2VkIGluIHRoZSBhdWRpbyB0aHJlYWQuCi0gICAgVmVj dG9yPEF1ZGlvTm9kZSo+IG1fZmluaXNoZWRTb3VyY2VOb2RlczsKLQogICAgIC8vIEVpdGhlciBh Y2Nlc3NlZCB3aGVuIHRoZSBncmFwaCBsb2NrIGlzIGhlbGQsIG9yIG9uIHRoZSBtYWluIHRocmVh ZCB3aGVuIHRoZSBhdWRpbyB0aHJlYWQgaGFzIGZpbmlzaGVkLgogICAgIFZlY3RvcjxBdWRpb0Nv bm5lY3Rpb25SZWZQdHI8QXVkaW9Ob2RlPj4gbV9yZWZlcmVuY2VkU291cmNlTm9kZXM7CiAKQEAg LTQxMiw2ICs0MDksNyBAQCBwcml2YXRlOgogICAgIEF1ZGlvSU9Qb3NpdGlvbiBtX291dHB1dFBv c2l0aW9uOwogCiAgICAgSGFzaE1hcDxTdHJpbmcsIFZlY3RvcjxBdWRpb1BhcmFtRGVzY3JpcHRv cj4+IG1fcGFyYW1ldGVyRGVzY3JpcHRvck1hcDsKKyAgICBib29sIG1faGFzRmluaXNoZWRBdWRp b1NvdXJjZU5vZGVzIHsgZmFsc2UgfTsKIAogICAgIC8vIFRoZXNlIGFyZSBjYWNoZWQgcGVyIGF1 ZGlvIGNvbnRleHQgZm9yIHBlcmZvcm1hbmNlIHJlYXNvbnMuIFRoZXkgY2Fubm90IGJlCiAgICAg Ly8gc3RhdGljIGJlY2F1c2UgdGhleSByZWx5IG9uIHRoZSBzYW1wbGUgcmF0ZS4K