<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22346</bug_id>
          
          <creation_ts>2008-11-18 15:59:10 -0800</creation_ts>
          <short_desc>PlatformString should also include HashSet.h for non-JSC builds</short_desc>
          <delta_ts>2008-11-18 17:58:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>99241</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2008-11-18 15:59:10 -0800</bug_when>
    <thetext>runtime/Identifier.h now also pulls in runtime/Collector.h, which in turn includes HashSet.h. We should do the same for non-JSC builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99245</commentid>
    <comment_count>1</comment_count>
      <attachid>25252</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2008-11-18 16:30:50 -0800</bug_when>
    <thetext>Created attachment 25252
Adds HashSet include to PlatformString.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99258</commentid>
    <comment_count>2</comment_count>
      <attachid>25252</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-11-18 17:36:47 -0800</bug_when>
    <thetext>Comment on attachment 25252
Adds HashSet include to PlatformString.h

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99259</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-11-18 17:37:10 -0800</bug_when>
    <thetext>I review+&apos;d this, but the ChangeLog entry really should be improved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99265</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2008-11-18 17:58:50 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/38589</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25252</attachid>
            <date>2008-11-18 16:30:50 -0800</date>
            <delta_ts>2008-11-18 17:36:47 -0800</delta_ts>
            <desc>Adds HashSet include to PlatformString.h</desc>
            <filename>hashset.diff</filename>
            <type>text/plain</type>
            <size>1115</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZjZiYjcwMS4uODg2NzhmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxMSBAQAogMjAwOC0xMS0xOCAgRGltaXRyaSBHbGF6
a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9QbGF0Zm9ybVN0cmluZy5oOgor
CisyMDA4LTExLTE4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisK
ICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KIAogICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh
dGZvcm0vdGV4dC9QbGF0Zm9ybVN0cmluZy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1BsYXRm
b3JtU3RyaW5nLmgKaW5kZXggYWU3ZGExYS4uMjBlYzA3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w
bGF0Zm9ybS90ZXh0L1BsYXRmb3JtU3RyaW5nLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0
L1BsYXRmb3JtU3RyaW5nLmgKQEAgLTMyLDkgKzMyLDEwIEBACiAjaWYgVVNFKEpTQykKICNpbmNs
dWRlIDxydW50aW1lL0lkZW50aWZpZXIuaD4KICNlbHNlCi0vLyBydW50aW1lL0lkZW50aWZpZXIu
aCBpbmNsdWRlcyBIYXNoTWFwLmguIFdlIGV4cGxpY2l0bHkgaW5jbHVkZSBpdCBpbiB0aGUgY2Fz
ZSBvZgotLy8gbm9uLUpTQyBidWlsZHMgdG8ga2VlcCB0aGluZ3MgY29uc2lzdGVudC4KKy8vIHJ1
bnRpbWUvSWRlbnRpZmllci5oIGluY2x1ZGVzIEhhc2hNYXAuaCBhbmQgSGFzaFNldC5oLiBXZSBl
eHBsaWNpdGx5IGluY2x1ZGUgCisvLyB0aGVtIGluIHRoZSBjYXNlIG9mIG5vbi1KU0MgYnVpbGRz
IHRvIGtlZXAgdGhpbmdzIGNvbnNpc3RlbnQuCiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KKyNp
bmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2VuZGlmCiAKICNpZiBQTEFURk9STShDRikgfHwgKFBM
QVRGT1JNKFFUKSAmJiBQTEFURk9STShEQVJXSU4pKQo=
</data>
<flag name="review"
          id="11676"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>