223459 2021-03-18 11:29:49 -0700 Don't spend time painting transparent cell backgrounds 2021-03-18 16:23:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham changseok darin esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1741287 0 simon.fraser 2021-03-18 11:29:49 -0700 Don't spend time painting transparent cell backgrounds 1741288 1 423622 simon.fraser 2021-03-18 11:31:03 -0700 Created attachment 423622 Patch 1741458 2 423622 darin 2021-03-18 15:26:33 -0700 Comment on attachment 423622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review > Source/WebCore/rendering/RenderTableCell.cpp:1287 > + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible. 1741459 3 423622 darin 2021-03-18 15:27:07 -0700 Comment on attachment 423622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review >> Source/WebCore/rendering/RenderTableCell.cpp:1287 >> + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) > > Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible. transparent black 1741490 4 simon.fraser 2021-03-18 16:22:37 -0700 https://trac.webkit.org/changeset/274682/webkit 1741491 5 webkit-bug-importer 2021-03-18 16:23:33 -0700 <rdar://problem/75596249> 423622 2021-03-18 11:31:03 -0700 2021-03-18 15:26:33 -0700 Patch bug-223459-20210318113102.patch text/plain 4046 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FhN2M0NjliYjFiNzlk ZDg3MjY2MmRkYTQwMjNjMGUxNWZlMTcyMi4uZGM2ZjI5NWNhYjg0OGM4Y2Y4NGE3N2Q0OTM5OTVl NGUzMzg5N2I3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAzLTE4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHNwZW5k IHRpbWUgcGFpbnRpbmcgdHJhbnNwYXJlbnQgY2VsbCBiYWNrZ3JvdW5kcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDU5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY2FuIGJhaWwgZWFybHkgZnJv bSBSZW5kZXJUYWJsZUNlbGw6OnBhaW50QmFja2dyb3VuZHNCZWhpbmRDZWxsKCkgaWYgdGhlIHN0 eWxlIGhhcworICAgICAgICBubyBiYWNrZ3JvdW5kIGltYWdlLCBhbmQgdGhlIGJhY2tncm91bmQg Y29sb3IgaXMgdHJhbnNwYXJlbnQgKHRoZSBkZWZhdWx0KS4KKworICAgICAgICBSZW1vdmVzIDIl IG9mIHBhaW50aW5nIHRpbWUgaW4gdGhlIE1vdGlvbk1hcmsgRGVzaWduIHN1YnRlc3QuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRhYmxlQ2VsbDo6cGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwpOgorCiAyMDIxLTAz LTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEF2 b2lkIHVubmVjZXNzYXJ5IHJlcGFpbnRzIHdoZW4gdHJhbnNmb3JtcyBjaGFuZ2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAKaW5kZXggMWQ5NTExZGNiMWZj MDFlNmVjMDBkNzlkYTQwNmI4ZWRjNjBmNzIwMy4uZmFiODAyN2VhMDBhZjIzMjhiZDUxMzZkYjQ4 NGIyMTdjNGM5ZjZlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlQ2VsbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl Q2VsbC5jcHAKQEAgLTEyODAsMzAgKzEyODAsMzAgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnBh aW50QmFja2dyb3VuZHNCZWhpbmRDZWxsKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXkK ICAgICBpZiAoIXRhYmxlRWx0LT5jb2xsYXBzZUJvcmRlcnMoKSAmJiBzdHlsZSgpLmVtcHR5Q2Vs bHMoKSA9PSBFbXB0eUNlbGw6OkhpZGUgJiYgIWZpcnN0Q2hpbGQoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgTGF5b3V0UG9pbnQgYWRqdXN0ZWRQYWludE9mZnNldCA9IHBhaW50T2Zmc2V0Owot ICAgIGlmIChiYWNrZ3JvdW5kT2JqZWN0ICE9IHRoaXMpCi0gICAgICAgIGFkanVzdGVkUGFpbnRP ZmZzZXQubW92ZUJ5KGxvY2F0aW9uKCkpOwotCiAgICAgY29uc3QgYXV0byYgc3R5bGUgPSBiYWNr Z3JvdW5kT2JqZWN0LT5zdHlsZSgpOwogICAgIGF1dG8mIGJnTGF5ZXIgPSBzdHlsZS5iYWNrZ3Jv dW5kTGF5ZXJzKCk7CiAKICAgICBhdXRvIGNvbG9yID0gc3R5bGUudmlzaXRlZERlcGVuZGVudENv bG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKLSAgICBhdXRvIGNvbXBvc2l0ZU9wID0g ZG9jdW1lbnQoKS5jb21wb3NpdGVPcGVyYXRvckZvckJhY2tncm91bmRDb2xvcihjb2xvciwgKnRo aXMpOworICAgIGlmICghYmdMYXllci5oYXNJbWFnZSgpICYmICghY29sb3IuaXNWYWxpZCgpIHx8 ICFjb2xvci5pc1Zpc2libGUoKSkpCisgICAgICAgIHJldHVybjsKIAogICAgIGNvbG9yID0gc3R5 bGUuY29sb3JCeUFwcGx5aW5nQ29sb3JGaWx0ZXIoY29sb3IpOwogCi0gICAgaWYgKGJnTGF5ZXIu aGFzSW1hZ2UoKSB8fCBjb2xvci5pc1ZhbGlkKCkpIHsKLSAgICAgICAgLy8gV2UgaGF2ZSB0byBj bGlwIGhlcmUgYmVjYXVzZSB0aGUgYmFja2dyb3VuZCB3b3VsZCBwYWludAotICAgICAgICAvLyBv biB0b3Agb2YgdGhlIGJvcmRlcnMgb3RoZXJ3aXNlLiAgVGhpcyBvbmx5IG1hdHRlcnMgZm9yIGNl bGxzIGFuZCByb3dzLgotICAgICAgICBib29sIHNob3VsZENsaXAgPSBiYWNrZ3JvdW5kT2JqZWN0 LT5oYXNMYXllcigpICYmIChiYWNrZ3JvdW5kT2JqZWN0ID09IHRoaXMgfHwgYmFja2dyb3VuZE9i amVjdCA9PSBwYXJlbnQoKSkgJiYgdGFibGVFbHQtPmNvbGxhcHNlQm9yZGVycygpOwotICAgICAg ICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIocGFpbnRJbmZvLmNvbnRleHQo KSwgc2hvdWxkQ2xpcCk7Ci0gICAgICAgIGlmIChzaG91bGRDbGlwKSB7Ci0gICAgICAgICAgICBM YXlvdXRSZWN0IGNsaXBSZWN0KGFkanVzdGVkUGFpbnRPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgp LCBhZGp1c3RlZFBhaW50T2Zmc2V0LnkoKSArIGJvcmRlclRvcCgpLAotICAgICAgICAgICAgICAg IHdpZHRoKCkgLSBib3JkZXJMZWZ0KCkgLSBib3JkZXJSaWdodCgpLCBoZWlnaHQoKSAtIGJvcmRl clRvcCgpIC0gYm9yZGVyQm90dG9tKCkpOwotICAgICAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQo KS5jbGlwKGNsaXBSZWN0KTsKLSAgICAgICAgfQotICAgICAgICBwYWludEZpbGxMYXllcnMocGFp bnRJbmZvLCBjb2xvciwgYmdMYXllciwgTGF5b3V0UmVjdChhZGp1c3RlZFBhaW50T2Zmc2V0LCBm cmFtZVJlY3QoKS5zaXplKCkpLCBCYWNrZ3JvdW5kQmxlZWROb25lLCBjb21wb3NpdGVPcCwgYmFj a2dyb3VuZE9iamVjdCk7CisgICAgTGF5b3V0UG9pbnQgYWRqdXN0ZWRQYWludE9mZnNldCA9IHBh aW50T2Zmc2V0OworICAgIGlmIChiYWNrZ3JvdW5kT2JqZWN0ICE9IHRoaXMpCisgICAgICAgIGFk anVzdGVkUGFpbnRPZmZzZXQubW92ZUJ5KGxvY2F0aW9uKCkpOworCisgICAgLy8gV2UgaGF2ZSB0 byBjbGlwIGhlcmUgYmVjYXVzZSB0aGUgYmFja2dyb3VuZCB3b3VsZCBwYWludAorICAgIC8vIG9u IHRvcCBvZiB0aGUgYm9yZGVycyBvdGhlcndpc2UuIFRoaXMgb25seSBtYXR0ZXJzIGZvciBjZWxs cyBhbmQgcm93cy4KKyAgICBib29sIHNob3VsZENsaXAgPSBiYWNrZ3JvdW5kT2JqZWN0LT5oYXNM YXllcigpICYmIChiYWNrZ3JvdW5kT2JqZWN0ID09IHRoaXMgfHwgYmFja2dyb3VuZE9iamVjdCA9 PSBwYXJlbnQoKSkgJiYgdGFibGVFbHQtPmNvbGxhcHNlQm9yZGVycygpOworICAgIEdyYXBoaWNz Q29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcihwYWludEluZm8uY29udGV4dCgpLCBzaG91bGRD bGlwKTsKKyAgICBpZiAoc2hvdWxkQ2xpcCkgeworICAgICAgICBMYXlvdXRSZWN0IGNsaXBSZWN0 KGFkanVzdGVkUGFpbnRPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBhZGp1c3RlZFBhaW50T2Zm c2V0LnkoKSArIGJvcmRlclRvcCgpLAorICAgICAgICAgICAgd2lkdGgoKSAtIGJvcmRlckxlZnQo KSAtIGJvcmRlclJpZ2h0KCksIGhlaWdodCgpIC0gYm9yZGVyVG9wKCkgLSBib3JkZXJCb3R0b20o KSk7CisgICAgICAgIHBhaW50SW5mby5jb250ZXh0KCkuY2xpcChjbGlwUmVjdCk7CiAgICAgfQor ICAgIGF1dG8gY29tcG9zaXRlT3AgPSBkb2N1bWVudCgpLmNvbXBvc2l0ZU9wZXJhdG9yRm9yQmFj a2dyb3VuZENvbG9yKGNvbG9yLCAqdGhpcyk7CisgICAgcGFpbnRGaWxsTGF5ZXJzKHBhaW50SW5m bywgY29sb3IsIGJnTGF5ZXIsIExheW91dFJlY3QoYWRqdXN0ZWRQYWludE9mZnNldCwgZnJhbWVS ZWN0KCkuc2l6ZSgpKSwgQmFja2dyb3VuZEJsZWVkTm9uZSwgY29tcG9zaXRlT3AsIGJhY2tncm91 bmRPYmplY3QpOwogfQogCiB2b2lkIFJlbmRlclRhYmxlQ2VsbDo6cGFpbnRCb3hEZWNvcmF0aW9u cyhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9pbnQmIHBhaW50T2Zmc2V0KQo=