<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223458</bug_id>
          
          <creation_ts>2021-03-18 11:25:41 -0700</creation_ts>
          <short_desc>Web Inspector: color-contrast() should have color swatch</short_desc>
          <delta_ts>2024-08-29 10:56:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=222530</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=223457</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=204772</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nikita Vasilyev">nvasilyev</reporter>
          <assigned_to name="Nikita Vasilyev">nvasilyev</assigned_to>
          <cc>inspector-bugzilla-changes</cc>
    
    <cc>ntim</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1741282</commentid>
    <comment_count>0</comment_count>
    <who name="Nikita Vasilyev">nvasilyev</who>
    <bug_when>2021-03-18 11:25:41 -0700</bug_when>
    <thetext>I propose to add a read-only color swatch before `color-contrast`

    [ ] color-contrast(var(--brand) 40%, white)
     ^
     resulting color</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741283</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-18 11:25:50 -0700</bug_when>
    <thetext>&lt;rdar://problem/75582067&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741525</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-03-18 17:46:52 -0700</bug_when>
    <thetext>Would also be really cool to somehow expose the different contrast ratios being compared.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741877</commentid>
    <comment_count>3</comment_count>
    <who name="Nikita Vasilyev">nvasilyev</who>
    <bug_when>2021-03-19 13:58:45 -0700</bug_when>
    <thetext>Yeah, that would be nice.

I&apos;ve worked on Bug 204772 - Web Inspector: Add text/background contrast ratio information to color picker. Unfortunately, I didn&apos;t finish it. If I add custom UI for color-contrast(), I should finish that patch 1st.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1742083</commentid>
    <comment_count>4</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-03-21 10:45:41 -0700</bug_when>
    <thetext>(In reply to Nikita Vasilyev from comment #3)
&gt; Yeah, that would be nice.
&gt; 
&gt; I&apos;ve worked on Bug 204772 - Web Inspector: Add text/background contrast
&gt; ratio information to color picker. Unfortunately, I didn&apos;t finish it. If I
&gt; add custom UI for color-contrast(), I should finish that patch 1st.

It&apos;s too bad none of that math / color conversion code is using the version we have in WebCore. Is there a pattern we can establish to expose some of the functionality we have in the engine to the inspector so the math always lines up perfectly?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2056308</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2024-08-29 10:56:21 -0700</bug_when>
    <thetext>We&apos;re removing color-contrast in bug 278864</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>