223452 2021-03-18 10:33:19 -0700 Avoid heap allocation under AudioWorkletNode::process() 2021-03-18 15:43:14 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223226 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1741247 0 cdumez 2021-03-18 10:33:19 -0700 Avoid heap allocation under AudioWorkletNode::process(): Thread 18 Crashed:: WebCore: AudioWorklet 0 com.apple.JavaScriptCore 0x000000079fd74aee 0x79fd72000 + 10990 1 com.apple.JavaScriptCore 0x00000007a151229b 0x79fd72000 + 24773275 2 com.apple.JavaScriptCore 0x000000079fdb2a5f 0x79fd72000 + 264799 3 com.apple.WebCore 0x0000000782bfadb5 WebCore::AudioArray<float>::resize(WTF::Checked<unsigned long, WTF::CrashOnOverflow>) + 133 (AudioArray.h:65) 4 com.apple.WebCore 0x0000000782c33965 WebCore::AudioWorkletNode::process(unsigned long) + 1333 (AudioWorkletNode.cpp:217) 5 com.apple.WebCore 0x0000000782bd8c8e WebCore::AudioNode::processIfNecessary(unsigned long) + 462 (AudioNode.cpp:474) 6 com.apple.WebCore 0x0000000782bdb547 WebCore::AudioNodeOutput::pull(WebCore::AudioBus*, unsigned long) + 407 (AudioNodeOutput.cpp:124) 7 com.apple.WebCore 0x0000000782bdb316 WebCore::AudioNodeInput::sumAllConnections(WebCore::AudioBus*, unsigned long) + 566 (AudioNodeInput.cpp:197) 8 com.apple.WebCore 0x0000000782bd3b47 WebCore::AudioNodeInput::pull(WebCore::AudioBus*, unsigned long) + 295 (AudioNodeInput.cpp:225) 9 com.apple.WebCore 0x0000000782bd36e5 WebCore::AudioDestinationNode::render(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long, WebCore::AudioIOPosition const&) + 469 (AudioDestinationNode.cpp:94) 10 com.apple.WebCore 0x0000000782c9a7ad WebCore::OfflineAudioDestinationNode::offlineRender() + 877 (OfflineAudioDestinationNode.cpp:164) 11 com.apple.WebCore 0x0000000782cba4c3 WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_2::operator()() + 35 (OfflineAudioDestinationNode.cpp:103) 12 com.apple.WebCore 0x0000000782cba499 WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_3::operator()(WebCore::ScriptExecutionContext&) + 25 (OfflineAudioDestinationNode.cpp:124) 13 com.apple.WebCore 0x0000000782cba3f3 WTF::Detail::CallableWrapper<WebCore::OfflineAudioDestinationNode::startRendering(WTF::CompletionHandler<void (WTF::Optional<WebCore::Exception>&&)>&&)::$_3, void, WebCore::ScriptExecutionContext&>::call(WebCore::ScriptExecutionContext&) + 51 (Function.h:52) 14 com.apple.WebCore 0x0000000782f1cdaa WTF::Function<void (WebCore::ScriptExecutionContext&)>::operator()(WebCore::ScriptExecutionContext&) const + 154 (Function.h:83) 15 com.apple.WebCore 0x0000000782f13e9d WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext&) + 29 (ScriptExecutionContext.h:192) 16 com.apple.WebCore 0x00000007856aef90 WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerOrWorkletGlobalScope*) + 128 (WorkerRunLoop.cpp:270) 1741252 1 423615 cdumez 2021-03-18 10:44:32 -0700 Created attachment 423615 Patch 1741403 2 423615 peng.liu6 2021-03-18 13:59:36 -0700 Comment on attachment 423615 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423615&action=review > Source/WebCore/ChangeLog:8 > + Always use arrays of size 128 (render quantum) for AudioParam values. We use to Nit. s/use to/used to/g 1741406 3 423650 cdumez 2021-03-18 14:00:57 -0700 Created attachment 423650 Patch 1741428 4 423650 darin 2021-03-18 14:33:07 -0700 Comment on attachment 423650 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423650&action=review > Source/WebCore/ChangeLog:26 > + behavior is thus consistant with Blink. consistent > Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp:215 > + std::fill(paramValues->data(), paramValues->data() + framesToProcess, audioParam->finalValue()); How about using std::fill_n instead? 1741429 5 423659 cdumez 2021-03-18 14:35:35 -0700 Created attachment 423659 Patch 1741464 6 ews-feeder 2021-03-18 15:42:32 -0700 Committed r274677: <https://commits.webkit.org/r274677> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423659. 1741465 7 webkit-bug-importer 2021-03-18 15:43:14 -0700 <rdar://problem/75594322> 423615 2021-03-18 10:44:32 -0700 2021-03-18 14:00:55 -0700 Patch bug-223452-20210318104431.patch text/plain 4002 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZjNjUyMmY0ZDZmZmYy YzQ4YWYyYTI4MGM1ZTVkMWU4ZDhiNjVkZS4uODgxYjc0YWJiOWRkNzg3MzVhNjk1ZjljZjI4OTEx NDQ1N2ZhNmIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIHVuZGVyIEF1ZGlvV29ya2xldE5vZGU6OnByb2Nlc3MoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWx3YXlzIHVzZSBhcnJheXMgb2Ygc2l6ZSAx MjggKHJlbmRlciBxdWFudHVtKSBmb3IgQXVkaW9QYXJhbSB2YWx1ZXMuIFdlIHVzZSB0bworICAg ICAgICBkeW5hbWljYWxseSBjaG9vc2UgYmV0d2VlbiBhIHNpemUgb2YgMTI4IGFuZCAxICh3aGVu IHRoZXJlIGlzIG5vIGF1dG9tYXRpb24KKyAgICAgICAgc2NoZWR1bGVkIGFuZCB0aGUgdmFsdWUg aXMgY29uc3RhbnQgZm9yIHRoZSBxdWFudHVtKS4gVGhpcyBhdm9pZHMgaGF2aW5nIHRvIG1ha2UK KyAgICAgICAgaGVhcCBhbGxvY2F0aW9ucyBvbiB0aGUgYXVkaW8gdGhyZWFkLCB3aGljaCBhcmUg YmFkIGZvciBwZXJmb3JtYW5jZS4KKworICAgICAgICBDb250ZW50IChhbmQgZXhpc3RpbmcgQXVk aW9Xb3JrbGV0IHRlc3RzKSBjYW4gaGFuZGxlIGVpdGhlciBzaXplIGJlY2F1c2UgdGhlCisgICAg ICAgIHNwZWNpZmljYXRpb24gc2F5cyBbMV06CisgICAgICAgICIiIgorICAgICAgICBGb3IgZWFj aCBhcnJheSwgdGhlIGFycmF5IGNvbnRhaW5zIHRoZSBjb21wdXRlZFZhbHVlIG9mIHRoZSBwYXJh bWV0ZXIgZm9yIGFsbAorICAgICAgICBmcmFtZXMgaW4gdGhlIHJlbmRlciBxdWFudHVtLiBIb3dl dmVyLCBpZiBubyBhdXRvbWF0aW9uIGlzIHNjaGVkdWxlZCBkdXJpbmcgdGhpcworICAgICAgICBy ZW5kZXIgcXVhbnR1bSwgdGhlIGFycmF5IE1BWSBoYXZlIGxlbmd0aCAxIHdpdGggdGhlIGFycmF5 IGVsZW1lbnQgYmVpbmcgdGhlCisgICAgICAgIGNvbnN0YW50IHZhbHVlIG9mIHRoZSBBdWRpb1Bh cmFtIGZvciB0aGUgcmVuZGVyIHF1YW50dW0uCisgICAgICAgICIiIgorCisgICAgICAgIE5vdGUg dGhhdCB0aGUgc3BlY2lmaWNhdGlvbiB1c2VzICJNQVkiIHNvIHRoaXMgaXMgbm90IGEgcmVxdWly ZW1lbnQgZm9yIHVzIHRvIHVzZQorICAgICAgICBhbiBhcnJheSBvZiBzaXplIDEgaW4gc3VjaCBj YXNlLiBJIGFsc28gdmVyaWZpZWQgdGhhdCBCbGluayBpcyBuZXZlciB1c2luZyBhbgorICAgICAg ICBhcnJheSBvZiBzaXplIDEgZWl0aGVyLiBUaGV5IGFsd2F5cyB1c2UgYXJyYXlzIG9mIDEyOCAo cmVuZGVyIHF1YW50dW0gc2l6ZSkgYW5kCisgICAgICAgIHN0ZDo6ZmlsbCgpIHRoZW0gd2l0aCB0 aGUgY29uc3RhbnQgdmFsdWUgd2hlbiB0aGVyZSBpcyBubyBhdXRvbWF0aW9uLiBPdXIgbmV3Cisg ICAgICAgIGJlaGF2aW9yIGlzIHRodXMgY29uc2lzdGFudCB3aXRoIEJsaW5rLgorCisgICAgICAg IFsxXSBodHRwczovL3dlYmF1ZGlvLmdpdGh1Yi5pby93ZWItYXVkaW8tYXBpLyNhdWRpb3dvcmts ZXRwcm9jZXNzLWNhbGxiYWNrLXBhcmFtZXRlcnMKKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVk aW8vQXVkaW9Xb3JrbGV0Tm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1dvcmtsZXRO b2RlOjppbml0aWFsaXplQXVkaW9QYXJhbWV0ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv V29ya2xldE5vZGU6OnByb2Nlc3MpOgorCiAyMDIxLTAzLTE4ICBUcnVpdHQgU2F2ZWxsICA8dHNh dmVsbEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzQ2NDQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvV29ya2xl dE5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1dvcmtsZXRO b2RlLmNwcAppbmRleCBkMTA5YTY1ODE2ZmI1YjUwYTRlNmRhZTYzZTFlZTlkNmVkZmM4MTk5Li4x MGViMzY0ZjAxNGYwODg2YzRhYmM4NGQ2NjE2NGFkZjcyODViMmU5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvV29ya2xldE5vZGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Xb3JrbGV0Tm9kZS5jcHAKQEAgLTE3 Myw3ICsxNzMsNyBAQCB2b2lkIEF1ZGlvV29ya2xldE5vZGU6OmluaXRpYWxpemVBdWRpb1BhcmFt ZXRlcnMoY29uc3QgVmVjdG9yPEF1ZGlvUGFyYW1EZXNjcmlwdAogICAgIH0KIAogICAgIGZvciAo YXV0byYgcGFyYW1ldGVyTmFtZSA6IG1fcGFyYW1ldGVycy0+bWFwKCkua2V5cygpKQotICAgICAg ICBtX3BhcmFtVmFsdWVzTWFwLmFkZChwYXJhbWV0ZXJOYW1lLCBtYWtlVW5pcXVlPEF1ZGlvRmxv YXRBcnJheT4oKSk7CisgICAgICAgIG1fcGFyYW1WYWx1ZXNNYXAuYWRkKHBhcmFtZXRlck5hbWUs IG1ha2VVbmlxdWU8QXVkaW9GbG9hdEFycmF5PihBdWRpb1V0aWxpdGllczo6cmVuZGVyUXVhbnR1 bVNpemUpKTsKIH0KIAogdm9pZCBBdWRpb1dvcmtsZXROb2RlOjpzZXRQcm9jZXNzb3IoUmVmUHRy PEF1ZGlvV29ya2xldFByb2Nlc3Nvcj4mJiBwcm9jZXNzb3IpCkBAIC0yMDgsMTUgKzIwOCwxMSBA QCB2b2lkIEF1ZGlvV29ya2xldE5vZGU6OnByb2Nlc3Moc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykK ICAgICBmb3IgKGF1dG8mIGF1ZGlvUGFyYW0gOiBtX3BhcmFtZXRlcnMtPm1hcCgpLnZhbHVlcygp KSB7CiAgICAgICAgIGF1dG8qIHBhcmFtVmFsdWVzID0gbV9wYXJhbVZhbHVlc01hcC5nZXQoYXVk aW9QYXJhbS0+bmFtZSgpKTsKICAgICAgICAgQVNTRVJUKHBhcmFtVmFsdWVzKTsKLSAgICAgICAg aWYgKGF1ZGlvUGFyYW0tPmhhc1NhbXBsZUFjY3VyYXRlVmFsdWVzKCkgJiYgYXVkaW9QYXJhbS0+ YXV0b21hdGlvblJhdGUoKSA9PSBBdXRvbWF0aW9uUmF0ZTo6QVJhdGUpIHsKLSAgICAgICAgICAg IHBhcmFtVmFsdWVzLT5yZXNpemUoZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgUkVMRUFTRV9B U1NFUlQocGFyYW1WYWx1ZXMtPnNpemUoKSA+PSBmcmFtZXNUb1Byb2Nlc3MpOworICAgICAgICBp ZiAoYXVkaW9QYXJhbS0+aGFzU2FtcGxlQWNjdXJhdGVWYWx1ZXMoKSAmJiBhdWRpb1BhcmFtLT5h dXRvbWF0aW9uUmF0ZSgpID09IEF1dG9tYXRpb25SYXRlOjpBUmF0ZSkKICAgICAgICAgICAgIGF1 ZGlvUGFyYW0tPmNhbGN1bGF0ZVNhbXBsZUFjY3VyYXRlVmFsdWVzKHBhcmFtVmFsdWVzLT5kYXRh KCksIGZyYW1lc1RvUHJvY2Vzcyk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAvLyBJ ZiBubyBhdXRvbWF0aW9uIGlzIHNjaGVkdWxlZCBkdXJpbmcgdGhpcyByZW5kZXIgcXVhbnR1bSwg dGhlIGFycmF5IG1heSBoYXZlIGxlbmd0aCAxCi0gICAgICAgICAgICAvLyB3aXRoIHRoZSBhcnJh eSBlbGVtZW50IGJlaW5nIHRoZSBjb25zdGFudCB2YWx1ZSBvZiB0aGUgQXVkaW9QYXJhbSBmb3Ig dGhlIHJlbmRlciBxdWFudHVtLgotICAgICAgICAgICAgcGFyYW1WYWx1ZXMtPnJlc2l6ZSgxKTsK LSAgICAgICAgICAgICpwYXJhbVZhbHVlcy0+ZGF0YSgpID0gYXVkaW9QYXJhbS0+ZmluYWxWYWx1 ZSgpOwotICAgICAgICB9CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN0ZDo6ZmlsbChwYXJh bVZhbHVlcy0+ZGF0YSgpLCBwYXJhbVZhbHVlcy0+ZGF0YSgpICsgZnJhbWVzVG9Qcm9jZXNzLCBh dWRpb1BhcmFtLT5maW5hbFZhbHVlKCkpOwogICAgIH0KIAogICAgIGJvb2wgdGhyZXdFeGNlcHRp b24gPSBmYWxzZTsK 423650 2021-03-18 14:00:57 -0700 2021-03-18 14:35:33 -0700 Patch bug-223452-20210318140056.patch text/plain 4045 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMzOTY3YWVmYTY3NjI5 NWY1M2RmMTQ4ZDhjMWU0ODgxZTZjNzE2ZC4uZTJkNmJmYmNhYTY5NjgzMTg1ZmM5M2NjNTk5Yjdh MTZlMjg4ZmQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIHVuZGVyIEF1ZGlvV29ya2xldE5vZGU6OnByb2Nlc3MoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWx3YXlzIHVzZSBhcnJheXMgb2Ygc2l6ZSAx MjggKHJlbmRlciBxdWFudHVtKSBmb3IgQXVkaW9QYXJhbSB2YWx1ZXMuIFdlIHVzZWQgdG8KKyAg ICAgICAgZHluYW1pY2FsbHkgY2hvb3NlIGJldHdlZW4gYSBzaXplIG9mIDEyOCBhbmQgMSAod2hl biB0aGVyZSBpcyBubyBhdXRvbWF0aW9uCisgICAgICAgIHNjaGVkdWxlZCBhbmQgdGhlIHZhbHVl IGlzIGNvbnN0YW50IGZvciB0aGUgcXVhbnR1bSkuIFRoaXMgYXZvaWRzIGhhdmluZyB0byBtYWtl CisgICAgICAgIGhlYXAgYWxsb2NhdGlvbnMgb24gdGhlIGF1ZGlvIHRocmVhZCwgd2hpY2ggYXJl IGJhZCBmb3IgcGVyZm9ybWFuY2UuCisKKyAgICAgICAgQ29udGVudCAoYW5kIGV4aXN0aW5nIEF1 ZGlvV29ya2xldCB0ZXN0cykgY2FuIGhhbmRsZSBlaXRoZXIgc2l6ZSBiZWNhdXNlIHRoZQorICAg ICAgICBzcGVjaWZpY2F0aW9uIHNheXMgWzFdOgorICAgICAgICAiIiIKKyAgICAgICAgRm9yIGVh Y2ggYXJyYXksIHRoZSBhcnJheSBjb250YWlucyB0aGUgY29tcHV0ZWRWYWx1ZSBvZiB0aGUgcGFy YW1ldGVyIGZvciBhbGwKKyAgICAgICAgZnJhbWVzIGluIHRoZSByZW5kZXIgcXVhbnR1bS4gSG93 ZXZlciwgaWYgbm8gYXV0b21hdGlvbiBpcyBzY2hlZHVsZWQgZHVyaW5nIHRoaXMKKyAgICAgICAg cmVuZGVyIHF1YW50dW0sIHRoZSBhcnJheSBNQVkgaGF2ZSBsZW5ndGggMSB3aXRoIHRoZSBhcnJh eSBlbGVtZW50IGJlaW5nIHRoZQorICAgICAgICBjb25zdGFudCB2YWx1ZSBvZiB0aGUgQXVkaW9Q YXJhbSBmb3IgdGhlIHJlbmRlciBxdWFudHVtLgorICAgICAgICAiIiIKKworICAgICAgICBOb3Rl IHRoYXQgdGhlIHNwZWNpZmljYXRpb24gdXNlcyAiTUFZIiBzbyB0aGlzIGlzIG5vdCBhIHJlcXVp cmVtZW50IGZvciB1cyB0byB1c2UKKyAgICAgICAgYW4gYXJyYXkgb2Ygc2l6ZSAxIGluIHN1Y2gg Y2FzZS4gSSBhbHNvIHZlcmlmaWVkIHRoYXQgQmxpbmsgaXMgbmV2ZXIgdXNpbmcgYW4KKyAgICAg ICAgYXJyYXkgb2Ygc2l6ZSAxIGVpdGhlci4gVGhleSBhbHdheXMgdXNlIGFycmF5cyBvZiAxMjgg KHJlbmRlciBxdWFudHVtIHNpemUpIGFuZAorICAgICAgICBzdGQ6OmZpbGwoKSB0aGVtIHdpdGgg dGhlIGNvbnN0YW50IHZhbHVlIHdoZW4gdGhlcmUgaXMgbm8gYXV0b21hdGlvbi4gT3VyIG5ldwor ICAgICAgICBiZWhhdmlvciBpcyB0aHVzIGNvbnNpc3RhbnQgd2l0aCBCbGluay4KKworICAgICAg ICBbMV0gaHR0cHM6Ly93ZWJhdWRpby5naXRodWIuaW8vd2ViLWF1ZGlvLWFwaS8jYXVkaW93b3Jr bGV0cHJvY2Vzcy1jYWxsYmFjay1wYXJhbWV0ZXJzCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1 ZGlvL0F1ZGlvV29ya2xldE5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Xb3JrbGV0 Tm9kZTo6aW5pdGlhbGl6ZUF1ZGlvUGFyYW1ldGVycyk6CisgICAgICAgIChXZWJDb3JlOjpBdWRp b1dvcmtsZXROb2RlOjpwcm9jZXNzKToKKwogMjAyMS0wMy0xOCAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGhlYXAgYWxsb2NhdGlvbiB1bmRlciBCYXNl QXVkaW9Db250ZXh0Ojpzb3VyY2VOb2RlRGlkRmluaXNoUGxheWJhY2soKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1dvcmtsZXROb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Xb3JrbGV0Tm9kZS5jcHAKaW5kZXgg ZDEwOWE2NTgxNmZiNWI1MGE0ZTZkYWU2M2UxZWU5ZDZlZGZjODE5OS4uMTBlYjM2NGYwMTRmMDg4 NmM0YWJjODRkNjYxNjRhZGY3Mjg1YjJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb1dvcmtsZXROb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvV29ya2xldE5vZGUuY3BwCkBAIC0xNzMsNyArMTczLDcgQEAg dm9pZCBBdWRpb1dvcmtsZXROb2RlOjppbml0aWFsaXplQXVkaW9QYXJhbWV0ZXJzKGNvbnN0IFZl Y3RvcjxBdWRpb1BhcmFtRGVzY3JpcHQKICAgICB9CiAKICAgICBmb3IgKGF1dG8mIHBhcmFtZXRl ck5hbWUgOiBtX3BhcmFtZXRlcnMtPm1hcCgpLmtleXMoKSkKLSAgICAgICAgbV9wYXJhbVZhbHVl c01hcC5hZGQocGFyYW1ldGVyTmFtZSwgbWFrZVVuaXF1ZTxBdWRpb0Zsb2F0QXJyYXk+KCkpOwor ICAgICAgICBtX3BhcmFtVmFsdWVzTWFwLmFkZChwYXJhbWV0ZXJOYW1lLCBtYWtlVW5pcXVlPEF1 ZGlvRmxvYXRBcnJheT4oQXVkaW9VdGlsaXRpZXM6OnJlbmRlclF1YW50dW1TaXplKSk7CiB9CiAK IHZvaWQgQXVkaW9Xb3JrbGV0Tm9kZTo6c2V0UHJvY2Vzc29yKFJlZlB0cjxBdWRpb1dvcmtsZXRQ cm9jZXNzb3I+JiYgcHJvY2Vzc29yKQpAQCAtMjA4LDE1ICsyMDgsMTEgQEAgdm9pZCBBdWRpb1dv cmtsZXROb2RlOjpwcm9jZXNzKHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgZm9yIChhdXRv JiBhdWRpb1BhcmFtIDogbV9wYXJhbWV0ZXJzLT5tYXAoKS52YWx1ZXMoKSkgewogICAgICAgICBh dXRvKiBwYXJhbVZhbHVlcyA9IG1fcGFyYW1WYWx1ZXNNYXAuZ2V0KGF1ZGlvUGFyYW0tPm5hbWUo KSk7CiAgICAgICAgIEFTU0VSVChwYXJhbVZhbHVlcyk7Ci0gICAgICAgIGlmIChhdWRpb1BhcmFt LT5oYXNTYW1wbGVBY2N1cmF0ZVZhbHVlcygpICYmIGF1ZGlvUGFyYW0tPmF1dG9tYXRpb25SYXRl KCkgPT0gQXV0b21hdGlvblJhdGU6OkFSYXRlKSB7Ci0gICAgICAgICAgICBwYXJhbVZhbHVlcy0+ cmVzaXplKGZyYW1lc1RvUHJvY2Vzcyk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKHBhcmFtVmFs dWVzLT5zaXplKCkgPj0gZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgaWYgKGF1ZGlvUGFyYW0t Pmhhc1NhbXBsZUFjY3VyYXRlVmFsdWVzKCkgJiYgYXVkaW9QYXJhbS0+YXV0b21hdGlvblJhdGUo KSA9PSBBdXRvbWF0aW9uUmF0ZTo6QVJhdGUpCiAgICAgICAgICAgICBhdWRpb1BhcmFtLT5jYWxj dWxhdGVTYW1wbGVBY2N1cmF0ZVZhbHVlcyhwYXJhbVZhbHVlcy0+ZGF0YSgpLCBmcmFtZXNUb1By b2Nlc3MpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gSWYgbm8gYXV0b21hdGlv biBpcyBzY2hlZHVsZWQgZHVyaW5nIHRoaXMgcmVuZGVyIHF1YW50dW0sIHRoZSBhcnJheSBtYXkg aGF2ZSBsZW5ndGggMQotICAgICAgICAgICAgLy8gd2l0aCB0aGUgYXJyYXkgZWxlbWVudCBiZWlu ZyB0aGUgY29uc3RhbnQgdmFsdWUgb2YgdGhlIEF1ZGlvUGFyYW0gZm9yIHRoZSByZW5kZXIgcXVh bnR1bS4KLSAgICAgICAgICAgIHBhcmFtVmFsdWVzLT5yZXNpemUoMSk7Ci0gICAgICAgICAgICAq cGFyYW1WYWx1ZXMtPmRhdGEoKSA9IGF1ZGlvUGFyYW0tPmZpbmFsVmFsdWUoKTsKLSAgICAgICAg fQorICAgICAgICBlbHNlCisgICAgICAgICAgICBzdGQ6OmZpbGwocGFyYW1WYWx1ZXMtPmRhdGEo KSwgcGFyYW1WYWx1ZXMtPmRhdGEoKSArIGZyYW1lc1RvUHJvY2VzcywgYXVkaW9QYXJhbS0+Zmlu YWxWYWx1ZSgpKTsKICAgICB9CiAKICAgICBib29sIHRocmV3RXhjZXB0aW9uID0gZmFsc2U7Cg== 423659 2021-03-18 14:35:35 -0700 2021-03-18 15:42:33 -0700 Patch bug-223452-20210318143534.patch text/plain 4025 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJkNDA0MzZkODY0ZTAz ZDNjMmE0MTU4NGMxMDJmMjA4ZThlYjA3MS4uYjE1OGMzNTgxYTcyMTg2NGQ4ZjFjOTIxYzZlMDk0 NjU2ZmNjZGZjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9uIHVuZGVyIEF1ZGlvV29ya2xldE5vZGU6OnByb2Nlc3MoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWx3YXlzIHVzZSBhcnJheXMgb2Ygc2l6ZSAxMjgg KHJlbmRlciBxdWFudHVtKSBmb3IgQXVkaW9QYXJhbSB2YWx1ZXMuIFdlIHVzZWQgdG8KKyAgICAg ICAgZHluYW1pY2FsbHkgY2hvb3NlIGJldHdlZW4gYSBzaXplIG9mIDEyOCBhbmQgMSAod2hlbiB0 aGVyZSBpcyBubyBhdXRvbWF0aW9uCisgICAgICAgIHNjaGVkdWxlZCBhbmQgdGhlIHZhbHVlIGlz IGNvbnN0YW50IGZvciB0aGUgcXVhbnR1bSkuIFRoaXMgYXZvaWRzIGhhdmluZyB0byBtYWtlCisg ICAgICAgIGhlYXAgYWxsb2NhdGlvbnMgb24gdGhlIGF1ZGlvIHRocmVhZCwgd2hpY2ggYXJlIGJh ZCBmb3IgcGVyZm9ybWFuY2UuCisKKyAgICAgICAgQ29udGVudCAoYW5kIGV4aXN0aW5nIEF1ZGlv V29ya2xldCB0ZXN0cykgY2FuIGhhbmRsZSBlaXRoZXIgc2l6ZSBiZWNhdXNlIHRoZQorICAgICAg ICBzcGVjaWZpY2F0aW9uIHNheXMgWzFdOgorICAgICAgICAiIiIKKyAgICAgICAgRm9yIGVhY2gg YXJyYXksIHRoZSBhcnJheSBjb250YWlucyB0aGUgY29tcHV0ZWRWYWx1ZSBvZiB0aGUgcGFyYW1l dGVyIGZvciBhbGwKKyAgICAgICAgZnJhbWVzIGluIHRoZSByZW5kZXIgcXVhbnR1bS4gSG93ZXZl ciwgaWYgbm8gYXV0b21hdGlvbiBpcyBzY2hlZHVsZWQgZHVyaW5nIHRoaXMKKyAgICAgICAgcmVu ZGVyIHF1YW50dW0sIHRoZSBhcnJheSBNQVkgaGF2ZSBsZW5ndGggMSB3aXRoIHRoZSBhcnJheSBl bGVtZW50IGJlaW5nIHRoZQorICAgICAgICBjb25zdGFudCB2YWx1ZSBvZiB0aGUgQXVkaW9QYXJh bSBmb3IgdGhlIHJlbmRlciBxdWFudHVtLgorICAgICAgICAiIiIKKworICAgICAgICBOb3RlIHRo YXQgdGhlIHNwZWNpZmljYXRpb24gdXNlcyAiTUFZIiBzbyB0aGlzIGlzIG5vdCBhIHJlcXVpcmVt ZW50IGZvciB1cyB0byB1c2UKKyAgICAgICAgYW4gYXJyYXkgb2Ygc2l6ZSAxIGluIHN1Y2ggY2Fz ZS4gSSBhbHNvIHZlcmlmaWVkIHRoYXQgQmxpbmsgaXMgbmV2ZXIgdXNpbmcgYW4KKyAgICAgICAg YXJyYXkgb2Ygc2l6ZSAxIGVpdGhlci4gVGhleSBhbHdheXMgdXNlIGFycmF5cyBvZiAxMjggKHJl bmRlciBxdWFudHVtIHNpemUpIGFuZAorICAgICAgICBzdGQ6OmZpbGwoKSB0aGVtIHdpdGggdGhl IGNvbnN0YW50IHZhbHVlIHdoZW4gdGhlcmUgaXMgbm8gYXV0b21hdGlvbi4gT3VyIG5ldworICAg ICAgICBiZWhhdmlvciBpcyB0aHVzIGNvbnNpc3RlbnQgd2l0aCBCbGluay4KKworICAgICAgICBb MV0gaHR0cHM6Ly93ZWJhdWRpby5naXRodWIuaW8vd2ViLWF1ZGlvLWFwaS8jYXVkaW93b3JrbGV0 cHJvY2Vzcy1jYWxsYmFjay1wYXJhbWV0ZXJzCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvV29ya2xldE5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Xb3JrbGV0Tm9k ZTo6aW5pdGlhbGl6ZUF1ZGlvUGFyYW1ldGVycyk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1dv cmtsZXROb2RlOjpwcm9jZXNzKToKKwogMjAyMS0wMy0xOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgU3dpdGNoIG91dCBvZiBzY2hlZHVsZWQgcmVzb3VyY2Ug bG9hZCBtb2RlIG9ubHkgYWZ0ZXIgYXN5bmMgc2NyaXB0cyBoYXZlIHJ1bgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1dvcmtsZXROb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Xb3JrbGV0Tm9kZS5jcHAKaW5kZXgg ZDEwOWE2NTgxNmZiNWI1MGE0ZTZkYWU2M2UxZWU5ZDZlZGZjODE5OS4uNTM4MjA1MTUyZGMyYjM0 MDQxMGI2ZjdmOWFmOGNmNTBhMWQyMzYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb1dvcmtsZXROb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvV29ya2xldE5vZGUuY3BwCkBAIC0xNzMsNyArMTczLDcgQEAg dm9pZCBBdWRpb1dvcmtsZXROb2RlOjppbml0aWFsaXplQXVkaW9QYXJhbWV0ZXJzKGNvbnN0IFZl Y3RvcjxBdWRpb1BhcmFtRGVzY3JpcHQKICAgICB9CiAKICAgICBmb3IgKGF1dG8mIHBhcmFtZXRl ck5hbWUgOiBtX3BhcmFtZXRlcnMtPm1hcCgpLmtleXMoKSkKLSAgICAgICAgbV9wYXJhbVZhbHVl c01hcC5hZGQocGFyYW1ldGVyTmFtZSwgbWFrZVVuaXF1ZTxBdWRpb0Zsb2F0QXJyYXk+KCkpOwor ICAgICAgICBtX3BhcmFtVmFsdWVzTWFwLmFkZChwYXJhbWV0ZXJOYW1lLCBtYWtlVW5pcXVlPEF1 ZGlvRmxvYXRBcnJheT4oQXVkaW9VdGlsaXRpZXM6OnJlbmRlclF1YW50dW1TaXplKSk7CiB9CiAK IHZvaWQgQXVkaW9Xb3JrbGV0Tm9kZTo6c2V0UHJvY2Vzc29yKFJlZlB0cjxBdWRpb1dvcmtsZXRQ cm9jZXNzb3I+JiYgcHJvY2Vzc29yKQpAQCAtMjA4LDE1ICsyMDgsMTEgQEAgdm9pZCBBdWRpb1dv cmtsZXROb2RlOjpwcm9jZXNzKHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgZm9yIChhdXRv JiBhdWRpb1BhcmFtIDogbV9wYXJhbWV0ZXJzLT5tYXAoKS52YWx1ZXMoKSkgewogICAgICAgICBh dXRvKiBwYXJhbVZhbHVlcyA9IG1fcGFyYW1WYWx1ZXNNYXAuZ2V0KGF1ZGlvUGFyYW0tPm5hbWUo KSk7CiAgICAgICAgIEFTU0VSVChwYXJhbVZhbHVlcyk7Ci0gICAgICAgIGlmIChhdWRpb1BhcmFt LT5oYXNTYW1wbGVBY2N1cmF0ZVZhbHVlcygpICYmIGF1ZGlvUGFyYW0tPmF1dG9tYXRpb25SYXRl KCkgPT0gQXV0b21hdGlvblJhdGU6OkFSYXRlKSB7Ci0gICAgICAgICAgICBwYXJhbVZhbHVlcy0+ cmVzaXplKGZyYW1lc1RvUHJvY2Vzcyk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKHBhcmFtVmFs dWVzLT5zaXplKCkgPj0gZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgaWYgKGF1ZGlvUGFyYW0t Pmhhc1NhbXBsZUFjY3VyYXRlVmFsdWVzKCkgJiYgYXVkaW9QYXJhbS0+YXV0b21hdGlvblJhdGUo KSA9PSBBdXRvbWF0aW9uUmF0ZTo6QVJhdGUpCiAgICAgICAgICAgICBhdWRpb1BhcmFtLT5jYWxj dWxhdGVTYW1wbGVBY2N1cmF0ZVZhbHVlcyhwYXJhbVZhbHVlcy0+ZGF0YSgpLCBmcmFtZXNUb1By b2Nlc3MpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gSWYgbm8gYXV0b21hdGlv biBpcyBzY2hlZHVsZWQgZHVyaW5nIHRoaXMgcmVuZGVyIHF1YW50dW0sIHRoZSBhcnJheSBtYXkg aGF2ZSBsZW5ndGggMQotICAgICAgICAgICAgLy8gd2l0aCB0aGUgYXJyYXkgZWxlbWVudCBiZWlu ZyB0aGUgY29uc3RhbnQgdmFsdWUgb2YgdGhlIEF1ZGlvUGFyYW0gZm9yIHRoZSByZW5kZXIgcXVh bnR1bS4KLSAgICAgICAgICAgIHBhcmFtVmFsdWVzLT5yZXNpemUoMSk7Ci0gICAgICAgICAgICAq cGFyYW1WYWx1ZXMtPmRhdGEoKSA9IGF1ZGlvUGFyYW0tPmZpbmFsVmFsdWUoKTsKLSAgICAgICAg fQorICAgICAgICBlbHNlCisgICAgICAgICAgICBzdGQ6OmZpbGxfbihwYXJhbVZhbHVlcy0+ZGF0 YSgpLCBmcmFtZXNUb1Byb2Nlc3MsIGF1ZGlvUGFyYW0tPmZpbmFsVmFsdWUoKSk7CiAgICAgfQog CiAgICAgYm9vbCB0aHJld0V4Y2VwdGlvbiA9IGZhbHNlOwo=