223449 2021-03-18 09:44:05 -0700 Avoid heap allocations under AudioSampleDataSource::pullSamplesInternal() 2021-05-12 07:13:27 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223226 1 cdumez cdumez cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1741229 0 cdumez 2021-03-18 09:44:05 -0700 Avoid heap allocations under AudioSampleDataSource::pullSamplesInternal(): Thread 12 Crashed:: WebCore: AudioWorklet 0 com.apple.JavaScriptCore 0x000000059fd88aee 0x59fd86000 + 10990 1 com.apple.JavaScriptCore 0x00000005a152629b 0x59fd86000 + 24773275 2 com.apple.JavaScriptCore 0x000000059fdc637b 0x59fd86000 + 263035 3 com.apple.WebCore 0x00000005808ffc65 WTF::Detail::CallableWrapperBase<void>::operator new(unsigned long) + 21 (Function.h:37) 4 com.apple.WebCore 0x0000000582265d18 std::__1::__unique_if<WTF::Detail::CallableWrapper<WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3, void> >::__unique_single std::__1::make_unique<WTF::Detail::CallableWrapper<WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3, void>, WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3>(WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3&&) + 40 (memory:2755) 5 com.apple.WebCore 0x0000000582265c86 decltype(auto) WTF::makeUnique<WTF::Detail::CallableWrapper<WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3, void>, WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3>(WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3&&) + 54 (StdLibExtras.h:507) 6 com.apple.WebCore 0x0000000582265c30 WTF::Function<void ()>::Function<WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3, void>(WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3&&) + 48 (Function.h:74) 7 com.apple.WebCore 0x000000058224e48d WTF::Function<void ()>::Function<WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3, void>(WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode)::$_3&&) + 29 (Function.h:74) 8 com.apple.WebCore 0x000000058224ddc8 WebCore::AudioSampleDataSource::pullSamplesInternal(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode) + 824 (AudioSampleDataSource.mm:242) 9 com.apple.WebCore 0x000000058224e8aa WebCore::AudioSampleDataSource::pullSamples(AudioBufferList&, unsigned long, unsigned long long, double, WebCore::AudioSampleDataSource::PullMode) + 170 (AudioSampleDataSource.mm:343) 10 com.apple.WebCore 0x000000058295c717 WebCore::WebAudioSourceProviderCocoa::provideInput(WebCore::AudioBus*, unsigned long) + 919 (WebAudioSourceProviderCocoa.mm:97) 11 com.apple.WebCore 0x0000000582c8c0a6 WebCore::MediaElementAudioSourceNode::provideInput(WebCore::AudioBus*, unsigned long) + 166 (MediaElementAudioSourceNode.cpp:125) 12 com.apple.WebCore 0x0000000582c8c52e WebCore::MediaElementAudioSourceNode::process(unsigned long) + 606 (MediaElementAudioSourceNode.cpp:178) 13 com.apple.WebCore 0x0000000582bdc9ae WebCore::AudioNode::processIfNecessary(unsigned long) + 462 (AudioNode.cpp:474) 1741237 1 423610 cdumez 2021-03-18 09:53:30 -0700 Created attachment 423610 Patch 1741302 2 ews-feeder 2021-03-18 11:48:16 -0700 Committed r274657: <https://commits.webkit.org/r274657> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423610. 1741306 3 webkit-bug-importer 2021-03-18 11:49:35 -0700 <rdar://problem/75583342> 1759241 4 youennf 2021-05-12 07:13:27 -0700 Hum, this logging was useful in the past to debug crackling and was recently useful again. I think we should try to resurrect it in some ways. 423610 2021-03-18 09:53:30 -0700 2021-03-18 11:48:17 -0700 Patch bug-223449-20210318095327.patch text/plain 3294 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUzMzViYWExNjFkOTli YTY2ZjkyZjI4ZWRkY2I4Yzg0ZGI2MjQxZi4uNTg1ZGIzOThhM2IyMWEwYjA2MWFhMzA1OTVjNmMz NmYyN2VkMTUxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgaGVhcCBhbGxvY2F0 aW9ucyB1bmRlciBBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDQ5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXVkaW9TYW1w bGVEYXRhU291cmNlOjpwdWxsU2FtcGxlc0ludGVybmFsKCkgd2FzIGRvaW5nIGhlYXAgYWxsb2Nh dGlvbnMgb24gdGhlIGF1ZGlvIHRocmVhZCwKKyAgICAgICAganVzdCBmb3IgbG9nZ2luZyBwdXJw b3NlcyAoUnVuTG9vcDo6ZGlzcGF0Y2goKSAmIEZ1bmN0aW9uIGNvbnN0cnVjdG9yIGRvIGhlYXAg YWxsb2NhdGlvbnMpLgorICAgICAgICBEcm9wIHRoaXMgbG9nZ2luZyB0byBhZGRyZXNzIHRoZSBp c3N1ZSwgYWZ0ZXIgY2xlYXJpbmcgdGhpcyB3aXRoIEplciBOb2JsZS4KKworICAgICAgICAqIHBs YXRmb3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbToKKyAgICAgICAgKFdl YkNvcmU6OkF1ZGlvU2FtcGxlRGF0YVNvdXJjZTo6cHVsbFNhbXBsZXNJbnRlcm5hbCk6CisKIDIw MjEtMDMtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9p ZCBoZWFwIGFsbG9jYXRpb24gdW5kZXIgUGFubmVyTm9kZTo6cHVsbElucHV0cygpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFT b3VyY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBs ZURhdGFTb3VyY2UubW0KaW5kZXggNTBhZGNiZjQ1NjVhZWUyMTI3MWU2MTJjMDJmZGNkYWZkZTI0 MzRmZi4uNTU4YzM4MmEyZTg0NWIxZTA4ZDAxZDMzZGI3ZjI4YzdhMWZlY2RjZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2EvQXVkaW9TYW1wbGVEYXRhU291 cmNlLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2Ft cGxlRGF0YVNvdXJjZS5tbQpAQCAtMjM5LDE4ICsyMzksMTEgQEAgYm9vbCBBdWRpb1NhbXBsZURh dGFTb3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwoQXVkaW9CdWZmZXJMaXN0JiBidWZmZXIsIHNp emVfdAogCiAgICAgICAgIG1fb3V0cHV0U2FtcGxlT2Zmc2V0ID0gKGVuZEZyYW1lIC0gc2FtcGxl Q291bnQpIC0gdGltZVN0YW1wOwogICAgICAgICBtX291dHB1dFNhbXBsZU9mZnNldCAtPSBjb21w dXRlT2Zmc2V0RGVsYXkobV9vdXRwdXREZXNjcmlwdGlvbi0+c2FtcGxlUmF0ZSgpLCBtX2xhc3RQ dXNoZWRTYW1wbGVDb3VudCk7Ci0gICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbbG9n SWRlbnRpZmllciA9IExPR0lERU5USUZJRVIsIG91dHB1dFNhbXBsZU9mZnNldCA9IG1fb3V0cHV0 U2FtcGxlT2Zmc2V0LCB0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZlB0cigqdGhpcyldIHsK LSAgICAgICAgICAgIEFMV0FZU19MT0cobG9nSWRlbnRpZmllciwgInNldHRpbmcgbmV3IG9mZnNl dCB0byAiLCBvdXRwdXRTYW1wbGVPZmZzZXQpOwotICAgICAgICB9KTsKICAgICB9CiAKICAgICB0 aW1lU3RhbXAgKz0gbV9vdXRwdXRTYW1wbGVPZmZzZXQ7CiAKICAgICBpZiAodGltZVN0YW1wIDwg c3RhcnRGcmFtZSB8fCB0aW1lU3RhbXAgKyBzYW1wbGVDb3VudCA+IGVuZEZyYW1lKSB7Ci0gICAg ICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbbG9nSWRlbnRpZmllciA9IExPR0lERU5USUZJ RVIsIHRpbWVTdGFtcCwgc3RhcnRGcmFtZSwgZW5kRnJhbWUsIHNhbXBsZUNvdW50LCBvdXRwdXRT YW1wbGVPZmZzZXQgPSBtX291dHB1dFNhbXBsZU9mZnNldCwgdGhpcywgcHJvdGVjdGVkVGhpcyA9 IG1ha2VSZWZQdHIoKnRoaXMpXSB7Ci0gICAgICAgICAgICBFUlJPUl9MT0cobG9nSWRlbnRpZmll ciwgIm5vdCBlbm91Z2ggZGF0YSwgc2FtcGxlICIsIHRpbWVTdGFtcCwgIiB3aXRoIG9mZnNldCAi LCBvdXRwdXRTYW1wbGVPZmZzZXQsICIsIHRyeWluZyB0byBnZXQgIiwgc2FtcGxlQ291bnQsICIg c2FtcGxlcywgYnV0IG5vdCBjb21wbGV0ZWx5IGluIHJhbmdlIFsiLCBzdGFydEZyYW1lLCAiIC4u ICIsIGVuZEZyYW1lLCAiXSIpOwotICAgICAgICB9KTsKLQogICAgICAgICBpZiAodGltZVN0YW1w IDwgc3RhcnRGcmFtZSB8fCB0aW1lU3RhbXAgPj0gZW5kRnJhbWUpIHsKICAgICAgICAgICAgIC8v IFdlIGFyZSBvdXQgb2YgdGhlIHdpbmRvdywgbGV0J3MgcmVzdGFydCB0aGUgb2Zmc2V0IGNvbXB1 dGF0aW9uLgogICAgICAgICAgICAgbV9zaG91bGRDb21wdXRlT3V0cHV0U2FtcGxlT2Zmc2V0ID0g dHJ1ZTsKQEAgLTI2MCw5ICsyNTMsNiBAQCBib29sIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZTo6cHVs bFNhbXBsZXNJbnRlcm5hbChBdWRpb0J1ZmZlckxpc3QmIGJ1ZmZlciwgc2l6ZV90CiAgICAgICAg IH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBXZSBhcmUgdG9vIGNsb3NlIGZyb20gZW5kRnJhbWUs IGxldCdzIHdhaXQgZm9yIG1vcmUgZGF0YSB0byBiZSBwdXNoZWQuCiAgICAgICAgICAgICBtX291 dHB1dFNhbXBsZU9mZnNldCAtPSBzYW1wbGVDb3VudDsKLSAgICAgICAgICAgIFJ1bkxvb3A6Om1h aW4oKS5kaXNwYXRjaChbbG9nSWRlbnRpZmllciA9IExPR0lERU5USUZJRVIsIG91dHB1dFNhbXBs ZU9mZnNldCA9IG1fb3V0cHV0U2FtcGxlT2Zmc2V0LCB0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZlB0cigqdGhpcyldIHsKLSAgICAgICAgICAgICAgICBBTFdBWVNfTE9HKGxvZ0lkZW50aWZp ZXIsICJ1cGRhdGluZyBvZmZzZXQgdG8gIiwgb3V0cHV0U2FtcGxlT2Zmc2V0KTsKLSAgICAgICAg ICAgIH0pOwogICAgICAgICB9CiAgICAgICAgIEF1ZGlvU2FtcGxlQnVmZmVyTGlzdDo6emVyb0FC TChidWZmZXIsIGJ5dGVDb3VudCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsK